Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106293/?format=api
{ "id": 106293, "url": "http://patches.dpdk.org/api/patches/106293/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-55-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-55-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-55-stephen@networkplumber.org", "date": "2022-01-24T00:04:50", "name": "[54/82] net/ixgbe: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "210a99e0bc98d8130c116f192d84b0d29f0fac20", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-55-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "http://patches.dpdk.org/api/series/21315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/21315/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106293/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106293/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B4DDA034F;\n\tMon, 24 Jan 2022 01:10:16 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CD776428DC;\n\tMon, 24 Jan 2022 01:06:23 +0100 (CET)", "from mail-pj1-f41.google.com (mail-pj1-f41.google.com\n [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 1D3954285C\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:06:19 +0100 (CET)", "by mail-pj1-f41.google.com with SMTP id\n w12-20020a17090a528c00b001b276aa3aabso19114702pjh.0\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:06:19 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.06.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:06:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=tpchy6wepQlqev+R7Ezt6aGM3ua5K4iRFgPL0yJtdMI=;\n b=lldH8/wKUJ1rYgEdQnPoAhuWqV9NZnn6Wd8lYxIgC8t0ebe3IAvjmKpTe6dm+JGTE/\n VLeky53yxeJi1apB5SjYp+cIQk0/+7fHelye7qK7XCNCLX5GvcKMYlnEc3bvgHFH6TtC\n yshwG1M8swi0KlCZFdykoYzmTL3jWZleqTs7IlzxQWmqTYZAXJxmYV2MFqeNQb+UtbUp\n cjQXjSg0jk1J5J/nAfnrZHhoU+ca26HZWNkLNl22+MCEvbz1Dna+hdoBdoRzVRcK4IYW\n gwr9xDHmTEaqnPhIz9Iz3MYN7SkUzOsin61vKw0ipu1mK8i8gQIRN7fTXLfw9nI5jVvo\n X22Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=tpchy6wepQlqev+R7Ezt6aGM3ua5K4iRFgPL0yJtdMI=;\n b=vaojGagipTduO4JF0N4K+rwesjbuVrqbQv6X6PnLfRyWWmaJ1xu+YSlD1Fm28A5Gc3\n BPpZEu1Oh37XzqNEgUKoWwqILJEhDpeNb3pPRy5142dPqs5qDTzWPmkJyTxsZf9vcWVh\n 7QY4Ekzmq6h/msbi1X7hjvJRA5SJ27CHOoLP5ytAfMOsGhCJJLpBJY/4uG25Jxn4Xa5c\n 7g5ByqC1pXwVIsJmz/F2xjdEY9DXFA84Dc/3ZveoeURC8ft6MJPcOsyhZmXQs0BTFzGB\n iwlTzbtkoeAHMQrhiJh4+2x+l04dOe9RQNNkOiZqHZtl7ucfrCWz/DhY7bxuOhuthSqu\n Q5iw==", "X-Gm-Message-State": "AOAM531cJ7zWGUY5hdj8CmSM715PkKGWCmpHQ6M50jhnjiUUUCH/oY58\n gx8kHDnr3T5I2FYN4I/Iel9ZBtdokZYDZg==", "X-Google-Smtp-Source": "\n ABdhPJySagq8gGyH2YNHIDZDYgiXrxOSp0K718xpxgxZbST2evBkvmEjbR9sysDK8IeczJQs54F1yw==", "X-Received": "by 2002:a17:90a:8807:: with SMTP id\n s7mr10524255pjn.223.1642982778091;\n Sun, 23 Jan 2022 16:06:18 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Haiyue Wang <haiyue.wang@intel.com>", "Subject": "[PATCH 54/82] net/ixgbe: remove unnecessary NULL checks", "Date": "Sun, 23 Jan 2022 16:04:50 -0800", "Message-Id": "<20220124000518.319850-55-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove redundant NULL pointer checks before free functions\nfound by nullfree.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++-------\n drivers/net/ixgbe/ixgbe_rxtx.c | 3 +--\n 2 files changed, 4 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex c8f0460440c0..840509ddd460 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1322,10 +1322,8 @@ static int ixgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev)\n \t\tIXGBE_DEV_PRIVATE_TO_FDIR_INFO(eth_dev->data->dev_private);\n \tstruct ixgbe_fdir_filter *fdir_filter;\n \n-\t\tif (fdir_info->hash_map)\n \t\trte_free(fdir_info->hash_map);\n-\tif (fdir_info->hash_handle)\n-\t\trte_hash_free(fdir_info->hash_handle);\n+\trte_hash_free(fdir_info->hash_handle);\n \n \twhile ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) {\n \t\tTAILQ_REMOVE(&fdir_info->fdir_list,\n@@ -1343,10 +1341,8 @@ static int ixgbe_l2_tn_filter_uninit(struct rte_eth_dev *eth_dev)\n \t\tIXGBE_DEV_PRIVATE_TO_L2_TN_INFO(eth_dev->data->dev_private);\n \tstruct ixgbe_l2_tn_filter *l2_tn_filter;\n \n-\tif (l2_tn_info->hash_map)\n-\t\trte_free(l2_tn_info->hash_map);\n-\tif (l2_tn_info->hash_handle)\n-\t\trte_hash_free(l2_tn_info->hash_handle);\n+\trte_free(l2_tn_info->hash_map);\n+\trte_hash_free(l2_tn_info->hash_handle);\n \n \twhile ((l2_tn_filter = TAILQ_FIRST(&l2_tn_info->l2_tn_list))) {\n \t\tTAILQ_REMOVE(&l2_tn_info->l2_tn_list,\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 99e928a2a971..9e8ea366a506 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -2983,8 +2983,7 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)\n \trxq->rx_tail = 0;\n \trxq->nb_rx_hold = 0;\n \n-\tif (rxq->pkt_first_seg != NULL)\n-\t\trte_pktmbuf_free(rxq->pkt_first_seg);\n+\trte_pktmbuf_free(rxq->pkt_first_seg);\n \n \trxq->pkt_first_seg = NULL;\n \trxq->pkt_last_seg = NULL;\n", "prefixes": [ "54/82" ] }