Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106244/?format=api
http://patches.dpdk.org/api/patches/106244/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-6-stephen@networkplumber.org", "date": "2022-01-24T00:04:01", "name": "[05/82] examples/ip_pipeline: remove unnecessary NULL checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2a743860ae918b0afb12f23bba9006d3b64b5076", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "http://patches.dpdk.org/api/series/21315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/21315/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106244/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106244/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 250B9A04A6;\n\tMon, 24 Jan 2022 01:05:54 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 67669427CE;\n\tMon, 24 Jan 2022 01:05:30 +0100 (CET)", "from mail-pg1-f171.google.com (mail-pg1-f171.google.com\n [209.85.215.171])\n by mails.dpdk.org (Postfix) with ESMTP id 94624427C0\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:05:27 +0100 (CET)", "by mail-pg1-f171.google.com with SMTP id z131so2613283pgz.12\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:05:27 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.05.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:05:26 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=m9Fhm5t+AxyhwGNqtgJo7EQpKlSWzjNFbTcX1SJZ86I=;\n b=pLWv0c9sT2qNA+s3P88Lq9ExeY10VBr6Tw4THLP6o5Xw/9KZ+WnAmWSQhMx5m4dxUf\n oz2MpxjsrpGqVg/NeCIzzNoOkvPU61WxNg3HCXTMOvhYtAA7Pw2LysR0aaKxJlIIZ5YG\n D2SmCYSNztZ5BvZUZ6y75jVJgnvh4UoMjM7Zu+8idHHnKj4oobrc5AYLYDymLLnpg9xv\n pP/SqkdyGATWzKxhkpVXtg1IvctPnzwQCxP4MOhl8d5IHoqK7JS2HxiiNAqSwB/W7rZI\n BZHGF1XPqkFfAbAP8PXLcKn+OL4HDnVR5gHNxylYwEQOVvY75njDUWa9uk88XfGL6nGH\n OEZg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=m9Fhm5t+AxyhwGNqtgJo7EQpKlSWzjNFbTcX1SJZ86I=;\n b=DW9ilkrYWyqZU/c47c/xNwwxA4GIsv5JsNs1e+ZtFKoI1MsPhiWYPon55rQ5/Milax\n ayAOLPKY5kuWYvxtY8naz+BuissFBsCWC27WVRb/f/bDSePX2MjVT0Gh9LU3ymSVKt/i\n khXfByKiqsyWWEJUXwKp5kk0v/JhO/ODKm5ms/VLvGQoCrnSbZKAc08VEnR45uwrigU5\n kvx4+VLv2iNFiDNBgV2AkGxZH6PZjD7b9etUWnvPg05bfSEKwN3jo1Z2QMsELNTZiDwa\n sEZfgPMs3Nct56GRTz292zAEcQFSCHV8edECvA4925epkpzxpPxforv3KQi1k4lcnR7+\n 35Ow==", "X-Gm-Message-State": "AOAM533t2IJSOxZbQ6gS3pCSOWoXaBbw+kzBGvK18GQocdM0eQGe6WBM\n WUJvJU57Zyta5MLSRAMhEaAW2/cCzOqd/g==", "X-Google-Smtp-Source": "\n ABdhPJzzO5hjrtgxPHlLX0NiWDg9zmbeIE3FxvYFmIcnnMXEuo5iZnotc0992pESPieQU8YBKgN4oQ==", "X-Received": "by 2002:a63:4e58:: with SMTP id o24mr9907609pgl.525.1642982726607;\n Sun, 23 Jan 2022 16:05:26 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH 05/82] examples/ip_pipeline: remove unnecessary NULL checks", "Date": "Sun, 23 Jan 2022 16:04:01 -0800", "Message-Id": "<20220124000518.319850-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove redundant NULL pointer checks before free functions\nfound by nullfree.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/ip_pipeline/cli.c | 12 ++++--------\n examples/ip_pipeline/cryptodev.c | 6 ++----\n examples/ip_pipeline/thread.c | 6 ++----\n 3 files changed, 8 insertions(+), 16 deletions(-)", "diff": "diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c\nindex 0c372675a919..c918f30e06f3 100644\n--- a/examples/ip_pipeline/cli.c\n+++ b/examples/ip_pipeline/cli.c\n@@ -3773,10 +3773,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p)\n \n \t\tswitch (xform[i]->type) {\n \t\tcase RTE_CRYPTO_SYM_XFORM_CIPHER:\n-\t\t\tif (p->cipher_auth.cipher_iv.val)\n-\t\t\t\tfree(p->cipher_auth.cipher_iv.val);\n-\t\t\tif (p->cipher_auth.cipher_iv_update.val)\n-\t\t\t\tfree(p->cipher_auth.cipher_iv_update.val);\n+\t\t\tfree(p->cipher_auth.cipher_iv.val);\n+\t\t\tfree(p->cipher_auth.cipher_iv_update.val);\n \t\t\tbreak;\n \t\tcase RTE_CRYPTO_SYM_XFORM_AUTH:\n \t\t\tif (p->cipher_auth.auth_iv.val)\n@@ -3785,10 +3783,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p)\n \t\t\t\tfree(p->cipher_auth.cipher_iv_update.val);\n \t\t\tbreak;\n \t\tcase RTE_CRYPTO_SYM_XFORM_AEAD:\n-\t\t\tif (p->aead.iv.val)\n-\t\t\t\tfree(p->aead.iv.val);\n-\t\t\tif (p->aead.aad.val)\n-\t\t\t\tfree(p->aead.aad.val);\n+\t\t\tfree(p->aead.iv.val);\n+\t\t\tfree(p->aead.aad.val);\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tcontinue;\ndiff --git a/examples/ip_pipeline/cryptodev.c b/examples/ip_pipeline/cryptodev.c\nindex 9997d974563f..cd0f9c3d4eac 100644\n--- a/examples/ip_pipeline/cryptodev.c\n+++ b/examples/ip_pipeline/cryptodev.c\n@@ -151,10 +151,8 @@ cryptodev_create(const char *name, struct cryptodev_params *params)\n \treturn cryptodev;\n \n error_exit:\n-\tif (cryptodev->mp_create)\n-\t\trte_mempool_free(cryptodev->mp_create);\n-\tif (cryptodev->mp_init)\n-\t\trte_mempool_free(cryptodev->mp_init);\n+\trte_mempool_free(cryptodev->mp_create);\n+\trte_mempool_free(cryptodev->mp_init);\n \n \tfree(cryptodev);\n \ndiff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c\nindex b2e97327052f..82d5f87c384c 100644\n--- a/examples/ip_pipeline/thread.c\n+++ b/examples/ip_pipeline/thread.c\n@@ -92,11 +92,9 @@ thread_free(void)\n \t\t\tcontinue;\n \n \t\t/* MSGQs */\n-\t\tif (t->msgq_req)\n-\t\t\trte_ring_free(t->msgq_req);\n+\t\trte_ring_free(t->msgq_req);\n \n-\t\tif (t->msgq_rsp)\n-\t\t\trte_ring_free(t->msgq_rsp);\n+\t\trte_ring_free(t->msgq_rsp);\n \t}\n }\n \n", "prefixes": [ "05/82" ] }{ "id": 106244, "url": "