Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106242/?format=api
{ "id": 106242, "url": "http://patches.dpdk.org/api/patches/106242/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124000518.319850-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124000518.319850-4-stephen@networkplumber.org", "date": "2022-01-24T00:03:59", "name": "[03/82] eal/windows: remove unnecessary NULL checks before free", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d5f418bed9d7193341a90ed4b09096764bcdbec8", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220124000518.319850-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 21315, "url": "http://patches.dpdk.org/api/series/21315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21315", "date": "2022-01-24T00:03:56", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/21315/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106242/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106242/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C06EA04A6;\n\tMon, 24 Jan 2022 01:05:43 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5B18A427C4;\n\tMon, 24 Jan 2022 01:05:28 +0100 (CET)", "from mail-pj1-f48.google.com (mail-pj1-f48.google.com\n [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 846CC427AB\n for <dev@dpdk.org>; Mon, 24 Jan 2022 01:05:25 +0100 (CET)", "by mail-pj1-f48.google.com with SMTP id d5so12234348pjk.5\n for <dev@dpdk.org>; Sun, 23 Jan 2022 16:05:25 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n ck21sm10935350pjb.51.2022.01.23.16.05.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 23 Jan 2022 16:05:24 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OgIanIgFtHcdHoFnpNWsa8XIcvgA8wPsembFoHuQzfg=;\n b=qkrmeDnhk44ygwVEF1zMOau1P8ij0Mw/12WsagZrmkf5tlI/LDMODRk3Wh6jfg7SGH\n 6b8iEI7ElK4VnTMNQjmYERRA5z0F+i3XuAmRylbu8NZ0NE5i6bq+rfzprExh/wjDlMjg\n fIeCV5b2KPyCA6D5p6ij2c9DbWdwF8vw44s4WNz2U+JigG1+2gHyY60NnpIHXT/tva9O\n cHqAc7UdmFjQIgAzoiJ8rWnyESdIUbqMDQ33vh1zTi7MPqzCGyy4FGPUykg1+nqTMiOQ\n iswFFPMn1h7W8eGBWFsnZBvIiwZYmwbmsrMQlITLe5XIdUH9goJ78/oNejtTfQ4lC+Yw\n GMEg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OgIanIgFtHcdHoFnpNWsa8XIcvgA8wPsembFoHuQzfg=;\n b=lJLocnTmW6iT3LPD+/v2d7xJ1zghWXbL9GtDWvIy/4KVNZFM9fvlDddVe7E6vyJkY0\n ARephL4VMTcJWDbNhrhowEMX5hkog7XyX7VyhP8XcGSLXochTFzOMgnBOHqlrLYtRd9M\n QU5NjHB6SdTyZl7hpXjtQzDhHT13d1oar5ft3u1UvHPI2XCn07/lvN6WWPVXP+TowBM1\n heVZoS8KKlysT7t7KssrR76CKoyXTNVWgTrB4ivA7dnsghthfoQL6IgWt4oYlgk9EDyl\n 2d2HksEDbaQhpbG2NCnIrqyPEtSVW4g5IqvoRHp1c7ygG6xJ6kwqfLSH8VJtZJHprpVT\n mZbQ==", "X-Gm-Message-State": "AOAM53331BAXelxqgzwB43pVIeUt+5Cn8SSTo3ix8RrJOQqK7F2luAvR\n W3zEGEa7/cyLDnumAwcj1hxeBb6NxKYLiQ==", "X-Google-Smtp-Source": "\n ABdhPJzv0A2WRnc2x1t6AGWOMrEY9TMqoYeA7Or4wzPQYqozc5P5EsL5vInvhGu2bIhkh1b4jpXDXA==", "X-Received": "by 2002:a17:902:a5c6:b0:149:c926:7c31 with SMTP id\n t6-20020a170902a5c600b00149c9267c31mr12439719plq.141.1642982724528;\n Sun, 23 Jan 2022 16:05:24 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH 03/82] eal/windows: remove unnecessary NULL checks before free", "Date": "Sun, 23 Jan 2022 16:03:59 -0800", "Message-Id": "<20220124000518.319850-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220124000518.319850-1-stephen@networkplumber.org>", "References": "<20220124000518.319850-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Calling free/rte_free/rte_mempool_free,... with NULL pointer\nis allowed; so remove unnecessary NULL checks.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/windows/eal_alarm.c | 3 +--\n lib/eal/windows/eal_memory.c | 3 +--\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eal/windows/eal_alarm.c b/lib/eal/windows/eal_alarm.c\nindex 103c1f909da3..51fe752c16d4 100644\n--- a/lib/eal/windows/eal_alarm.c\n+++ b/lib/eal/windows/eal_alarm.c\n@@ -162,8 +162,7 @@ rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg)\n fail:\n \tif (timer != NULL)\n \t\tCloseHandle(timer);\n-\tif (ap != NULL)\n-\t\tfree(ap);\n+\tfree(ap);\n \n exit:\n \trte_eal_trace_alarm_set(us, cb_fn, cb_arg, ret);\ndiff --git a/lib/eal/windows/eal_memory.c b/lib/eal/windows/eal_memory.c\nindex 2fd37d97085e..215d768e2c57 100644\n--- a/lib/eal/windows/eal_memory.c\n+++ b/lib/eal/windows/eal_memory.c\n@@ -190,8 +190,7 @@ eal_mem_virt2iova_init(void)\n \tret = 0;\n \n exit:\n-\tif (detail != NULL)\n-\t\tfree(detail);\n+\tfree(detail);\n \tif (list != INVALID_HANDLE_VALUE)\n \t\tSetupDiDestroyDeviceInfoList(list);\n \n", "prefixes": [ "03/82" ] }