Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106163/?format=api
{ "id": 106163, "url": "http://patches.dpdk.org/api/patches/106163/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220121103122.2926856-3-ronan.randles@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220121103122.2926856-3-ronan.randles@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220121103122.2926856-3-ronan.randles@intel.com", "date": "2022-01-21T10:31:09", "name": "[v2,02/15] net: add function to pretty print IPv4", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "3aba209a3033959f9246817f3240a4aa645794e1", "submitter": { "id": 2439, "url": "http://patches.dpdk.org/api/people/2439/?format=api", "name": "Ronan Randles", "email": "ronan.randles@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220121103122.2926856-3-ronan.randles@intel.com/mbox/", "series": [ { "id": 21295, "url": "http://patches.dpdk.org/api/series/21295/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21295", "date": "2022-01-21T10:31:07", "name": "add packet generator library and example app", "version": 2, "mbox": "http://patches.dpdk.org/series/21295/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/106163/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/106163/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 006AEA034E;\n\tFri, 21 Jan 2022 11:31:44 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B299842751;\n\tFri, 21 Jan 2022 11:31:34 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id C5B1940042\n for <dev@dpdk.org>; Fri, 21 Jan 2022 11:31:32 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jan 2022 02:31:32 -0800", "from silpixa00401120.ir.intel.com ([10.55.128.255])\n by orsmga008.jf.intel.com with ESMTP; 21 Jan 2022 02:31:31 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1642761093; x=1674297093;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=5+UYx+hbjVJM/7fvf5oUftHOMI30Hf333p11TZUG+qc=;\n b=NZXQl9GwZUHmrcftss8MFlL+7PkofJjBugv0peroS61toDC+ipoU0fXQ\n Y48dYl8adt/VjlZXkJ6z9a4Xy4EYeszUN4ArE/vx6nqN2wbXbHH3fnh9v\n DliJVag70ZDGYLiAVlUvyWBJBwn81Ay+uEY1bs/MUFXj8MUWY9FjZZaOS\n rDTf0IaEXb95q6yquWeAYtMvbOQVI0K7AjnSCuuW0YgpyfVK8BCR8vOjT\n FBAOUdgafiqZMnxm61i+XzC728dvHNqcJ1HLOibgQK7gzMe8JY8VUsU0y\n NCX9RwAO91CwZLyjBIXdzmwjVRxBKGPCO5BKwFOAFB9w603C53lCFcsbC A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10233\"; a=\"270045070\"", "E=Sophos;i=\"5.88,304,1635231600\"; d=\"scan'208\";a=\"270045070\"", "E=Sophos;i=\"5.88,304,1635231600\"; d=\"scan'208\";a=\"533222716\"" ], "X-ExtLoop1": "1", "From": "Ronan Randles <ronan.randles@intel.com>", "To": "dev@dpdk.org", "Cc": "Ronan Randles <ronan.randles@intel.com>", "Subject": "[PATCH v2 02/15] net: add function to pretty print IPv4", "Date": "Fri, 21 Jan 2022 10:31:09 +0000", "Message-Id": "<20220121103122.2926856-3-ronan.randles@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220121103122.2926856-1-ronan.randles@intel.com>", "References": "<20211214141242.3383831-1-ronan.randles@intel.com>\n <20220121103122.2926856-1-ronan.randles@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This function accepts an uint32_t representation of an IP address and\nproduces a string representation stored in a char * buffer. Realavent\nunit tests also included.\n\nSigned-off-by: Ronan Randles <ronan.randles@intel.com>\n---\n app/test/test_net.c | 26 ++++++++++++++++++++++++++\n lib/net/rte_ip.c | 15 +++++++++++++++\n lib/net/rte_ip.h | 20 ++++++++++++++++++++\n lib/net/version.map | 1 +\n 4 files changed, 62 insertions(+)", "diff": "diff --git a/app/test/test_net.c b/app/test/test_net.c\nindex 2cb7d3e1c9..75beeea671 100644\n--- a/app/test/test_net.c\n+++ b/app/test/test_net.c\n@@ -46,7 +46,32 @@ test_rte_ip_parse_addr(void)\n \t\t\t\treturn -1;\n \t\t}\n \t}\n+\treturn 0;\n+}\n+\n+static int\n+test_rte_ip_print_addr(void)\n+{\n+\tprintf(\"Running IP printing tests...\\n\");\n+\tchar buffer[128];\n \n+\tstruct ip_str_t {\n+\t\tuint32_t ip_addr;\n+\t\tconst char *exp_output;\n+\t} ip_str_tests[] = {\n+\t\t{ .ip_addr = 16909060, .exp_output = \"1.2.3.4\"},\n+\t\t{ .ip_addr = 3232301055, . exp_output = \"192.168.255.255\"},\n+\t\t{ .ip_addr = 2886729737, .exp_output = \"172.16.0.9\"}\n+\t};\n+\n+\tuint32_t i;\n+\tfor (i = 0; i < RTE_DIM(ip_str_tests); i++) {\n+\t\tint32_t err = rte_ip_print_addr(ip_str_tests[i].ip_addr,\n+\t\t\t\t\t\t\t\tbuffer, 128);\n+\n+\t\tif (err || strcmp(buffer, ip_str_tests[i].exp_output))\n+\t\t\treturn -1;\n+\t}\n \n \treturn 0;\n }\n@@ -55,6 +80,7 @@ static int\n test_net_tests(void)\n {\n \tint ret = test_rte_ip_parse_addr();\n+\tret += test_rte_ip_print_addr();\n \treturn ret;\n }\n \ndiff --git a/lib/net/rte_ip.c b/lib/net/rte_ip.c\nindex b859dfb640..fbd9161317 100644\n--- a/lib/net/rte_ip.c\n+++ b/lib/net/rte_ip.c\n@@ -41,3 +41,18 @@ rte_ip_parse_addr(const char *src_ip, uint32_t *output_addr)\n \tfree(tok);\n \treturn ret;\n }\n+\n+int32_t\n+rte_ip_print_addr(uint32_t ip_addr, char *buffer, uint32_t buffer_size)\n+{\n+\tif (buffer == NULL)\n+\t\treturn -1;\n+\n+\tsnprintf(buffer, buffer_size, \"%u.%u.%u.%u\",\n+\t\t(ip_addr >> 24),\n+\t\t(ip_addr >> 16) & UINT8_MAX,\n+\t\t(ip_addr >> 8) & UINT8_MAX,\n+\t\t ip_addr & UINT8_MAX);\n+\n+\treturn 0;\n+}\ndiff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h\nindex 188054fda4..e46f0b41ba 100644\n--- a/lib/net/rte_ip.h\n+++ b/lib/net/rte_ip.h\n@@ -444,6 +444,26 @@ __rte_experimental\n int32_t\n rte_ip_parse_addr(const char *src_ip, uint32_t *output_addr);\n \n+\n+/**\n+ * Print IP address from 32 bit int into char * buffer.\n+ *\n+ * @param ip_addr\n+ * ip address to be printed.\n+ * @param buffer\n+ * The buffer the string will be saved into.\n+ * @param buffer_size\n+ * size of buffer to be used.\n+ *\n+ * @retval 0\n+ * Success.\n+ * @retval -1\n+ * Failure due to invalid input arguments.\n+ */\n+__rte_experimental\n+int32_t\n+rte_ip_print_addr(uint32_t ip_addr, char *buffer, uint32_t buffer_size);\n+\n /**\n * IPv6 Header\n */\ndiff --git a/lib/net/version.map b/lib/net/version.map\nindex c530d1a4e4..7fe9892d03 100644\n--- a/lib/net/version.map\n+++ b/lib/net/version.map\n@@ -17,4 +17,5 @@ EXPERIMENTAL {\n \tglobal:\n \n \trte_ip_parse_addr;\n+\trte_ip_print_addr;\n };\n", "prefixes": [ "v2", "02/15" ] }