Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105613/?format=api
{ "id": 105613, "url": "http://patches.dpdk.org/api/patches/105613/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220104083824.23001-15-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220104083824.23001-15-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220104083824.23001-15-kalesh-anakkur.purayil@broadcom.com", "date": "2022-01-04T08:38:20", "name": "[14/18] net/bnxt: fix ring teardown", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2cd4669262c970a1fc6a334d66d370c575cab2b1", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220104083824.23001-15-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 21060, "url": "http://patches.dpdk.org/api/series/21060/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21060", "date": "2022-01-04T08:38:06", "name": "bnxt PMD fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/21060/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105613/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105613/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2ACD0A00C5;\n\tTue, 4 Jan 2022 09:20:27 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5DE33411F3;\n\tTue, 4 Jan 2022 09:19:34 +0100 (CET)", "from relay.smtp-ext.broadcom.com (lpdvsmtp11.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id 349D741145\n for <dev@dpdk.org>; Tue, 4 Jan 2022 09:19:33 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 89628C0000F1;\n Tue, 4 Jan 2022 00:19:31 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 89628C0000F1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1641284372;\n bh=Hvz6KjiuTUF3V4ibQMaaIEfZXkoj2Xr9BiMz5po86SA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=X0yj7C1mwDQFv8ldrFPZo1hgQvPD6oHFLCx1NPF1gN/bCKUY9o3GxKBbZp3SQuq/b\n 3IcxYfyEtFHwjLGeTFsD+JrO3XP6y9D6ceFu/W8zVl4Xof2kB6jUDUZ/0BdfErdKvs\n vajjVmYq3O1joQ2bTj/jjGHF69S/syXIVBV61igU=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Subject": "[dpdk-dev] [PATCH 14/18] net/bnxt: fix ring teardown", "Date": "Tue, 4 Jan 2022 14:08:20 +0530", "Message-Id": "<20220104083824.23001-15-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20220104083824.23001-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20220104083824.23001-1-kalesh-anakkur.purayil@broadcom.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Ajit Khaparde <ajit.khaparde@broadcom.com>\n\nCheck for valid bit while scanning for hwrm_done completion\nduring ring teardown. Not checking the valid bit could cause a\nring overflow when we ring the doorbell.\n\nFixes: 4fb6ab3f866d (\"net/bnxt: check flush status during ring free\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxr.c | 3 +++\n drivers/net/bnxt/bnxt_txr.c | 3 +++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex 9621809..b60c247 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -1411,6 +1411,9 @@ int bnxt_flush_rx_cmp(struct bnxt_cp_ring_info *cpr)\n \t\tcons = RING_CMP(cpr->cp_ring_struct, raw_cons);\n \t\trxcmp = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[cons];\n \n+\t\tif (!bnxt_cpr_cmp_valid(rxcmp, raw_cons, ring_mask + 1))\n+\t\t\tbreak;\n+\n \t\tif (CMP_TYPE(rxcmp) == CMPL_BASE_TYPE_HWRM_DONE)\n \t\t\treturn 1;\n \ndiff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex e2b7e40..3b8f238 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -602,6 +602,9 @@ int bnxt_flush_tx_cmp(struct bnxt_cp_ring_info *cpr)\n \t\tcons = RING_CMPL(ring_mask, raw_cons);\n \t\ttxcmp = (struct tx_cmpl *)&cp_desc_ring[cons];\n \n+\t\tif (!bnxt_cpr_cmp_valid(txcmp, raw_cons, ring_mask + 1))\n+\t\t\tbreak;\n+\n \t\topaque = rte_cpu_to_le_32(txcmp->opaque);\n \t\traw_cons = NEXT_RAW_CMP(raw_cons);\n \n", "prefixes": [ "14/18" ] }