Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105611/?format=api
{ "id": 105611, "url": "http://patches.dpdk.org/api/patches/105611/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220104083824.23001-13-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220104083824.23001-13-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220104083824.23001-13-kalesh-anakkur.purayil@broadcom.com", "date": "2022-01-04T08:38:18", "name": "[12/18] net/bnxt: refactor bnxt_stop_rxtx() for reuse", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b49764defe3e76bdf5bb2a904b3c85a5c1a4b988", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220104083824.23001-13-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 21060, "url": "http://patches.dpdk.org/api/series/21060/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21060", "date": "2022-01-04T08:38:06", "name": "bnxt PMD fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/21060/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105611/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105611/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 457EDA00C5;\n\tTue, 4 Jan 2022 09:20:16 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1DF6E411B8;\n\tTue, 4 Jan 2022 09:19:32 +0100 (CET)", "from relay.smtp-ext.broadcom.com (lpdvsmtp11.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id EE6A5411A7\n for <dev@dpdk.org>; Tue, 4 Jan 2022 09:19:29 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 4882DC0000F1;\n Tue, 4 Jan 2022 00:19:28 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 4882DC0000F1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1641284369;\n bh=RadfgO/Sx0Au1fYl48ayaAN2oJ1HSRibQdPY8ziEI1E=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=qa2I5k6r2ZlDHKWrsA3SrNUFyU4iNouqin8Bi8Kf/0qOyESk7HK+PV1IvDiy6yDTc\n Q2GLfEBLHoW/arnX2yTSpbrIonwGqXHsWivJVvt22xEZJMjnjZ5RtlOXVw6JkCJuiy\n o/ytOlzKV1eapIORtoUHefO+923mPzZpKrCc8tSE=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Subject": "[dpdk-dev] [PATCH 12/18] net/bnxt: refactor bnxt_stop_rxtx() for\n reuse", "Date": "Tue, 4 Jan 2022 14:08:18 +0530", "Message-Id": "<20220104083824.23001-13-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20220104083824.23001-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20220104083824.23001-1-kalesh-anakkur.purayil@broadcom.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nBy accepting rte_eth_dev as input, bnxt_stop_rxtx() can be used\nin multiple scenarios such as representor devices.\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 16 ++++++++--------\n drivers/net/bnxt/bnxt_cpr.h | 2 +-\n drivers/net/bnxt/bnxt_ethdev.c | 5 ++---\n drivers/net/bnxt/bnxt_reps.c | 3 +--\n 4 files changed, 12 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex a43b22a..593eebf 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -149,7 +149,7 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\t * Avoid any rx/tx packet processing during firmware reset\n \t\t * operation.\n \t\t */\n-\t\tbnxt_stop_rxtx(bp);\n+\t\tbnxt_stop_rxtx(bp->eth_dev);\n \n \t\t/* Ignore reset notify async events when stopping the port */\n \t\tif (!bp->eth_dev->data->dev_started) {\n@@ -383,15 +383,15 @@ bool bnxt_is_recovery_enabled(struct bnxt *bp)\n \treturn false;\n }\n \n-void bnxt_stop_rxtx(struct bnxt *bp)\n+void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev)\n {\n-\tbp->eth_dev->rx_pkt_burst = &bnxt_dummy_recv_pkts;\n-\tbp->eth_dev->tx_pkt_burst = &bnxt_dummy_xmit_pkts;\n+\teth_dev->rx_pkt_burst = &bnxt_dummy_recv_pkts;\n+\teth_dev->tx_pkt_burst = &bnxt_dummy_xmit_pkts;\n \n-\trte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =\n-\t\tbp->eth_dev->rx_pkt_burst;\n-\trte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =\n-\t\tbp->eth_dev->tx_pkt_burst;\n+\trte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst =\n+\t\teth_dev->rx_pkt_burst;\n+\trte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst =\n+\t\teth_dev->tx_pkt_burst;\n \trte_mb();\n \n \t/* Allow time for threads to exit the real burst functions. */\ndiff --git a/drivers/net/bnxt/bnxt_cpr.h b/drivers/net/bnxt/bnxt_cpr.h\nindex 73468ed..52db382 100644\n--- a/drivers/net/bnxt/bnxt_cpr.h\n+++ b/drivers/net/bnxt/bnxt_cpr.h\n@@ -117,7 +117,7 @@ void bnxt_wait_for_device_shutdown(struct bnxt *bp);\n bool bnxt_is_recovery_enabled(struct bnxt *bp);\n bool bnxt_is_primary_func(struct bnxt *bp);\n \n-void bnxt_stop_rxtx(struct bnxt *bp);\n+void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev);\n \n /**\n * Check validity of a completion ring entry. If the entry is valid, include a\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 00acdb7..cf3bd77 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1471,8 +1471,7 @@ static int bnxt_dev_stop(struct rte_eth_dev *eth_dev)\n \teth_dev->data->dev_started = 0;\n \n \t/* Prevent crashes when queues are still in use */\n-\teth_dev->rx_pkt_burst = &bnxt_dummy_recv_pkts;\n-\teth_dev->tx_pkt_burst = &bnxt_dummy_xmit_pkts;\n+\tbnxt_stop_rxtx(eth_dev);\n \n \tbnxt_disable_int(bp);\n \n@@ -4557,7 +4556,7 @@ static void bnxt_check_fw_health(void *arg)\n \tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n \tbp->flags |= BNXT_FLAG_FW_RESET;\n \n-\tbnxt_stop_rxtx(bp);\n+\tbnxt_stop_rxtx(bp->eth_dev);\n \n \tPMD_DRV_LOG(ERR, \"Detected FW dead condition\\n\");\n \ndiff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex 22b76b7..f24f5ef 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -505,8 +505,7 @@ int bnxt_rep_dev_stop_op(struct rte_eth_dev *eth_dev)\n \tstruct bnxt_representor *vfr_bp = eth_dev->data->dev_private;\n \n \t/* Avoid crashes as we are about to free queues */\n-\teth_dev->rx_pkt_burst = &bnxt_dummy_recv_pkts;\n-\teth_dev->tx_pkt_burst = &bnxt_dummy_xmit_pkts;\n+\tbnxt_stop_rxtx(eth_dev);\n \n \tBNXT_TF_DBG(DEBUG, \"BNXT Port:%d VFR stop\\n\", eth_dev->data->port_id);\n \n", "prefixes": [ "12/18" ] }