Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105297/?format=api
{ "id": 105297, "url": "http://patches.dpdk.org/api/patches/105297/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/782531af297f80054ea965893bf2ed4a71af472c.1640071468.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<782531af297f80054ea965893bf2ed4a71af472c.1640071468.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/782531af297f80054ea965893bf2ed4a71af472c.1640071468.git.wangyunjian@huawei.com", "date": "2021-12-21T07:37:44", "name": "[1/1] net/mlx5: fix stack buffer overflow", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "0aa8f9befa43b28e7a6c71eebf12d0c096752dc2", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/782531af297f80054ea965893bf2ed4a71af472c.1640071468.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 20990, "url": "http://patches.dpdk.org/api/series/20990/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20990", "date": "2021-12-21T07:37:44", "name": "[1/1] net/mlx5: fix stack buffer overflow", "version": 1, "mbox": "http://patches.dpdk.org/series/20990/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105297/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105297/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2BAFDA0350;\n\tTue, 21 Dec 2021 08:37:54 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A3D1640040;\n\tTue, 21 Dec 2021 08:37:53 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 6977D4003C;\n Tue, 21 Dec 2021 08:37:52 +0100 (CET)", "from dggpemm500024.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JJ7Zv0h9lzbjbr;\n Tue, 21 Dec 2021 15:37:27 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2308.20; Tue, 21 Dec 2021 15:37:49 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 21 Dec\n 2021 15:37:48 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <viacheslavo@nvidia.com>, <dingxiaoxiong@huawei.com>,\n <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH 1/1] net/mlx5: fix stack buffer overflow", "Date": "Tue, 21 Dec 2021 15:37:44 +0800", "Message-ID": "\n <782531af297f80054ea965893bf2ed4a71af472c.1640071468.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The mlx5_sysfs_switch_info function get 'phys_port_name' buffer, using\n'IF_NAMESIZE' for that case will be wrong and it can cause buffer overflow.\n\nDetected with address sanitizer:\n0 (/usr/lib64/libasan.so.4+0x60b57)\n1 vfscanf (/usr/lib64/libasan.so.4+0x6170f)\n2 __interceptor_fscanf (/usr/lib64/libasan.so.4+0x61823)\n3 mlx5_sysfs_switch_info ../drivers/net/mlx5/linux/mlx5_ethdev_os.c:1098\n4 mlx5_os_pci_probe_pf ../drivers/net/mlx5/linux/mlx5_os.c:2417\n5 mlx5_os_pci_probe ../drivers/net/mlx5/linux/mlx5_os.c:2647\n6 mlx5_os_net_probe ../drivers/net/mlx5/linux/mlx5_os.c:2722\n7 drivers_probe ../drivers/common/mlx5/mlx5_common.c:657\n8 mlx5_common_dev_probe ../drivers/common/mlx5/mlx5_common.c:711\n9 rte_pci_probe_one_driver ../drivers/bus/pci/pci_common.c:269\n10 pci_probe_all_drivers ../drivers/bus/pci/pci_common.c:353\n11 pci_probe ../drivers/bus/pci/pci_common.c:380\n12 rte_bus_probe ../lib/eal/common/eal_common_bus.c:72\n13 rte_eal_init ../lib/eal/linux/eal.c:1286\n14 main ../app/test-pmd/testpmd.c:4112\n15 __libc_start_main (/usr/lib64/libc.so.6+0x23f7f)\n16 _start (dpdk/arm64-armv8a-linuxapp-gcc/app/dpdk-testpmd+0x4c88a3)\n\nFixes: 63d1db710fbc (\"net/mlx5: fix unlimited parsing of switch info\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\nindex c19825ee52..1d97110864 100644\n--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n@@ -1066,7 +1066,7 @@ int\n mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info)\n {\n \tchar ifname[IF_NAMESIZE];\n-\tchar port_name[IF_NAMESIZE];\n+\tchar port_name[IF_NAMESIZE + 1];\n \tFILE *file;\n \tstruct mlx5_switch_info data = {\n \t\t.master = 0,\n", "prefixes": [ "1/1" ] }