Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 105272,
    "url": "http://patches.dpdk.org/api/patches/105272/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211220055039.4035627-3-feifei.wang2@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211220055039.4035627-3-feifei.wang2@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211220055039.4035627-3-feifei.wang2@arm.com",
    "date": "2021-12-20T05:50:38",
    "name": "[2/3] net/ice: reduce redundant store operation",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0326d076abb7d15832895cdc05d4f0a56a3241d5",
    "submitter": {
        "id": 1771,
        "url": "http://patches.dpdk.org/api/people/1771/?format=api",
        "name": "Feifei Wang",
        "email": "feifei.wang2@arm.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211220055039.4035627-3-feifei.wang2@arm.com/mbox/",
    "series": [
        {
            "id": 20979,
            "url": "http://patches.dpdk.org/api/series/20979/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20979",
            "date": "2021-12-20T05:50:36",
            "name": "reduce redundant store operation for Tx free",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/20979/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/105272/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/105272/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81770A034C;\n\tMon, 20 Dec 2021 06:51:01 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1191C4115B;\n\tMon, 20 Dec 2021 06:50:55 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 44D8D4115A\n for <dev@dpdk.org>; Mon, 20 Dec 2021 06:50:54 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B93C51042;\n Sun, 19 Dec 2021 21:50:53 -0800 (PST)",
            "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.123])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9D7C43F5A1;\n Sun, 19 Dec 2021 21:50:51 -0800 (PST)"
        ],
        "From": "Feifei Wang <feifei.wang2@arm.com>",
        "To": "Qiming Yang <qiming.yang@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>",
        "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>",
        "Subject": "[PATCH 2/3] net/ice: reduce redundant store operation",
        "Date": "Mon, 20 Dec 2021 13:50:38 +0800",
        "Message-Id": "<20211220055039.4035627-3-feifei.wang2@arm.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20211220055039.4035627-1-feifei.wang2@arm.com>",
        "References": "<20211220055039.4035627-1-feifei.wang2@arm.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "For free buffer in ice driver, it is unnecessary to store 'NULL' into\ntxep.mbuf. This is because when putting mbuf into Tx queue, tx_tail is\nthe sentinel. And when doing tx_free, tx_next_dd is the sentinel. In all\nprocesses, mbuf==NULL is not a condition in check. Thus reset of mbuf is\nunnecessary and can be omitted.\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/ice/ice_rxtx.c | 2 --\n 1 file changed, 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex f6d8564ab8..e043335bad 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -2893,12 +2893,10 @@ ice_tx_free_bufs(struct ice_tx_queue *txq)\n \tif (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {\n \t\tfor (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {\n \t\t\trte_mempool_put(txep->mbuf->pool, txep->mbuf);\n-\t\t\ttxep->mbuf = NULL;\n \t\t}\n \t} else {\n \t\tfor (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {\n \t\t\trte_pktmbuf_free_seg(txep->mbuf);\n-\t\t\ttxep->mbuf = NULL;\n \t\t}\n \t}\n \n",
    "prefixes": [
        "2/3"
    ]
}