Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105269/?format=api
{ "id": 105269, "url": "http://patches.dpdk.org/api/patches/105269/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211220054246.4031616-1-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211220054246.4031616-1-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211220054246.4031616-1-feifei.wang2@arm.com", "date": "2021-12-20T05:42:46", "name": "net/i40e: remove redundant judgment for rearm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "73905ba4e177d93ee53ebd7f2974b8e604d55a80", "submitter": { "id": 1771, "url": "http://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211220054246.4031616-1-feifei.wang2@arm.com/mbox/", "series": [ { "id": 20978, "url": "http://patches.dpdk.org/api/series/20978/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20978", "date": "2021-12-20T05:42:46", "name": "net/i40e: remove redundant judgment for rearm", "version": 1, "mbox": "http://patches.dpdk.org/series/20978/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105269/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B2EEFA034C;\n\tMon, 20 Dec 2021 06:42:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 392EF40395;\n\tMon, 20 Dec 2021 06:42:57 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id C2D8F40141\n for <dev@dpdk.org>; Mon, 20 Dec 2021 06:42:55 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A22B1042;\n Sun, 19 Dec 2021 21:42:55 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.123])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7D0483F5A1;\n Sun, 19 Dec 2021 21:42:52 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Ruifeng Wang <ruifeng.wang@arm.com>, Beilei Xing <beilei.xing@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Subject": "[PATCH] net/i40e: remove redundant judgment for rearm", "Date": "Mon, 20 Dec 2021 13:42:46 +0800", "Message-Id": "<20211220054246.4031616-1-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Merged variable updates under the same condition. It reduces branch.\n\nIn n1sdp, there is no performance improvement with this patch.\nIn x86, there is also no performance improvement.\n\nSuggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_neon.c | 9 +++++----\n drivers/net/i40e/i40e_rxtx_vec_sse.c | 9 +++++----\n 2 files changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c\nindex b951ea2dc3..c7e4222b61 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_neon.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c\n@@ -64,14 +64,15 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq)\n \t}\n \n \trxq->rxrearm_start += RTE_I40E_RXQ_REARM_THRESH;\n-\tif (rxq->rxrearm_start >= rxq->nb_rx_desc)\n+\trx_id = rxq->rxrearm_start - 1;\n+\n+\tif (unlikely(rxq->rxrearm_start >= rxq->nb_rx_desc)) {\n \t\trxq->rxrearm_start = 0;\n+\t\trx_id = rxq->nb_rx_desc - 1;\n+\t}\n \n \trxq->rxrearm_nb -= RTE_I40E_RXQ_REARM_THRESH;\n \n-\trx_id = (uint16_t)((rxq->rxrearm_start == 0) ?\n-\t\t\t (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1));\n-\n \trte_io_wmb();\n \t/* Update the tail pointer on the NIC */\n \tI40E_PCI_REG_WRITE_RELAXED(rxq->qrx_tail, rx_id);\ndiff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e_rxtx_vec_sse.c\nindex 497b2404c6..0910039d69 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_sse.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c\n@@ -77,14 +77,15 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq)\n \t}\n \n \trxq->rxrearm_start += RTE_I40E_RXQ_REARM_THRESH;\n-\tif (rxq->rxrearm_start >= rxq->nb_rx_desc)\n+\trx_id = rxq->rxrearm_start - 1;\n+\n+\tif (unlikely(rxq->rxrearm_start >= rxq->nb_rx_desc)) {\n \t\trxq->rxrearm_start = 0;\n+\t\trx_id = rxq->nb_rx_desc - 1;\n+\t}\n \n \trxq->rxrearm_nb -= RTE_I40E_RXQ_REARM_THRESH;\n \n-\trx_id = (uint16_t)((rxq->rxrearm_start == 0) ?\n-\t\t\t (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1));\n-\n \t/* Update the tail pointer on the NIC */\n \tI40E_PCI_REG_WC_WRITE(rxq->qrx_tail, rx_id);\n }\n", "prefixes": [] }