Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105191/?format=api
{ "id": 105191, "url": "http://patches.dpdk.org/api/patches/105191/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1639676975-1316-28-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1639676975-1316-28-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1639676975-1316-28-git-send-email-anoobj@marvell.com", "date": "2021-12-16T17:49:33", "name": "[v2,27/29] crypto/cnxk: add per pkt IV in lookaside IPsec debug mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "88483a2964bca85a4a280bd1c94bc59112a85fbf", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1639676975-1316-28-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 20957, "url": "http://patches.dpdk.org/api/series/20957/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20957", "date": "2021-12-16T17:49:06", "name": "New features and improvements in cnxk crypto PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/20957/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105191/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105191/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 71358A0032;\n\tThu, 16 Dec 2021 18:55:31 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BF75E41154;\n\tThu, 16 Dec 2021 18:55:05 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id E1FF44114D\n for <dev@dpdk.org>; Thu, 16 Dec 2021 18:55:03 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1BGENSPe008296\n for <dev@dpdk.org>; Thu, 16 Dec 2021 09:55:03 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3d02p0af5k-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 16 Dec 2021 09:55:03 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Thu, 16 Dec 2021 09:55:01 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Thu, 16 Dec 2021 09:55:01 -0800", "from HY-LT1002.marvell.com (HY-LT1002.marvell.com [10.28.176.218])\n by maili.marvell.com (Postfix) with ESMTP id A12DB3F7048;\n Thu, 16 Dec 2021 09:54:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=FGKHc5xs89UyCm9iDrLL+wB81Sx4kq5iIcBxjTB7B+o=;\n b=PJOxziTQdYV8gucEEwVasRblLAg0rIp2Y896FU8nfvo94+HtoYQmZWqYIaS3rSkc18T0\n 2+LZQvLcrIg1ZePO961tu6OTSxXS5Wi1uHKaI2KAFfe8sLN05LQFj5t5/zAgxdlebCui\n aa46saNshk9h5a4beBzYKScEVRcrGYgzFegvlrGHvuVJE7QGuc8CAjz3BKtPT8mebKwn\n h7bbfz67PrX/nyol0HWlnoZ2FjO2GnUENmxfp3nOLnNSCfWhh+vRvo/rUm5DrnZMLIEd\n 6MruG+bs41+By9HH/zSHWz5J5NptmvFkmN7CLVQjhh1vI4dDcdHugxM/mFNzOwCpnV2a 4Q==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "CC": "Archana Muniganti <marchana@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH v2 27/29] crypto/cnxk: add per pkt IV in lookaside IPsec debug\n mode", "Date": "Thu, 16 Dec 2021 23:19:33 +0530", "Message-ID": "<1639676975-1316-28-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1639676975-1316-1-git-send-email-anoobj@marvell.com>", "References": "<1638859858-734-1-git-send-email-anoobj@marvell.com>\n <1639676975-1316-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "rORlo_oku_BXX4C6xaOanXSZRGWBGuRD", "X-Proofpoint-ORIG-GUID": "rORlo_oku_BXX4C6xaOanXSZRGWBGuRD", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2021-12-16_06,2021-12-16_01,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Archana Muniganti <marchana@marvell.com>\n\nFor cn9k, use HW GEN IV as default and add per pkt IV\nin lookaside IPsec debug mode. Debug mode helps to verify\nlookaside PMD using known outbound vectors in lookaside\nautotest.\n\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\n---\n drivers/common/cnxk/roc_ie_on.h | 7 +++++\n drivers/crypto/cnxk/cn9k_ipsec.c | 34 +++++++++++++++++------\n drivers/crypto/cnxk/cn9k_ipsec.h | 2 ++\n drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 14 +++++++---\n drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 2 ++\n 5 files changed, 47 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_ie_on.h b/drivers/common/cnxk/roc_ie_on.h\nindex cb56a70..aaad872 100644\n--- a/drivers/common/cnxk/roc_ie_on.h\n+++ b/drivers/common/cnxk/roc_ie_on.h\n@@ -22,6 +22,8 @@ enum roc_ie_on_ucc_ipsec {\n \n /* Helper macros */\n #define ROC_IE_ON_INB_RPTR_HDR 0x8\n+#define ROC_IE_ON_MAX_IV_LEN 16\n+#define ROC_IE_ON_PER_PKT_IV BIT(43)\n \n enum {\n \tROC_IE_ON_SA_ENC_NULL = 0,\n@@ -55,6 +57,11 @@ enum {\n \tROC_IE_ON_SA_ENCAP_UDP = 1,\n };\n \n+enum {\n+\tROC_IE_ON_IV_SRC_HW_GEN_DEFAULT = 0,\n+\tROC_IE_ON_IV_SRC_FROM_DPTR = 1,\n+};\n+\n struct roc_ie_on_outb_hdr {\n \tuint32_t ip_id;\n \tuint32_t seq;\ndiff --git a/drivers/crypto/cnxk/cn9k_ipsec.c b/drivers/crypto/cnxk/cn9k_ipsec.c\nindex 62b9c26..9f876f7 100644\n--- a/drivers/crypto/cnxk/cn9k_ipsec.c\n+++ b/drivers/crypto/cnxk/cn9k_ipsec.c\n@@ -426,13 +426,7 @@ cn9k_ipsec_outb_sa_create(struct cnxk_cpt_qp *qp,\n \n \tctx_len += RTE_ALIGN_CEIL(ctx_len, 8);\n \n-\tif (crypto_xform->type == RTE_CRYPTO_SYM_XFORM_AEAD) {\n-\t\tsa->cipher_iv_off = crypto_xform->aead.iv.offset;\n-\t\tsa->cipher_iv_len = crypto_xform->aead.iv.length;\n-\t} else {\n-\t\tsa->cipher_iv_off = crypto_xform->cipher.iv.offset;\n-\t\tsa->cipher_iv_len = crypto_xform->cipher.iv.length;\n-\n+\tif (crypto_xform->type != RTE_CRYPTO_SYM_XFORM_AEAD) {\n \t\tauth_key = auth_xform->auth.key.data;\n \t\tauth_key_len = auth_xform->auth.key.length;\n \n@@ -465,7 +459,31 @@ cn9k_ipsec_outb_sa_create(struct cnxk_cpt_qp *qp,\n \n \tparam1.u16 = 0;\n \tparam1.s.ikev2 = 1;\n-\tparam1.s.per_pkt_iv = 1;\n+\n+\tsa->custom_hdr_len = sizeof(struct roc_ie_on_outb_hdr) -\n+\t\t\t ROC_IE_ON_MAX_IV_LEN;\n+\n+#ifdef LA_IPSEC_DEBUG\n+\t/* Use IV from application in debug mode */\n+\tif (ipsec->options.iv_gen_disable == 1) {\n+\t\tparam1.s.per_pkt_iv = ROC_IE_ON_IV_SRC_FROM_DPTR;\n+\t\tsa->custom_hdr_len = sizeof(struct roc_ie_on_outb_hdr);\n+\n+\t\tif (crypto_xform->type == RTE_CRYPTO_SYM_XFORM_AEAD) {\n+\t\t\tsa->cipher_iv_off = crypto_xform->aead.iv.offset;\n+\t\t\tsa->cipher_iv_len = crypto_xform->aead.iv.length;\n+\t\t} else {\n+\t\t\tsa->cipher_iv_off = crypto_xform->cipher.iv.offset;\n+\t\t\tsa->cipher_iv_len = crypto_xform->cipher.iv.length;\n+\t\t}\n+\t}\n+#else\n+\tif (ipsec->options.iv_gen_disable != 0) {\n+\t\tplt_err(\"Application provided IV is not supported\");\n+\t\treturn -ENOTSUP;\n+\t}\n+#endif\n+\n \tw4.s.param1 = param1.u16;\n \n \tinst_tmpl->w4 = w4.u64;\ndiff --git a/drivers/crypto/cnxk/cn9k_ipsec.h b/drivers/crypto/cnxk/cn9k_ipsec.h\nindex fc440d5..f3acad5 100644\n--- a/drivers/crypto/cnxk/cn9k_ipsec.h\n+++ b/drivers/crypto/cnxk/cn9k_ipsec.h\n@@ -24,6 +24,8 @@ struct cn9k_ipsec_sa {\n \tuint16_t cipher_iv_off;\n \t/** Cipher IV length in bytes */\n \tuint8_t cipher_iv_len;\n+\t/** Outbound custom header length */\n+\tuint8_t custom_hdr_len;\n \t/** Response length calculation data */\n \tstruct cnxk_ipsec_outb_rlens rlens;\n \t/** Outbound IP-ID */\ndiff --git a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h b/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h\nindex 2b0261e..9a1e217 100644\n--- a/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h\n+++ b/drivers/crypto/cnxk/cn9k_ipsec_la_ops.h\n@@ -74,7 +74,7 @@ static __rte_always_inline int\n process_outb_sa(struct rte_crypto_op *cop, struct cn9k_ipsec_sa *sa,\n \t\tstruct cpt_inst_s *inst)\n {\n-\tconst unsigned int hdr_len = sizeof(struct roc_ie_on_outb_hdr);\n+\tconst unsigned int hdr_len = sa->custom_hdr_len;\n \tstruct rte_crypto_sym_op *sym_op = cop->sym;\n \tstruct rte_mbuf *m_src = sym_op->m_src;\n \tstruct roc_ie_on_outb_sa *out_sa;\n@@ -103,9 +103,15 @@ process_outb_sa(struct rte_crypto_op *cop, struct cn9k_ipsec_sa *sa,\n \t\treturn -ENOMEM;\n \t}\n \n-\tmemcpy(&hdr->iv[0],\n-\t rte_crypto_op_ctod_offset(cop, uint8_t *, sa->cipher_iv_off),\n-\t sa->cipher_iv_len);\n+#ifdef LA_IPSEC_DEBUG\n+\tif (sa->inst.w4 & ROC_IE_ON_PER_PKT_IV) {\n+\t\tmemcpy(&hdr->iv[0],\n+\t\t rte_crypto_op_ctod_offset(cop, uint8_t *,\n+\t\t\t\t\t\t sa->cipher_iv_off),\n+\t\t sa->cipher_iv_len);\n+\t}\n+#endif\n+\n \thdr->seq = rte_cpu_to_be_32(sa->seq_lo);\n \thdr->ip_id = rte_cpu_to_be_32(sa->ip_id);\n \ndiff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c\nindex 457e166..f79e4d7 100644\n--- a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c\n+++ b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c\n@@ -1166,7 +1166,9 @@ static void\n cn9k_sec_caps_update(struct rte_security_capability *sec_cap)\n {\n \tif (sec_cap->ipsec.direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) {\n+#ifdef LA_IPSEC_DEBUG\n \t\tsec_cap->ipsec.options.iv_gen_disable = 1;\n+#endif\n \t}\n }\n \n", "prefixes": [ "v2", "27/29" ] }