Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105159/?format=api
{ "id": 105159, "url": "http://patches.dpdk.org/api/patches/105159/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211216120349.2088759-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211216120349.2088759-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211216120349.2088759-1-ferruh.yigit@intel.com", "date": "2021-12-16T12:03:49", "name": "[dpdk-kmods,v2] linux/igb_uio: fix build for switch fall through", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "679f61016cc12897baa834a375c9b03562786a71", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211216120349.2088759-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 20953, "url": "http://patches.dpdk.org/api/series/20953/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20953", "date": "2021-12-16T12:03:49", "name": "[dpdk-kmods,v2] linux/igb_uio: fix build for switch fall through", "version": 2, "mbox": "http://patches.dpdk.org/series/20953/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105159/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/105159/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 67BECA00C3;\n\tThu, 16 Dec 2021 13:03:56 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E358740696;\n\tThu, 16 Dec 2021 13:03:55 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 22E2B40143\n for <dev@dpdk.org>; Thu, 16 Dec 2021 13:03:53 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Dec 2021 04:03:52 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.27])\n by FMSMGA003.fm.intel.com with ESMTP; 16 Dec 2021 04:03:52 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639656234; x=1671192234;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=TrSnIgegkerrM7ELTZOj15WNa3ZKyPITnu8GIhaBuE8=;\n b=S8s/y7Ej7bp/jtz0L6vVt41AD11oakiYaeb93rcA7vmqZ2IQFAYxrqi7\n v0S8pp9lgrrclo51VSkp058FZpmzV5lMjW3o5bIOc5oF1HbBtEpl75iGS\n Wo+d3R+Y8efdYD2/P8O74aiZWW6i5+SYSQpjR7BIFhYP1H/un3UkNTv5v\n T+dxnKp2Vo6t1Bd4JKjXV20INeT476JfZ0ldIcMjpjAEr2na2ycDNSeRp\n kX4K1vh0mgPHhTTznXsm4H4p8OzdlnAT5s1Jse8e2qpKnetB1t4GAIJ+g\n UmK/A7SiccX6REV2i2ue8fzCtdq3nhNyzWbcHXPSCXdlnBd1PiU4y5FNP Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10199\"; a=\"220151369\"", "E=Sophos;i=\"5.88,211,1635231600\"; d=\"scan'208\";a=\"220151369\"", "E=Sophos;i=\"5.88,211,1635231600\"; d=\"scan'208\";a=\"605483612\"" ], "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[dpdk-kmods v2] linux/igb_uio: fix build for switch fall through", "Date": "Thu, 16 Dec 2021 12:03:49 +0000", "Message-Id": "<20211216120349.2088759-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.33.1", "In-Reply-To": "<20211215184859.1859870-1-ferruh.yigit@intel.com>", "References": "<20211215184859.1859870-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't\ntake any fall through comments into account but only uses compiler\n'fallthrough' attribute to document fall through action is intended.\n\n\"falls through\" comment was used in the code which is causing a build\nerror now, this patch converts comment to the 'fallthrough' macro\ndefined in the Linux.\n\nTo cover the case where an old Linux version doesn't have the macro,\ndefined it in the compatibility header too.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: Stephen Hemminger <stephen@networkplumber.org>\n\nv2:\n* Add both dummy and attribute fallthrough macro definition to\n compatibility header.\n---\n linux/igb_uio/compat.h | 14 ++++++++++++++\n linux/igb_uio/igb_uio.c | 6 +++---\n 2 files changed, 17 insertions(+), 3 deletions(-)", "diff": "diff --git a/linux/igb_uio/compat.h b/linux/igb_uio/compat.h\nindex 8dbb896ae118..71172f40cff1 100644\n--- a/linux/igb_uio/compat.h\n+++ b/linux/igb_uio/compat.h\n@@ -152,3 +152,17 @@ static inline bool igbuio_kernel_is_locked_down(void)\n \treturn false;\n #endif\n }\n+\n+#ifndef fallthrough\n+\n+#ifndef __has_attribute\n+#define __has_attribute(x) 0\n+#endif\n+\n+#if __has_attribute(__fallthrough__)\n+#define fallthrough\t__attribute__((__fallthrough__))\n+#else\n+#define fallthrough\tdo {} while (0) /* fallthrough */\n+#endif\n+\n+#endif\ndiff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c\nindex ea439d131de1..33e0e0286b69 100644\n--- a/linux/igb_uio/igb_uio.c\n+++ b/linux/igb_uio/igb_uio.c\n@@ -250,7 +250,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)\n \t\t}\n #endif\n \n-\t/* falls through - to MSI */\n+\tfallthrough;\n \tcase RTE_INTR_MODE_MSI:\n #ifndef HAVE_ALLOC_IRQ_VECTORS\n \t\tif (pci_enable_msi(udev->pdev) == 0) {\n@@ -269,7 +269,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)\n \t\t\tbreak;\n \t\t}\n #endif\n-\t/* falls through - to INTX */\n+\tfallthrough;\n \tcase RTE_INTR_MODE_LEGACY:\n \t\tif (pci_intx_mask_supported(udev->pdev)) {\n \t\t\tdev_dbg(&udev->pdev->dev, \"using INTX\");\n@@ -279,7 +279,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)\n \t\t\tbreak;\n \t\t}\n \t\tdev_notice(&udev->pdev->dev, \"PCI INTX mask not supported\\n\");\n-\t/* falls through - to no IRQ */\n+\tfallthrough;\n \tcase RTE_INTR_MODE_NONE:\n \t\tudev->mode = RTE_INTR_MODE_NONE;\n \t\tudev->info.irq = UIO_IRQ_NONE;\n", "prefixes": [ "dpdk-kmods", "v2" ] }