Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105131/?format=api
{ "id": 105131, "url": "http://patches.dpdk.org/api/patches/105131/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211214141242.3383831-2-ronan.randles@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211214141242.3383831-2-ronan.randles@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211214141242.3383831-2-ronan.randles@intel.com", "date": "2021-12-14T14:12:31", "name": "[01/12] net: add string to IPv4 parse function", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "aadb1c2d949be4ef59824acfca6dfc123c6d182a", "submitter": { "id": 2439, "url": "http://patches.dpdk.org/api/people/2439/?format=api", "name": "Ronan Randles", "email": "ronan.randles@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211214141242.3383831-2-ronan.randles@intel.com/mbox/", "series": [ { "id": 20944, "url": "http://patches.dpdk.org/api/series/20944/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20944", "date": "2021-12-14T14:12:30", "name": "add packet generator library and example app", "version": 1, "mbox": "http://patches.dpdk.org/series/20944/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105131/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8967A00C3;\n\tTue, 14 Dec 2021 15:12:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 436384114A;\n\tTue, 14 Dec 2021 15:12:51 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id D1ADD4003C\n for <dev@dpdk.org>; Tue, 14 Dec 2021 15:12:48 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Dec 2021 06:12:47 -0800", "from silpixa00401120.ir.intel.com ([10.55.129.95])\n by orsmga006.jf.intel.com with ESMTP; 14 Dec 2021 06:12:46 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639491169; x=1671027169;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=sXddrN5qu5q5oylC1x8jKFCSM0mTtRG7Zn1BKIFH4uo=;\n b=NlHdy7IXGV/vTXhTNEytnZpMyA3NFtTkuSRN6aerEEZzzb2W6vLFAcx+\n VIQyngyjY6WoD6NoJyQJLv/z12hBVVNo4r33AZclpWOsQ8/NGXsHSACMS\n 1mCiiQDYoSlHBPSX2G4m1RBxT2noPUaQ243R+UI+WPnoOe0QaW0kuRBsR\n jnc5Sy/Ons/1/8J2+9ErbfuTqJSiXi8s1iZ0p/9au3zJLjOqS9WC2zgVo\n onQJKsWNCfGGNIWG3pM6ANv4UdF+9TpyqKAE7/tcgNHSt5WJuwxWNgfrc\n ja1G/IkkNLBhjCyqE/uAiDI+iKYUE+hEEWDGeufSs4TcJM0ehiIv6DEb4 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10197\"; a=\"302362300\"", "E=Sophos;i=\"5.88,205,1635231600\"; d=\"scan'208\";a=\"302362300\"", "E=Sophos;i=\"5.88,205,1635231600\"; d=\"scan'208\";a=\"465104081\"" ], "X-ExtLoop1": "1", "From": "Ronan Randles <ronan.randles@intel.com>", "To": "dev@dpdk.org", "Cc": "harry.van.haaren@intel.com,\n\tRonan Randles <ronan.randles@intel.com>", "Subject": "[PATCH 01/12] net: add string to IPv4 parse function", "Date": "Tue, 14 Dec 2021 14:12:31 +0000", "Message-Id": "<20211214141242.3383831-2-ronan.randles@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211214141242.3383831-1-ronan.randles@intel.com>", "References": "<20211214141242.3383831-1-ronan.randles@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added function that accepts ip string as a parameter and returns an ip\naddress represented by a uint32_t. Relevant unit test for this function\nis also included.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\nSigned-off-by: Ronan Randles <ronan.randles@intel.com>\n---\n app/test/meson.build | 2 ++\n app/test/test_net.c | 61 ++++++++++++++++++++++++++++++++++++++++++++\n lib/net/meson.build | 1 +\n lib/net/rte_ip.c | 43 +++++++++++++++++++++++++++++++\n lib/net/rte_ip.h | 18 +++++++++++++\n lib/net/version.map | 8 ++++++\n 6 files changed, 133 insertions(+)\n create mode 100644 app/test/test_net.c\n create mode 100644 lib/net/rte_ip.c", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 2b480adfba..4cf540fc74 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -100,6 +100,7 @@ test_sources = files(\n 'test_meter.c',\n 'test_mcslock.c',\n 'test_mp_secondary.c',\n+ 'test_net.c',\n 'test_per_lcore.c',\n 'test_pflock.c',\n 'test_pmd_perf.c',\n@@ -177,6 +178,7 @@ test_deps = [\n 'ipsec',\n 'lpm',\n 'member',\n+ 'net',\n 'node',\n 'pipeline',\n 'port',\ndiff --git a/app/test/test_net.c b/app/test/test_net.c\nnew file mode 100644\nindex 0000000000..2cb7d3e1c9\n--- /dev/null\n+++ b/app/test/test_net.c\n@@ -0,0 +1,61 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2021 Intel Corporation\n+ */\n+\n+#include <stdio.h>\n+#include <stdint.h>\n+\n+#include <rte_ip.h>\n+#include <rte_common.h>\n+#include \"test.h\"\n+\n+static int\n+test_rte_ip_parse_addr(void)\n+{\n+\tprintf(\"Running IP parsing tests...\\n\");\n+\n+\tstruct str_ip_t {\n+\t\tconst char *str;\n+\t\tuint32_t exp_output;\n+\t\tuint32_t expected_to_fail;\n+\t} str_ip_tests[] = {\n+\t\t{ .str = \"1.2.3.4\", .exp_output = RTE_IPV4(1, 2, 3, 4)},\n+\t\t{ .str = \"192.168.255.255\", .exp_output =\n+\t\t\t\tRTE_IPV4(192, 168, 255, 255)},\n+\t\t{ .str = \"172.16.0.9\", .exp_output =\n+\t\t\t\tRTE_IPV4(172, 16, 0, 9)},\n+\t\t{ .str = \"1.2.3\", .expected_to_fail = 1},\n+\t\t{ .str = \"1.2.3.4.5\", .expected_to_fail = 1},\n+\t\t{ .str = \"fail.1.2.3\", .expected_to_fail = 1},\n+\t\t{ .str = \"\", .expected_to_fail = 1},\n+\t\t{ .str = \"1.2.3.fail\", .expected_to_fail = 1}\n+\t};\n+\n+\tuint32_t i;\n+\tfor (i = 0; i < RTE_DIM(str_ip_tests); i++) {\n+\t\tuint32_t test_addr;\n+\t\tint32_t err = rte_ip_parse_addr(str_ip_tests[i].str,\n+\t\t\t\t\t\t\t&test_addr);\n+\t\tif (!test_addr) {\n+\t\t\tif (str_ip_tests[i].expected_to_fail != 1)\n+\t\t\t\treturn -1;\n+\t\t}\n+\n+\t\tif (err || test_addr != str_ip_tests[i].exp_output) {\n+\t\t\tif (str_ip_tests[i].expected_to_fail != 1)\n+\t\t\t\treturn -1;\n+\t\t}\n+\t}\n+\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_net_tests(void)\n+{\n+\tint ret = test_rte_ip_parse_addr();\n+\treturn ret;\n+}\n+\n+REGISTER_TEST_COMMAND(net_autotest, test_net_tests);\ndiff --git a/lib/net/meson.build b/lib/net/meson.build\nindex e899846578..b2577a7592 100644\n--- a/lib/net/meson.build\n+++ b/lib/net/meson.build\n@@ -26,6 +26,7 @@ headers = files(\n sources = files(\n 'rte_arp.c',\n 'rte_ether.c',\n+ 'rte_ip.c',\n 'rte_net.c',\n 'rte_net_crc.c',\n )\ndiff --git a/lib/net/rte_ip.c b/lib/net/rte_ip.c\nnew file mode 100644\nindex 0000000000..b859dfb640\n--- /dev/null\n+++ b/lib/net/rte_ip.c\n@@ -0,0 +1,43 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2021 Intel Corporation\n+ */\n+\n+#include <string.h>\n+#include <rte_ip.h>\n+\n+int32_t\n+rte_ip_parse_addr(const char *src_ip, uint32_t *output_addr)\n+{\n+\tint32_t ret = 0;\n+\tchar *current_position;\n+\n+\tif (src_ip == NULL)\n+\t\treturn -1;\n+\n+\tchar *tok = strdup(src_ip);\n+\tif (tok == NULL)\n+\t\treturn -1;\n+\n+\tchar *current_digit = strtok_r(tok, \".\", ¤t_position);\n+\n+\t*output_addr = 0;\n+\tuint32_t i = 0;\n+\twhile (current_digit) {\n+\t\tuint32_t shift = ((3 - i) * 8);\n+\t\tunsigned long parsed_value = strtoul(current_digit, NULL, 0)\n+\t\t\t\t\t\t\t\t<< shift;\n+\n+\t\tif (parsed_value == 0 && strcmp(current_digit, \"0\"))\n+\t\t\tbreak;\n+\n+\t\t*output_addr |= parsed_value;\n+\t\tcurrent_digit = strtok_r(NULL, \".\", ¤t_position);\n+\t\ti++;\n+\n+\t}\n+\tif (i != 4)\n+\t\treturn -1;\n+\n+\tfree(tok);\n+\treturn ret;\n+}\ndiff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h\nindex c575250852..188054fda4 100644\n--- a/lib/net/rte_ip.h\n+++ b/lib/net/rte_ip.h\n@@ -426,6 +426,24 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,\n \treturn 0;\n }\n \n+/**\n+ * IP address parser.\n+ *\n+ * @param src_ip\n+ * The IP address to be parsed.\n+ * @param output_addr\n+ * The array in which the parsed digits will be saved.\n+ *\n+ * @retval 0\n+ * Success.\n+ * @retval -1\n+ * Failure due to invalid input arguments.\n+ */\n+\n+__rte_experimental\n+int32_t\n+rte_ip_parse_addr(const char *src_ip, uint32_t *output_addr);\n+\n /**\n * IPv6 Header\n */\ndiff --git a/lib/net/version.map b/lib/net/version.map\nindex 4f4330d1c4..3e5a307e48 100644\n--- a/lib/net/version.map\n+++ b/lib/net/version.map\n@@ -12,3 +12,11 @@ DPDK_22 {\n \n \tlocal: *;\n };\n+\n+EXPERIMENTAL {\n+\tglobal:\n+\n+\trte_net_skip_ip6_ext;\n+\trte_ether_unformat_addr;\n+\trte_ip_parse_addr;\n+};\n", "prefixes": [ "01/12" ] }