Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105111/?format=api
{ "id": 105111, "url": "http://patches.dpdk.org/api/patches/105111/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/1639410348-21262-1-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1639410348-21262-1-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dts/1639410348-21262-1-git-send-email-juraj.linkes@pantheon.tech", "date": "2021-12-13T15:45:48", "name": "[v2] framework/packet: fix pylama errors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ee9231335aa186cfa8672d80c5fcfe9b9465cbdf", "submitter": { "id": 1626, "url": "http://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/1639410348-21262-1-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 20930, "url": "http://patches.dpdk.org/api/series/20930/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=20930", "date": "2021-12-13T15:45:48", "name": "[v2] framework/packet: fix pylama errors", "version": 2, "mbox": "http://patches.dpdk.org/series/20930/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105111/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/105111/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 29CFFA00BE;\n\tMon, 13 Dec 2021 16:45:53 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EE03440E09;\n\tMon, 13 Dec 2021 16:45:52 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by mails.dpdk.org (Postfix) with ESMTP id BE65D406A2\n for <dts@dpdk.org>; Mon, 13 Dec 2021 16:45:51 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id F1A3B15CCA8;\n Mon, 13 Dec 2021 16:45:50 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id ic1aYrN8DMMy; Mon, 13 Dec 2021 16:45:49 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 5DF931376E9;\n Mon, 13 Dec 2021 16:45:49 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "lijuan.tu@intel.com,\n\tohilyard@iol.unh.edu,\n\tjunx.dong@intel.com", "Cc": "dts@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Subject": "[PATCH v2] framework/packet: fix pylama errors", "Date": "Mon, 13 Dec 2021 16:45:48 +0100", "Message-Id": "<1639410348-21262-1-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1638793208-2584-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1638793208-2584-1-git-send-email-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Pylama found the following errors:\nframework/packet.py:119: [E] E0102 class already defined line 38 [pylint]\nframework/packet.py:121: [E] E0602 Undefined variable 'Ether' [pylint]\nframework/packet.py:122: [E] E0602 Undefined variable 'Dot1Q' [pylint]\nframework/packet.py:123: [E] E0602 Undefined variable 'Dot1BR' [pylint]\nframework/packet.py:124: [E] E0602 Undefined variable 'Ether' [pylint]\nframework/packet.py:125: [E] E0602 Undefined variable 'ARP' [pylint]\nframework/packet.py:126: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:127: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:128: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:129: [E] E0602 Undefined variable 'IPv6' [pylint]\nframework/packet.py:130: [E] E0602 Undefined variable 'IPv6' [pylint]\nframework/packet.py:131: [E] E0602 Undefined variable 'IPv6' [pylint]\nframework/packet.py:132: [E] E0602 Undefined variable 'UDP' [pylint]\nframework/packet.py:133: [E] E0602 Undefined variable 'TCP' [pylint]\nframework/packet.py:134: [E] E0602 Undefined variable 'SCTP' [pylint]\nframework/packet.py:135: [E] E0602 Undefined variable 'ICMP' [pylint]\nframework/packet.py:136: [E] E0602 Undefined variable 'GRE' [pylint]\nframework/packet.py:138: [E] E0602 Undefined variable 'VXLAN' [pylint]\nframework/packet.py:139: [E] E0602 Undefined variable 'NSH' [pylint]\nframework/packet.py:140: [E] E0602 Undefined variable 'MPLS' [pylint]\nframework/packet.py:142: [E] E0602 Undefined variable 'Ether' [pylint]\nframework/packet.py:143: [E] E0602 Undefined variable 'Dot1Q' [pylint]\nframework/packet.py:144: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:145: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:146: [E] E0602 Undefined variable 'IPv6' [pylint]\nframework/packet.py:147: [E] E0602 Undefined variable 'IPv6' [pylint]\nframework/packet.py:149: [E] E0602 Undefined variable 'TCP' [pylint]\nframework/packet.py:150: [E] E0602 Undefined variable 'UDP' [pylint]\nframework/packet.py:151: [E] E0602 Undefined variable 'SCTP' [pylint]\nframework/packet.py:152: [E] E0602 Undefined variable 'ICMP' [pylint]\nframework/packet.py:154: [E] E0602 Undefined variable 'LLDPDU' [pylint]\nframework/packet.py:155: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:156: [E] E0602 Undefined variable 'IPv6' [pylint]\nframework/packet.py:157: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:158: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:159: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:160: [E] E0602 Undefined variable 'IP' [pylint]\nframework/packet.py:161: [E] E0602 Undefined variable 'GRE' [pylint]\nframework/packet.py:212: [E] E0602 Undefined variable 'Dot1Q' [pylint]\nframework/packet.py:230: [E] E0602 Undefined variable 'Dot1BR' [pylint]\nframework/packet.py:381: [E] E0102 class already defined line 38 [pylint]\nframework/packet.py:895: [E] E0704 The raise statement is not inside an except clause [pylint]\nframework/packet.py:898: [E] E0704 The raise statement is not inside an except clause [pylint]\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\n---\nLijuan, please add additional people to review if needed.\n---\n framework/packet.py | 27 ++++++++++++++++++++++++---\n 1 file changed, 24 insertions(+), 3 deletions(-)", "diff": "diff --git a/framework/packet.py b/framework/packet.py\nindex adfa985a..787cfaee 100644\n--- a/framework/packet.py\n+++ b/framework/packet.py\n@@ -34,9 +34,30 @@ Base on scapy(python program for packet manipulation)\n \"\"\"\n import shutil\n \n+import os\n+import random\n+import re\n+import socket\n+import struct\n+import sys\n+import time\n from importlib import import_module\n from socket import AF_INET6\n-from scapy.all import *\n+\n+from scapy.contrib.lldp import LLDPDU, LLDPDUManagementAddress\n+from scapy.contrib.mpls import MPLS\n+from scapy.contrib.nsh import NSH\n+from scapy.layers.inet import ICMP, IP, TCP, UDP\n+from scapy.layers.inet6 import IPv6, IPv6ExtHdrFragment, IPv6ExtHdrRouting\n+from scapy.layers.l2 import ARP, GRE, Dot1Q, Ether\n+from scapy.layers.sctp import SCTP\n+from scapy.layers.vxlan import VXLAN\n+from scapy.packet import Raw\n+from scapy.sendrecv import sendp\n+from scapy.utils import hexstr, rdpcap, wrpcap\n+\n+from dep.scapy_modules.Dot1BR import Dot1BR\n+\n from .utils import convert_int2ip, convert_ip2int, get_module_path\n \n # load extension layers\n@@ -893,10 +914,10 @@ class Packet(object):\n name, config = layer\n if name not in self.pkt_layers:\n print(\"[%s] is missing in packet!!!\" % name)\n- raise\n+ raise Exception(f\"{name} is missing in packet!!!\")\n if self.config_layer(name, config) is False:\n print(\"[%s] failed to configure!!!\" % name)\n- raise\n+ raise Exception(f\"{name} failed to configure!!!\")\n \n def strip_layer_element(self, layer, element, p_index=0):\n \"\"\"\n", "prefixes": [ "v2" ] }