Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105066/?format=api
http://patches.dpdk.org/api/patches/105066/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211210140952.2907974-3-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211210140952.2907974-3-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211210140952.2907974-3-ciara.power@intel.com", "date": "2021-12-10T14:09:52", "name": "[3/3] crypto/ipsec_mb: fix tainted data for session", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bdac01fcf2ebddf8072def744f9024e49513b7f2", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Ciara Power", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211210140952.2907974-3-ciara.power@intel.com/mbox/", "series": [ { "id": 20911, "url": "http://patches.dpdk.org/api/series/20911/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20911", "date": "2021-12-10T14:09:50", "name": "[1/3] crypto/ipsec_mb: fix qp setup null pointer dereference", "version": 1, "mbox": "http://patches.dpdk.org/series/20911/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105066/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/105066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F308FA0093;\n\tFri, 10 Dec 2021 15:10:26 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E1684426DC;\n\tFri, 10 Dec 2021 15:10:13 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id A63EC426DA;\n Fri, 10 Dec 2021 15:10:11 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Dec 2021 06:10:10 -0800", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.49])\n by orsmga004.jf.intel.com with ESMTP; 10 Dec 2021 06:10:08 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639145411; x=1670681411;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=h6ipAbblu1FzKjzbDTsYQ8Jyb0i4w76Vp0s042aVQyk=;\n b=QnTFSbF2xL+Wahjc7nC4Hy9Kfhth5ZirSvf2p6jqrB1sh3gwbplsrauj\n 46y78BcIENTbFnc+OV/G71Ec/+900PM3XSK3octY2lRSW/0bIAgnZZLQs\n 8bmYi08emihkVXbT46552HowQ3c/epEyyR2UG9hPl6NzZw0nAef7ktY/F\n l2WNh5GuXYtZHX4OZzQY8h+41vGktLqyJ0iyYsXg99ZhjVxWEXPeC489x\n 14u8FAPlj1QLuH5nTAA1DfBDUCfTML5D0BWJWqi+iEJ5244QUCk/HdJTI\n QBTNLsUuPHfEIkrFSGNf2Fr6kV1dQ97ADqQQsjhClc0bJ3hsxUS3n77Gb w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10193\"; a=\"324613227\"", "E=Sophos;i=\"5.88,195,1635231600\"; d=\"scan'208\";a=\"324613227\"", "E=Sophos;i=\"5.88,195,1635231600\"; d=\"scan'208\";a=\"612937013\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, john.mcnamara@intel.com, roy.fan.zhang@intel.com,\n Ciara Power <ciara.power@intel.com>, piotrx.bronowski@intel.com,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Subject": "[PATCH 3/3] crypto/ipsec_mb: fix tainted data for session", "Date": "Fri, 10 Dec 2021 14:09:52 +0000", "Message-Id": "<20211210140952.2907974-3-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211210140952.2907974-1-ciara.power@intel.com>", "References": "<20211210140952.2907974-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Downcasting a void * to struct aesni_gcm_session * caused the session\ndata to be treated as tainted.\nRemoving the void * temporary variable and adding a cast avoids this\nissue.\n\nCoverity issue: 374377\nFixes: 746825e5c0ea (\"crypto/ipsec_mb: move aesni_gcm PMD\")\nCc: piotrx.bronowski@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c\nindex 2c203795ab..e5ad629fe5 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c\n@@ -713,19 +713,17 @@ aesni_gcm_process_bulk(struct rte_cryptodev *dev,\n \t\t\t__rte_unused union rte_crypto_sym_ofs ofs,\n \t\t\tstruct rte_crypto_sym_vec *vec)\n {\n-\tvoid *sess_priv;\n \tstruct aesni_gcm_session *s;\n \tstruct gcm_context_data gdata_ctx;\n \tIMB_MGR *mb_mgr;\n \n-\tsess_priv = get_sym_session_private_data(sess, dev->driver_id);\n-\tif (unlikely(sess_priv == NULL)) {\n+\ts = (struct aesni_gcm_session *) get_sym_session_private_data(sess,\n+\t\tdev->driver_id);\n+\tif (unlikely(s == NULL)) {\n \t\taesni_gcm_fill_error_code(vec, EINVAL);\n \t\treturn 0;\n \t}\n \n-\ts = sess_priv;\n-\n \t/* get per-thread MB MGR, create one if needed */\n \tmb_mgr = get_per_thread_mb_mgr();\n \tif (unlikely(mb_mgr == NULL))\n", "prefixes": [ "3/3" ] }{ "id": 105066, "url": "