Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105065/?format=api
{ "id": 105065, "url": "http://patches.dpdk.org/api/patches/105065/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211210140952.2907974-2-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211210140952.2907974-2-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211210140952.2907974-2-ciara.power@intel.com", "date": "2021-12-10T14:09:51", "name": "[2/3] crypto/ipsec_mb: fix qp cleanup null pointer dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8c2e80bbebba5c13b9efba42e1fd6234fecd9b6c", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Ciara Power", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211210140952.2907974-2-ciara.power@intel.com/mbox/", "series": [ { "id": 20911, "url": "http://patches.dpdk.org/api/series/20911/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20911", "date": "2021-12-10T14:09:50", "name": "[1/3] crypto/ipsec_mb: fix qp setup null pointer dereference", "version": 1, "mbox": "http://patches.dpdk.org/series/20911/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105065/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105065/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A9928A0093;\n\tFri, 10 Dec 2021 15:10:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B6DBE4114F;\n\tFri, 10 Dec 2021 15:10:10 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 39EDA40041;\n Fri, 10 Dec 2021 15:10:09 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Dec 2021 06:10:08 -0800", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.49])\n by orsmga004.jf.intel.com with ESMTP; 10 Dec 2021 06:10:06 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639145409; x=1670681409;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Y9tyIKyMehYB2qtIL1KJFrDrfjJXO9WwVVPQ7kBEOqU=;\n b=dOiWm3T/cY5Xtlym4UhixUPoAM4HIfAP2ZSKiBZmG7rW6fQE1+5usK2y\n NPiSAUiEzs5QitZaedmJaoAyF1M9Du79t5tiv3LxCQGa8vsClKK8mP8R1\n Y2gKHj10llw4YttremdXBF+dkzg+b/5pMEflSnCYU3jq/BvXEph4stolX\n 2gurwNofBzIxM8B4O1TXZuqNec5WD0IEIw6IzLmP/q55KKksC3+eJBbPu\n 1svEr50HuBRh7Q4SJVCjX1w+clkhi2FtTBplmWI5/iza1NigWhvED8THS\n K8IgjWCUj1HJb2fsfO2iytjt2nrbUvXwH+PZAf/awpMHQrMyrg6edcaDF w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10193\"; a=\"324613225\"", "E=Sophos;i=\"5.88,195,1635231600\"; d=\"scan'208\";a=\"324613225\"", "E=Sophos;i=\"5.88,195,1635231600\"; d=\"scan'208\";a=\"612936994\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, john.mcnamara@intel.com, roy.fan.zhang@intel.com,\n Ciara Power <ciara.power@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Subject": "[PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer dereference", "Date": "Fri, 10 Dec 2021 14:09:51 +0000", "Message-Id": "<20211210140952.2907974-2-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211210140952.2907974-1-ciara.power@intel.com>", "References": "<20211210140952.2907974-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The qp was being used in the cleanup without checking if it was non NULL.\nA check is now added to verify qp is non NULL before use.\n\nCoverity issue: 374375\nFixes: c75542ae4200 (\"crypto/ipsec_mb: introduce IPsec_mb framework\")\nCc: roy.fan.zhang@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c\nindex 6efa417d67..1ebd23e8f0 100644\n--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c\n+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c\n@@ -285,6 +285,8 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn 0;\n \n qp_setup_cleanup:\n+\tif (qp == NULL)\n+\t\treturn ret;\n #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM\n \tif (qp->mb_mgr)\n \t\tfree_mb_mgr(qp->mb_mgr);\n@@ -294,8 +296,7 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \tif (qp->mb_mgr_mz)\n \t\trte_memzone_free(qp->mb_mgr_mz);\n #endif\n-\tif (qp)\n-\t\trte_free(qp);\n+\trte_free(qp);\n \treturn ret;\n }\n \n", "prefixes": [ "2/3" ] }