Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105063/?format=api
{ "id": 105063, "url": "http://patches.dpdk.org/api/patches/105063/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/cb91b25ebb8bf85101c5acd8c24361e7f049fab0.1639136262.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cb91b25ebb8bf85101c5acd8c24361e7f049fab0.1639136262.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cb91b25ebb8bf85101c5acd8c24361e7f049fab0.1639136262.git.wangyunjian@huawei.com", "date": "2021-12-10T11:41:01", "name": "[1/1] net/bondig: fix type-mismatch in bonding", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "926984de86cc85d2d02f88d769f353f3b89b8329", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/cb91b25ebb8bf85101c5acd8c24361e7f049fab0.1639136262.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 20910, "url": "http://patches.dpdk.org/api/series/20910/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20910", "date": "2021-12-10T11:41:01", "name": "[1/1] net/bondig: fix type-mismatch in bonding", "version": 1, "mbox": "http://patches.dpdk.org/series/20910/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105063/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/105063/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 626D3A0093;\n\tFri, 10 Dec 2021 12:41:16 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E42C24014F;\n\tFri, 10 Dec 2021 12:41:15 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 6CADD40041\n for <dev@dpdk.org>; Fri, 10 Dec 2021 12:41:14 +0100 (CET)", "from dggpemm500021.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4J9TVx29jYzbl7j;\n Fri, 10 Dec 2021 19:40:57 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2308.20; Fri, 10 Dec 2021 19:41:11 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 10 Dec\n 2021 19:41:11 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<chas3@att.com>, <humin29@huawei.com>, <dingxiaoxiong@huawei.com>,\n <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>", "Subject": "[dpdk-dev] [PATCH 1/1] net/bondig: fix type-mismatch in bonding", "Date": "Fri, 10 Dec 2021 19:41:01 +0800", "Message-ID": "\n <cb91b25ebb8bf85101c5acd8c24361e7f049fab0.1639136262.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There were some type-mismatch issues in bonding and fix them:\n- Use %u to fix argument type mismatch in RTE_BOND_LOG.\n- The internals->mode is of type uint8_t. But the function\n parameter 'mode' is of type int. So change the mode type\n from int to uint8_t.\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/bonding/eth_bond_private.h | 2 +-\n drivers/net/bonding/rte_eth_bond_api.c | 2 +-\n drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++--\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h\nindex 8b104b6391..05117cc0d2 100644\n--- a/drivers/net/bonding/eth_bond_private.h\n+++ b/drivers/net/bonding/eth_bond_private.h\n@@ -240,7 +240,7 @@ slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev,\n \t\tuint16_t slave_port_id);\n \n int\n-bond_ethdev_mode_set(struct rte_eth_dev *eth_dev, int mode);\n+bond_ethdev_mode_set(struct rte_eth_dev *eth_dev, uint8_t mode);\n \n int\n slave_configure(struct rte_eth_dev *bonded_eth_dev,\ndiff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c\nindex 84943cffe2..e577be85a7 100644\n--- a/drivers/net/bonding/rte_eth_bond_api.c\n+++ b/drivers/net/bonding/rte_eth_bond_api.c\n@@ -668,7 +668,7 @@ __eth_bond_slave_remove_lock_free(uint16_t bonded_port_id,\n \t\t}\n \n \tif (slave_idx < 0) {\n-\t\tRTE_BOND_LOG(ERR, \"Couldn't find slave in port list, slave count %d\",\n+\t\tRTE_BOND_LOG(ERR, \"Couldn't find slave in port list, slave count %u\",\n \t\t\t\tinternals->slave_count);\n \t\treturn -1;\n \t}\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 84f4900ee5..c48f41fc93 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1554,7 +1554,7 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)\n }\n \n int\n-bond_ethdev_mode_set(struct rte_eth_dev *eth_dev, int mode)\n+bond_ethdev_mode_set(struct rte_eth_dev *eth_dev, uint8_t mode)\n {\n \tstruct bond_dev_private *internals;\n \n@@ -3293,7 +3293,7 @@ bond_alloc(struct rte_vdev_device *dev, uint8_t mode)\n \t/* Set mode 4 default configuration */\n \tbond_mode_8023ad_setup(eth_dev, NULL);\n \tif (bond_ethdev_mode_set(eth_dev, mode)) {\n-\t\tRTE_BOND_LOG(ERR, \"Failed to set bonded device %d mode to %d\",\n+\t\tRTE_BOND_LOG(ERR, \"Failed to set bonded device %u mode to %u\",\n \t\t\t\t eth_dev->data->port_id, mode);\n \t\tgoto err;\n \t}\n", "prefixes": [ "1/1" ] }