Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104225/?format=api
{ "id": 104225, "url": "http://patches.dpdk.org/api/patches/104225/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211112053418.14292-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211112053418.14292-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211112053418.14292-1-alvinx.zhang@intel.com", "date": "2021-11-12T05:34:18", "name": "[v2] net/ice: fix pointer of the meta data", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "72e426d7ff7d5348f5f6d3c9d56e10760025ddb2", "submitter": { "id": 1398, "url": "http://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211112053418.14292-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 20509, "url": "http://patches.dpdk.org/api/series/20509/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20509", "date": "2021-11-12T05:34:18", "name": "[v2] net/ice: fix pointer of the meta data", "version": 2, "mbox": "http://patches.dpdk.org/series/20509/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/104225/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/104225/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 75FAAA0548;\n\tFri, 12 Nov 2021 06:34:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ECCF440692;\n\tFri, 12 Nov 2021 06:34:29 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 48A8540687;\n Fri, 12 Nov 2021 06:34:27 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2021 21:34:26 -0800", "from shwdenpg235.ccr.corp.intel.com ([10.253.106.22])\n by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2021 21:34:23 -0800" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10165\"; a=\"213803724\"", "E=Sophos;i=\"5.87,228,1631602800\"; d=\"scan'208\";a=\"213803724\"", "E=Sophos;i=\"5.87,228,1631602800\"; d=\"scan'208\";a=\"565401889\"" ], "From": "Alvin Zhang <alvinx.zhang@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Subject": "[PATCH v2] net/ice: fix pointer of the meta data", "Date": "Fri, 12 Nov 2021 13:34:18 +0800", "Message-Id": "<20211112053418.14292-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20211112052539.21316-1-alvinx.zhang@intel.com>", "References": "<20211112052539.21316-1-alvinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes coverity issue by directly passing the address\nof the meta data to subfunction.\n\nCoverity issue: 373867\n\nFixes: 5ad3db8d4bdd (\"net/ice: enable advanced RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/ice/ice_hash.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex 4b682a4..afbb357 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -1055,10 +1055,9 @@ struct rss_attr_type {\n static int\n ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n \t\tconst struct rte_flow_action actions[],\n-\t\tuint64_t pattern_hint, void **meta,\n+\t\tuint64_t pattern_hint, struct ice_rss_meta *rss_meta,\n \t\tstruct rte_flow_error *error)\n {\n-\tstruct ice_rss_meta *rss_meta = (struct ice_rss_meta *)*meta;\n \tstruct ice_rss_hash_cfg *cfg = pattern_match_item->meta;\n \tenum rte_flow_action_type action_type;\n \tconst struct rte_flow_action_rss *rss;\n@@ -1196,7 +1195,7 @@ struct rss_attr_type {\n \n \t/* Check rss action. */\n \tret = ice_hash_parse_action(pattern_match_item, actions, phint,\n-\t\t\t\t (void **)&rss_meta_ptr, error);\n+\t\t\t\t rss_meta_ptr, error);\n \n error:\n \tif (!ret && meta)\n", "prefixes": [ "v2" ] }