Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10402/?format=api
{ "id": 10402, "url": "http://patches.dpdk.org/api/patches/10402/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1454694945-18040-3-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1454694945-18040-3-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1454694945-18040-3-git-send-email-david.marchand@6wind.com", "date": "2016-02-05T17:55:43", "name": "[dpdk-dev,2/4] virtio: fix incorrect check when mapping pci resources", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e75674090eea1552a2b6b608834b2a795970d329", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1454694945-18040-3-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/10402/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/10402/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7C55CC35E;\n\tFri, 5 Feb 2016 18:55:54 +0100 (CET)", "from mail-wm0-f44.google.com (mail-wm0-f44.google.com\n\t[74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 3DF73C34E\n\tfor <dev@dpdk.org>; Fri, 5 Feb 2016 18:55:53 +0100 (CET)", "by mail-wm0-f44.google.com with SMTP id 128so80984460wmz.1\n\tfor <dev@dpdk.org>; Fri, 05 Feb 2016 09:55:53 -0800 (PST)", "from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net.\n\t[78.126.77.144]) by smtp.gmail.com with ESMTPSA id\n\tgt7sm16942517wjc.1.2016.02.05.09.55.52\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 05 Feb 2016 09:55:52 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ktxRkeMR6TUGWd9cH11LLfecaWaSYHYonI8Ocw9ws+g=;\n\tb=rFSjscBV+pPJMRO1MxMRrZGVFsOf80jA7fWZtj7lrhkJJQPh5rwr874u+Vt4lt/7nc\n\ttiF8iex76+NZe2pmDT45dUXHUSyBMQzycCCQOSwC1ZhOWqBhfxxdEpc+iHCYfTXxvAkX\n\tx3nzBplaeuNDyK3kLuBAh1K/Tll6zuHgH2sMCJzWVgOYwg1h3Sew4Xq2yzFf0A1pxAhd\n\tdW17JrwwTvVxCNxZGobrX4Z+S+ZKKN5bnwCE1Gs9DPUjxfp/LEFKITH9SukYXwzHl/gj\n\tGN5WULUFvx1tVWmZXifMqizObSdQqTosJX1aoSyHwduoCQvpH82S5hbneDGiXBG3Msq9\n\ttTlw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ktxRkeMR6TUGWd9cH11LLfecaWaSYHYonI8Ocw9ws+g=;\n\tb=ZgnsWUb5CTbg18wNQT+iTNjLu2Ng5JVyhQiGF/yQ4D/D9X1kniBoeF4xCSirEhh3Y+\n\tJtIn2a56Pc3W1DHcPGoVRGWFalGZBehJ+Gv4ESpkAlkt4fKMarTTZNkTfJx24kEguEDA\n\t6wj/JnKQT49yWS7pK7XySaBjWcQidfKshtHy/f51s3hknP7iVwI6fSSg1V9FtJ0UPmDJ\n\tK7UNuues3wpXd1dDVlUUB/Dv9WWLLT+DouVqrQgvSqgcfHkWmnz9qEAn1IzU380vzkTX\n\t6flr1ZJOw4wMYOnJDTKbYTw4PIVSqLhCsjlFDhNdjyFPidawseYdppRHYA9h1qJntvQM\n\tjXDQ==", "X-Gm-Message-State": "AG10YORee8dwzVxvR8VJJfsxu2YJUvsuNbsRwxafX4gLmdi9qMxQBj0+0nQRCsUlIfos485D", "X-Received": "by 10.28.145.194 with SMTP id t185mr18690633wmd.32.1454694953137;\n\tFri, 05 Feb 2016 09:55:53 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 5 Feb 2016 18:55:43 +0100", "Message-Id": "<1454694945-18040-3-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1454694945-18040-1-git-send-email-david.marchand@6wind.com>", "References": "<1454694945-18040-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH 2/4] virtio: fix incorrect check when mapping pci\n\tresources", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "According to the api, rte_eal_pci_map_device is only successful when returning\n0.\n\nFixes: 6ba1f63b5ab0 (\"virtio: support specification 1.0\")\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n drivers/net/virtio/virtio_pci.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex cd8b0ae..b1610dd 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -795,7 +795,7 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n \tstruct virtio_pci_cap cap;\n \tint ret;\n \n-\tif (rte_eal_pci_map_device(dev) < 0) {\n+\tif (rte_eal_pci_map_device(dev)) {\n \t\tPMD_INIT_LOG(DEBUG, \"failed to map pci device!\");\n \t\treturn -1;\n \t}\n", "prefixes": [ "dpdk-dev", "2/4" ] }