Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103808/?format=api
{ "id": 103808, "url": "http://patches.dpdk.org/api/patches/103808/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211104215846.58672-23-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211104215846.58672-23-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211104215846.58672-23-ajit.khaparde@broadcom.com", "date": "2021-11-04T21:58:46", "name": "[v5,22/22] net/bnxt: use enum for bank ID", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "31a8d36876652df3785bab961077bff33a5c095e", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211104215846.58672-23-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 20322, "url": "http://patches.dpdk.org/api/series/20322/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20322", "date": "2021-11-04T21:58:24", "name": "fixes and enhancements to Truflow", "version": 5, "mbox": "http://patches.dpdk.org/series/20322/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/103808/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/103808/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7751DA0C5E;\n\tThu, 4 Nov 2021 23:01:32 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2458A42823;\n\tThu, 4 Nov 2021 22:59:28 +0100 (CET)", "from mail-pl1-f182.google.com (mail-pl1-f182.google.com\n [209.85.214.182])\n by mails.dpdk.org (Postfix) with ESMTP id 1B791427B0\n for <dev@dpdk.org>; Thu, 4 Nov 2021 22:59:23 +0100 (CET)", "by mail-pl1-f182.google.com with SMTP id b13so9600235plg.2\n for <dev@dpdk.org>; Thu, 04 Nov 2021 14:59:23 -0700 (PDT)", "from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id pg5sm8532242pjb.26.2021.11.04.14.59.20\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 04 Nov 2021 14:59:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=zs9HbDebpuyWbi8/dEAwr/vdnVDPmvVR57J1hZLT0y0=;\n b=KVG/s8deuqJ7vOJy6TRkQGq1Y4KWFGJPx5zMWKtTlsfMh1Oxpy54JgK0fme2a2JZZR\n N28J+JqKefmvt86VL9pYqJ/jvw3WjtRCE+xa/ow+3CaM6NwF+Nczp9JZHA4+b29jA4WB\n ujZyur1CzQ6oQlfHddE4PKEj4leY26QAFesrE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=zs9HbDebpuyWbi8/dEAwr/vdnVDPmvVR57J1hZLT0y0=;\n b=Ey+Fuie7OoCaKKKpHOjYXzjJNE4MrRIcqrz59Wt3TdGvC/G0fFWAvCCh9PZrIbV8jE\n HQpnaJvg6fgDayVjdOC8ezwDFPiVE8BAxsjtpBJMdPESWr8elTzAZLzJFMTxYx9W8AF7\n 3SEE2KwBbZI+TlIm368pZJDPWcIZl1HR52ygH+triwRanuRPs0Q3tGmp+DvvC4iUC4j2\n huKHyreAs16rfc7NKPaqDQnLF+JDLXAVsePA73vDB0zB1x6fy1aG7Pr5GmPgoDykz97X\n KK1qfEH3nkipr5mMMI/x5tNKMyrH0hkf44bCVpQDUxmIYYVynfKIPIfgsU6peN/LuR38\n zYWw==", "X-Gm-Message-State": "AOAM532kKclIze3istZxYWXZKg8RLj04/jN8O5k7BgDeu+YunEsx4FWs\n BYzBs1hgJEJCGySxoONlcTh90jgFzxnpyYAb0jsgm+9p1/ROL541nc/JIIDbgTuXqZenpTkq+aA\n jjhDXDPJO7Fo8FfG1Dj94FYbyS2g2wnapHAUM1TvYjgop+PmdqHvy03ikcng15G0=", "X-Google-Smtp-Source": "\n ABdhPJzEHd56Tldjmk921Y1FwUUwfMcTrDnol+q+EuqkAlYMQ5gVlGutuOv8t5W7mfzAFRvUp/aZHA==", "X-Received": "by 2002:a17:902:ce8c:b0:141:d411:7e25 with SMTP id\n f12-20020a170902ce8c00b00141d4117e25mr33050465plg.85.1636063162023;\n Thu, 04 Nov 2021 14:59:22 -0700 (PDT)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Jay Ding <jay.ding@broadcom.com>, Steve Rempe <steve.rempe@broadcom.com>,\n Farah Smith <farah.smith@broadcom.com>", "Date": "Thu, 4 Nov 2021 14:58:46 -0700", "Message-Id": "<20211104215846.58672-23-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.30.1 (Apple Git-130)", "In-Reply-To": "<20211104215846.58672-1-ajit.khaparde@broadcom.com>", "References": "<20211103005251.25524-1-ajit.khaparde@broadcom.com>\n <20211104215846.58672-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000a11b3a05cffda3ee\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH v5 22/22] net/bnxt: use enum for bank ID", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jay Ding <jay.ding@broadcom.com>\n\nInstead of integer, using enum tf_sram_bank_id for bank\nid in tf_set_sram_policy_parms.\n\nAdd index check against the allocation of the meter\ninstance for meter drop count because there is no\nreason to access it if the corresponding meter\nentry is not allocated.\n\nSigned-off-by: Jay Ding <jay.ding@broadcom.com>\nReviewed-by: Steve Rempe <steve.rempe@broadcom.com>\nReviewed-by: Farah Smith <farah.smith@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/tf_core/tf_core.h | 4 +-\n drivers/net/bnxt/tf_core/tf_device.h | 4 +-\n drivers/net/bnxt/tf_core/tf_device_p58.c | 10 ++--\n drivers/net/bnxt/tf_core/tf_tbl.c | 75 ++++++++++++------------\n 4 files changed, 47 insertions(+), 46 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/tf_core.h b/drivers/net/bnxt/tf_core/tf_core.h\nindex b2886355fa..f891d7a48f 100644\n--- a/drivers/net/bnxt/tf_core/tf_core.h\n+++ b/drivers/net/bnxt/tf_core/tf_core.h\n@@ -2520,7 +2520,7 @@ struct tf_set_sram_policy_parms {\n \t/**\n \t * [in] Array of Bank id for each truflow tbl type\n \t */\n-\tuint8_t *bank_id;\n+\tenum tf_sram_bank_id bank_id[TF_TBL_TYPE_ACT_MODIFY_64B + 1];\n };\n \n /**\n@@ -2552,7 +2552,7 @@ struct tf_get_sram_policy_parms {\n \t/**\n \t * [out] Array of Bank id for each truflow tbl type\n \t */\n-\tuint8_t bank_id[TF_TBL_TYPE_ACT_MODIFY_64B + 1];\n+\tenum tf_sram_bank_id bank_id[TF_TBL_TYPE_ACT_MODIFY_64B + 1];\n };\n \n /**\ndiff --git a/drivers/net/bnxt/tf_core/tf_device.h b/drivers/net/bnxt/tf_core/tf_device.h\nindex 3d5de988c4..bfb5de4370 100644\n--- a/drivers/net/bnxt/tf_core/tf_device.h\n+++ b/drivers/net/bnxt/tf_core/tf_device.h\n@@ -1116,7 +1116,7 @@ struct tf_dev_ops {\n \t * - (-EINVAL) on failure.\n \t */\n \tint (*tf_dev_set_sram_policy)(enum tf_dir dir,\n-\t\t\t\t uint8_t *bank_id);\n+\t\t\t\t enum tf_sram_bank_id *bank_id);\n \n \t/**\n \t * Device specific function that gets the sram policy\n@@ -1132,7 +1132,7 @@ struct tf_dev_ops {\n \t * - (-EINVAL) on failure.\n \t */\n \tint (*tf_dev_get_sram_policy)(enum tf_dir dir,\n-\t\t\t\t uint8_t *bank_id);\n+\t\t\t\t enum tf_sram_bank_id *bank_id);\n };\n \n /**\ndiff --git a/drivers/net/bnxt/tf_core/tf_device_p58.c b/drivers/net/bnxt/tf_core/tf_device_p58.c\nindex 3c1c3a2de1..30c0af7eef 100644\n--- a/drivers/net/bnxt/tf_core/tf_device_p58.c\n+++ b/drivers/net/bnxt/tf_core/tf_device_p58.c\n@@ -673,7 +673,7 @@ static int tf_dev_p58_get_sram_resources(void *q,\n \treturn 0;\n }\n \n-int sram_bank_hcapi_type[] = {\n+static int sram_bank_hcapi_type[] = {\n \tCFA_RESOURCE_TYPE_P58_SRAM_BANK_0,\n \tCFA_RESOURCE_TYPE_P58_SRAM_BANK_1,\n \tCFA_RESOURCE_TYPE_P58_SRAM_BANK_2,\n@@ -694,15 +694,15 @@ int sram_bank_hcapi_type[] = {\n * - (-EINVAL) on failure.\n */\n static int tf_dev_p58_set_sram_policy(enum tf_dir dir,\n-\t\t\t\t uint8_t *bank_id)\n+\t\t\t\t enum tf_sram_bank_id *bank_id)\n {\n \tstruct tf_rm_element_cfg *rm_cfg = tf_tbl_p58[dir];\n \tuint8_t type;\n \tuint8_t parent[TF_SRAM_BANK_ID_MAX] = { 0xFF, 0xFF, 0xFF, 0xFF };\n \n \tfor (type = TF_TBL_TYPE_FULL_ACT_RECORD;\n-\t\t\ttype < TF_TBL_TYPE_ACT_MODIFY_64B + 1; type++) {\n-\t\tif (bank_id[type] > 3)\n+\t\t\ttype <= TF_TBL_TYPE_ACT_MODIFY_64B; type++) {\n+\t\tif (bank_id[type] >= TF_SRAM_BANK_ID_MAX)\n \t\t\treturn -EINVAL;\n \n \t\trm_cfg[type].hcapi_type = sram_bank_hcapi_type[bank_id[type]];\n@@ -735,7 +735,7 @@ static int tf_dev_p58_set_sram_policy(enum tf_dir dir,\n * - (-EINVAL) on failure.\n */\n static int tf_dev_p58_get_sram_policy(enum tf_dir dir,\n-\t\t\t\t uint8_t *bank_id)\n+\t\t\t\t enum tf_sram_bank_id *bank_id)\n {\n \tstruct tf_rm_element_cfg *rm_cfg = tf_tbl_p58[dir];\n \tuint8_t type;\ndiff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c\nindex 3fb22b52ac..f18e4ba346 100644\n--- a/drivers/net/bnxt/tf_core/tf_tbl.c\n+++ b/drivers/net/bnxt/tf_core/tf_tbl.c\n@@ -307,28 +307,28 @@ tf_tbl_set(struct tf *tfp,\n \t}\n \ttbl_db = (struct tbl_rm_db *)tbl_db_ptr;\n \n-\n-\t/* Do not check meter drop counter because it is not allocated\n-\t * resources\n+\t/* Verify that the entry has been previously allocated.\n+\t * for meter drop counter, check the corresponding meter\n+\t * entry\n \t */\n-\tif (parms->type != TF_TBL_TYPE_METER_DROP_CNT) {\n-\t\t/* Verify that the entry has been previously allocated */\n-\t\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n+\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n+\tif (parms->type != TF_TBL_TYPE_METER_DROP_CNT)\n \t\taparms.subtype = parms->type;\n-\t\taparms.allocated = &allocated;\n-\t\taparms.index = parms->idx;\n-\t\trc = tf_rm_is_allocated(&aparms);\n-\t\tif (rc)\n-\t\t\treturn rc;\n+\telse\n+\t\taparms.subtype = TF_TBL_TYPE_METER_INST;\n+\taparms.allocated = &allocated;\n+\taparms.index = parms->idx;\n+\trc = tf_rm_is_allocated(&aparms);\n+\tif (rc)\n+\t\treturn rc;\n \n-\t\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t \"%s, Invalid or not allocated, type:%s, idx:%d\\n\",\n-\t\t\t tf_dir_2_str(parms->dir),\n-\t\t\t tf_tbl_type_2_str(parms->type),\n-\t\t\t parms->idx);\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t \"%s, Invalid or not allocated, type:%s, idx:%d\\n\",\n+\t\t tf_dir_2_str(parms->dir),\n+\t\t tf_tbl_type_2_str(parms->type),\n+\t\t parms->idx);\n+\t\treturn -EINVAL;\n \t}\n \n \t/* Set the entry */\n@@ -398,27 +398,28 @@ tf_tbl_get(struct tf *tfp,\n \t}\n \ttbl_db = (struct tbl_rm_db *)tbl_db_ptr;\n \n-\t/* Do not check meter drop counter because it is not allocated\n-\t * resources.\n+\t/* Verify that the entry has been previously allocated.\n+\t * for meter drop counter, check the corresponding meter\n+\t * entry\n \t */\n-\tif (parms->type != TF_TBL_TYPE_METER_DROP_CNT) {\n-\t\t/* Verify that the entry has been previously allocated */\n-\t\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n+\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n+\tif (parms->type != TF_TBL_TYPE_METER_DROP_CNT)\n \t\taparms.subtype = parms->type;\n-\t\taparms.index = parms->idx;\n-\t\taparms.allocated = &allocated;\n-\t\trc = tf_rm_is_allocated(&aparms);\n-\t\tif (rc)\n-\t\t\treturn rc;\n+\telse\n+\t\taparms.subtype = TF_TBL_TYPE_METER_INST;\n+\taparms.index = parms->idx;\n+\taparms.allocated = &allocated;\n+\trc = tf_rm_is_allocated(&aparms);\n+\tif (rc)\n+\t\treturn rc;\n \n-\t\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t \"%s, Invalid or not allocated index, type:%s, idx:%d\\n\",\n-\t\t\t tf_dir_2_str(parms->dir),\n-\t\t\t tf_tbl_type_2_str(parms->type),\n-\t\t\t parms->idx);\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t \"%s, Invalid or not allocated index, type:%s, idx:%d\\n\",\n+\t\t tf_dir_2_str(parms->dir),\n+\t\t tf_tbl_type_2_str(parms->type),\n+\t\t parms->idx);\n+\t\treturn -EINVAL;\n \t}\n \n \t/* Set the entry */\n", "prefixes": [ "v5", "22/22" ] }