Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103792/?format=api
{ "id": 103792, "url": "http://patches.dpdk.org/api/patches/103792/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211104215846.58672-7-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211104215846.58672-7-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211104215846.58672-7-ajit.khaparde@broadcom.com", "date": "2021-11-04T21:58:30", "name": "[v5,06/22] net/bnxt: remove unused functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e43bfe094ade5748c910d5c941e22c2b807f9354", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211104215846.58672-7-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 20322, "url": "http://patches.dpdk.org/api/series/20322/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20322", "date": "2021-11-04T21:58:24", "name": "fixes and enhancements to Truflow", "version": 5, "mbox": "http://patches.dpdk.org/series/20322/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/103792/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/103792/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9453A0C5E;\n\tThu, 4 Nov 2021 22:59:39 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02CA6427B7;\n\tThu, 4 Nov 2021 22:59:06 +0100 (CET)", "from mail-pl1-f182.google.com (mail-pl1-f182.google.com\n [209.85.214.182])\n by mails.dpdk.org (Postfix) with ESMTP id B838D4279B\n for <dev@dpdk.org>; Thu, 4 Nov 2021 22:59:00 +0100 (CET)", "by mail-pl1-f182.google.com with SMTP id t21so9566563plr.6\n for <dev@dpdk.org>; Thu, 04 Nov 2021 14:59:00 -0700 (PDT)", "from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id pg5sm8532242pjb.26.2021.11.04.14.58.58\n for <dev@dpdk.org>\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 04 Nov 2021 14:58:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version;\n bh=2GDASBZIyNPtNxb8sIExblZGHPhCd9QeNQ1db40O57k=;\n b=ghVFEjuuDwYLfCrISUy22bcBX/Y46OgYu5iaqqn8aO7ZMYO6BJumPBJf/jXNLdqJVr\n hs8/TwxHUyUsckuOPZsbU0C4dSj0zWQKtAvr9b4L8jIROowRdCqblFeUu/7PyrvQUjHb\n b45F2Pn++DPXMIbCYCgL0QKG3C+v9WyzML/Qo=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=2GDASBZIyNPtNxb8sIExblZGHPhCd9QeNQ1db40O57k=;\n b=ySVOiWcRLCO/lxjKP/azgSt9WaUaiS9WWkckXqrElywDK2dXTtUFrtBMoRK5wNhtIM\n UpkVqVX5Vx+EV1S7hRAa4CK75FVn4gnbssW73BQx6c7c8TwlCygPP2POodg1vkOIZskU\n Kma6sTIvgmzPck+gsbVfnkXWBdwX0V6W0sx/jSRxVtciRzvSDPE7DjbhbsSBLRnkjp0y\n xr8Pv2ul0Bv6PnTZK5fNwqi3wxto7lebbyyAAs2cgGB9Ksy9/0jO4Gclb7gxduakNvfG\n cRHioUTe4yxqfXwEPZWRwnLugMsBxhi8jefw/KHvV8+i1Pafzhc9XZCwwE3LK/7xqW/1\n oO3Q==", "X-Gm-Message-State": "AOAM531dapBn50MlFIuMStMEpfq46/NYsRWHuCQsCaEK7FlWN/Oh6W7N\n IlLIGEhtPwKGReaEz68aASSE8l+8X+s+XYKorEUgLzWbfCkmpLmvAkko8+TvpJdRAG0N1m5hCT2\n u4OwsRkdBlVhmrVzEZrYdKakUgpF2Vg+cXKG93LusWIQ/ICF2fzskhnUtYt0Wm2Y=", "X-Google-Smtp-Source": "\n ABdhPJy8J+oje27TQKsxJuwF59FXnNP7eeetAVvNjFPONwx3YuiwGsK9xZ4+bb1WCwQw7rHLviSBUg==", "X-Received": "by 2002:a17:90a:a396:: with SMTP id\n x22mr8557164pjp.14.1636063139598;\n Thu, 04 Nov 2021 14:58:59 -0700 (PDT)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Date": "Thu, 4 Nov 2021 14:58:30 -0700", "Message-Id": "<20211104215846.58672-7-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.30.1 (Apple Git-130)", "In-Reply-To": "<20211104215846.58672-1-ajit.khaparde@broadcom.com>", "References": "<20211103005251.25524-1-ajit.khaparde@broadcom.com>\n <20211104215846.58672-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"0000000000004bcff905cffda2cf\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH v5 06/22] net/bnxt: remove unused functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove unused functions from the code.\nSpecifically the following functions are being removed.\n\nvoid bnxt_get_iface_mac(uint16_t port, enum bnxt_ulp_intf_type type,\n\t\t\tuint8_t *mac, uint8_t *parent_mac);\nuint16_t bnxt_get_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type);\nuint16_t bnxt_get_parent_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type);\nstruct bnxt *bnxt_get_bp(uint16_t port);\nuint16_t bnxt_get_svif(uint16_t port_id, bool func_svif,\n\t\t enum bnxt_ulp_intf_type type);\nuint16_t bnxt_get_fw_func_id(uint16_t port, enum bnxt_ulp_intf_type type);\nuint16_t bnxt_get_parif(uint16_t port, enum bnxt_ulp_intf_type type);\nuint16_t bnxt_get_phy_port_id(uint16_t port);\nuint16_t bnxt_get_vport(uint16_t port);\nenum bnxt_ulp_intf_type\nbnxt_get_interface_type(uint16_t port);\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 13 ---\n drivers/net/bnxt/bnxt_ethdev.c | 203 ---------------------------------\n 2 files changed, 216 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 97e281a2fc..4ab9ebd049 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -1054,19 +1054,6 @@ int32_t\n bnxt_ulp_create_vfr_default_rules(struct rte_eth_dev *vfr_ethdev);\n int32_t\n bnxt_ulp_delete_vfr_default_rules(struct bnxt_representor *vfr);\n-void bnxt_get_iface_mac(uint16_t port, enum bnxt_ulp_intf_type type,\n-\t\t\tuint8_t *mac, uint8_t *parent_mac);\n-uint16_t bnxt_get_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type);\n-uint16_t bnxt_get_parent_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type);\n-struct bnxt *bnxt_get_bp(uint16_t port);\n-uint16_t bnxt_get_svif(uint16_t port_id, bool func_svif,\n-\t\t enum bnxt_ulp_intf_type type);\n-uint16_t bnxt_get_fw_func_id(uint16_t port, enum bnxt_ulp_intf_type type);\n-uint16_t bnxt_get_parif(uint16_t port, enum bnxt_ulp_intf_type type);\n-uint16_t bnxt_get_phy_port_id(uint16_t port);\n-uint16_t bnxt_get_vport(uint16_t port);\n-enum bnxt_ulp_intf_type\n-bnxt_get_interface_type(uint16_t port);\n int bnxt_rep_dev_start_op(struct rte_eth_dev *eth_dev);\n \n void bnxt_cancel_fc_thread(struct bnxt *bp);\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 257e6b0d6a..2ab0cf3784 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -5047,209 +5047,6 @@ static void bnxt_config_vf_req_fwd(struct bnxt *bp)\n \tBNXT_HWRM_CMD_TO_FORWARD(HWRM_OEM_CMD);\n }\n \n-struct bnxt *\n-bnxt_get_bp(uint16_t port)\n-{\n-\tstruct bnxt *bp;\n-\tstruct rte_eth_dev *dev;\n-\n-\tif (!rte_eth_dev_is_valid_port(port)) {\n-\t\tPMD_DRV_LOG(ERR, \"Invalid port %d\\n\", port);\n-\t\treturn NULL;\n-\t}\n-\n-\tdev = &rte_eth_devices[port];\n-\tif (!is_bnxt_supported(dev)) {\n-\t\tPMD_DRV_LOG(ERR, \"Device %d not supported\\n\", port);\n-\t\treturn NULL;\n-\t}\n-\n-\tbp = (struct bnxt *)dev->data->dev_private;\n-\tif (!BNXT_TRUFLOW_EN(bp)) {\n-\t\tPMD_DRV_LOG(ERR, \"TRUFLOW not enabled\\n\");\n-\t\treturn NULL;\n-\t}\n-\n-\treturn bp;\n-}\n-\n-uint16_t\n-bnxt_get_svif(uint16_t port_id, bool func_svif,\n-\t enum bnxt_ulp_intf_type type)\n-{\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt *bp;\n-\n-\teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n-\t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n-\t\tif (!vfr)\n-\t\t\treturn 0;\n-\n-\t\tif (type == BNXT_ULP_INTF_TYPE_VF_REP)\n-\t\t\treturn vfr->svif;\n-\n-\t\teth_dev = vfr->parent_dev;\n-\t}\n-\n-\tbp = eth_dev->data->dev_private;\n-\n-\treturn func_svif ? bp->func_svif : bp->port_svif;\n-}\n-\n-void\n-bnxt_get_iface_mac(uint16_t port, enum bnxt_ulp_intf_type type,\n-\t\t uint8_t *mac, uint8_t *parent_mac)\n-{\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt *bp;\n-\n-\tif (type != BNXT_ULP_INTF_TYPE_TRUSTED_VF &&\n-\t type != BNXT_ULP_INTF_TYPE_PF)\n-\t\treturn;\n-\n-\teth_dev = &rte_eth_devices[port];\n-\tbp = eth_dev->data->dev_private;\n-\tmemcpy(mac, bp->mac_addr, RTE_ETHER_ADDR_LEN);\n-\n-\tif (type == BNXT_ULP_INTF_TYPE_TRUSTED_VF)\n-\t\tmemcpy(parent_mac, bp->parent->mac_addr, RTE_ETHER_ADDR_LEN);\n-}\n-\n-uint16_t\n-bnxt_get_parent_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type)\n-{\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt *bp;\n-\n-\tif (type != BNXT_ULP_INTF_TYPE_TRUSTED_VF)\n-\t\treturn 0;\n-\n-\teth_dev = &rte_eth_devices[port];\n-\tbp = eth_dev->data->dev_private;\n-\n-\treturn bp->parent->vnic;\n-}\n-uint16_t\n-bnxt_get_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type)\n-{\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt_vnic_info *vnic;\n-\tstruct bnxt *bp;\n-\n-\teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n-\t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n-\t\tif (!vfr)\n-\t\t\treturn 0;\n-\n-\t\tif (type == BNXT_ULP_INTF_TYPE_VF_REP)\n-\t\t\treturn vfr->dflt_vnic_id;\n-\n-\t\teth_dev = vfr->parent_dev;\n-\t}\n-\n-\tbp = eth_dev->data->dev_private;\n-\n-\tvnic = BNXT_GET_DEFAULT_VNIC(bp);\n-\n-\treturn vnic->fw_vnic_id;\n-}\n-\n-uint16_t\n-bnxt_get_fw_func_id(uint16_t port, enum bnxt_ulp_intf_type type)\n-{\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt *bp;\n-\n-\teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n-\t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n-\t\tif (!vfr)\n-\t\t\treturn 0;\n-\n-\t\tif (type == BNXT_ULP_INTF_TYPE_VF_REP)\n-\t\t\treturn vfr->fw_fid;\n-\n-\t\teth_dev = vfr->parent_dev;\n-\t}\n-\n-\tbp = eth_dev->data->dev_private;\n-\n-\treturn bp->fw_fid;\n-}\n-\n-enum bnxt_ulp_intf_type\n-bnxt_get_interface_type(uint16_t port)\n-{\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt *bp;\n-\n-\teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev))\n-\t\treturn BNXT_ULP_INTF_TYPE_VF_REP;\n-\n-\tbp = eth_dev->data->dev_private;\n-\tif (BNXT_PF(bp))\n-\t\treturn BNXT_ULP_INTF_TYPE_PF;\n-\telse if (BNXT_VF_IS_TRUSTED(bp))\n-\t\treturn BNXT_ULP_INTF_TYPE_TRUSTED_VF;\n-\telse if (BNXT_VF(bp))\n-\t\treturn BNXT_ULP_INTF_TYPE_VF;\n-\n-\treturn BNXT_ULP_INTF_TYPE_INVALID;\n-}\n-\n-uint16_t\n-bnxt_get_phy_port_id(uint16_t port_id)\n-{\n-\tstruct bnxt_representor *vfr;\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt *bp;\n-\n-\teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n-\t\tvfr = eth_dev->data->dev_private;\n-\t\tif (!vfr)\n-\t\t\treturn 0;\n-\n-\t\teth_dev = vfr->parent_dev;\n-\t}\n-\n-\tbp = eth_dev->data->dev_private;\n-\n-\treturn BNXT_PF(bp) ? bp->pf->port_id : bp->parent->port_id;\n-}\n-\n-uint16_t\n-bnxt_get_parif(uint16_t port_id, enum bnxt_ulp_intf_type type)\n-{\n-\tstruct rte_eth_dev *eth_dev;\n-\tstruct bnxt *bp;\n-\n-\teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n-\t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n-\t\tif (!vfr)\n-\t\t\treturn 0;\n-\n-\t\tif (type == BNXT_ULP_INTF_TYPE_VF_REP)\n-\t\t\treturn vfr->fw_fid - 1;\n-\n-\t\teth_dev = vfr->parent_dev;\n-\t}\n-\n-\tbp = eth_dev->data->dev_private;\n-\n-\treturn BNXT_PF(bp) ? bp->fw_fid - 1 : bp->parent->fid - 1;\n-}\n-\n-uint16_t\n-bnxt_get_vport(uint16_t port_id)\n-{\n-\treturn (1 << bnxt_get_phy_port_id(port_id));\n-}\n-\n static void bnxt_alloc_error_recovery_info(struct bnxt *bp)\n {\n \tstruct bnxt_error_recovery_info *info = bp->recovery_info;\n", "prefixes": [ "v5", "06/22" ] }