Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103673/?format=api
{ "id": 103673, "url": "http://patches.dpdk.org/api/patches/103673/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211103160432.8052-1-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211103160432.8052-1-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211103160432.8052-1-somnath.kotur@broadcom.com", "date": "2021-11-03T16:04:32", "name": "net/bnxt: fix regression in non-vector mode Rx data path on Thor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ef7b3be042a6f5f2c65455a2f13a2473555c3f3f", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211103160432.8052-1-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 20281, "url": "http://patches.dpdk.org/api/series/20281/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20281", "date": "2021-11-03T16:04:32", "name": "net/bnxt: fix regression in non-vector mode Rx data path on Thor", "version": 1, "mbox": "http://patches.dpdk.org/series/20281/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/103673/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/103673/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 125FCA0C47;\n\tWed, 3 Nov 2021 17:10:41 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB2E24111F;\n\tWed, 3 Nov 2021 17:10:40 +0100 (CET)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.166.228])\n by mails.dpdk.org (Postfix) with ESMTP id 094FC40E5A\n for <dev@dpdk.org>; Wed, 3 Nov 2021 17:10:40 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 27C51EA;\n Wed, 3 Nov 2021 09:10:37 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 27C51EA", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1635955839;\n bh=kRNdXC53DNNCqAdqRms8WBxyXW0FI2YyLr5HRpjurUI=;\n h=From:To:Cc:Subject:Date:From;\n b=v9eGNKiLrA41Qcb57g7OnvTcTeYUUEfN4s3SY+zlt/WKrhyDJJpFSEDyhXTKTWQzn\n vBqM6MADnrppUGyJF2bbynEaD9v4+6jaJiYlDYm81IH8+VicvLY/TXD6D1dKihh8H0\n /NX1TbEubo6NEnhndxQitU+nQSZ3nL3EGSfEhJJM=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Wed, 3 Nov 2021 21:34:32 +0530", "Message-Id": "<20211103160432.8052-1-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/bnxt: fix regression in non-vector mode Rx\n data path on Thor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The patch introduced by\ncommit 657c2a7f1dd4 (\"net/bnxt: create aggregation rings when needed\")\nended up shortening the return code path from the function thereby\nresulting in not executing the line of code at the end of the function\nthat was resetting the next consumer index to 0.\nThis would result in an application crash when error recovery or other\nport stop/start scenarios were invoked on Thor which is what this\ncommit 61cd4384fabf (\"net/bnxt: fix crash after port stop/start\")\nwas addressing.\nFix it by moving the resetting line of code before the return path\nin the case when aggregration rings are not used (default case).\n\nFixes: 657c2a7f1dd4 (\"net/bnxt: create aggregation rings when needed\")\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxr.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex 992f97388c..8bc8ddc353 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -1369,6 +1369,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)\n \t\trxr->rx_buf_ring[i] = &rxq->fake_mbuf;\n \t}\n \n+\t/* Explicitly reset this driver internal tracker on a ring init */\n+\trxr->rx_next_cons = 0;\n+\n \tif (!bnxt_need_agg_ring(rxq->bp->eth_dev))\n \t\treturn 0;\n \n@@ -1407,9 +1410,6 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)\n \t}\n \tPMD_DRV_LOG(DEBUG, \"TPA alloc Done!\\n\");\n \n-\t/* Explicitly reset this driver internal tracker on a ring init */\n-\trxr->rx_next_cons = 0;\n-\n \treturn 0;\n }\n \n", "prefixes": [] }