Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103591/?format=api
http://patches.dpdk.org/api/patches/103591/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211103030705.211093-1-jie1x.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211103030705.211093-1-jie1x.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211103030705.211093-1-jie1x.wang@intel.com", "date": "2021-11-03T03:07:05", "name": "app/testpmd: fix set Rx offloads RSS hash off", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "710719d9f919336a0aafabf15f7409995f612103", "submitter": { "id": 2201, "url": "http://patches.dpdk.org/api/people/2201/?format=api", "name": "Jie Wang", "email": "jie1x.wang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211103030705.211093-1-jie1x.wang@intel.com/mbox/", "series": [ { "id": 20250, "url": "http://patches.dpdk.org/api/series/20250/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20250", "date": "2021-11-03T03:07:05", "name": "app/testpmd: fix set Rx offloads RSS hash off", "version": 1, "mbox": "http://patches.dpdk.org/series/20250/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/103591/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/103591/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D808A0C4B;\n\tWed, 3 Nov 2021 04:07:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 366E1410FD;\n\tWed, 3 Nov 2021 04:07:30 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id DE4C240E03\n for <dev@dpdk.org>; Wed, 3 Nov 2021 04:07:28 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Nov 2021 20:07:28 -0700", "from dpdk.cd.intel.com ([10.240.178.133])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Nov 2021 20:07:25 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10156\"; a=\"255042661\"", "E=Sophos;i=\"5.87,204,1631602800\"; d=\"scan'208\";a=\"255042661\"", "E=Sophos;i=\"5.87,204,1631602800\"; d=\"scan'208\";a=\"500867401\"" ], "From": "Jie Wang <jie1x.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "yuying.zhang@intel.com, xiaoyun.li@intel.com, stevex.yang@intel.com,\n junfeng.guo@intel.com, qi.z.zhang@intel.com,\n Jie Wang <jie1x.wang@intel.com>", "Date": "Wed, 3 Nov 2021 11:07:05 +0800", "Message-Id": "<20211103030705.211093-1-jie1x.wang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] app/testpmd: fix set Rx offloads RSS hash off", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When we set Rx offloads RSS hash off in cmdline, then we start\nport, if dev->data->dev_conf.rxmode.mq_mode RSS enable(multiple\nqueues mode), it will load RSS hash in driver and sync to port.\n\nAfter setting Rx offloads RSS hash off, this patch removes\nRTE_ETH_MQ_RX_RSS in port->dev_conf.rxmode.mq_mode to fix this issue.\n\nFixes: c73a9071877a (\"app/testpmd: add commands to test new offload API\")\n\nSigned-off-by: Jie Wang <jie1x.wang@intel.com>\n---\n app/test-pmd/cmdline.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex d08a1c9777..63b60f196e 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -16180,6 +16180,9 @@ cmd_config_per_port_rx_offload_parsed(void *parsed_result,\n \t\tport->dev_conf.rxmode.offloads &= ~single_offload;\n \t\tfor (q = 0; q < nb_rx_queues; q++)\n \t\t\tport->rx_conf[q].offloads &= ~single_offload;\n+\n+\t\tif (single_offload & 0x80000)\n+\t\t\tport->dev_conf.rxmode.mq_mode &= ~RTE_ETH_MQ_RX_RSS;\n \t}\n \n \tcmd_reconfig_device_queue(port_id, 1, 1);\n", "prefixes": [] }{ "id": 103591, "url": "