Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103418/?format=api
{ "id": 103418, "url": "http://patches.dpdk.org/api/patches/103418/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211102040556.7840-20-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211102040556.7840-20-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211102040556.7840-20-venkatkumar.duvvuru@broadcom.com", "date": "2021-11-02T04:05:55", "name": "[v3,19/20] net/bnxt: check for mismatch of control and physical port", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a614e3a4da587c67c2a806148c836be9da512cbc", "submitter": { "id": 1635, "url": "http://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211102040556.7840-20-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 20191, "url": "http://patches.dpdk.org/api/series/20191/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20191", "date": "2021-11-02T04:05:36", "name": "fixes and enhancements to Truflow", "version": 3, "mbox": "http://patches.dpdk.org/series/20191/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/103418/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/103418/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC9B1A0C4D;\n\tTue, 2 Nov 2021 05:08:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CAC5D41203;\n\tTue, 2 Nov 2021 05:06:38 +0100 (CET)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.166.228])\n by mails.dpdk.org (Postfix) with ESMTP id 04B8A41150\n for <dev@dpdk.org>; Tue, 2 Nov 2021 05:06:37 +0100 (CET)", "from S60.dhcp.broadcom.net (unknown [10.123.66.170])\n (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 7DEB2EA;\n Mon, 1 Nov 2021 21:06:35 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 7DEB2EA", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1635825996;\n bh=qL18R9gny23olt4gOESRxhfqug8PsHJ0mx44GhGPYGM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=qJNbi7ZDIWu6P6dpn5BDwA6hy4C8vaSmucN/khiEQh6a550FQ8oluxJjNGyMccVdF\n m1LJRt/fUjo0rNW02w4512QCTT23eCzsKlxws5Jzn3kgfXMmhw44b8CDIYvjP5PuJk\n 846FVjd7SyEAZ2r4DHA/mkgjWnKWCXvya3cC3FGw=", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kishore Padmanabha <kishore.padmanabha@broadcom.com>", "Date": "Tue, 2 Nov 2021 09:35:55 +0530", "Message-Id": "<20211102040556.7840-20-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211102040556.7840-1-venkatkumar.duvvuru@broadcom.com>", "References": "<20211001055909.27276-1-venkatkumar.duvvuru@broadcom.com>\n <20211102040556.7840-1-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v3 19/20] net/bnxt: check for mismatch of control\n and physical port", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nDuring the parsing of the ingress port ignore for a flow, added\ncheck to match the control port and the physical port that is configured\nto be ignored. If they do not match then the configuration to setup the\nsvif ignore shall fail.\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nReviewed-by: Michael Baucom <michael.baucom@broadcom.com>\nReviewed-by: Shahaji Bhosle <shahaji.bhosle@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_port_db.c | 23 +++++++++++++++++++++++\n drivers/net/bnxt/tf_ulp/ulp_port_db.h | 13 +++++++++++++\n drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 12 ++++++++++++\n 3 files changed, 48 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_port_db.c b/drivers/net/bnxt/tf_ulp/ulp_port_db.c\nindex 5e7c1d1c17..f8ffb567b5 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_port_db.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_port_db.c\n@@ -679,3 +679,26 @@ ulp_port_db_parent_vnic_get(struct bnxt_ulp_context *ulp_ctxt,\n \t}\n \treturn -EINVAL;\n }\n+\n+/*\n+ * Api to get the phy port for a given port id.\n+ *\n+ * ulp_ctxt [in] Ptr to ulp context\n+ * port_id [in] device port id\n+ * phy_port [out] phy_port of the dpdk port_id\n+ *\n+ * Returns 0 on success or negative number on failure.\n+ */\n+int32_t\n+ulp_port_db_phy_port_get(struct bnxt_ulp_context *ulp_ctxt,\n+\t\t\t uint32_t port_id, uint16_t *phy_port)\n+{\n+\tstruct ulp_func_if_info *info;\n+\n+\tinfo = ulp_port_db_func_if_info_get(ulp_ctxt, port_id);\n+\tif (info) {\n+\t\t*phy_port = info->phy_port_id;\n+\t\treturn 0;\n+\t}\n+\treturn -EINVAL;\n+}\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_port_db.h b/drivers/net/bnxt/tf_ulp/ulp_port_db.h\nindex 740c186e12..b112f1a216 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_port_db.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_port_db.h\n@@ -314,4 +314,17 @@ int32_t\n ulp_port_db_parent_vnic_get(struct bnxt_ulp_context *ulp_ctxt,\n \t\t\t uint32_t port_id, uint8_t **vnic);\n \n+/*\n+ * Api to get the phy port for a given port id.\n+ *\n+ * ulp_ctxt [in] Ptr to ulp context\n+ * port_id [in] device port id\n+ * phy_port [out] phy_port of the dpdk port_id\n+ *\n+ * Returns 0 on success or negative number on failure.\n+ */\n+int32_t\n+ulp_port_db_phy_port_get(struct bnxt_ulp_context *ulp_ctxt,\n+\t\t\t uint32_t port_id, uint16_t *phy_port);\n+\n #endif /* _ULP_PORT_DB_H_ */\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\nindex 2ec3279239..f4274dd634 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n@@ -686,6 +686,18 @@ ulp_rte_phy_port_hdr_handler(const struct rte_flow_item *item,\n \tULP_COMP_FLD_IDX_WR(params, BNXT_ULP_CF_IDX_SVIF_FLAG,\n \t\t\t rte_be_to_cpu_16(svif));\n \tif (!mask) {\n+\t\tuint32_t port_id = 0;\n+\t\tuint16_t phy_port = 0;\n+\n+\t\t/* Validate the control port */\n+\t\tport_id = ULP_COMP_FLD_IDX_RD(params,\n+\t\t\t\t\t BNXT_ULP_CF_IDX_DEV_PORT_ID);\n+\t\tif (ulp_port_db_phy_port_get(params->ulp_ctx,\n+\t\t\t\t\t port_id, &phy_port) ||\n+\t\t (uint16_t)port_spec->index != phy_port) {\n+\t\t\tBNXT_TF_DBG(ERR, \"Mismatch of control and phy_port\\n\");\n+\t\t\treturn BNXT_TF_RC_PARSE_ERR;\n+\t\t}\n \t\tULP_BITMAP_SET(params->hdr_bitmap.bits,\n \t\t\t BNXT_ULP_HDR_BIT_SVIF_IGNORE);\n \t\tmemset(hdr_field->mask, 0xFF, sizeof(mask));\n", "prefixes": [ "v3", "19/20" ] }