Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 103299,
    "url": "http://patches.dpdk.org/api/patches/103299/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211101073701.825389-3-dkozlyuk@nvidia.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211101073701.825389-3-dkozlyuk@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211101073701.825389-3-dkozlyuk@nvidia.com",
    "date": "2021-11-01T07:37:00",
    "name": "[v2,2/3] app/test: fix mempool test on FreeBSD",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e2a05badce3fe5144ec46a5ca63f4968fe6aa6e2",
    "submitter": {
        "id": 2367,
        "url": "http://patches.dpdk.org/api/people/2367/?format=api",
        "name": "Dmitry Kozlyuk",
        "email": "dkozlyuk@oss.nvidia.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211101073701.825389-3-dkozlyuk@nvidia.com/mbox/",
    "series": [
        {
            "id": 20163,
            "url": "http://patches.dpdk.org/api/series/20163/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20163",
            "date": "2021-11-01T07:36:58",
            "name": "Mempool fixes for FreeBSD",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/20163/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/103299/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/103299/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C044DA0C52;\n\tMon,  1 Nov 2021 08:37:26 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ADDBA410FE;\n\tMon,  1 Nov 2021 08:37:25 +0100 (CET)",
            "from AZHDRRW-EX01.nvidia.com (azhdrrw-ex01.nvidia.com\n [20.51.104.162]) by mails.dpdk.org (Postfix) with ESMTP id A9BB4410FD\n for <dev@dpdk.org>; Mon,  1 Nov 2021 08:37:24 +0100 (CET)",
            "from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106)\n by mxs.oss.nvidia.com (10.13.234.36) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.858.15; Mon, 1 Nov 2021 00:37:24 -0700",
            "from MW4PR04CA0351.namprd04.prod.outlook.com (2603:10b6:303:8a::26)\n by BYAPR12MB4984.namprd12.prod.outlook.com (2603:10b6:a03:105::26)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov\n 2021 07:37:21 +0000",
            "from CO1NAM11FT024.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:8a:cafe::33) by MW4PR04CA0351.outlook.office365.com\n (2603:10b6:303:8a::26) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend\n Transport; Mon, 1 Nov 2021 07:37:21 +0000",
            "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT024.mail.protection.outlook.com (10.13.174.162) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4649.14 via Frontend Transport; Mon, 1 Nov 2021 07:37:21 +0000",
            "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 1 Nov\n 2021 07:37:18 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mQycDqxQ8FALeAf/x9tYljUH9SE/zHi4m/5PNk9Z9jNrfCUJvN5yMk66eYOWo5ll9gTm5sj9Cnxkh+A2zGHNliPGDf5v+5DjS5PGWHcR/gMmV1M3Q+dYKfQDxGPNT3IESGJVkFvBhUbJXBpR4pHDOFgINBIRKaDuqjCLvNXBFxf1E2QJZ1NP+z8NWxBo8Y6SbzqI/PyPR+TGTolzR0BZyiMzy66v+54XBAU37pa4ALP8zgALXY+iHFh5EMKaAXdZFrWaADaogv0Eo1XfBiXRa0XRBlcg6cjYRE5hzHT8jl74/SAFhiOOq4fBvAMbwUEhNm1JTldiL/HUCXoANKd/3g==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=DBXtWhzUHH7DcP/aQovzJsaJaipgjplM8P7R2r8aa1I=;\n b=UyKXX4aqJ0V9Qc/15ooMA66b1BLgcrZ5neiJX0pfHYSe3sfWjsu0QV/56ISr/EpdYB2KIe0T9PZoei0zYhCbqGfkencaS8Nj5zpP2/L8D/axYlUZnKhW4xRfRXnFHHQKdCPqDjUUvBLELHpVew5yRyh53InwBWuy+gkGZVlYA52DR1fNfn2WU53yXml72dLasZM40OOZ95OMKKqViuV7Oa25MVeJ6oFMJl2NVCgUdhj0KHJCOX7yaLCrNTKA1PKW+wB6xgbFQnNYbLwjqvpRjcbXgNvozSv75yA3p+We1TyQqxHvFY5UqS7VuTgeLluF6qlBL3/IUXW3zKqeLlN0SA==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=6wind.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DBXtWhzUHH7DcP/aQovzJsaJaipgjplM8P7R2r8aa1I=;\n b=dYfEjUMvQEnk+LRH/Ygv4U79omXRbzJJb10g0u3yfS7X0aQKvMYtdZsAhfv79dA/p85BfpU6rbdEXCD5OS6g6CgFJ3wMzOLHZ+ryn67wPLaUgxsAURjrLRIBx9qNmCT28k78H5tb7kmndfGNmIYj7wsREzctOodUfZiVSYynX0lhry6l8y4/wnEOSe6FKejcfULEP+3UlFQVr4JRlYL+zNnN6Iih3s7S94N8/xKqzFcdeCKRx9cqtKgaZv88+wSSTuq+4qGL/J2tBl016dtsu0lKpKGKN9j6SI+4reg2cOh1Cwxw2ICE/kcAMyMsp0s1H0y08ZuGoUTPY7YlRsbhew==",
        "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; 6wind.com; dkim=none (message not signed)\n header.d=none;6wind.com; dmarc=pass action=none header.from=nvidia.com;",
        "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;",
        "From": "Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>",
        "To": "<dev@dpdk.org>",
        "CC": "Yu Jiang <yux.jiang@intel.com>, Olivier Matz <olivier.matz@6wind.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>",
        "Date": "Mon, 1 Nov 2021 09:37:00 +0200",
        "Message-ID": "<20211101073701.825389-3-dkozlyuk@nvidia.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20211101073701.825389-1-dkozlyuk@nvidia.com>",
        "References": "<20211029084051.679233-1-dkozlyuk@nvidia.com>\n <20211101073701.825389-1-dkozlyuk@nvidia.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[172.20.187.5]",
        "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)",
        "X-EOPAttributedMessage": "0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-Office365-Filtering-Correlation-Id": "7d0ab5dc-6087-4723-405b-08d99d0a707f",
        "X-MS-TrafficTypeDiagnostic": "BYAPR12MB4984:",
        "X-Microsoft-Antispam-PRVS": "\n <BYAPR12MB4984864E7650B809E05BDDF1B98A9@BYAPR12MB4984.namprd12.prod.outlook.com>",
        "X-MS-Oob-TLC-OOBClassifiers": "OLM:8882;",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n s+j1vwFNwSiBQbp6jT7e/nX+HqXICR2ne2PNPNiF0xxGzlZT82ur3GtCgFGHU9tSnk6NcjYg+x4Ga/SzTCfstOViB+qwTrVeG50vndw0DT7cTYwAY6SbNuMCSSX5nXdlDLJTQr4XovkIe7/qJI1WDWnzkJfRQ5FACikPQzu9N8Byg3FbuIt0kHZ4pbS2om/r8nAgPuO0oE/eX2N485ZjkCU5Y++HRSfCqLDbvZ8hUuiA4OQoJUTocsPUE7HUztHd9oS5DVb5cbOnnIHhymLho7xzC5qX8OIZBiOzPsoqoXDNBr9nfRtfUdXO9sADL29zcA2Jua1ouT7W7Xz0QuW7nJ+ZL8sEjAmR4G4uwbYg1tn3I/m2vh/D/LDTfQvUTTTDRgdVl+AmT6kA1Vro5SW/64NDds+IJ+Lj40RYfgGD7wUtoVEgpn3xhvX2mkhW7c2vB+wmqN8zFjejDQGmpAAmMZTfwx1eQQB38Etdhkwp6N3pHjSSBlvraVVpHIVG23E4icgHrsxDsZJ935fMkKcqm229AB8FmyFoyJKfCqNcl7gwAFfYXXyXeo6TJANLQOvfqjYaJwARSCII1TkfV0HpVC2rBEVElh9qYx/cMAolmnqieV2F7dAUirCl+5qmLT3DMSZWEMb1bpCYHXDTIH2MvQLm37aRbOXtawuUc9KdfHoUZXXIYKfl6vQGTc6StX4U8WVLJrwbfRQ0wubE+lQDVQ==",
        "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(8936002)(107886003)(186003)(7636003)(508600001)(16526019)(336012)(36906005)(426003)(55016002)(5660300002)(6916009)(2616005)(316002)(2906002)(70206006)(1076003)(86362001)(356005)(54906003)(4326008)(26005)(6666004)(70586007)(6286002)(8676002)(36756003)(82310400003)(83380400001)(7696005)(36860700001)(47076005);\n DIR:OUT; SFP:1101;",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "01 Nov 2021 07:37:21.1118 (UTC)",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7d0ab5dc-6087-4723-405b-08d99d0a707f",
        "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a",
        "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]",
        "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT024.eop-nam11.prod.protection.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR12MB4984",
        "Subject": "[dpdk-dev] [PATCH v2 2/3] app/test: fix mempool test on FreeBSD",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "FreeBSD EAL does not implement rte_mem_virt2iova() causing an error:\n\n    EAL: Test assert test_mempool_flag_non_io_unset_when_populated_with_valid_iova\n    line 781 failed: Cannot get IOVA\n    test failed at test_mempool():1030\n    Test Failed\n\nChange unit test to use rte_memzone_reserve() to allocate memory,\nwhich allows to obtain IOVA directly.\n\nBugzilla ID: 863\nFixes: 11541c5c81dd (\"mempool: add non-IO flag\")\n\nReported-by: Yu Jiang <yux.jiang@intel.com>\nSigned-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>\n---\n app/test/test_mempool.c | 28 +++++++++++++++-------------\n 1 file changed, 15 insertions(+), 13 deletions(-)",
    "diff": "diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c\nindex 4b0f6b0e7f..ced20dcdc3 100644\n--- a/app/test/test_mempool.c\n+++ b/app/test/test_mempool.c\n@@ -740,16 +740,17 @@ test_mempool_events_safety(void)\n static int\n test_mempool_flag_non_io_set_when_no_iova_contig_set(void)\n {\n-\tvoid *virt = NULL;\n+\tconst struct rte_memzone *mz = NULL;\n+\tvoid *virt;\n \trte_iova_t iova;\n \tsize_t size = MEMPOOL_ELT_SIZE * 16;\n \tstruct rte_mempool *mp = NULL;\n \tint ret;\n \n-\tvirt = rte_malloc(\"test_mempool\", size, rte_mem_page_size());\n-\tRTE_TEST_ASSERT_NOT_NULL(virt, \"Cannot allocate memory\");\n-\tiova = rte_mem_virt2iova(virt);\n-\tRTE_TEST_ASSERT_NOT_EQUAL(iova,  RTE_BAD_IOVA, \"Cannot get IOVA\");\n+\tmz = rte_memzone_reserve(\"test_mempool\", size, SOCKET_ID_ANY, 0);\n+\tRTE_TEST_ASSERT_NOT_NULL(mz, \"Cannot allocate memory\");\n+\tvirt = mz->addr;\n+\tiova = mz->iova;\n \tmp = rte_mempool_create_empty(\"empty\", MEMPOOL_SIZE,\n \t\t\t\t      MEMPOOL_ELT_SIZE, 0, 0,\n \t\t\t\t      SOCKET_ID_ANY, RTE_MEMPOOL_F_NO_IOVA_CONTIG);\n@@ -772,14 +773,15 @@ test_mempool_flag_non_io_set_when_no_iova_contig_set(void)\n \tret = TEST_SUCCESS;\n exit:\n \trte_mempool_free(mp);\n-\trte_free(virt);\n+\trte_memzone_free(mz);\n \treturn ret;\n }\n \n static int\n test_mempool_flag_non_io_unset_when_populated_with_valid_iova(void)\n {\n-\tvoid *virt = NULL;\n+\tconst struct rte_memzone *mz = NULL;\n+\tvoid *virt;\n \trte_iova_t iova;\n \tsize_t total_size = MEMPOOL_ELT_SIZE * MEMPOOL_SIZE;\n \tsize_t block_size = total_size / 3;\n@@ -789,12 +791,12 @@ test_mempool_flag_non_io_unset_when_populated_with_valid_iova(void)\n \t/*\n \t * Since objects from the pool are never used in the test,\n \t * we don't care for contiguous IOVA, on the other hand,\n-\t * reiuring it could cause spurious test failures.\n+\t * requiring it could cause spurious test failures.\n \t */\n-\tvirt = rte_malloc(\"test_mempool\", total_size, rte_mem_page_size());\n-\tRTE_TEST_ASSERT_NOT_NULL(virt, \"Cannot allocate memory\");\n-\tiova = rte_mem_virt2iova(virt);\n-\tRTE_TEST_ASSERT_NOT_EQUAL(iova,  RTE_BAD_IOVA, \"Cannot get IOVA\");\n+\tmz = rte_memzone_reserve(\"test_mempool\", total_size, SOCKET_ID_ANY, 0);\n+\tRTE_TEST_ASSERT_NOT_NULL(mz, \"Cannot allocate memory\");\n+\tvirt = mz->addr;\n+\tiova = mz->iova;\n \tmp = rte_mempool_create_empty(\"empty\", MEMPOOL_SIZE,\n \t\t\t\t      MEMPOOL_ELT_SIZE, 0, 0,\n \t\t\t\t      SOCKET_ID_ANY, 0);\n@@ -827,7 +829,7 @@ test_mempool_flag_non_io_unset_when_populated_with_valid_iova(void)\n \n exit:\n \trte_mempool_free(mp);\n-\trte_free(virt);\n+\trte_memzone_free(mz);\n \treturn ret;\n }\n \n",
    "prefixes": [
        "v2",
        "2/3"
    ]
}