Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102763/?format=api
http://patches.dpdk.org/api/patches/102763/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211025110415.20683-5-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211025110415.20683-5-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20211025110415.20683-5-ivan.malov@oktetlabs.ru", "date": "2021-10-25T11:04:13", "name": "[5/7] net/sfc: support represented port flow item", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5b4236cf0325256b8aa5330755095c858880be25", "submitter": { "id": 869, "url": "http://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211025110415.20683-5-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 19954, "url": "http://patches.dpdk.org/api/series/19954/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19954", "date": "2021-10-25T11:04:09", "name": "[1/7] net/sfc: do not allow flow rules to refer to VF representors", "version": 1, "mbox": "http://patches.dpdk.org/series/19954/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102763/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/102763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 39C4CA0C52;\n\tMon, 25 Oct 2021 13:04:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E6B314115B;\n\tMon, 25 Oct 2021 13:04:30 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id BFD1F410DA\n for <dev@dpdk.org>; Mon, 25 Oct 2021 13:04:23 +0200 (CEST)", "from localhost.localdomain (unknown [5.144.121.149])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 74BED7F6FC;\n Mon, 25 Oct 2021 14:04:23 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 74BED7F6FC", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1635159863;\n bh=OJBYh2cDOdpm9IaqZzCrVfilH2fUWzLb1rYhKrJrYSQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=PlC7bAaxbJzy/BIzMHIdpj2tteqCh9Y7CIFiRIdLSUwmxSRI/L+UpAAFr9lnSOFrH\n aUIhUIPnc08og1aH+c4yGGLtCyE6XFHAC8ZpKqTdR8W/0MXJpcWTGPomFzxzQn1OOo\n tYYmY9a3lEr6Z8LEO5dUO6aQaQproUxG/pxh/yZ0=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Date": "Mon, 25 Oct 2021 14:04:13 +0300", "Message-Id": "<20211025110415.20683-5-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20211025110415.20683-1-ivan.malov@oktetlabs.ru>", "References": "<20211025110415.20683-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/7] net/sfc: support represented port flow item", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for item REPRESENTED_PORT to match on traffic entering\nthe embedded switch from the entity represented by the given\nethdev (network port or VF).\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n doc/guides/nics/features/sfc.ini | 1 +\n doc/guides/nics/sfc_efx.rst | 2 ++\n drivers/net/sfc/sfc_mae.c | 52 +++++++++++++++++++++++++-------\n drivers/net/sfc/sfc_switch.c | 29 ++++++++++++++++++\n drivers/net/sfc/sfc_switch.h | 4 +++\n 5 files changed, 77 insertions(+), 11 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/sfc.ini b/doc/guides/nics/features/sfc.ini\nindex 7db868e59f..c830426eb2 100644\n--- a/doc/guides/nics/features/sfc.ini\n+++ b/doc/guides/nics/features/sfc.ini\n@@ -53,6 +53,7 @@ port_id = Y\n port_representor = Y\n pppoed = Y\n pppoes = Y\n+represented_port = Y\n tcp = Y\n udp = Y\n vf = Y\ndiff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 843c24991c..8dbd250b3c 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -194,6 +194,8 @@ Supported pattern items (***transfer*** rules):\n \n - PORT_REPRESENTOR (cannot repeat; conflicts with other traffic source items)\n \n+- REPRESENTED_PORT (cannot repeat; conflicts with other traffic source items)\n+\n - PORT_ID (cannot repeat; conflicts with other traffic source items)\n \n - PHY_PORT (cannot repeat; conflicts with other traffic source items)\ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex bd8a913a49..8ec4036275 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -1333,9 +1333,9 @@ sfc_mae_rule_parse_item_port_id(const struct rte_flow_item *item,\n }\n \n static int\n-sfc_mae_rule_parse_item_port_representor(const struct rte_flow_item *item,\n-\t\t\t\t\t struct sfc_flow_parse_ctx *ctx,\n-\t\t\t\t\t struct rte_flow_error *error)\n+sfc_mae_rule_parse_item_ethdev_based(const struct rte_flow_item *item,\n+\t\t\t\t struct sfc_flow_parse_ctx *ctx,\n+\t\t\t\t struct rte_flow_error *error)\n {\n \tstruct sfc_mae_parse_ctx *ctx_mae = ctx->mae;\n \tconst struct rte_flow_item_ethdev supp_mask = {\n@@ -1363,20 +1363,38 @@ sfc_mae_rule_parse_item_port_representor(const struct rte_flow_item *item,\n \tif (mask->port_id != supp_mask.port_id) {\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n-\t\t\t\t\"Bad mask in the PORT_REPRESENTOR pattern item\");\n+\t\t\t\t\"Bad mask in the ethdev-based pattern item\");\n \t}\n \n \t/* If \"spec\" is not set, could be any port ID */\n \tif (spec == NULL)\n \t\treturn 0;\n \n-\trc = sfc_mae_switch_get_ethdev_mport(\n-\t\t\tctx_mae->sa->mae.switch_domain_id,\n-\t\t\tspec->port_id, &mport_sel);\n-\tif (rc != 0) {\n-\t\treturn rte_flow_error_set(error, rc,\n+\tswitch (item->type) {\n+\tcase RTE_FLOW_ITEM_TYPE_PORT_REPRESENTOR:\n+\t\trc = sfc_mae_switch_get_ethdev_mport(\n+\t\t\t\tctx_mae->sa->mae.switch_domain_id,\n+\t\t\t\tspec->port_id, &mport_sel);\n+\t\tif (rc != 0) {\n+\t\t\treturn rte_flow_error_set(error, rc,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t\"Can't get m-port for the given ethdev\");\n+\t\t}\n+\t\tbreak;\n+\tcase RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT:\n+\t\trc = sfc_mae_switch_get_entity_mport(\n+\t\t\t\tctx_mae->sa->mae.switch_domain_id,\n+\t\t\t\tspec->port_id, &mport_sel);\n+\t\tif (rc != 0) {\n+\t\t\treturn rte_flow_error_set(error, rc,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t\"Can't get m-port for the given ethdev\");\n+\t\t}\n+\t\tbreak;\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n-\t\t\t\t\"Can't get m-port for the given ethdev\");\n+\t\t\t\t\"Unsupported ethdev-based flow item\");\n \t}\n \n \trc = efx_mae_match_spec_mport_set(ctx_mae->match_spec,\n@@ -2329,7 +2347,19 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t\t.prev_layer = SFC_FLOW_ITEM_ANY_LAYER,\n \t\t.layer = SFC_FLOW_ITEM_ANY_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n-\t\t.parse = sfc_mae_rule_parse_item_port_representor,\n+\t\t.parse = sfc_mae_rule_parse_item_ethdev_based,\n+\t},\n+\t{\n+\t\t.type = RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT,\n+\t\t.name = \"REPRESENTED_PORT\",\n+\t\t/*\n+\t\t * In terms of RTE flow, this item is a META one,\n+\t\t * and its position in the pattern is don't care.\n+\t\t */\n+\t\t.prev_layer = SFC_FLOW_ITEM_ANY_LAYER,\n+\t\t.layer = SFC_FLOW_ITEM_ANY_LAYER,\n+\t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n+\t\t.parse = sfc_mae_rule_parse_item_ethdev_based,\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_PHY_PORT,\ndiff --git a/drivers/net/sfc/sfc_switch.c b/drivers/net/sfc/sfc_switch.c\nindex 3f7518fa30..5c10e8fc74 100644\n--- a/drivers/net/sfc/sfc_switch.c\n+++ b/drivers/net/sfc/sfc_switch.c\n@@ -567,6 +567,35 @@ sfc_mae_switch_get_ethdev_mport(uint16_t switch_domain_id,\n \treturn rc;\n }\n \n+int\n+sfc_mae_switch_get_entity_mport(uint16_t switch_domain_id,\n+\t\t\t\tuint16_t ethdev_port_id,\n+\t\t\t\tefx_mport_sel_t *mport_sel)\n+{\n+\tstatic struct sfc_mae_switch_port *port;\n+\tint rc;\n+\n+\trte_spinlock_lock(&sfc_mae_switch.lock);\n+\trc = sfc_mae_find_switch_port_by_ethdev(switch_domain_id,\n+\t\t\t\t\t\tethdev_port_id, &port);\n+\tif (rc != 0)\n+\t\tgoto unlock;\n+\n+\tif (port->type == SFC_MAE_SWITCH_PORT_INDEPENDENT &&\n+\t !port->data.indep.mae_admin) {\n+\t\t/* See sfc_mae_assign_entity_mport() */\n+\t\trc = ENOTSUP;\n+\t\tgoto unlock;\n+\t}\n+\n+\t*mport_sel = port->entity_mport;\n+\n+unlock:\n+\trte_spinlock_unlock(&sfc_mae_switch.lock);\n+\n+\treturn rc;\n+}\n+\n int\n sfc_mae_switch_port_id_by_entity(uint16_t switch_domain_id,\n \t\t\t\t const efx_mport_sel_t *entity_mportp,\ndiff --git a/drivers/net/sfc/sfc_switch.h b/drivers/net/sfc/sfc_switch.h\nindex a5a0fb4fc5..62aea9b785 100644\n--- a/drivers/net/sfc/sfc_switch.h\n+++ b/drivers/net/sfc/sfc_switch.h\n@@ -106,6 +106,10 @@ int sfc_mae_switch_get_ethdev_mport(uint16_t switch_domain_id,\n \t\t\t\t uint16_t ethdev_port_id,\n \t\t\t\t efx_mport_sel_t *mport_sel);\n \n+int sfc_mae_switch_get_entity_mport(uint16_t switch_domain_id,\n+\t\t\t\t uint16_t ethdev_port_id,\n+\t\t\t\t efx_mport_sel_t *mport_sel);\n+\n int sfc_mae_switch_port_id_by_entity(uint16_t switch_domain_id,\n \t\t\t\t const efx_mport_sel_t *entity_mportp,\n \t\t\t\t enum sfc_mae_switch_port_type type,\n", "prefixes": [ "5/7" ] }{ "id": 102763, "url": "