Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102761/?format=api
{ "id": 102761, "url": "http://patches.dpdk.org/api/patches/102761/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211025110415.20683-2-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211025110415.20683-2-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20211025110415.20683-2-ivan.malov@oktetlabs.ru", "date": "2021-10-25T11:04:10", "name": "[2/7] net/sfc: rename ethdev m-port retrieval helper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "05c1c01b644a1d3b0c7235859aee016936cb647f", "submitter": { "id": 869, "url": "http://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211025110415.20683-2-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 19954, "url": "http://patches.dpdk.org/api/series/19954/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19954", "date": "2021-10-25T11:04:09", "name": "[1/7] net/sfc: do not allow flow rules to refer to VF representors", "version": 1, "mbox": "http://patches.dpdk.org/series/19954/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102761/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/102761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 66DEFA0C52;\n\tMon, 25 Oct 2021 13:04:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7122D4113B;\n\tMon, 25 Oct 2021 13:04:25 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 5371B407FF\n for <dev@dpdk.org>; Mon, 25 Oct 2021 13:04:23 +0200 (CEST)", "from localhost.localdomain (unknown [5.144.121.149])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B39607F670;\n Mon, 25 Oct 2021 14:04:22 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B39607F670", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1635159862;\n bh=+dhUt+JaCUFQS2/5B+SUJmpEDxqfNuSEPG7wxWI9D+g=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=tuK8ufGTM86GPnua9YRQ39KHV+vICLG46xHUajTh74Q0AKjLlbgFAsuV4kE2S4zBg\n ZL28HsFMU04UUY+hDg3GN1mwcNcsw5AB45B4oOADtEMUA1xaisR3Op4mMNe9MMG6Sf\n uxT+UpE7eW7Qm2dvyaGP9Zn8dURg6b2gD9xPXATI=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Date": "Mon, 25 Oct 2021 14:04:10 +0300", "Message-Id": "<20211025110415.20683-2-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20211025110415.20683-1-ivan.malov@oktetlabs.ru>", "References": "<20211025110415.20683-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/7] net/sfc: rename ethdev m-port retrieval\n helper", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function in question has an unfortunate name that reads\nlike finding a SW switch port entry. In fact just one of\nthe two m-ports is retrieved from that entry.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_mae.c | 10 +++++-----\n drivers/net/sfc/sfc_switch.c | 6 +++---\n drivers/net/sfc/sfc_switch.h | 6 +++---\n 3 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 455744c570..84b13925ff 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -1276,8 +1276,8 @@ sfc_mae_rule_parse_item_port_id(const struct rte_flow_item *item,\n \t\t\t\t\t \"The port ID is too large\");\n \t}\n \n-\trc = sfc_mae_switch_port_by_ethdev(ctx_mae->sa->mae.switch_domain_id,\n-\t\t\t\t\t spec->id, &mport_sel);\n+\trc = sfc_mae_switch_get_ethdev_mport(ctx_mae->sa->mae.switch_domain_id,\n+\t\t\t\t\t spec->id, &mport_sel);\n \tif (rc != 0) {\n \t\treturn rte_flow_error_set(error, rc,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM, item,\n@@ -1335,7 +1335,7 @@ sfc_mae_rule_parse_item_port_representor(const struct rte_flow_item *item,\n \tif (spec == NULL)\n \t\treturn 0;\n \n-\trc = sfc_mae_switch_port_by_ethdev(\n+\trc = sfc_mae_switch_get_ethdev_mport(\n \t\t\tctx_mae->sa->mae.switch_domain_id,\n \t\t\tspec->port_id, &mport_sel);\n \tif (rc != 0) {\n@@ -3406,8 +3406,8 @@ sfc_mae_rule_parse_action_port_id(struct sfc_adapter *sa,\n \n \tport_id = (conf->original != 0) ? sas->port_id : conf->id;\n \n-\trc = sfc_mae_switch_port_by_ethdev(mae->switch_domain_id,\n-\t\t\t\t\t port_id, &mport);\n+\trc = sfc_mae_switch_get_ethdev_mport(mae->switch_domain_id,\n+\t\t\t\t\t port_id, &mport);\n \tif (rc != 0) {\n \t\tsfc_err(sa, \"failed to find MAE switch port SW entry for RTE ethdev port %u: %s\",\n \t\t\tport_id, strerror(rc));\ndiff --git a/drivers/net/sfc/sfc_switch.c b/drivers/net/sfc/sfc_switch.c\nindex 265a17f4c4..3f7518fa30 100644\n--- a/drivers/net/sfc/sfc_switch.c\n+++ b/drivers/net/sfc/sfc_switch.c\n@@ -537,9 +537,9 @@ sfc_mae_find_switch_port_by_ethdev(uint16_t switch_domain_id,\n }\n \n int\n-sfc_mae_switch_port_by_ethdev(uint16_t switch_domain_id,\n-\t\t\t uint16_t ethdev_port_id,\n-\t\t\t efx_mport_sel_t *mport_sel)\n+sfc_mae_switch_get_ethdev_mport(uint16_t switch_domain_id,\n+\t\t\t\tuint16_t ethdev_port_id,\n+\t\t\t\tefx_mport_sel_t *mport_sel)\n {\n \tstruct sfc_mae_switch_port *port;\n \tint rc;\ndiff --git a/drivers/net/sfc/sfc_switch.h b/drivers/net/sfc/sfc_switch.h\nindex 7917141038..a5a0fb4fc5 100644\n--- a/drivers/net/sfc/sfc_switch.h\n+++ b/drivers/net/sfc/sfc_switch.h\n@@ -102,9 +102,9 @@ int sfc_mae_assign_switch_port(uint16_t switch_domain_id,\n int sfc_mae_clear_switch_port(uint16_t switch_domain_id,\n \t\t\t uint16_t switch_port_id);\n \n-int sfc_mae_switch_port_by_ethdev(uint16_t switch_domain_id,\n-\t\t\t\t uint16_t ethdev_port_id,\n-\t\t\t\t efx_mport_sel_t *mport_sel);\n+int sfc_mae_switch_get_ethdev_mport(uint16_t switch_domain_id,\n+\t\t\t\t uint16_t ethdev_port_id,\n+\t\t\t\t efx_mport_sel_t *mport_sel);\n \n int sfc_mae_switch_port_id_by_entity(uint16_t switch_domain_id,\n \t\t\t\t const efx_mport_sel_t *entity_mportp,\n", "prefixes": [ "2/7" ] }