Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10272/?format=api
{ "id": 10272, "url": "http://patches.dpdk.org/api/patches/10272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1454078953-23744-6-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1454078953-23744-6-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1454078953-23744-6-git-send-email-david.marchand@6wind.com", "date": "2016-01-29T14:49:09", "name": "[dpdk-dev,v2,5/9] pci: cosmetic change", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d22d2fa1a57def4e5647919c48f0a7f833ebf0b7", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1454078953-23744-6-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/10272/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/10272/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 84B73C6F8;\n\tFri, 29 Jan 2016 15:49:30 +0100 (CET)", "from mail-wm0-f44.google.com (mail-wm0-f44.google.com\n\t[74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 26FFBC6DE\n\tfor <dev@dpdk.org>; Fri, 29 Jan 2016 15:49:25 +0100 (CET)", "by mail-wm0-f44.google.com with SMTP id p63so71322273wmp.1\n\tfor <dev@dpdk.org>; Fri, 29 Jan 2016 06:49:25 -0800 (PST)", "from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net.\n\t[78.126.77.144]) by smtp.gmail.com with ESMTPSA id\n\ty188sm7811294wmy.11.2016.01.29.06.49.22\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 29 Jan 2016 06:49:23 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=e+CHrIA4WPK79L4KXhPsi448LDdQgvg11wk2q3qam2E=;\n\tb=Cf2X5rCvfMv9CbnljiX7qUcD8fniusWuSURanDq8CVKtXKLkQK2U7ZdsRCjSatrQ4z\n\t3M6mmB0+kFs3Q3e4UswYLFDrqcS+o8qBgRtP5qrVmovm1EBCn24RZvNogN+iPwBRat4x\n\tamYJ/5QUX24Oo8AkxkozGU4/2mXTO9P4HcaiMe6Vd1xuQZreVpysBi2EwnWkICbJOQO4\n\tP2nhQF7emLR6HldDR+gZpCTP2gdMQ1rBG7n8/bOmHu8epsHAmQu1VXkHFvoqcf8Ox5kR\n\tYIP3ZEtK9fidKs/O4NI6z8ahwOd13hu4QQLTEHatjtdje9erousFtrC6+ante+9anfqs\n\to/Zg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=e+CHrIA4WPK79L4KXhPsi448LDdQgvg11wk2q3qam2E=;\n\tb=P724Cj2PhmL1Ez/p8x6jwjH3D+mMD6GDU7XJvnBWz0FKeNc0X1q4/envbarohjW0lM\n\tjh5HWstR/n8LI4lDQ+PyuTRBV+9Y7xJEnBWcELTMY0vxMdLVNBPAwQ+cnM29Buum90BA\n\tpPfigF21vKREseM1Fx7iEjTOsHyHxGk7eGi/LSR4f8xF03d00nJFnyrDeMy04hqhnHUq\n\tlyyUd3uZyii6mv6sEQOvVZxnd4B4Q7EUMIWACT67QUNaLnXCaUXHFKFsF12a0VpmxoyW\n\tvOy+zSgSw73EvTwCYG0l5VaycpnRCDdxEQa2q97dKmzxpPwAMg2OtOot1Frjv1/4ayDD\n\tWJ2A==", "X-Gm-Message-State": "AG10YORYXYzxrGZBVhlt4IsDD3P24/5JNGWfh3loM8qHArLCYjigM6ygpQ43mTmpcRqwxHJT", "X-Received": "by 10.194.246.134 with SMTP id xw6mr8921143wjc.158.1454078964037;\n\tFri, 29 Jan 2016 06:49:24 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 29 Jan 2016 15:49:09 +0100", "Message-Id": "<1454078953-23744-6-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1454078953-23744-1-git-send-email-david.marchand@6wind.com>", "References": "<1453476464-31767-1-git-send-email-david.marchand@6wind.com>\n\t<1454078953-23744-1-git-send-email-david.marchand@6wind.com>", "Cc": "viktorin@rehivetech.com", "Subject": "[dpdk-dev] [PATCH v2 5/9] pci: cosmetic change", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Indent previous commit, rename functions (internal and local functions do\nnot need rte_eal_ prefix).\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/common/eal_common_pci.c | 106 ++++++++++++++++-----------------\n 1 file changed, 52 insertions(+), 54 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex a6791c1..fd88305 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -206,50 +206,49 @@ pci_driver_supports_device(const struct rte_pci_driver *dr,\n * driver.\n */\n static int\n-rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,\n-\t\t\t struct rte_pci_device *dev)\n+pci_probe_device(struct rte_pci_driver *dr, struct rte_pci_device *dev)\n {\n \tint ret;\n-\t\tstruct rte_pci_addr *loc = &dev->addr;\n+\tstruct rte_pci_addr *loc = &dev->addr;\n \n-\t\tRTE_LOG(DEBUG, EAL, \"PCI device \"PCI_PRI_FMT\" on NUMA socket %i\\n\",\n-\t\t\t\tloc->domain, loc->bus, loc->devid, loc->function,\n-\t\t\t\tdev->numa_node);\n+\tRTE_LOG(DEBUG, EAL, \"PCI device \"PCI_PRI_FMT\" on NUMA socket %i\\n\",\n+\t\tloc->domain, loc->bus, loc->devid, loc->function,\n+\t\tdev->numa_node);\n \n-\t\tRTE_LOG(DEBUG, EAL, \" probe driver: %x:%x %s\\n\", dev->id.vendor_id,\n-\t\t\t\tdev->id.device_id, dr->name);\n+\tRTE_LOG(DEBUG, EAL, \" probe driver: %x:%x %s\\n\", dev->id.vendor_id,\n+\t\tdev->id.device_id, dr->name);\n \n-\t\t/* no initialization when blacklisted, return without error */\n-\t\tif (dev->devargs != NULL &&\n-\t\t\tdev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {\n-\t\t\tRTE_LOG(DEBUG, EAL, \" Device is blacklisted, not initializing\\n\");\n-\t\t\treturn 1;\n-\t\t}\n+\t/* no initialization when blacklisted, return without error */\n+\tif (dev->devargs != NULL &&\n+\t\tdev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {\n+\t\tRTE_LOG(DEBUG, EAL, \" Device is blacklisted, not initializing\\n\");\n+\t\treturn 1;\n+\t}\n \n-\t\tif (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {\n+\tif (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {\n #ifdef RTE_PCI_CONFIG\n-\t\t\t/*\n-\t\t\t * Set PCIe config space for high performance.\n-\t\t\t * Return value can be ignored.\n-\t\t\t */\n-\t\t\tpci_config_space_set(dev);\n+\t\t/*\n+\t\t * Set PCIe config space for high performance.\n+\t\t * Return value can be ignored.\n+\t\t */\n+\t\tpci_config_space_set(dev);\n #endif\n-\t\t\t/* map resources for devices that use igb_uio */\n-\t\t\tret = pci_map_device(dev);\n-\t\t\tif (ret != 0)\n-\t\t\t\treturn ret;\n-\t\t} else if (dr->drv_flags & RTE_PCI_DRV_FORCE_UNBIND &&\n-\t\t\t\trte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\t\t/* unbind current driver */\n-\t\t\tif (pci_unbind_kernel_driver(dev) < 0)\n-\t\t\t\treturn -1;\n-\t\t}\n-\n-\t\t/* reference driver structure */\n-\t\tdev->driver = dr;\n-\n-\t\t/* call the driver devinit() function */\n-\t\treturn dr->devinit(dr, dev);\n+\t\t/* map resources for devices that use igb_uio */\n+\t\tret = pci_map_device(dev);\n+\t\tif (ret != 0)\n+\t\t\treturn ret;\n+\t} else if (dr->drv_flags & RTE_PCI_DRV_FORCE_UNBIND &&\n+\t\t rte_eal_process_type() == RTE_PROC_PRIMARY) {\n+\t\t/* unbind current driver */\n+\t\tif (pci_unbind_kernel_driver(dev) < 0)\n+\t\t\treturn -1;\n+\t}\n+\n+\t/* reference driver structure */\n+\tdev->driver = dr;\n+\n+\t/* call the driver devinit() function */\n+\treturn dr->devinit(dr, dev);\n }\n \n /*\n@@ -257,29 +256,28 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,\n * driver.\n */\n static int\n-rte_eal_pci_detach_dev(struct rte_pci_driver *dr,\n-\t\tstruct rte_pci_device *dev)\n+pci_detach_device(struct rte_pci_driver *dr, struct rte_pci_device *dev)\n {\n-\t\tstruct rte_pci_addr *loc = &dev->addr;\n+\tstruct rte_pci_addr *loc = &dev->addr;\n \n-\t\tRTE_LOG(DEBUG, EAL, \"PCI device \"PCI_PRI_FMT\" on NUMA socket %i\\n\",\n-\t\t\t\tloc->domain, loc->bus, loc->devid,\n-\t\t\t\tloc->function, dev->numa_node);\n+\tRTE_LOG(DEBUG, EAL, \"PCI device \"PCI_PRI_FMT\" on NUMA socket %i\\n\",\n+\t\tloc->domain, loc->bus, loc->devid,\n+\t\tloc->function, dev->numa_node);\n \n-\t\tRTE_LOG(DEBUG, EAL, \" remove driver: %x:%x %s\\n\", dev->id.vendor_id,\n-\t\t\t\tdev->id.device_id, dr->name);\n+\tRTE_LOG(DEBUG, EAL, \" remove driver: %x:%x %s\\n\", dev->id.vendor_id,\n+\t\tdev->id.device_id, dr->name);\n \n-\t\tif (dr->devuninit && (dr->devuninit(dev) < 0))\n-\t\t\treturn -1;\t/* negative value is an error */\n+\tif (dr->devuninit && (dr->devuninit(dev) < 0))\n+\t\treturn -1;\t/* negative value is an error */\n \n-\t\t/* clear driver structure */\n-\t\tdev->driver = NULL;\n+\t/* clear driver structure */\n+\tdev->driver = NULL;\n \n-\t\tif (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING)\n-\t\t\t/* unmap resources for devices that use igb_uio */\n-\t\t\tpci_unmap_device(dev);\n+\tif (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING)\n+\t\t/* unmap resources for devices that use igb_uio */\n+\t\tpci_unmap_device(dev);\n \n-\t\treturn 0;\n+\treturn 0;\n }\n \n /*\n@@ -297,7 +295,7 @@ pci_probe_all_drivers(struct rte_pci_device *dev)\n \t\tif (!pci_driver_supports_device(dr, dev))\n \t\t\tcontinue;\n \n-\t\trc = rte_eal_pci_probe_one_driver(dr, dev);\n+\t\trc = pci_probe_device(dr, dev);\n \t\tif (rc < 0)\n \t\t\t/* negative value is an error */\n \t\t\treturn -1;\n@@ -324,7 +322,7 @@ pci_detach_all_drivers(struct rte_pci_device *dev)\n \t\tif (!pci_driver_supports_device(dr, dev))\n \t\t\tcontinue;\n \n-\t\trc = rte_eal_pci_detach_dev(dr, dev);\n+\t\trc = pci_detach_device(dr, dev);\n \t\tif (rc < 0)\n \t\t\t/* negative value is an error */\n \t\t\treturn -1;\n", "prefixes": [ "dpdk-dev", "v2", "5/9" ] }