Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102682/?format=api
http://patches.dpdk.org/api/patches/102682/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/48f7b483238dec1b63282f892562f614fb447394.1634919021.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<48f7b483238dec1b63282f892562f614fb447394.1634919021.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/48f7b483238dec1b63282f892562f614fb447394.1634919021.git.gmuthukrishn@marvell.com", "date": "2021-10-22T16:11:42", "name": "[v3] mempool: add telemetry endpoint for mempool info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8b1a16c2088724c41d62169184a91c9490c06666", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/48f7b483238dec1b63282f892562f614fb447394.1634919021.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 19923, "url": "http://patches.dpdk.org/api/series/19923/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19923", "date": "2021-10-22T16:11:42", "name": "[v3] mempool: add telemetry endpoint for mempool info", "version": 3, "mbox": "http://patches.dpdk.org/series/19923/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102682/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08053A0C43;\n\tFri, 22 Oct 2021 18:11:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AE8BE410DF;\n\tFri, 22 Oct 2021 18:11:52 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id E96B14003E\n for <dev@dpdk.org>; Fri, 22 Oct 2021 18:11:50 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id\n 19M9qIlq011085;\n Fri, 22 Oct 2021 09:11:49 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3buu23scxj-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 22 Oct 2021 09:11:48 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Fri, 22 Oct 2021 09:11:47 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Fri, 22 Oct 2021 09:11:47 -0700", "from localhost.localdomain (unknown [10.28.34.38])\n by maili.marvell.com (Postfix) with ESMTP id 9E4923F7079;\n Fri, 22 Oct 2021 09:11:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=7l+5VdTHlCDl9ILY8+/JEqBGpJndHoiRypFGVWEDoE4=;\n b=R90Haij7Sh4sr0lMQrh+euJAxANcRSRoMlrhsqATo74nkcchCVenfJGdE9opRkJ2mDHJ\n xAk+BTsoS8Rad3ZezkAH50n5N5ZmGdoPHVu8Nz4R4ZbRvZgOs2/C5pQnkVbwotQOhSLZ\n LsSKU0NGrjV8iR0VmsiUH3vcsMEkxJbxm25Kw6gHRdOykleUl0uALePcXQsME88iNeLw\n qiWDertf6r8LCohGwf5fQonmmZ7TB65wJeJuzj6COuz8iwoOtb7xMyR7lvzXDKUHI9y0\n 2tMJWNzhAdZ4WyXmVcICSNLxHNu6XeOG5GkwfhDm1ww9ooE319zEUXxiQZ195XXFZorw sg==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Olivier Matz <olivier.matz@6wind.com>, Andrew Rybchenko\n <andrew.rybchenko@oktetlabs.ru>,\n <jerinj@marvell.com>, <bruce.richardson@intel.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "Date": "Fri, 22 Oct 2021 21:41:42 +0530", "Message-ID": "\n <48f7b483238dec1b63282f892562f614fb447394.1634919021.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <ee814c268b2c443934dc3c3e21e037d07bf9225f.1632896470.git.gmuthukrishn@marvell.com>", "References": "\n <ee814c268b2c443934dc3c3e21e037d07bf9225f.1632896470.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "0A4dIbbOcAeFVV0iExBbCYV3vyaKwdCB", "X-Proofpoint-ORIG-GUID": "0A4dIbbOcAeFVV0iExBbCYV3vyaKwdCB", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-10-22_04,2021-10-22_01,2020-04-07_01", "Subject": "[dpdk-dev] [v3] mempool: add telemetry endpoint for mempool info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add telemetry endpoint for mempool info.\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\nReviewed-by: Bruce Richardson <bruce.richardson@intel.com>\n---\nv3:\n - added explicit telemetry dependency in meson\n---\n lib/mempool/meson.build | 2 +-\n lib/mempool/rte_mempool.c | 84 +++++++++++++++++++++++++++++++++++++++\n 2 files changed, 85 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build\nindex e48bd6a14a..b8aaa00694 100644\n--- a/lib/mempool/meson.build\n+++ b/lib/mempool/meson.build\n@@ -20,4 +20,4 @@ headers = files(\n 'rte_mempool_trace.h',\n 'rte_mempool_trace_fp.h',\n )\n-deps += ['ring']\n+deps += ['ring', 'telemetry']\ndiff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c\nindex b75d26c82a..2d915e591d 100644\n--- a/lib/mempool/rte_mempool.c\n+++ b/lib/mempool/rte_mempool.c\n@@ -31,6 +31,7 @@\n #include <rte_spinlock.h>\n #include <rte_tailq.h>\n #include <rte_eal_paging.h>\n+#include <rte_telemetry.h>\n \n #include \"rte_mempool.h\"\n #include \"rte_mempool_trace.h\"\n@@ -1483,3 +1484,86 @@ rte_mempool_event_callback_unregister(rte_mempool_event_callback *func,\n \trte_errno = -ret;\n \treturn ret;\n }\n+\n+static void\n+mempool_list_cb(struct rte_mempool *mp, void *arg)\n+{\n+\tstruct rte_tel_data *d = (struct rte_tel_data *)arg;\n+\n+\trte_tel_data_add_array_string(d, mp->name);\n+}\n+\n+static int\n+mempool_handle_list(const char *cmd __rte_unused,\n+\t\t const char *params __rte_unused, struct rte_tel_data *d)\n+{\n+\trte_tel_data_start_array(d, RTE_TEL_STRING_VAL);\n+\trte_mempool_walk(mempool_list_cb, d);\n+\treturn 0;\n+}\n+\n+struct mempool_info_cb_arg {\n+\tchar *pool_name;\n+\tstruct rte_tel_data *d;\n+};\n+\n+static void\n+mempool_info_cb(struct rte_mempool *mp, void *arg)\n+{\n+\tstruct mempool_info_cb_arg *info = (struct mempool_info_cb_arg *)arg;\n+\tconst struct rte_memzone *mz;\n+\n+\tif (strncmp(mp->name, info->pool_name, RTE_MEMZONE_NAMESIZE))\n+\t\treturn;\n+\n+\trte_tel_data_add_dict_string(info->d, \"name\", mp->name);\n+\trte_tel_data_add_dict_int(info->d, \"pool_id\", mp->pool_id);\n+\trte_tel_data_add_dict_int(info->d, \"flags\", mp->flags);\n+\trte_tel_data_add_dict_int(info->d, \"socket_id\", mp->socket_id);\n+\trte_tel_data_add_dict_int(info->d, \"size\", mp->size);\n+\trte_tel_data_add_dict_int(info->d, \"cache_size\", mp->cache_size);\n+\trte_tel_data_add_dict_int(info->d, \"elt_size\", mp->elt_size);\n+\trte_tel_data_add_dict_int(info->d, \"header_size\", mp->header_size);\n+\trte_tel_data_add_dict_int(info->d, \"trailer_size\", mp->trailer_size);\n+\trte_tel_data_add_dict_int(info->d, \"private_data_size\",\n+\t\t\t\t mp->private_data_size);\n+\trte_tel_data_add_dict_int(info->d, \"ops_index\", mp->ops_index);\n+\trte_tel_data_add_dict_int(info->d, \"populated_size\",\n+\t\t\t\t mp->populated_size);\n+\n+\tmz = mp->mz;\n+\trte_tel_data_add_dict_string(info->d, \"mz_name\", mz->name);\n+\trte_tel_data_add_dict_int(info->d, \"mz_len\", mz->len);\n+\trte_tel_data_add_dict_int(info->d, \"mz_hugepage_sz\",\n+\t\t\t\t mz->hugepage_sz);\n+\trte_tel_data_add_dict_int(info->d, \"mz_socket_id\", mz->socket_id);\n+\trte_tel_data_add_dict_int(info->d, \"mz_flags\", mz->flags);\n+}\n+\n+static int\n+mempool_handle_info(const char *cmd __rte_unused, const char *params,\n+\t\t struct rte_tel_data *d)\n+{\n+\tstruct mempool_info_cb_arg mp_arg;\n+\tchar name[RTE_MEMZONE_NAMESIZE];\n+\n+\tif (!params || strlen(params) == 0)\n+\t\treturn -EINVAL;\n+\n+\trte_strlcpy(name, params, RTE_MEMZONE_NAMESIZE);\n+\n+\trte_tel_data_start_dict(d);\n+\tmp_arg.pool_name = name;\n+\tmp_arg.d = d;\n+\trte_mempool_walk(mempool_info_cb, &mp_arg);\n+\n+\treturn 0;\n+}\n+\n+RTE_INIT(mempool_init_telemetry)\n+{\n+\trte_telemetry_register_cmd(\"/mempool/list\", mempool_handle_list,\n+\t\t\"Returns list of available mempool. Takes no parameters\");\n+\trte_telemetry_register_cmd(\"/mempool/info\", mempool_handle_info,\n+\t\t\"Returns mempool info. Parameters: pool_name\");\n+}\n", "prefixes": [ "v3" ] }{ "id": 102682, "url": "