Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102599/?format=api
{ "id": 102599, "url": "http://patches.dpdk.org/api/patches/102599/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1634836698-10864-5-git-send-email-vladimir.medvedkin@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1634836698-10864-5-git-send-email-vladimir.medvedkin@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1634836698-10864-5-git-send-email-vladimir.medvedkin@intel.com", "date": "2021-10-21T17:18:17", "name": "[v4,4/5] test/thash: add tests for a new Toeplitz hash function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "62f6fe575b980245a4dcdbe72b54b6a7362dc5ac", "submitter": { "id": 1216, "url": "http://patches.dpdk.org/api/people/1216/?format=api", "name": "Vladimir Medvedkin", "email": "vladimir.medvedkin@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1634836698-10864-5-git-send-email-vladimir.medvedkin@intel.com/mbox/", "series": [ { "id": 19885, "url": "http://patches.dpdk.org/api/series/19885/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19885", "date": "2021-10-21T17:18:15", "name": "optimized Toeplitz hash implementation", "version": 4, "mbox": "http://patches.dpdk.org/series/19885/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102599/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A2068A0C43;\n\tThu, 21 Oct 2021 19:21:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7870641102;\n\tThu, 21 Oct 2021 19:20:46 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 7692F40E6E\n for <dev@dpdk.org>; Thu, 21 Oct 2021 19:20:41 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Oct 2021 10:18:31 -0700", "from silpixa00400072.ir.intel.com ([10.237.222.213])\n by orsmga003.jf.intel.com with ESMTP; 21 Oct 2021 10:18:29 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10144\"; a=\"252594980\"", "E=Sophos;i=\"5.87,170,1631602800\"; d=\"scan'208\";a=\"252594980\"", "E=Sophos;i=\"5.87,170,1631602800\"; d=\"scan'208\";a=\"445426251\"" ], "X-ExtLoop1": "1", "From": "Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "To": "dev@dpdk.org", "Cc": "yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n bruce.richardson@intel.com, konstantin.ananyev@intel.com,\n stephen@networkplumber.org", "Date": "Thu, 21 Oct 2021 18:18:17 +0100", "Message-Id": "<1634836698-10864-5-git-send-email-vladimir.medvedkin@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": [ "<1634836698-10864-1-git-send-email-vladimir.medvedkin@intel.com>", "<1634754016-367978-1-git-send-email-vladimir.medvedkin@intel.com>" ], "References": [ "<1634836698-10864-1-git-send-email-vladimir.medvedkin@intel.com>", "<1634754016-367978-1-git-send-email-vladimir.medvedkin@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v4 4/5] test/thash: add tests for a new Toeplitz\n hash function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch provides a set of tests for verifying the new\nimplementation of Toeplitz hash function using GFNI.\n\nSigned-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>\n---\n app/test/test_thash.c | 237 ++++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 237 insertions(+)", "diff": "diff --git a/app/test/test_thash.c b/app/test/test_thash.c\nindex d8981fb..a625306 100644\n--- a/app/test/test_thash.c\n+++ b/app/test/test_thash.c\n@@ -6,6 +6,7 @@\n #include <rte_eal.h>\n #include <rte_ip.h>\n #include <rte_random.h>\n+#include <rte_malloc.h>\n \n #include \"test.h\"\n \n@@ -78,6 +79,34 @@ uint8_t default_rss_key[] = {\n 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,\n };\n \n+static const uint8_t big_rss_key[] = {\n+\t0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,\n+\t0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,\n+\t0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,\n+\t0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,\n+\t0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,\n+\t0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,\n+\t0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,\n+\t0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,\n+\t0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,\n+\t0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,\n+\t0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,\n+\t0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,\n+\t0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,\n+\t0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,\n+\t0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,\n+\t0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,\n+\t0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,\n+\t0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,\n+\t0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,\n+\t0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,\n+\t0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,\n+\t0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,\n+\t0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,\n+\t0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,\n+\t0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa,\n+};\n+\n static int\n test_toeplitz_hash_calc(void)\n {\n@@ -145,6 +174,210 @@ test_toeplitz_hash_calc(void)\n }\n \n static int\n+test_toeplitz_hash_gfni(void)\n+{\n+\tuint32_t i, j;\n+\tunion rte_thash_tuple tuple;\n+\tuint32_t rss_l3, rss_l3l4;\n+\tuint64_t rss_key_matrixes[RTE_DIM(default_rss_key)];\n+\n+\tif (!rte_thash_gfni_supported())\n+\t\treturn TEST_SKIPPED;\n+\n+\t/* Convert RSS key into matrixes */\n+\trte_thash_complete_matrix(rss_key_matrixes, default_rss_key,\n+\t\tRTE_DIM(default_rss_key));\n+\n+\tfor (i = 0; i < RTE_DIM(v4_tbl); i++) {\n+\t\ttuple.v4.src_addr = rte_cpu_to_be_32(v4_tbl[i].src_ip);\n+\t\ttuple.v4.dst_addr = rte_cpu_to_be_32(v4_tbl[i].dst_ip);\n+\t\ttuple.v4.sport = rte_cpu_to_be_16(v4_tbl[i].dst_port);\n+\t\ttuple.v4.dport = rte_cpu_to_be_16(v4_tbl[i].src_port);\n+\n+\t\trss_l3 = rte_thash_gfni(rss_key_matrixes, (uint8_t *)&tuple,\n+\t\t\t\tRTE_THASH_V4_L3_LEN * 4);\n+\t\trss_l3l4 = rte_thash_gfni(rss_key_matrixes, (uint8_t *)&tuple,\n+\t\t\t\tRTE_THASH_V4_L4_LEN * 4);\n+\t\tif ((rss_l3 != v4_tbl[i].hash_l3) ||\n+\t\t\t\t(rss_l3l4 != v4_tbl[i].hash_l3l4))\n+\t\t\treturn -TEST_FAILED;\n+\t}\n+\n+\tfor (i = 0; i < RTE_DIM(v6_tbl); i++) {\n+\t\tfor (j = 0; j < RTE_DIM(tuple.v6.src_addr); j++)\n+\t\t\ttuple.v6.src_addr[j] = v6_tbl[i].src_ip[j];\n+\t\tfor (j = 0; j < RTE_DIM(tuple.v6.dst_addr); j++)\n+\t\t\ttuple.v6.dst_addr[j] = v6_tbl[i].dst_ip[j];\n+\t\ttuple.v6.sport = rte_cpu_to_be_16(v6_tbl[i].dst_port);\n+\t\ttuple.v6.dport = rte_cpu_to_be_16(v6_tbl[i].src_port);\n+\t\trss_l3 = rte_thash_gfni(rss_key_matrixes, (uint8_t *)&tuple,\n+\t\t\t\tRTE_THASH_V6_L3_LEN * 4);\n+\t\trss_l3l4 = rte_thash_gfni(rss_key_matrixes, (uint8_t *)&tuple,\n+\t\t\t\tRTE_THASH_V6_L4_LEN * 4);\n+\t\tif ((rss_l3 != v6_tbl[i].hash_l3) ||\n+\t\t\t\t(rss_l3l4 != v6_tbl[i].hash_l3l4))\n+\t\t\treturn -TEST_FAILED;\n+\t}\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+#define DATA_SZ\t\t4\n+#define ITER\t\t1000\n+\n+enum {\n+\tSCALAR_DATA_BUF_1_HASH_IDX = 0,\n+\tSCALAR_DATA_BUF_2_HASH_IDX,\n+\tGFNI_DATA_BUF_1_HASH_IDX,\n+\tGFNI_DATA_BUF_2_HASH_IDX,\n+\tGFNI_BULK_DATA_BUF_1_HASH_IDX,\n+\tGFNI_BULK_DATA_BUF_2_HASH_IDX,\n+\tHASH_IDXES\n+};\n+\n+static int\n+test_toeplitz_hash_rand_data(void)\n+{\n+\tuint32_t data[2][DATA_SZ];\n+\tuint32_t scalar_data[2][DATA_SZ];\n+\tuint32_t hash[HASH_IDXES] = { 0 };\n+\tuint64_t rss_key_matrixes[RTE_DIM(default_rss_key)];\n+\tint i, j;\n+\tuint8_t *bulk_data[2];\n+\n+\tif (!rte_thash_gfni_supported())\n+\t\treturn TEST_SKIPPED;\n+\n+\trte_thash_complete_matrix(rss_key_matrixes, default_rss_key,\n+\t\tRTE_DIM(default_rss_key));\n+\n+\tfor (i = 0; i < 2; i++)\n+\t\tbulk_data[i] = (uint8_t *)data[i];\n+\n+\tfor (i = 0; i < ITER; i++) {\n+\t\tfor (j = 0; j < DATA_SZ; j++) {\n+\t\t\tdata[0][j] = rte_rand();\n+\t\t\tdata[1][j] = rte_rand();\n+\t\t\tscalar_data[0][j] = rte_cpu_to_be_32(data[0][j]);\n+\t\t\tscalar_data[1][j] = rte_cpu_to_be_32(data[1][j]);\n+\t\t}\n+\n+\t\thash[SCALAR_DATA_BUF_1_HASH_IDX] = rte_softrss(scalar_data[0],\n+\t\t\tDATA_SZ, default_rss_key);\n+\t\thash[SCALAR_DATA_BUF_2_HASH_IDX] = rte_softrss(scalar_data[1],\n+\t\t\tDATA_SZ, default_rss_key);\n+\t\thash[GFNI_DATA_BUF_1_HASH_IDX] = rte_thash_gfni(\n+\t\t\trss_key_matrixes, (uint8_t *)data[0],\n+\t\t\tDATA_SZ * sizeof(uint32_t));\n+\t\thash[GFNI_DATA_BUF_2_HASH_IDX] = rte_thash_gfni(\n+\t\t\trss_key_matrixes, (uint8_t *)data[1],\n+\t\t\tDATA_SZ * sizeof(uint32_t));\n+\t\trte_thash_gfni_bulk(rss_key_matrixes,\n+\t\t\tDATA_SZ * sizeof(uint32_t), bulk_data,\n+\t\t\t&hash[GFNI_BULK_DATA_BUF_1_HASH_IDX], 2);\n+\n+\t\tif ((hash[SCALAR_DATA_BUF_1_HASH_IDX] !=\n+\t\t\t\thash[GFNI_DATA_BUF_1_HASH_IDX]) ||\n+\t\t\t\t(hash[SCALAR_DATA_BUF_1_HASH_IDX] !=\n+\t\t\t\thash[GFNI_BULK_DATA_BUF_1_HASH_IDX]) ||\n+\t\t\t\t(hash[SCALAR_DATA_BUF_2_HASH_IDX] !=\n+\t\t\t\thash[GFNI_DATA_BUF_2_HASH_IDX]) ||\n+\t\t\t\t(hash[SCALAR_DATA_BUF_2_HASH_IDX] !=\n+\t\t\t\thash[GFNI_BULK_DATA_BUF_2_HASH_IDX]))\n+\n+\t\t\treturn -TEST_FAILED;\n+\t}\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+enum {\n+\tRSS_V4_IDX,\n+\tRSS_V6_IDX\n+};\n+\n+static int\n+test_toeplitz_hash_gfni_bulk(void)\n+{\n+\tuint32_t i, j;\n+\tunion rte_thash_tuple tuple[2];\n+\tuint8_t *tuples[2];\n+\tuint32_t rss[2] = { 0 };\n+\tuint64_t rss_key_matrixes[RTE_DIM(default_rss_key)];\n+\n+\tif (!rte_thash_gfni_supported())\n+\t\treturn TEST_SKIPPED;\n+\n+\t/* Convert RSS key into matrixes */\n+\trte_thash_complete_matrix(rss_key_matrixes, default_rss_key,\n+\t\tRTE_DIM(default_rss_key));\n+\n+\tfor (i = 0; i < RTE_DIM(tuples); i++) {\n+\t\t/* allocate memory enough for a biggest tuple */\n+\t\ttuples[i] = rte_zmalloc(NULL, RTE_THASH_V6_L4_LEN * 4, 0);\n+\t\tif (tuples[i] == NULL)\n+\t\t\treturn -TEST_FAILED;\n+\t}\n+\n+\tfor (i = 0; i < RTE_MIN(RTE_DIM(v4_tbl), RTE_DIM(v6_tbl)); i++) {\n+\t\t/*Load IPv4 headers and copy it into the corresponding tuple*/\n+\t\ttuple[0].v4.src_addr = rte_cpu_to_be_32(v4_tbl[i].src_ip);\n+\t\ttuple[0].v4.dst_addr = rte_cpu_to_be_32(v4_tbl[i].dst_ip);\n+\t\ttuple[0].v4.sport = rte_cpu_to_be_16(v4_tbl[i].dst_port);\n+\t\ttuple[0].v4.dport = rte_cpu_to_be_16(v4_tbl[i].src_port);\n+\t\trte_memcpy(tuples[0], &tuple[0], RTE_THASH_V4_L4_LEN * 4);\n+\n+\t\t/*Load IPv6 headers and copy it into the corresponding tuple*/\n+\t\tfor (j = 0; j < RTE_DIM(tuple[1].v6.src_addr); j++)\n+\t\t\ttuple[1].v6.src_addr[j] = v6_tbl[i].src_ip[j];\n+\t\tfor (j = 0; j < RTE_DIM(tuple[1].v6.dst_addr); j++)\n+\t\t\ttuple[1].v6.dst_addr[j] = v6_tbl[i].dst_ip[j];\n+\t\ttuple[1].v6.sport = rte_cpu_to_be_16(v6_tbl[i].dst_port);\n+\t\ttuple[1].v6.dport = rte_cpu_to_be_16(v6_tbl[i].src_port);\n+\t\trte_memcpy(tuples[1], &tuple[1], RTE_THASH_V6_L4_LEN * 4);\n+\n+\t\trte_thash_gfni_bulk(rss_key_matrixes, RTE_THASH_V6_L4_LEN * 4,\n+\t\t\ttuples, rss, 2);\n+\n+\t\tif ((rss[RSS_V4_IDX] != v4_tbl[i].hash_l3l4) ||\n+\t\t\t\t(rss[RSS_V6_IDX] != v6_tbl[i].hash_l3l4))\n+\t\t\treturn -TEST_FAILED;\n+\t}\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int\n+test_big_tuple_gfni(void)\n+{\n+\tuint32_t arr[16];\n+\tuint32_t arr_softrss[16];\n+\tuint32_t hash_1, hash_2;\n+\tuint64_t rss_key_matrixes[RTE_DIM(big_rss_key)];\n+\tunsigned int i, size = RTE_DIM(arr) * sizeof(uint32_t);\n+\n+\tif (!rte_thash_gfni_supported())\n+\t\treturn TEST_SKIPPED;\n+\n+\t/* Convert RSS key into matrixes */\n+\trte_thash_complete_matrix(rss_key_matrixes, big_rss_key,\n+\t\tRTE_DIM(big_rss_key));\n+\n+\tfor (i = 0; i < RTE_DIM(arr); i++) {\n+\t\tarr[i] = rte_rand();\n+\t\tarr_softrss[i] = rte_be_to_cpu_32(arr[i]);\n+\t}\n+\n+\thash_1 = rte_softrss(arr_softrss, RTE_DIM(arr), big_rss_key);\n+\thash_2 = rte_thash_gfni(rss_key_matrixes, (uint8_t *)arr, size);\n+\n+\tif (hash_1 != hash_2)\n+\t\treturn -TEST_FAILED;\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int\n test_create_invalid(void)\n {\n \tstruct rte_thash_ctx *ctx;\n@@ -577,6 +810,10 @@ static struct unit_test_suite thash_tests = {\n \t.teardown = NULL,\n \t.unit_test_cases = {\n \tTEST_CASE(test_toeplitz_hash_calc),\n+\tTEST_CASE(test_toeplitz_hash_gfni),\n+\tTEST_CASE(test_toeplitz_hash_rand_data),\n+\tTEST_CASE(test_toeplitz_hash_gfni_bulk),\n+\tTEST_CASE(test_big_tuple_gfni),\n \tTEST_CASE(test_create_invalid),\n \tTEST_CASE(test_multiple_create),\n \tTEST_CASE(test_free_null),\n", "prefixes": [ "v4", "4/5" ] }