Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10258/?format=api
{ "id": 10258, "url": "http://patches.dpdk.org/api/patches/10258/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1454076516-21591-2-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1454076516-21591-2-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1454076516-21591-2-git-send-email-david.marchand@6wind.com", "date": "2016-01-29T14:08:28", "name": "[dpdk-dev,1/9] pci: no need for dynamic tailq init", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c2789f55753eb9ea52cc158ace1fdd14fcd3bdd1", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1454076516-21591-2-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/10258/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/10258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E3B28C69C;\n\tFri, 29 Jan 2016 15:08:45 +0100 (CET)", "from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 146B1C672\n\tfor <dev@dpdk.org>; Fri, 29 Jan 2016 15:08:43 +0100 (CET)", "by mail-wm0-f47.google.com with SMTP id r129so70125815wmr.0\n\tfor <dev@dpdk.org>; Fri, 29 Jan 2016 06:08:43 -0800 (PST)", "from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net.\n\t[78.126.77.144]) by smtp.gmail.com with ESMTPSA id\n\t67sm7669944wmp.20.2016.01.29.06.08.41\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 29 Jan 2016 06:08:42 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=o4uo32LLlzJG992UiamLHfvMi/2HI6Z4ycmQyV4BPrw=;\n\tb=tw+N6VwOLCRvx/hdBBGW776yqR7JdR7j4YsDXM+xmEOc1To76QVYxPvG4w6FwqSDMa\n\t1enUWaOFe84LT0hWH9phDSoTs14ozSgtHT0u2rpdKnempOTYch0SBrt/81P6dW2ncEk3\n\tbSV2wBsRvPKQZRU1CPjoI6BAPUnw55CcOiv+IHiPCGSk/NgWkN5d7oCAIh12A1nhvxTp\n\tMkE/mt8anykI3gR1zMJ+uWM+2iObyIkhkFIWkbiot/CpElkEK+94LMPB2QGGL4WD8b9W\n\t4lpp7khQUlqiXqCFbZGKAvhf9I/J3yw2ELsRyf3fFseyxU5jBR8d1UZIZtWDFALyPm8C\n\tKGCQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=o4uo32LLlzJG992UiamLHfvMi/2HI6Z4ycmQyV4BPrw=;\n\tb=jXUsam4SyMen5rcOgOS+3w33Z1xpR8HrcNDDPDHl410ka5ubCK80bUrUN49+0GQAOz\n\tIjIYVPvkMNB6bcrk19ckuEeuZper0GntjuZKGG0QU+EuvOCHTIiLLtDVGXK+lK1OB90p\n\tFkP/agxTH2GFnBEvO2KEdRkdhccC+srVfJo7DsqRnGPaMO4knx4CYQzudhFatnBk5R5M\n\thaFWMCaN1dt0/UUe+f6ypHnuPtJs7pNe5LlGhyU11E3VZkRcwUoJPPzUqRnMPQquSr17\n\tJ4WIu/Q55BI+YkRzcGdRDHcJrLR1hXDOFzRqo4r3SaEWMoDwSTVzkZj2BI+YVc8FTjhd\n\tv0hQ==", "X-Gm-Message-State": "AG10YOTFqmQ6RMZoyFbMT2HZ59ZchN1ExGf7TxBrDzLVg4gQU11UH0EwazAKMGCm+z51wsYX", "X-Received": "by 10.28.49.4 with SMTP id x4mr9712678wmx.63.1454076522937;\n\tFri, 29 Jan 2016 06:08:42 -0800 (PST)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 29 Jan 2016 15:08:28 +0100", "Message-Id": "<1454076516-21591-2-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1454076516-21591-1-git-send-email-david.marchand@6wind.com>", "References": "<1454076516-21591-1-git-send-email-david.marchand@6wind.com>", "Cc": "viktorin@rehivetech.com", "Subject": "[dpdk-dev] [PATCH 1/9] pci: no need for dynamic tailq init", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These lists can be initialized once and for all at build time.\nWith this, those lists are only manipulated in a common place\n(and we could even make them private).\n\nA nice side effect is that pci drivers can now register in constructors.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/bsdapp/eal/eal_pci.c | 3 ---\n lib/librte_eal/common/eal_common_pci.c | 6 ++++--\n lib/librte_eal/linuxapp/eal/eal_pci.c | 3 ---\n 3 files changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c\nindex 6c21fbd..4584522 100644\n--- a/lib/librte_eal/bsdapp/eal/eal_pci.c\n+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c\n@@ -483,9 +483,6 @@ int rte_eal_pci_write_config(const struct rte_pci_device *dev,\n int\n rte_eal_pci_init(void)\n {\n-\tTAILQ_INIT(&pci_driver_list);\n-\tTAILQ_INIT(&pci_device_list);\n-\n \t/* for debug purposes, PCI can be disabled */\n \tif (internal_config.no_pci)\n \t\treturn 0;\ndiff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c\nindex dcfe947..1e12776 100644\n--- a/lib/librte_eal/common/eal_common_pci.c\n+++ b/lib/librte_eal/common/eal_common_pci.c\n@@ -82,8 +82,10 @@\n \n #include \"eal_private.h\"\n \n-struct pci_driver_list pci_driver_list;\n-struct pci_device_list pci_device_list;\n+struct pci_driver_list pci_driver_list =\n+\tTAILQ_HEAD_INITIALIZER(pci_driver_list);\n+struct pci_device_list pci_device_list =\n+\tTAILQ_HEAD_INITIALIZER(pci_device_list);\n \n static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)\n {\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c\nindex bc5b5be..a354f76 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c\n@@ -625,9 +625,6 @@ int rte_eal_pci_write_config(const struct rte_pci_device *device,\n int\n rte_eal_pci_init(void)\n {\n-\tTAILQ_INIT(&pci_driver_list);\n-\tTAILQ_INIT(&pci_device_list);\n-\n \t/* for debug purposes, PCI can be disabled */\n \tif (internal_config.no_pci)\n \t\treturn 0;\n", "prefixes": [ "dpdk-dev", "1/9" ] }