Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102569/?format=api
{ "id": 102569, "url": "http://patches.dpdk.org/api/patches/102569/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211021095023.18288-27-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211021095023.18288-27-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211021095023.18288-27-jiawenwu@trustnetic.com", "date": "2021-10-21T09:50:23", "name": "[v2,26/26] net/ngbe: add Tx done cleanup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7be54ae513bcf324d240d2390cbb1fd9e675b917", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211021095023.18288-27-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 19874, "url": "http://patches.dpdk.org/api/series/19874/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19874", "date": "2021-10-21T09:49:58", "name": "net/ngbe: add many features", "version": 2, "mbox": "http://patches.dpdk.org/series/19874/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102569/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/102569/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 19959A0547;\n\tThu, 21 Oct 2021 11:54:44 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1D9EE4126B;\n\tThu, 21 Oct 2021 11:51:28 +0200 (CEST)", "from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216])\n by mails.dpdk.org (Postfix) with ESMTP id E992741284\n for <dev@dpdk.org>; Thu, 21 Oct 2021 11:51:23 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 21 Oct 2021 17:51:17 +0800 (CST)" ], "X-QQ-mid": "bizesmtp38t1634809878tfr4jik5", "X-QQ-SSF": "01400000000000E0I000000A0000000", "X-QQ-FEAT": "a4niRxydalEjgaVODz8MZrzRVZeBbmiIN5+JNyDVpGLUIl43hnGyhobEXCv3B\n PDqLghmisjo/UCzyvkxT8Uqv4+OB9PkLj3SU69rps+nIdkEZ0bm8aNAnn8AUg3Twf7Igahv\n 6UE4vyHzCpijd7WmhTmKKMgYjmAgqvuVe44HnMOAeGzkvKkmE7gfHFCLo8xEhjEZRGTxLm/\n S1oMeoWHFvX8JN3D0kUSKa6BTiY4O1v2NFPmW44Nkyfnrvrng21yyqMtCNZrF5Zx1FBchTe\n PIc0lRbMo3xcBN6wP32taCmMl41XJZlNBy5hCvnN0s+2Mpuaa3l5hb8hIcpoYCvuj+yjMGq\n JY13sFQ2PiLhtf8Pbqajabe2AqIbvTPFKUpNsmpfIeyB4Dfj5A=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Thu, 21 Oct 2021 17:50:23 +0800", "Message-Id": "<20211021095023.18288-27-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20211021095023.18288-1-jiawenwu@trustnetic.com>", "References": "<20211021095023.18288-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign2", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 26/26] net/ngbe: add Tx done cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for API rte_eth_tx_done_cleanup().\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/ngbe_ethdev.c | 1 +\n drivers/net/ngbe/ngbe_rxtx.c | 89 ++++++++++++++++++++++++++++++++++\n drivers/net/ngbe/ngbe_rxtx.h | 1 +\n 3 files changed, 91 insertions(+)", "diff": "diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 706227339f..e9e3c03ee0 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -3103,6 +3103,7 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = {\n \t.timesync_adjust_time = ngbe_timesync_adjust_time,\n \t.timesync_read_time = ngbe_timesync_read_time,\n \t.timesync_write_time = ngbe_timesync_write_time,\n+\t.tx_done_cleanup = ngbe_dev_tx_done_cleanup,\n };\n \n RTE_PMD_REGISTER_PCI(net_ngbe, rte_ngbe_pmd);\ndiff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c\nindex e1a999a470..575ae60f4f 100644\n--- a/drivers/net/ngbe/ngbe_rxtx.c\n+++ b/drivers/net/ngbe/ngbe_rxtx.c\n@@ -1713,6 +1713,95 @@ ngbe_tx_queue_release_mbufs(struct ngbe_tx_queue *txq)\n \t}\n }\n \n+static int\n+ngbe_tx_done_cleanup_full(struct ngbe_tx_queue *txq, uint32_t free_cnt)\n+{\n+\tstruct ngbe_tx_entry *swr_ring = txq->sw_ring;\n+\tuint16_t i, tx_last, tx_id;\n+\tuint16_t nb_tx_free_last;\n+\tuint16_t nb_tx_to_clean;\n+\tuint32_t pkt_cnt;\n+\n+\t/* Start free mbuf from the next of tx_tail */\n+\ttx_last = txq->tx_tail;\n+\ttx_id = swr_ring[tx_last].next_id;\n+\n+\tif (txq->nb_tx_free == 0 && ngbe_xmit_cleanup(txq))\n+\t\treturn 0;\n+\n+\tnb_tx_to_clean = txq->nb_tx_free;\n+\tnb_tx_free_last = txq->nb_tx_free;\n+\tif (!free_cnt)\n+\t\tfree_cnt = txq->nb_tx_desc;\n+\n+\t/* Loop through swr_ring to count the amount of\n+\t * freeable mubfs and packets.\n+\t */\n+\tfor (pkt_cnt = 0; pkt_cnt < free_cnt; ) {\n+\t\tfor (i = 0; i < nb_tx_to_clean &&\n+\t\t\tpkt_cnt < free_cnt &&\n+\t\t\ttx_id != tx_last; i++) {\n+\t\t\tif (swr_ring[tx_id].mbuf != NULL) {\n+\t\t\t\trte_pktmbuf_free_seg(swr_ring[tx_id].mbuf);\n+\t\t\t\tswr_ring[tx_id].mbuf = NULL;\n+\n+\t\t\t\t/*\n+\t\t\t\t * last segment in the packet,\n+\t\t\t\t * increment packet count\n+\t\t\t\t */\n+\t\t\t\tpkt_cnt += (swr_ring[tx_id].last_id == tx_id);\n+\t\t\t}\n+\n+\t\t\ttx_id = swr_ring[tx_id].next_id;\n+\t\t}\n+\n+\t\tif (pkt_cnt < free_cnt) {\n+\t\t\tif (ngbe_xmit_cleanup(txq))\n+\t\t\t\tbreak;\n+\n+\t\t\tnb_tx_to_clean = txq->nb_tx_free - nb_tx_free_last;\n+\t\t\tnb_tx_free_last = txq->nb_tx_free;\n+\t\t}\n+\t}\n+\n+\treturn (int)pkt_cnt;\n+}\n+\n+static int\n+ngbe_tx_done_cleanup_simple(struct ngbe_tx_queue *txq,\n+\t\t\tuint32_t free_cnt)\n+{\n+\tint i, n, cnt;\n+\n+\tif (free_cnt == 0 || free_cnt > txq->nb_tx_desc)\n+\t\tfree_cnt = txq->nb_tx_desc;\n+\n+\tcnt = free_cnt - free_cnt % txq->tx_free_thresh;\n+\n+\tfor (i = 0; i < cnt; i += n) {\n+\t\tif (txq->nb_tx_desc - txq->nb_tx_free < txq->tx_free_thresh)\n+\t\t\tbreak;\n+\n+\t\tn = ngbe_tx_free_bufs(txq);\n+\n+\t\tif (n == 0)\n+\t\t\tbreak;\n+\t}\n+\n+\treturn i;\n+}\n+\n+int\n+ngbe_dev_tx_done_cleanup(void *tx_queue, uint32_t free_cnt)\n+{\n+\tstruct ngbe_tx_queue *txq = (struct ngbe_tx_queue *)tx_queue;\n+\tif (txq->offloads == 0 &&\n+\t\ttxq->tx_free_thresh >= RTE_PMD_NGBE_TX_MAX_BURST)\n+\t\treturn ngbe_tx_done_cleanup_simple(txq, free_cnt);\n+\n+\treturn ngbe_tx_done_cleanup_full(txq, free_cnt);\n+}\n+\n static void\n ngbe_tx_free_swring(struct ngbe_tx_queue *txq)\n {\ndiff --git a/drivers/net/ngbe/ngbe_rxtx.h b/drivers/net/ngbe/ngbe_rxtx.h\nindex 58425bbdd3..d5cae4934a 100644\n--- a/drivers/net/ngbe/ngbe_rxtx.h\n+++ b/drivers/net/ngbe/ngbe_rxtx.h\n@@ -368,6 +368,7 @@ struct ngbe_txq_ops {\n void ngbe_set_tx_function(struct rte_eth_dev *dev, struct ngbe_tx_queue *txq);\n \n void ngbe_set_rx_function(struct rte_eth_dev *dev);\n+int ngbe_dev_tx_done_cleanup(void *tx_queue, uint32_t free_cnt);\n \n uint64_t ngbe_get_tx_port_offloads(struct rte_eth_dev *dev);\n uint64_t ngbe_get_rx_queue_offloads(struct rte_eth_dev *dev);\n", "prefixes": [ "v2", "26/26" ] }