Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102340/?format=api
{ "id": 102340, "url": "http://patches.dpdk.org/api/patches/102340/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211020065944.19617-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211020065944.19617-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211020065944.19617-1-david.marchand@redhat.com", "date": "2021-10-20T06:59:43", "name": "[1/2] dmadev: hide devices array", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0c84a6ff73aa2b7923df3a9d53d294e4105b33c0", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211020065944.19617-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 19818, "url": "http://patches.dpdk.org/api/series/19818/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19818", "date": "2021-10-20T06:59:43", "name": "[1/2] dmadev: hide devices array", "version": 1, "mbox": "http://patches.dpdk.org/series/19818/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102340/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102340/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC84CA0C45;\n\tWed, 20 Oct 2021 09:00:04 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6717740E6E;\n\tWed, 20 Oct 2021 09:00:04 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id D5D7C40142\n for <dev@dpdk.org>; Wed, 20 Oct 2021 09:00:02 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-476-XNOj3GFWPJ26_nE2yu1JTg-1; Wed, 20 Oct 2021 02:59:59 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB95C1006AA4;\n Wed, 20 Oct 2021 06:59:57 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.193.101])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 2AB1C62A41;\n Wed, 20 Oct 2021 06:59:55 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1634713202;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=d9USp4o4XFTz4Nl6nXkx/z/W+YBy785tcbf92W3cyKU=;\n b=YApaAPA00UWF4iMtHcmgYhpW4/vdGduHTNpfZ06e1xzcWUcCVFHsd2A0tB/8ZUVpZeyv1J\n 1nOTt+SAUWTdB3BHalfpTvnKOBQwRUkULHcJKaqMx3SA4R037s/Z2gv0z6n8xDIQJJugVv\n iahFpo7wVPPviMaBtRoL+hle/iC0Toc=", "X-MC-Unique": "XNOj3GFWPJ26_nE2yu1JTg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Chengwen Feng <fengchengwen@huawei.com>,\n\tRay Kinsella <mdr@ashroe.eu>", "Date": "Wed, 20 Oct 2021 08:59:43 +0200", "Message-Id": "<20211020065944.19617-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 1/2] dmadev: hide devices array", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "No need to expose rte_dma_devices out of the dmadev library.\nExisting helpers should be enough, and inlines make use of\nrte_dma_fp_objs.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test/test_dmadev.c | 5 +++--\n lib/dmadev/rte_dmadev.c | 2 +-\n lib/dmadev/rte_dmadev_pmd.h | 2 --\n lib/dmadev/version.map | 1 -\n 4 files changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c\nindex 1e327bd45f..8b58256afc 100644\n--- a/app/test/test_dmadev.c\n+++ b/app/test/test_dmadev.c\n@@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id)\n \t};\n \tconst int vchan = 0;\n \n+\trte_dma_info_get(dev_id, &info);\n+\n \tprintf(\"\\n### Test dmadev instance %u [%s]\\n\",\n-\t\t\tdev_id, rte_dma_devices[dev_id].data->dev_name);\n+\t\t\tdev_id, info.dev_name);\n \n-\trte_dma_info_get(dev_id, &info);\n \tif (info.max_vchans < 1)\n \t\tERR_RETURN(\"Error, no channels available on device id %u\\n\", dev_id);\n \ndiff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c\nindex 182d32aedb..d4b32b2971 100644\n--- a/lib/dmadev/rte_dmadev.c\n+++ b/lib/dmadev/rte_dmadev.c\n@@ -18,7 +18,7 @@\n static int16_t dma_devices_max;\n \n struct rte_dma_fp_object *rte_dma_fp_objs;\n-struct rte_dma_dev *rte_dma_devices;\n+static struct rte_dma_dev *rte_dma_devices;\n static struct {\n \t/* Hold the dev_max information of the primary process. This field is\n \t * set by the primary process and is read by the secondary process.\ndiff --git a/lib/dmadev/rte_dmadev_pmd.h b/lib/dmadev/rte_dmadev_pmd.h\nindex b97b5bf10b..5316ad5b5f 100644\n--- a/lib/dmadev/rte_dmadev_pmd.h\n+++ b/lib/dmadev/rte_dmadev_pmd.h\n@@ -131,8 +131,6 @@ struct rte_dma_dev {\n \tuint64_t reserved[2]; /**< Reserved for future fields. */\n } __rte_cache_aligned;\n \n-extern struct rte_dma_dev *rte_dma_devices;\n-\n /**\n * @internal\n * Allocate a new dmadev slot for an DMA device and return the pointer to that\ndiff --git a/lib/dmadev/version.map b/lib/dmadev/version.map\nindex ef561acd46..89f7a5b1d3 100644\n--- a/lib/dmadev/version.map\n+++ b/lib/dmadev/version.map\n@@ -30,7 +30,6 @@ EXPERIMENTAL {\n INTERNAL {\n \tglobal:\n \n-\trte_dma_devices;\n \trte_dma_fp_objs;\n \trte_dma_pmd_allocate;\n \trte_dma_pmd_release;\n", "prefixes": [ "1/2" ] }