Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102238/?format=api
{ "id": 102238, "url": "http://patches.dpdk.org/api/patches/102238/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211019130445.1955622-4-zhihongx.peng@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211019130445.1955622-4-zhihongx.peng@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211019130445.1955622-4-zhihongx.peng@intel.com", "date": "2021-10-19T13:04:45", "name": "[v12,4/4] performance-thread: Fix cross compilation failed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c4667889e2de90060d1790dd993a6bbaf97ea2c8", "submitter": { "id": 1643, "url": "http://patches.dpdk.org/api/people/1643/?format=api", "name": "Peng, ZhihongX", "email": "zhihongx.peng@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211019130445.1955622-4-zhihongx.peng@intel.com/mbox/", "series": [ { "id": 19795, "url": "http://patches.dpdk.org/api/series/19795/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19795", "date": "2021-10-19T13:04:42", "name": "[v12,1/4] Enable ASan for memory detector on DPDK", "version": 12, "mbox": "http://patches.dpdk.org/series/19795/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102238/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CC85DA0C41;\n\tTue, 19 Oct 2021 15:19:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B4995411AA;\n\tTue, 19 Oct 2021 15:19:06 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 2BEAC4119C;\n Tue, 19 Oct 2021 15:19:04 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Oct 2021 06:05:21 -0700", "from unknown (HELO localhost.localdomain) ([10.240.183.65])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Oct 2021 06:05:17 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10141\"; a=\"228454387\"", "E=Sophos;i=\"5.87,163,1631602800\"; d=\"scan'208\";a=\"228454387\"", "E=Sophos;i=\"5.87,163,1631602800\"; d=\"scan'208\";a=\"483212046\"" ], "From": "zhihongx.peng@intel.com", "To": "david.marchand@redhat.com, anatoly.burakov@intel.com,\n konstantin.ananyev@intel.com, stephen@networkplumber.org,\n cristian.dumitrescu@intel.com, john.mcnamara@intel.com,\n bruce.richardson@intel.com", "Cc": "dev@dpdk.org, xueqin.lin@intel.com,\n Zhihong Peng <zhihongx.peng@intel.com>,\n stable@dpdk.org", "Date": "Tue, 19 Oct 2021 21:04:45 +0800", "Message-Id": "<20211019130445.1955622-4-zhihongx.peng@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211019130445.1955622-1-zhihongx.peng@intel.com>", "References": "<20211019101207.1451058-4-zhihongx.peng@intel.com>\n <20211019130445.1955622-1-zhihongx.peng@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v12 4/4] performance-thread: Fix cross\n compilation failed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Zhihong Peng <zhihongx.peng@intel.com>\n\nThe gcc(arm-linux-gcc) will check code more stricter when ASan enabled.\n\"strncpy specified bound XX equals destination size\" error occurs here.\n\nFixes: 116819b9ed0d (\"examples/performance-thread: add lthread subsystem\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xueqin Lin <xueqin.lin@intel.com>\nSigned-off-by: Zhihong Peng <zhihongx.peng@intel.com>\n---\nv11: Use rte_strlcpy to replace strncpy.\nv12: Delete rte_strlcpy's rte_.\n---\n examples/performance-thread/common/lthread.c | 4 ++--\n examples/performance-thread/common/lthread_cond.c | 6 +++---\n examples/performance-thread/common/lthread_mutex.c | 6 +++---\n 3 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/examples/performance-thread/common/lthread.c b/examples/performance-thread/common/lthread.c\nindex 3f1f48db43..190e5874b1 100644\n--- a/examples/performance-thread/common/lthread.c\n+++ b/examples/performance-thread/common/lthread.c\n@@ -20,6 +20,7 @@\n #include <sys/mman.h>\n \n #include <rte_log.h>\n+#include <rte_string_fns.h>\n #include <ctx.h>\n #include <stack.h>\n \n@@ -463,6 +464,5 @@ void lthread_set_funcname(const char *f)\n {\n \tstruct lthread *lt = THIS_LTHREAD;\n \n-\tstrncpy(lt->funcname, f, sizeof(lt->funcname));\n-\tlt->funcname[sizeof(lt->funcname)-1] = 0;\n+\tstrlcpy(lt->funcname, f, sizeof(lt->funcname));\n }\ndiff --git a/examples/performance-thread/common/lthread_cond.c b/examples/performance-thread/common/lthread_cond.c\nindex cdcc7a7b5a..e7be17089a 100644\n--- a/examples/performance-thread/common/lthread_cond.c\n+++ b/examples/performance-thread/common/lthread_cond.c\n@@ -20,6 +20,7 @@\n \n #include <rte_log.h>\n #include <rte_common.h>\n+#include <rte_string_fns.h>\n \n #include \"lthread_api.h\"\n #include \"lthread_diag_api.h\"\n@@ -57,10 +58,9 @@ lthread_cond_init(char *name, struct lthread_cond **cond,\n \t}\n \n \tif (name == NULL)\n-\t\tstrncpy(c->name, \"no name\", sizeof(c->name));\n+\t\tstrlcpy(c->name, \"no name\", sizeof(c->name));\n \telse\n-\t\tstrncpy(c->name, name, sizeof(c->name));\n-\tc->name[sizeof(c->name)-1] = 0;\n+\t\tstrlcpy(c->name, name, sizeof(c->name));\n \n \tc->root_sched = THIS_SCHED;\n \ndiff --git a/examples/performance-thread/common/lthread_mutex.c b/examples/performance-thread/common/lthread_mutex.c\nindex 01da6cad4f..709ab9f553 100644\n--- a/examples/performance-thread/common/lthread_mutex.c\n+++ b/examples/performance-thread/common/lthread_mutex.c\n@@ -19,6 +19,7 @@\n #include <rte_log.h>\n #include <rte_spinlock.h>\n #include <rte_common.h>\n+#include <rte_string_fns.h>\n \n #include \"lthread_api.h\"\n #include \"lthread_int.h\"\n@@ -52,10 +53,9 @@ lthread_mutex_init(char *name, struct lthread_mutex **mutex,\n \t}\n \n \tif (name == NULL)\n-\t\tstrncpy(m->name, \"no name\", sizeof(m->name));\n+\t\tstrlcpy(m->name, \"no name\", sizeof(m->name));\n \telse\n-\t\tstrncpy(m->name, name, sizeof(m->name));\n-\tm->name[sizeof(m->name)-1] = 0;\n+\t\tstrlcpy(m->name, name, sizeof(m->name));\n \n \tm->root_sched = THIS_SCHED;\n \tm->owner = NULL;\n", "prefixes": [ "v12", "4/4" ] }