Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102064/?format=api
{ "id": 102064, "url": "http://patches.dpdk.org/api/patches/102064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211018144201.2028022-7-gakhil@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211018144201.2028022-7-gakhil@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211018144201.2028022-7-gakhil@marvell.com", "date": "2021-10-18T14:42:00", "name": "[v3,6/7] cryptodev: update fast path APIs to use new flat array", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fd8e80ee3410a562283c1cd2b911f50c945505d9", "submitter": { "id": 2094, "url": "http://patches.dpdk.org/api/people/2094/?format=api", "name": "Akhil Goyal", "email": "gakhil@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211018144201.2028022-7-gakhil@marvell.com/mbox/", "series": [ { "id": 19749, "url": "http://patches.dpdk.org/api/series/19749/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19749", "date": "2021-10-18T14:41:54", "name": "cryptodev: hide internal structures", "version": 3, "mbox": "http://patches.dpdk.org/series/19749/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102064/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C73CAA0C43;\n\tMon, 18 Oct 2021 16:44:09 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B3CA240DF5;\n\tMon, 18 Oct 2021 16:44:09 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 9664640142\n for <dev@dpdk.org>; Mon, 18 Oct 2021 16:44:08 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id\n 19ICYI0I024744;\n Mon, 18 Oct 2021 07:43:02 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 3bs1bujc59-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 18 Oct 2021 07:43:01 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 18 Oct 2021 07:43:00 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 18 Oct 2021 07:43:00 -0700", "from localhost.localdomain (unknown [10.28.36.185])\n by maili.marvell.com (Postfix) with ESMTP id 005185C68E6;\n Mon, 18 Oct 2021 07:42:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=iTyDXBT2NmKgb/+vn9/3HIROO/2oTO/LF9iDqvEaPyM=;\n b=eswTPCN58h77QNtK5QKd5MN7S27BmUfJaXJ0Z4wQiksJvvL5slvdRIWjB6TPRxAB9AiJ\n UwG6eE2JlaZWI0xMhdqdGpX8WLLvGgZCMdhDEuIwAebBILuTr/yDa6OOi0eK40HqdjvV\n dtgocLJYuIpi3Vt7scA4Rh6WH/IJAA2qlFyiEMooPVuemIY4HLUexOcp6AU77veSWjM8\n nB1YjKnhm/2/2LPb3kUFTxZ2S0vPEGVG18i448vTH75ZeTes+eFCCyAo9IK2CyWNAB5w\n wEeWxL05oitPf6QFpDVODojLtjWRxeyLgU6jhiCQg5y66UTS3wyGukZ7FUrf2vFERgCc Cg==", "From": "Akhil Goyal <gakhil@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>,\n <hemant.agrawal@nxp.com>, <anoobj@marvell.com>,\n <pablo.de.lara.guarch@intel.com>, <fiona.trahe@intel.com>,\n <declan.doherty@intel.com>, <matan@nvidia.com>, <g.singh@nxp.com>,\n <roy.fan.zhang@intel.com>, <jianjay.zhou@huawei.com>,\n <asomalap@amd.com>, <ruifeng.wang@arm.com>,\n <konstantin.ananyev@intel.com>, <radu.nicolau@intel.com>,\n <ajit.khaparde@broadcom.com>, <rnagadheeraj@marvell.com>,\n <adwivedi@marvell.com>, <ciara.power@intel.com>,\n Akhil Goyal <gakhil@marvell.com>", "Date": "Mon, 18 Oct 2021 20:12:00 +0530", "Message-ID": "<20211018144201.2028022-7-gakhil@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211018144201.2028022-1-gakhil@marvell.com>", "References": "<20211011124309.4066491-1-gakhil@marvell.com>\n <20211018144201.2028022-1-gakhil@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "ZW9KvYQwGvfYOOWTNCAIxTS7MReh2wn0", "X-Proofpoint-ORIG-GUID": "ZW9KvYQwGvfYOOWTNCAIxTS7MReh2wn0", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-10-18_06,2021-10-18_01,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH v3 6/7] cryptodev: update fast path APIs to use\n new flat array", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rework fast-path cryptodev functions to use rte_crypto_fp_ops[].\nWhile it is an API/ABI breakage, this change is intended to be\ntransparent for both users (no changes in user app is required) and\nPMD developers (no changes in PMD is required).\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\nAcked-by: Fan Zhang <roy.fan.zhang@intel.com>\n---\n lib/cryptodev/rte_cryptodev.h | 27 +++++++++++++++++----------\n 1 file changed, 17 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h\nindex ce0dca72be..56e3868ada 100644\n--- a/lib/cryptodev/rte_cryptodev.h\n+++ b/lib/cryptodev/rte_cryptodev.h\n@@ -1832,13 +1832,18 @@ static inline uint16_t\n rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,\n \t\tstruct rte_crypto_op **ops, uint16_t nb_ops)\n {\n-\tstruct rte_cryptodev *dev = &rte_cryptodevs[dev_id];\n+\tconst struct rte_crypto_fp_ops *fp_ops;\n+\tvoid *qp;\n \n \trte_cryptodev_trace_dequeue_burst(dev_id, qp_id, (void **)ops, nb_ops);\n-\tnb_ops = (*dev->dequeue_burst)\n-\t\t\t(dev->data->queue_pairs[qp_id], ops, nb_ops);\n+\n+\tfp_ops = &rte_crypto_fp_ops[dev_id];\n+\tqp = fp_ops->qp.data[qp_id];\n+\n+\tnb_ops = fp_ops->dequeue_burst(qp, ops, nb_ops);\n+\n #ifdef RTE_CRYPTO_CALLBACKS\n-\tif (unlikely(dev->deq_cbs != NULL)) {\n+\tif (unlikely(fp_ops->qp.deq_cb != NULL)) {\n \t\tstruct rte_cryptodev_cb_rcu *list;\n \t\tstruct rte_cryptodev_cb *cb;\n \n@@ -1848,7 +1853,7 @@ rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,\n \t\t * cb and cb->fn/cb->next, __ATOMIC_ACQUIRE memory order is\n \t\t * not required.\n \t\t */\n-\t\tlist = &dev->deq_cbs[qp_id];\n+\t\tlist = &fp_ops->qp.deq_cb[qp_id];\n \t\trte_rcu_qsbr_thread_online(list->qsbr, 0);\n \t\tcb = __atomic_load_n(&list->next, __ATOMIC_RELAXED);\n \n@@ -1899,10 +1904,13 @@ static inline uint16_t\n rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,\n \t\tstruct rte_crypto_op **ops, uint16_t nb_ops)\n {\n-\tstruct rte_cryptodev *dev = &rte_cryptodevs[dev_id];\n+\tconst struct rte_crypto_fp_ops *fp_ops;\n+\tvoid *qp;\n \n+\tfp_ops = &rte_crypto_fp_ops[dev_id];\n+\tqp = fp_ops->qp.data[qp_id];\n #ifdef RTE_CRYPTO_CALLBACKS\n-\tif (unlikely(dev->enq_cbs != NULL)) {\n+\tif (unlikely(fp_ops->qp.enq_cb != NULL)) {\n \t\tstruct rte_cryptodev_cb_rcu *list;\n \t\tstruct rte_cryptodev_cb *cb;\n \n@@ -1912,7 +1920,7 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,\n \t\t * cb and cb->fn/cb->next, __ATOMIC_ACQUIRE memory order is\n \t\t * not required.\n \t\t */\n-\t\tlist = &dev->enq_cbs[qp_id];\n+\t\tlist = &fp_ops->qp.enq_cb[qp_id];\n \t\trte_rcu_qsbr_thread_online(list->qsbr, 0);\n \t\tcb = __atomic_load_n(&list->next, __ATOMIC_RELAXED);\n \n@@ -1927,8 +1935,7 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,\n #endif\n \n \trte_cryptodev_trace_enqueue_burst(dev_id, qp_id, (void **)ops, nb_ops);\n-\treturn (*dev->enqueue_burst)(\n-\t\t\tdev->data->queue_pairs[qp_id], ops, nb_ops);\n+\treturn fp_ops->enqueue_burst(qp, ops, nb_ops);\n }\n \n \n", "prefixes": [ "v3", "6/7" ] }