Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101989/?format=api
http://patches.dpdk.org/api/patches/101989/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211018122818.1579942-2-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211018122818.1579942-2-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211018122818.1579942-2-kevin.laatz@intel.com", "date": "2021-10-18T12:28:03", "name": "[v8,01/16] raw/ioat: only build if dmadev not present", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "64ef6e4b60cef1e1612f8324ef74805e9536e5f4", "submitter": { "id": 921, "url": "http://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211018122818.1579942-2-kevin.laatz@intel.com/mbox/", "series": [ { "id": 19737, "url": "http://patches.dpdk.org/api/series/19737/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19737", "date": "2021-10-18T12:28:02", "name": "add dmadev driver for idxd devices", "version": 8, "mbox": "http://patches.dpdk.org/series/19737/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/101989/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/101989/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0CC95A0C43;\n\tMon, 18 Oct 2021 14:28:32 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E6178410EF;\n\tMon, 18 Oct 2021 14:28:27 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 4ED83410E4\n for <dev@dpdk.org>; Mon, 18 Oct 2021 14:28:26 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Oct 2021 05:28:25 -0700", "from silpixa00401122.ir.intel.com ([10.55.128.10])\n by orsmga008.jf.intel.com with ESMTP; 18 Oct 2021 05:28:22 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10140\"; a=\"215401527\"", "E=Sophos;i=\"5.85,382,1624345200\"; d=\"scan'208\";a=\"215401527\"", "E=Sophos;i=\"5.85,382,1624345200\"; d=\"scan'208\";a=\"493562406\"" ], "X-ExtLoop1": "1", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com, fengchengwen@huawei.com,\n jerinj@marvell.com, conor.walsh@intel.com,\n Kevin Laatz <kevin.laatz@intel.com>", "Date": "Mon, 18 Oct 2021 12:28:03 +0000", "Message-Id": "<20211018122818.1579942-2-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211018122818.1579942-1-kevin.laatz@intel.com>", "References": "<20210827172048.558704-1-kevin.laatz@intel.com>\n <20211018122818.1579942-1-kevin.laatz@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 01/16] raw/ioat: only build if dmadev not\n present", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nOnly build the rawdev IDXD/IOAT drivers if the dmadev drivers are not\npresent.\n\nThis change requires the dependencies to be reordered in\ndrivers/meson.build so that rawdev can use the \"RTE_DMA_* build macros to\ncheck for the presence of the equivalent dmadev driver.\n\nA note is also added to the documentation to inform users of this change.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nReviewed-by: Conor Walsh <conor.walsh@intel.com>\n---\n doc/guides/rawdevs/ioat.rst | 8 ++++++++\n drivers/meson.build | 4 ++--\n drivers/raw/ioat/meson.build | 24 +++++++++++++++++++++---\n 3 files changed, 31 insertions(+), 5 deletions(-)", "diff": "diff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst\nindex a28e909935..a65530bd30 100644\n--- a/doc/guides/rawdevs/ioat.rst\n+++ b/doc/guides/rawdevs/ioat.rst\n@@ -34,6 +34,14 @@ Compilation\n For builds using ``meson`` and ``ninja``, the driver will be built when the target platform is x86-based.\n No additional compilation steps are necessary.\n \n+.. note::\n+ Since the addition of the dmadev library, the ``ioat`` and ``idxd`` parts of this driver\n+ will only be built if their ``dmadev`` counterparts are not built.\n+ The following can be used to disable the ``dmadev`` drivers,\n+ if the raw drivers are to be used instead::\n+\n+ $ meson -Ddisable_drivers=dma/* <build_dir>\n+\n Device Setup\n -------------\n \ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex b7d680868a..34c0276487 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -10,15 +10,15 @@ subdirs = [\n 'common/qat', # depends on bus.\n 'common/sfc_efx', # depends on bus.\n 'mempool', # depends on common and bus.\n+ 'dma', # depends on common and bus.\n 'net', # depends on common, bus, mempool\n- 'raw', # depends on common, bus and net.\n+ 'raw', # depends on common, bus, dma and net.\n 'crypto', # depends on common, bus and mempool (net in future).\n 'compress', # depends on common, bus, mempool.\n 'regex', # depends on common, bus, regexdev.\n 'vdpa', # depends on common, bus and mempool.\n 'event', # depends on common, bus, mempool and net.\n 'baseband', # depends on common and bus.\n- 'dma', # depends on common and bus.\n ]\n \n if meson.is_cross_build()\ndiff --git a/drivers/raw/ioat/meson.build b/drivers/raw/ioat/meson.build\nindex 0e81cb5951..1b866aab74 100644\n--- a/drivers/raw/ioat/meson.build\n+++ b/drivers/raw/ioat/meson.build\n@@ -2,14 +2,32 @@\n # Copyright 2019 Intel Corporation\n \n build = dpdk_conf.has('RTE_ARCH_X86')\n+# only use ioat rawdev driver if we don't have the equivalent dmadev ones\n+if dpdk_conf.has('RTE_DMA_IDXD') and dpdk_conf.has('RTE_DMA_IOAT')\n+ build = false\n+ reason = 'replaced by dmadev drivers'\n+ subdir_done()\n+endif\n+\n reason = 'only supported on x86'\n sources = files(\n- 'idxd_bus.c',\n- 'idxd_pci.c',\n 'ioat_common.c',\n- 'ioat_rawdev.c',\n 'ioat_rawdev_test.c',\n )\n+\n+if not dpdk_conf.has('RTE_DMA_IDXD')\n+ sources += files(\n+ 'idxd_bus.c',\n+ 'idxd_pci.c',\n+ )\n+endif\n+\n+if not dpdk_conf.has('RTE_DMA_IOAT')\n+ sources += files (\n+ 'ioat_rawdev.c',\n+ )\n+endif\n+\n deps += ['bus_pci', 'mbuf', 'rawdev']\n headers = files(\n 'rte_ioat_rawdev.h',\n", "prefixes": [ "v8", "01/16" ] }{ "id": 101989, "url": "