Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101464/?format=api
{ "id": 101464, "url": "http://patches.dpdk.org/api/patches/101464/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211013182720.32486-11-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211013182720.32486-11-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211013182720.32486-11-hemant.agrawal@nxp.com", "date": "2021-10-13T18:27:15", "name": "[v3,10/15] crypto/dpaa2_sec: enhance error checks with raw buffer APIs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fa06fd6eaa5c91064e10e8075caafb1c020bf5ad", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211013182720.32486-11-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 19612, "url": "http://patches.dpdk.org/api/series/19612/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19612", "date": "2021-10-13T18:27:05", "name": "crypto: add raw vector support in DPAAx", "version": 3, "mbox": "http://patches.dpdk.org/series/19612/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/101464/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/101464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 39D80A0C55;\n\tWed, 13 Oct 2021 20:33:03 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D6836411D8;\n\tWed, 13 Oct 2021 20:32:13 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41])\n by mails.dpdk.org (Postfix) with ESMTP id 43AD9411FF\n for <dev@dpdk.org>; Wed, 13 Oct 2021 20:32:12 +0200 (CEST)", "from DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15)\n by DU2PR04MB8805.eurprd04.prod.outlook.com (2603:10a6:10:2e0::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct\n 2021 18:32:11 +0000", "from DU2PR04MB8630.eurprd04.prod.outlook.com\n ([fe80::945d:e362:712d:1b80]) by DU2PR04MB8630.eurprd04.prod.outlook.com\n ([fe80::945d:e362:712d:1b80%3]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021\n 18:32:11 +0000", "from dpdk-xeon.ap.freescale.net (92.120.0.67) by\n SG3P274CA0016.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::28) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 18:32:09 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gfwj1CnoqO4Tmyn5JikJL/xbVhZZGj96y/LpoTbBx8XGB2wJeXZebT6+GKH1HcwOF8q+ARbvACprttLvUM2yGhrzpVIsGrZpBlPr7JnSZe29PqC0Jyk+1Hp0QHadaFsTv3y8g6QsgICfEvcXIzS3AXz59C3I+tyNn+gPMyypnVE+wsXHtowaJk1LRRXmoQLl4+NtahtNzG+3Y950AookMohVlhgqSXjJA78xX03lxwRgN333LqctVs2z8SZjD2HzU66MslLgsrsuTAf94fjZ6DHom/LRQ1VYA7wMRCucPq4pBSv2hwZathEf4ffK5xT3Nm1la6UR+yLWOHh7KcPjpQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=hM1YExVC9ypiO1YsXFiAyDaTqzgZZszZZhcVa+m2EoY=;\n b=Iz7o8/CAt7OTYlxEF6TTeVQmjcjNwr/o4R1TB3SIUK7bZLs/8EO+0x+vs9e0K3qafmyEKAV/tylzCZdVL2rL+eCFLGrRwXIaz6+3XwHZ+sSZs7s8kkxYDve++x/g/VdlxItHMUlebj5/ylALj1vZQi6PJvbRfY3MnN9kmT/KbNWJDPSPw90hiD4MuE5SueMt56TdCCQVeKk899F3pdBzbclkyykcv/WeM5qq9DSnFqpHCMz6HAFlQtS4bvCao57Uktrdet1XyrFStxBej3tikK8j0293MTbyipQGlufpd3ZqU6L0/jF+9DFCt5pQDNO7QKYVIts9vSWP4hn/ydPb0Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=hM1YExVC9ypiO1YsXFiAyDaTqzgZZszZZhcVa+m2EoY=;\n b=GmqP8XvrLtEqj+lpxTY+JLIcOyW6MCliWGkBN70aGIQ1HIDdVz93am30Hz55jT2/T6jS6btG+dsv7pp8oVAPxtbpX0qf/j/CINnNFsMI9LZbgp3LbLYWP1tJjVMquXv/ybDxdHiQMjyyjC4qXuTnjXbAqqcHmERY/UIDvtVqpbc=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=nxp.com;", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\tgakhil@marvell.com", "Cc": "roy.fan.zhang@intel.com, konstantin.ananyev@intel.com,\n Gagandeep Singh <g.singh@nxp.com>", "Date": "Wed, 13 Oct 2021 23:57:15 +0530", "Message-Id": "<20211013182720.32486-11-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211013182720.32486-1-hemant.agrawal@nxp.com>", "References": "<20211013182720.32486-1-hemant.agrawal@nxp.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG3P274CA0016.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::28)\n To DU2PR04MB8630.eurprd04.prod.outlook.com\n (2603:10a6:10:2dd::15)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "611a27a5-1358-487f-4c79-08d98e77c52a", "X-MS-TrafficTypeDiagnostic": "DU2PR04MB8805:", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DU2PR04MB8805063F08F85F47AA6C10EE89B79@DU2PR04MB8805.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1051;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n lsA7GtdZjIahtgFXc0adO92293IQSUqkCxbjcXFqvDb7H1CxBO7+q1MUvDbQTX2pU8ZyXbvOwVyDRlu/6Lq4ulvk9GRXYrIYdwv2zVJjSpgh/5kB7w3hzXVMHpjSc7DthISnsdoF6YohfIR8Xsti6XU+VzfSbqmUGlfh+l6fjX0mVsPVMBTty+z+3/rXN66kD6e9N9AvejI+ITNuCOzOyYnjwK2Rmo1N8NIndldz6KFFONi0QcgsfsKgZtL5bEANAQcoAp3gvy1sXVUpuLXeNmyDeK1Zcd3ZEf/WG2QJ22h/jHc/9zbpNexqleZ521C/JOTuK3libr5VYELwuTgB3yfDrBr0wiUIldran+OSqlBK20rBm2aLWjU/bz7PCQLo9nR5cT+htBE1P5/OVrGfqvljx4j2qh7ygtb/Azm8MGWFNDJjTS9aMTa9ayhlNc6Ur5jAJ2V+CKF9UbM8nPJDP0/sM0wv0maEzRKRxfOJkn9Ugc2yi8UKQg5buAWPIee0EgvAdzsONl5LvF8MjDk4yltZMqDqTAjEw+pPTMTwX03FidLFK8BkIeCZPnMxeUrLs2YqzQGAoaIMzvtgWcoXXyg2uwrGXs/GqjRx9mJvjC2MxVFZ2lMuXm7Ayx1eMOVsk4+qFa2Cms4+JOCUKzlhe72G6j3+8DMhZ6Q5k/Sl/Dxwe+5EPFLYV6PWLi7ilxtKUyeiyb1uO2OFe9BVerim/w==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DU2PR04MB8630.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(6666004)(956004)(186003)(66476007)(26005)(44832011)(66556008)(52116002)(83380400001)(66946007)(8936002)(36756003)(8676002)(2616005)(1076003)(4326008)(508600001)(38100700002)(6486002)(86362001)(6506007)(38350700002)(316002)(2906002)(5660300002)(6512007);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n xVwnIgdIUy48W4IqAt+D1ra9s4wCdZo2xp96Af6xv3dXDRBIkKwLaKbsLLBhWtJ0lqjMsAGw4+CvKatNC1otL9m7O7ZDKXC3SWonZOzNSq/VXI78H4LVFBaNAIdudPPzeALXMrWL8m9LFyelRQKQH9dZtu4iTwxTuH0ANTvYRw9faHxDiCfApGsBgWm04FTTX3rWyYV7qEBseoFoLmrAGJuB5XZpry3Bvbe+/D212NKd9841bo5XLafv2X0szAHrw+s2IsXATcxn2srOjDMND7MU6yJ4UDKEbILYPck7wp4inMITTllI3nfOXuNM4EXkCL24L6e9fY9tKa5eZGrWwfbAa/ZMylmCD4IJ5YJxBuzF7oKLylEXcMO0uY3nB3+sCqmkngTeQmaXFtzY49h5s7TmW2JoLG0dnD9sgPNFrOhsOPdBABV0WN2oBDPsP8NMX8vBYasncTIbjamLQftdwdXi9JdIrW031jhGPxtMj8O3VAg9Jq0R7qDLdzSDc5+YtQ7jy3BhF/ExrhGKKhVWJiGUy3cFGyONDSe7Tv8bLey+wlrVMTiSH0CAnQNZmPkRW6FgzbYXn89WA923pNoCYksu8riwSz7t7qT/GypWqkfBO9ZVipgbWWqZGcLxlwI7DVAdsYIBagWK6jIVJeLR7ODQfyeZh4/VLkH0lu5kuFJ+TLLdsU49jU6xykExlm/r1mgsqZrDI6RbVKhUCiofsqTIdDTYYvWHXFw3MsGWvgAYHI8GghoQeSmAh9in9J8qmOaak0DpL7LGyBpIFS/FzFJKPa64QnPqWEp7THrLPwW40Y8oTJSOzyjf/F8GFW/JpBS9EbOJct3h/UXbQWJ6V+c4UllCH1JuVQQ2VBjb9VPtERE0UtxdVGvc5IuZvgdCbjSm6MDXG9fOdcFoKUWptePRZKWquev01nNmWrSvrHqO1QNKzTSbzS67cZVLbqYbfeS87St35eQTHKxfWW4m1CXUXVDqqhHfRKXHtRwa+dWM0MjaFGiAbkigbl8NHV6NNSvDU3gAmo4WHvRDDom1RRzOLw29emsvN+pi2tlPnh6bFsz+EgJp6HnbRBMMGPnhgv+SyuoMDpd0hYcQIvonkpmNJg4cXf6sK7kGC2MNa6/IqExwQWLo0NaPOHPrBRxmGeYa1DwxaHyGQ1vE/BWilBFGb72vAi526X/umToxOg0+ai3SKazsrriPcc7YOtj06wLyMAYD939mh1NEa498DM3/OCWH4j0Jt0LpWDnyWcVKhSJHYlKesdwg1kSNR0wX14XdSxrDJvD0c9FeEXtCsqOgevZPACLxuwXd8FdtCTf41qZMDU2IaATKhdt9SBuD", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 611a27a5-1358-487f-4c79-08d98e77c52a", "X-MS-Exchange-CrossTenant-AuthSource": "DU2PR04MB8630.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Oct 2021 18:32:11.1733 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n /pcvXiTJ/T9DerVPtJQqkkj1QUuBYr7P5EGmcIF6UtpQ8QqHFzoBrWmFEPTPmmQOf1N7ag183zlg155bfdeVVw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DU2PR04MB8805", "Subject": "[dpdk-dev] [PATCH v3 10/15] crypto/dpaa2_sec: enhance error checks\n with raw buffer APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Gagandeep Singh <g.singh@nxp.com>\n\nThis patch improves error conditions and support of\nWireless algos with raw buffers.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 31 ++++-----------------\n 1 file changed, 6 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c\nindex 4f78cef9c0..a2ffc6c02f 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c\n@@ -355,16 +355,7 @@ build_raw_dp_auth_fd(uint8_t *drv_ctx,\n \tdata_len = total_len - ofs.ofs.auth.head - ofs.ofs.auth.tail;\n \tdata_offset = ofs.ofs.auth.head;\n \n-\tif (sess->auth_alg == RTE_CRYPTO_AUTH_SNOW3G_UIA2 ||\n-\t\tsess->auth_alg == RTE_CRYPTO_AUTH_ZUC_EIA3) {\n-\t\tif ((data_len & 7) || (data_offset & 7)) {\n-\t\t\tDPAA2_SEC_ERR(\"AUTH: len/offset must be full bytes\");\n-\t\t\treturn -ENOTSUP;\n-\t\t}\n-\n-\t\tdata_len = data_len >> 3;\n-\t\tdata_offset = data_offset >> 3;\n-\t}\n+\t/* For SNOW3G and ZUC, lengths in bits only supported */\n \tfle = (struct qbman_fle *)rte_malloc(NULL,\n \t\tFLE_SG_MEM_SIZE(2 * sgl->num),\n \t\t\tRTE_CACHE_LINE_SIZE);\n@@ -609,17 +600,7 @@ build_raw_dp_cipher_fd(uint8_t *drv_ctx,\n \tdata_len = total_len - ofs.ofs.cipher.head - ofs.ofs.cipher.tail;\n \tdata_offset = ofs.ofs.cipher.head;\n \n-\tif (sess->cipher_alg == RTE_CRYPTO_CIPHER_SNOW3G_UEA2 ||\n-\t\tsess->cipher_alg == RTE_CRYPTO_CIPHER_ZUC_EEA3) {\n-\t\tif ((data_len & 7) || (data_offset & 7)) {\n-\t\t\tDPAA2_SEC_ERR(\"CIPHER: len/offset must be full bytes\");\n-\t\t\treturn -ENOTSUP;\n-\t\t}\n-\n-\t\tdata_len = data_len >> 3;\n-\t\tdata_offset = data_offset >> 3;\n-\t}\n-\n+\t/* For SNOW3G and ZUC, lengths in bits only supported */\n \t/* first FLE entry used to store mbuf and session ctxt */\n \tfle = (struct qbman_fle *)rte_malloc(NULL,\n \t\t\tFLE_SG_MEM_SIZE(2*sgl->num),\n@@ -878,7 +859,7 @@ dpaa2_sec_raw_dequeue_burst(void *qp_data, uint8_t *drv_ctx,\n \tstruct qbman_result *dq_storage;\n \tuint32_t fqid = dpaa2_qp->rx_vq.fqid;\n \tint ret, num_rx = 0;\n-\tuint8_t is_last = 0, status;\n+\tuint8_t is_last = 0, status, is_success = 0;\n \tstruct qbman_swp *swp;\n \tconst struct qbman_fd *fd;\n \tstruct qbman_pull_desc pulldesc;\n@@ -957,11 +938,11 @@ dpaa2_sec_raw_dequeue_burst(void *qp_data, uint8_t *drv_ctx,\n \t\t\t/* TODO Parse SEC errors */\n \t\t\tDPAA2_SEC_ERR(\"SEC returned Error - %x\",\n \t\t\t\t fd->simple.frc);\n-\t\t\tstatus = RTE_CRYPTO_OP_STATUS_ERROR;\n+\t\t\tis_success = false;\n \t\t} else {\n-\t\t\tstatus = RTE_CRYPTO_OP_STATUS_SUCCESS;\n+\t\t\tis_success = true;\n \t\t}\n-\t\tpost_dequeue(user_data, num_rx, status);\n+\t\tpost_dequeue(user_data, num_rx, is_success);\n \n \t\tnum_rx++;\n \t\tdq_storage++;\n", "prefixes": [ "v3", "10/15" ] }