Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101290/?format=api
{ "id": 101290, "url": "http://patches.dpdk.org/api/patches/101290/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211013002415.24453-11-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211013002415.24453-11-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20211013002415.24453-11-ivan.malov@oktetlabs.ru", "date": "2021-10-13T00:24:15", "name": "[v3,10/10] net/sfc: refine pattern of GROUP flows in tunnel offload", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0a8b1c86b72ea89ada1c803cc2de8f6570cc7920", "submitter": { "id": 869, "url": "http://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211013002415.24453-11-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 19576, "url": "http://patches.dpdk.org/api/series/19576/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19576", "date": "2021-10-13T00:24:05", "name": "net/sfc: add support for tunnel offload", "version": 3, "mbox": "http://patches.dpdk.org/series/19576/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/101290/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/101290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7F84FA0C4D;\n\tWed, 13 Oct 2021 02:25:25 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D970E41179;\n\tWed, 13 Oct 2021 02:24:40 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 69704410E5\n for <dev@dpdk.org>; Wed, 13 Oct 2021 02:24:31 +0200 (CEST)", "from localhost.localdomain (unknown [5.144.120.72])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2731D7F6FE;\n Wed, 13 Oct 2021 03:24:31 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2731D7F6FE", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1634084671;\n bh=rN/pnUr87S43+518tldY3ITRiVEaX+UjJqZvIUQ0z+Y=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=Z44zHFVDAN0ZCm5PUHT0Qf0hyc5yIOEz6AhZsyQZUMTtUKwV5AO3D+TNEpnADPWUC\n qnsbhGxvi3Szs+zglhKn1uAd/13cA28M3mzYYieUCd0Gy69SKs+wNe+jDIxCvFSGJF\n +9SdiGq65h1XuYzawVzuNFxQAIImhCJkfEBNx7Hg=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Date": "Wed, 13 Oct 2021 03:24:15 +0300", "Message-Id": "<20211013002415.24453-11-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20211013002415.24453-1-ivan.malov@oktetlabs.ru>", "References": "<20210929205730.775-1-ivan.malov@oktetlabs.ru>\n <20211013002415.24453-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 10/10] net/sfc: refine pattern of GROUP flows\n in tunnel offload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "By design, in a GROUP flow, outer match criteria go to \"ENC\" fields\nof the action rule match specification. The current HW/FW hasn't\ngot support for these fields (except the VXLAN VNI) yet.\n\nAs a workaround, start parsing the pattern from the tunnel item.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_mae.c | 37 ++++++++++++++++++++++++++-----------\n drivers/net/sfc/sfc_mae.h | 1 +\n 2 files changed, 27 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex c9139cc800..feda6c19a6 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -2121,14 +2121,21 @@ sfc_mae_rule_parse_item_tunnel(const struct rte_flow_item *item,\n \tconst uint8_t *mask = NULL;\n \tint rc;\n \n-\t/*\n-\t * We're about to start processing inner frame items.\n-\t * Process pattern data that has been deferred so far\n-\t * and reset pattern data storage.\n-\t */\n-\trc = sfc_mae_rule_process_pattern_data(ctx_mae, error);\n-\tif (rc != 0)\n-\t\treturn rc;\n+\tif (ctx_mae->ft_rule_type == SFC_FT_RULE_GROUP) {\n+\t\t/*\n+\t\t * As a workaround, pattern processing has started from\n+\t\t * this (tunnel) item. No pattern data to process yet.\n+\t\t */\n+\t} else {\n+\t\t/*\n+\t\t * We're about to start processing inner frame items.\n+\t\t * Process pattern data that has been deferred so far\n+\t\t * and reset pattern data storage.\n+\t\t */\n+\t\trc = sfc_mae_rule_process_pattern_data(ctx_mae, error);\n+\t\tif (rc != 0)\n+\t\t\treturn rc;\n+\t}\n \n \tmemset(&ctx_mae->pattern_data, 0, sizeof(ctx_mae->pattern_data));\n \n@@ -2447,10 +2454,10 @@ sfc_mae_rule_preparse_item_mark(const struct rte_flow_item_mark *spec,\n \n static int\n sfc_mae_rule_encap_parse_init(struct sfc_adapter *sa,\n-\t\t\t const struct rte_flow_item pattern[],\n \t\t\t struct sfc_mae_parse_ctx *ctx,\n \t\t\t struct rte_flow_error *error)\n {\n+\tconst struct rte_flow_item *pattern = ctx->pattern;\n \tstruct sfc_mae *mae = &sa->mae;\n \tuint8_t recirc_id = 0;\n \tint rc;\n@@ -2525,6 +2532,13 @@ sfc_mae_rule_encap_parse_init(struct sfc_adapter *sa,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n \t\t\t\t\t\t pattern, \"tunnel offload: GROUP: tunnel type mismatch\");\n \t\t}\n+\n+\t\t/*\n+\t\t * The HW/FW hasn't got support for the use of \"ENC\" fields in\n+\t\t * action rules (except the VNET_ID one) yet. As a workaround,\n+\t\t * start parsing the pattern from the tunnel item.\n+\t\t */\n+\t\tctx->pattern = pattern;\n \t\tbreak;\n \tdefault:\n \t\tSFC_ASSERT(B_FALSE);\n@@ -2669,11 +2683,12 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,\n \tctx_mae.encap_type = EFX_TUNNEL_PROTOCOL_NONE;\n \tctx_mae.match_spec = ctx_mae.match_spec_action;\n \tctx_mae.field_ids_remap = field_ids_no_remap;\n+\tctx_mae.pattern = pattern;\n \n \tctx.type = SFC_FLOW_PARSE_CTX_MAE;\n \tctx.mae = &ctx_mae;\n \n-\trc = sfc_mae_rule_encap_parse_init(sa, pattern, &ctx_mae, error);\n+\trc = sfc_mae_rule_encap_parse_init(sa, &ctx_mae, error);\n \tif (rc != 0)\n \t\tgoto fail_encap_parse_init;\n \n@@ -2685,7 +2700,7 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,\n \tspec->ft = ctx_mae.ft;\n \n \trc = sfc_flow_parse_pattern(sa, sfc_flow_items, RTE_DIM(sfc_flow_items),\n-\t\t\t\t pattern, &ctx, error);\n+\t\t\t\t ctx_mae.pattern, &ctx, error);\n \tif (rc != 0)\n \t\tgoto fail_parse_pattern;\n \ndiff --git a/drivers/net/sfc/sfc_mae.h b/drivers/net/sfc/sfc_mae.h\nindex e4aa38be44..6c1a5bfee7 100644\n--- a/drivers/net/sfc/sfc_mae.h\n+++ b/drivers/net/sfc/sfc_mae.h\n@@ -332,6 +332,7 @@ struct sfc_mae_parse_ctx {\n \tenum sfc_flow_tunnel_rule_type\tft_rule_type;\n \tstruct sfc_mae_pattern_data\tpattern_data;\n \tefx_tunnel_protocol_t\t\tencap_type;\n+\tconst struct rte_flow_item\t*pattern;\n \tunsigned int\t\t\tpriority;\n \tstruct sfc_flow_tunnel\t\t*ft;\n };\n", "prefixes": [ "v3", "10/10" ] }