Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101233/?format=api
{ "id": 101233, "url": "http://patches.dpdk.org/api/patches/101233/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211012143942.1133718-3-xuemingl@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211012143942.1133718-3-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211012143942.1133718-3-xuemingl@nvidia.com", "date": "2021-10-12T14:39:39", "name": "[v6,2/5] app/testpmd: new parameter to enable shared Rx queue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dc83c2dd6b45bf424f0b64a0ab7a3932f4cf55d1", "submitter": { "id": 1904, "url": "http://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211012143942.1133718-3-xuemingl@nvidia.com/mbox/", "series": [ { "id": 19562, "url": "http://patches.dpdk.org/api/series/19562/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19562", "date": "2021-10-12T14:39:37", "name": "ethdev: introduce shared Rx queue", "version": 6, "mbox": "http://patches.dpdk.org/series/19562/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/101233/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/101233/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4A3F8A0C47;\n\tTue, 12 Oct 2021 16:40:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9404741198;\n\tTue, 12 Oct 2021 16:40:19 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2056.outbound.protection.outlook.com [40.107.237.56])\n by mails.dpdk.org (Postfix) with ESMTP id 03C0D41193\n for <dev@dpdk.org>; Tue, 12 Oct 2021 16:40:16 +0200 (CEST)", "from MW4PR03CA0222.namprd03.prod.outlook.com (2603:10b6:303:b9::17)\n by CY4PR1201MB0024.namprd12.prod.outlook.com (2603:10b6:910:1b::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Tue, 12 Oct\n 2021 14:40:14 +0000", "from CO1NAM11FT012.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:b9:cafe::ad) by MW4PR03CA0222.outlook.office365.com\n (2603:10b6:303:b9::17) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend\n Transport; Tue, 12 Oct 2021 14:40:14 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT012.mail.protection.outlook.com (10.13.175.192) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 14:40:13 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct\n 2021 14:40:08 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NPloxUf+aN/e95aGOhe9mak52RNMOqIx4M5I0qfnMmB0J9y7nfN7M3Azn/7rh95IOq87eRJ6DfxK1ggxcp93jwusfCoNr8TRycPnIOKxl3kr2Y081HhkPEnwLyddfIu+xKbZuSsiSfs5FrMUUFBQm/hmjlnM0YTksTW44zhCJHYHR0blD1dvazNQ4VQOrPMkQ9IizjezaXnYz+xlZRK75DXEooxe63m8ZzN3TYwS2LBGKu1IX8Qa+uns3IpUm7h7+yvFe1NYHiBTckhy+yrMRfqGWdPNnaqw1EqHG3aYp98tqJ+KoNHjvi/av6NuzvZmeEkdUzEkhaXmekNt9bBirQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=jKMMVrjX7r3awXpBMEg0+cMTrwwDtwfUKqsbM4O+WqA=;\n b=mtHX6obIETcy/azgFreKVBqr2Q3MSAZw4kZnT2nWSt3T2kARFUq7nbxQec1u88dttH0japToFDlLg2SqqsnLI5yshDePYaM3X3meL31+4uv+ys9Veofd4p4HnHj5C5w/pbBZBYe0vtfU8vwZCTYmgzOd2hn4RlSSSxCorz6Zi55hkU2G/3ILtCVm5SnwBq/tPn6I6vp25Ggl2HyH8Qvb2HlAabDLexSgR6IAwrTSEZgQX99kDkucSx2Op/A15OtoEUm54hwhsd5qQ2paLI6oYdO1XXkp0z3tEm22IiH0JzJIW9kiXOVSzkTD2rm3Kxgm1oTjGwFjn4KF/iGqbRCQTQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jKMMVrjX7r3awXpBMEg0+cMTrwwDtwfUKqsbM4O+WqA=;\n b=grNl+1f6E1wdgGDtHe9fjUvHoote0y6UhIjIt5gAmkZjRaU6/2qjVtQ6jeIdF8UNsgbPdwaiVVEc1uFVklqd+ZJkR1wwG43liLkdM6VlY8Thq2ny5nXmGOm+hG9WuMbPsOYrGTKu3jkXmbqcfvgii+hZ738zt8fq0aCyUvLV2xcG0kupX5iHdiq1/4WSa2zUiyJLk2v+7GY3bmyTGLmAsll1LCnBG1QQrVstgjnALXX5FqBVoLlsa1mWdb2QLLBJ9FnddPY7JPZ+0rwtQFCWaFOfu6tloRYtQcZ3qC7pFw5t0sdhQn7HGfJzvtjqII5x+psgZKWBIFEEOyN7Sb7tKQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Xueming Li <xuemingl@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<xuemingl@nvidia.com>, Jerin Jacob <jerinjacobk@gmail.com>, Ferruh Yigit\n <ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Thomas Monjalon\n <thomas@monjalon.net>, Lior Margalit <lmargalit@nvidia.com>, \"Ananyev\n Konstantin\" <konstantin.ananyev@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>", "Date": "Tue, 12 Oct 2021 22:39:39 +0800", "Message-ID": "<20211012143942.1133718-3-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211012143942.1133718-1-xuemingl@nvidia.com>", "References": "<20210727034204.20649-1-xuemingl@nvidia.com>\n <20211012143942.1133718-1-xuemingl@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "9230d37b-3114-43c3-aa29-08d98d8e335c", "X-MS-TrafficTypeDiagnostic": "CY4PR1201MB0024:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <CY4PR1201MB002497281D1085715B789CE3A1B69@CY4PR1201MB0024.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:3968;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n LUlAbOWwJf71Cg+55ftXCMfZNm+VFo1oHMrCR4zlGIyOkhKQq+6NpCE2yHfU7qeePj4WRqe+EwxBHy5nPAqnTvTn2zRC7TrPyKvI+NhuH4gPQ3ZsGIu6wW226BLn3Wc9O39jAVtPtqMDRZGvsdgo6pwQ2o9dEQhSgei/4DREXTI6Xe3jVg+hXEo91u4bCTKPuMExBC/KDwPUYnVu6nc/F8JqZXyzqm8Xq1LXlkOnH6PZAi2ID2r2hWg5fiGAPHP6jY+gf3gRbrUKJMW15zxSK8UY0aeZLWfOM76Vmyj39eCTcDPMaUKPKfGxDQFoRGO5ipLQhFGAk+Jy35Xyy0CiH4xq+9PeL1VEaHU7fPS1UJe6BpcqUUkF5ryN8Hc4e41NJK+kDWnDfaaAP6Lmp1kmZJY5zgedIoZk3b6omTE1p3numOZvcJjAS2A9wK1R6FuJGMvkgNKHU0pzGW/ek3Fqc0Dq02ulgryY9+QMHSt0B1uSo6JY4A+tI8J8wEnq7v78st9TPlARddmuOM/OCUxl5brVKmV4uIF9wxStF+p1Wcocr/+vm0lT6L1zoeWjiq5A03ifcskBkastIGFO9KJKyC5XK4/Q/uryez0J81JJdVXQQ6wIWKD5Mmn1CwnTUqxfOy1XdZc/nCJQWjIVWoAJIzqoABE/frN6z/7hBHjp+enMKBrr2tUHJPNKrKB9YxAbbNoaNEU1LnyK93qhxrZrBA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(508600001)(7636003)(1076003)(82310400003)(5660300002)(8936002)(55016002)(8676002)(83380400001)(6666004)(7696005)(54906003)(47076005)(336012)(86362001)(4326008)(6916009)(356005)(16526019)(2616005)(426003)(316002)(26005)(70206006)(6286002)(70586007)(36860700001)(36756003)(186003)(2906002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Oct 2021 14:40:13.5069 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9230d37b-3114-43c3-aa29-08d98d8e335c", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT012.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR1201MB0024", "Subject": "[dpdk-dev] [PATCH v6 2/5] app/testpmd: new parameter to enable\n shared Rx queue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adds \"--rxq-share=X\" parameter to enable shared RxQ, share if device\nsupports, otherwise fallback to standard RxQ.\n\nShare group number grows per X ports. X defaults to MAX, implies all\nports join share group 1.\n\nForwarding engine \"shared-rxq\" should be used which Rx only and update\nstream statistics correctly.\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n app/test-pmd/config.c | 6 +++++-\n app/test-pmd/parameters.c | 13 +++++++++++++\n app/test-pmd/testpmd.c | 12 ++++++++++++\n app/test-pmd/testpmd.h | 2 ++\n doc/guides/testpmd_app_ug/run_app.rst | 7 +++++++\n 5 files changed, 39 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 9c66329e96e..96fc2ab888b 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2709,7 +2709,11 @@ rxtx_config_display(void)\n \t\t\tprintf(\" RX threshold registers: pthresh=%d hthresh=%d \"\n \t\t\t\t\" wthresh=%d\\n\",\n \t\t\t\tpthresh_tmp, hthresh_tmp, wthresh_tmp);\n-\t\t\tprintf(\" RX Offloads=0x%\"PRIx64\"\\n\", offloads_tmp);\n+\t\t\tprintf(\" RX Offloads=0x%\"PRIx64, offloads_tmp);\n+\t\t\tif (rx_conf->share_group > 0)\n+\t\t\t\tprintf(\" share group=%u\",\n+\t\t\t\t rx_conf->share_group);\n+\t\t\tprintf(\"\\n\");\n \t\t}\n \n \t\t/* per tx queue config only for first queue to be less verbose */\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 3f94a82e321..30dae326310 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -167,6 +167,7 @@ usage(char* progname)\n \tprintf(\" --tx-ip=src,dst: IP addresses in Tx-only mode\\n\");\n \tprintf(\" --tx-udp=src[,dst]: UDP ports in Tx-only mode\\n\");\n \tprintf(\" --eth-link-speed: force link speed.\\n\");\n+\tprintf(\" --rxq-share: number of ports per shared rxq groups, defaults to MAX(1 group)\\n\");\n \tprintf(\" --disable-link-check: disable check on link status when \"\n \t \"starting/stopping ports.\\n\");\n \tprintf(\" --disable-device-start: do not automatically start port\\n\");\n@@ -607,6 +608,7 @@ launch_args_parse(int argc, char** argv)\n \t\t{ \"rxpkts\",\t\t\t1, 0, 0 },\n \t\t{ \"txpkts\",\t\t\t1, 0, 0 },\n \t\t{ \"txonly-multi-flow\",\t\t0, 0, 0 },\n+\t\t{ \"rxq-share\",\t\t\t2, 0, 0 },\n \t\t{ \"eth-link-speed\",\t\t1, 0, 0 },\n \t\t{ \"disable-link-check\",\t\t0, 0, 0 },\n \t\t{ \"disable-device-start\",\t0, 0, 0 },\n@@ -1271,6 +1273,17 @@ launch_args_parse(int argc, char** argv)\n \t\t\t}\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"txonly-multi-flow\"))\n \t\t\t\ttxonly_multi_flow = 1;\n+\t\t\tif (!strcmp(lgopts[opt_idx].name, \"rxq-share\")) {\n+\t\t\t\tif (optarg == NULL) {\n+\t\t\t\t\trxq_share = UINT32_MAX;\n+\t\t\t\t} else {\n+\t\t\t\t\tn = atoi(optarg);\n+\t\t\t\t\tif (n >= 0)\n+\t\t\t\t\t\trxq_share = (uint32_t)n;\n+\t\t\t\t\telse\n+\t\t\t\t\t\trte_exit(EXIT_FAILURE, \"rxq-share must be >= 0\\n\");\n+\t\t\t\t}\n+\t\t\t}\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"no-flush-rx\"))\n \t\t\t\tno_flush_rx = 1;\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"eth-link-speed\")) {\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 97ae52e17ec..9c26301d397 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -498,6 +498,11 @@ uint8_t record_core_cycles;\n */\n uint8_t record_burst_stats;\n \n+/*\n+ * Number of ports per shared Rx queue group, 0 disable.\n+ */\n+uint32_t rxq_share;\n+\n unsigned int num_sockets = 0;\n unsigned int socket_ids[RTE_MAX_NUMA_NODES];\n \n@@ -3401,6 +3406,13 @@ rxtx_port_config(struct rte_port *port)\n \tfor (qid = 0; qid < nb_rxq; qid++) {\n \t\toffloads = port->rx_conf[qid].offloads;\n \t\tport->rx_conf[qid] = port->dev_info.default_rxconf;\n+\n+\t\tif (rxq_share > 0 &&\n+\t\t (port->dev_info.dev_capa & RTE_ETH_DEV_CAPA_RXQ_SHARE))\n+\t\t\t/* Non-zero share group to enable RxQ share. */\n+\t\t\tport->rx_conf[qid].share_group = nb_ports / rxq_share\n+\t\t\t\t\t\t\t + 1;\n+\n \t\tif (offloads != 0)\n \t\t\tport->rx_conf[qid].offloads = offloads;\n \ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 5863b2f43f3..3dfaaad94c0 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -477,6 +477,8 @@ extern enum tx_pkt_split tx_pkt_split;\n \n extern uint8_t txonly_multi_flow;\n \n+extern uint32_t rxq_share;\n+\n extern uint16_t nb_pkt_per_burst;\n extern uint16_t nb_pkt_flowgen_clones;\n extern int nb_flows_flowgen;\ndiff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst\nindex 640eadeff73..ff5908dcd50 100644\n--- a/doc/guides/testpmd_app_ug/run_app.rst\n+++ b/doc/guides/testpmd_app_ug/run_app.rst\n@@ -389,6 +389,13 @@ The command line options are:\n \n Generate multiple flows in txonly mode.\n \n+* ``--rxq-share=[X]``\n+\n+ Create queues in shared Rx queue mode if device supports.\n+ Group number grows per X ports. X defaults to MAX, implies all ports\n+ join share group 1. Forwarding engine \"shared-rxq\" should be used\n+ which Rx only and update stream statistics correctly.\n+\n * ``--eth-link-speed``\n \n Set a forced link speed to the ethernet port::\n", "prefixes": [ "v6", "2/5" ] }