Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/101017/?format=api
{ "id": 101017, "url": "http://patches.dpdk.org/api/patches/101017/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211011112945.2876-9-radu.nicolau@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211011112945.2876-9-radu.nicolau@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211011112945.2876-9-radu.nicolau@intel.com", "date": "2021-10-11T11:29:43", "name": "[v8,08/10] ipsec: add support for initial SQN value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aadc6dc25f26f0e1d438b0c9b43ff56a0c5d3a3c", "submitter": { "id": 743, "url": "http://patches.dpdk.org/api/people/743/?format=api", "name": "Radu Nicolau", "email": "radu.nicolau@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211011112945.2876-9-radu.nicolau@intel.com/mbox/", "series": [ { "id": 19516, "url": "http://patches.dpdk.org/api/series/19516/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19516", "date": "2021-10-11T11:29:35", "name": "new features for ipsec and security libraries", "version": 8, "mbox": "http://patches.dpdk.org/series/19516/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/101017/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/101017/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7196A034F;\n\tMon, 11 Oct 2021 13:42:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 567464113A;\n\tMon, 11 Oct 2021 13:42:03 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 67F714111F\n for <dev@dpdk.org>; Mon, 11 Oct 2021 13:41:59 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Oct 2021 04:41:50 -0700", "from silpixa00400884.ir.intel.com ([10.243.22.82])\n by orsmga007.jf.intel.com with ESMTP; 11 Oct 2021 04:41:46 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10133\"; a=\"207660549\"", "E=Sophos;i=\"5.85,364,1624345200\"; d=\"scan'208\";a=\"207660549\"", "E=Sophos;i=\"5.85,364,1624345200\"; d=\"scan'208\";a=\"479822062\"" ], "X-ExtLoop1": "1", "From": "Radu Nicolau <radu.nicolau@intel.com>", "To": "Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Cc": "dev@dpdk.org, mdr@ashroe.eu, bruce.richardson@intel.com,\n roy.fan.zhang@intel.com, hemant.agrawal@nxp.com, gakhil@marvell.com,\n anoobj@marvell.com, declan.doherty@intel.com, abhijit.sinha@intel.com,\n daniel.m.buckley@intel.com, marchana@marvell.com, ktejasree@marvell.com,\n matan@nvidia.com, Radu Nicolau <radu.nicolau@intel.com>", "Date": "Mon, 11 Oct 2021 12:29:43 +0100", "Message-Id": "<20211011112945.2876-9-radu.nicolau@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211011112945.2876-1-radu.nicolau@intel.com>", "References": "<20210713133542.3550525-1-radu.nicolau@intel.com>\n <20211011112945.2876-1-radu.nicolau@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 08/10] ipsec: add support for initial SQN value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update IPsec library to support initial SQN value.\n\nSigned-off-by: Declan Doherty <declan.doherty@intel.com>\nSigned-off-by: Radu Nicolau <radu.nicolau@intel.com>\nSigned-off-by: Abhijit Sinha <abhijit.sinha@intel.com>\nSigned-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>\nAcked-by: Fan Zhang <roy.fan.zhang@intel.com>\n---\n doc/guides/rel_notes/release_21_11.rst | 1 +\n lib/ipsec/sa.c | 25 ++++++++++++++++++-------\n 2 files changed, 19 insertions(+), 7 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst\nindex f0bc4438a4..0686679677 100644\n--- a/doc/guides/rel_notes/release_21_11.rst\n+++ b/doc/guides/rel_notes/release_21_11.rst\n@@ -140,6 +140,7 @@ New Features\n * Added support for NAT-T / UDP encapsulated ESP\n * Added support TSO offload support; only supported for inline crypto mode.\n * Added support for SA telemetry.\n+ * Added support for setting a non default starting ESN value.\n \n \n Removed Items\ndiff --git a/lib/ipsec/sa.c b/lib/ipsec/sa.c\nindex 44dcc524ee..85e06069de 100644\n--- a/lib/ipsec/sa.c\n+++ b/lib/ipsec/sa.c\n@@ -294,11 +294,11 @@ esp_inb_tun_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm)\n * Init ESP outbound specific things.\n */\n static void\n-esp_outb_init(struct rte_ipsec_sa *sa, uint32_t hlen)\n+esp_outb_init(struct rte_ipsec_sa *sa, uint32_t hlen, uint64_t sqn)\n {\n \tuint8_t algo_type;\n \n-\tsa->sqn.outb = 1;\n+\tsa->sqn.outb = sqn > 1 ? sqn : 1;\n \n \talgo_type = sa->algo_type;\n \n@@ -376,7 +376,7 @@ esp_outb_tun_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm)\n \tsa->tx_offload.val = rte_mbuf_tx_offload(sa->hdr_l3_off,\n \t\tsa->hdr_len - sa->hdr_l3_off, 0, 0, 0, 0, 0);\n \n-\tesp_outb_init(sa, sa->hdr_len);\n+\tesp_outb_init(sa, sa->hdr_len, prm->ipsec_xform.esn.value);\n }\n \n /*\n@@ -502,7 +502,7 @@ esp_sa_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm,\n \tcase (RTE_IPSEC_SATP_DIR_OB | RTE_IPSEC_SATP_MODE_TRANS |\n \t\t\tRTE_IPSEC_SATP_NATT_ENABLE):\n \tcase (RTE_IPSEC_SATP_DIR_OB | RTE_IPSEC_SATP_MODE_TRANS):\n-\t\tesp_outb_init(sa, 0);\n+\t\tesp_outb_init(sa, 0, prm->ipsec_xform.esn.value);\n \t\tbreak;\n \t}\n \n@@ -513,15 +513,19 @@ esp_sa_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm,\n * helper function, init SA replay structure.\n */\n static void\n-fill_sa_replay(struct rte_ipsec_sa *sa, uint32_t wnd_sz, uint32_t nb_bucket)\n+fill_sa_replay(struct rte_ipsec_sa *sa, uint32_t wnd_sz, uint32_t nb_bucket,\n+\tuint64_t sqn)\n {\n \tsa->replay.win_sz = wnd_sz;\n \tsa->replay.nb_bucket = nb_bucket;\n \tsa->replay.bucket_index_mask = nb_bucket - 1;\n \tsa->sqn.inb.rsn[0] = (struct replay_sqn *)(sa + 1);\n-\tif ((sa->type & RTE_IPSEC_SATP_SQN_MASK) == RTE_IPSEC_SATP_SQN_ATOM)\n+\tsa->sqn.inb.rsn[0]->sqn = sqn;\n+\tif ((sa->type & RTE_IPSEC_SATP_SQN_MASK) == RTE_IPSEC_SATP_SQN_ATOM) {\n \t\tsa->sqn.inb.rsn[1] = (struct replay_sqn *)\n \t\t\t((uintptr_t)sa->sqn.inb.rsn[0] + rsn_size(nb_bucket));\n+\t\tsa->sqn.inb.rsn[1]->sqn = sqn;\n+\t}\n }\n \n int\n@@ -591,13 +595,20 @@ rte_ipsec_sa_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm,\n \tsa->sqn_mask = (prm->ipsec_xform.options.esn == 0) ?\n \t\tUINT32_MAX : UINT64_MAX;\n \n+\t/* if we are starting from a non-zero sn value */\n+\tif (prm->ipsec_xform.esn.value > 0) {\n+\t\tif (prm->ipsec_xform.direction ==\n+\t\t\t\tRTE_SECURITY_IPSEC_SA_DIR_EGRESS)\n+\t\t\tsa->sqn.outb = prm->ipsec_xform.esn.value;\n+\t}\n+\n \trc = esp_sa_init(sa, prm, &cxf);\n \tif (rc != 0)\n \t\trte_ipsec_sa_fini(sa);\n \n \t/* fill replay window related fields */\n \tif (nb != 0)\n-\t\tfill_sa_replay(sa, wsz, nb);\n+\t\tfill_sa_replay(sa, wsz, nb, prm->ipsec_xform.esn.value);\n \n \treturn sz;\n }\n", "prefixes": [ "v8", "08/10" ] }