Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100901/?format=api
http://patches.dpdk.org/api/patches/100901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1633765318-28356-6-git-send-email-navasile@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1633765318-28356-6-git-send-email-navasile@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1633765318-28356-6-git-send-email-navasile@linux.microsoft.com", "date": "2021-10-09T07:41:54", "name": "[v16,5/9] eal: implement thread priority management functions", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "602444b3564ad6865cd5411ff07e0a685906f12d", "submitter": { "id": 1668, "url": "http://patches.dpdk.org/api/people/1668/?format=api", "name": "Narcisa Ana Maria Vasile", "email": "navasile@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1633765318-28356-6-git-send-email-navasile@linux.microsoft.com/mbox/", "series": [ { "id": 19478, "url": "http://patches.dpdk.org/api/series/19478/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19478", "date": "2021-10-09T07:41:49", "name": "eal: Add EAL API for threading", "version": 16, "mbox": "http://patches.dpdk.org/series/19478/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/100901/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/100901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2525BA0C41;\n\tSat, 9 Oct 2021 09:42:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2C9654111A;\n\tSat, 9 Oct 2021 09:42:14 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 6616140040\n for <dev@dpdk.org>; Sat, 9 Oct 2021 09:42:07 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1059)\n id 07BD120B87E7; Sat, 9 Oct 2021 00:42:05 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 07BD120B87E7", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1633765326;\n bh=PRtzbBQJJ/eyJBuDkFJkkdiHME3PoH8kkAS3FO7nF5g=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=q4IRskAlF/G5IS08xcNybARZILZKeACwuB1y0ctClEeBErBPWcBTRL9GILDjYN0Id\n nKAX4us5vn6ESUIsi9VSPILH04T8lwPqXV2Jsry1XCqGFUDfRM3Pns7C0mxJnFRTHZ\n sz2YPVofQjSiJFVrw5/NBNVFcZIXLR3oDPxVwii8=", "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>", "To": "dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,\n khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com,\n roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n pallavi.kadam@intel.com", "Date": "Sat, 9 Oct 2021 00:41:54 -0700", "Message-Id": "<1633765318-28356-6-git-send-email-navasile@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1633765318-28356-1-git-send-email-navasile@linux.microsoft.com>", "References": "<1633732841-17873-1-git-send-email-navasile@linux.microsoft.com>\n <1633765318-28356-1-git-send-email-navasile@linux.microsoft.com>", "Subject": "[dpdk-dev] [PATCH v16 5/9] eal: implement thread priority\n management functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Narcisa Vasile <navasile@microsoft.com>\n\nAdd functions for setting and getting the priority of a thread.\nPriorities on multiple platforms are similarly determined by\na priority value and a priority class/policy.\n\nOn Linux, the following mapping is created:\nRTE_THREAD_PRIORITY_NORMAL corresponds to\n* policy SCHED_OTHER\n* priority value: (sched_get_priority_min(SCHED_OTHER) +\n sched_get_priority_max(SCHED_OTHER))/2;\nRTE_THREAD_PRIORITY_REALTIME_CRITICAL corresponds to\n* policy SCHED_RR\n* priority value: sched_get_priority_max(SCHED_RR);\n\nOn Windows, the following mapping is created:\nRTE_THREAD_PRIORITY_NORMAL corresponds to\n* class NORMAL_PRIORITY_CLASS\n* priority THREAD_PRIORITY_NORMAL\nRTE_THREAD_PRIORITY_REALTIME_CRITICAL corresponds to\n* class REALTIME_PRIORITY_CLASS\n* priority THREAD_PRIORITY_TIME_CRITICAL\n\nSigned-off-by: Narcisa Vasile <navasile@microsoft.com>\n---\n lib/eal/common/rte_thread.c | 97 ++++++++++++++++++++++++++\n lib/eal/include/rte_thread.h | 34 ++++++++++\n lib/eal/version.map | 2 +\n lib/eal/windows/rte_thread.c | 127 +++++++++++++++++++++++++++++++++++\n 4 files changed, 260 insertions(+)", "diff": "diff --git a/lib/eal/common/rte_thread.c b/lib/eal/common/rte_thread.c\nindex 73b7b3141c..7ab08561a5 100644\n--- a/lib/eal/common/rte_thread.c\n+++ b/lib/eal/common/rte_thread.c\n@@ -50,6 +50,103 @@ rte_thread_get_affinity_by_id(rte_thread_t thread_id,\n \t\tsizeof(*cpuset), cpuset);\n }\n \n+static int\n+thread_map_priority_to_os_value(enum rte_thread_priority eal_pri,\n+\t\tint *os_pri, int *pol)\n+{\n+\t/* Clear the output parameters */\n+\t*os_pri = sched_get_priority_min(SCHED_OTHER) - 1;\n+\t*pol = -1;\n+\n+\tswitch (eal_pri) {\n+\tcase RTE_THREAD_PRIORITY_NORMAL:\n+\t\t*pol = SCHED_OTHER;\n+\n+\t\t/*\n+\t\t * Choose the middle of the range to represent\n+\t\t * the priority 'normal'.\n+\t\t * On Linux, this should be 0, since both\n+\t\t * sched_get_priority_min/_max return 0 for SCHED_OTHER.\n+\t\t */\n+\t\t*os_pri = (sched_get_priority_min(SCHED_OTHER) +\n+\t\t\tsched_get_priority_max(SCHED_OTHER))/2;\n+\t\tbreak;\n+\tcase RTE_THREAD_PRIORITY_REALTIME_CRITICAL:\n+\t\t*pol = SCHED_RR;\n+\t\t*os_pri = sched_get_priority_max(SCHED_RR);\n+\t\tbreak;\n+\tdefault:\n+\t\tRTE_LOG(DEBUG, EAL, \"The requested priority value is invalid.\\n\");\n+\t\treturn EINVAL;\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n+thread_map_os_priority_to_eal_priority(int policy, int os_pri,\n+\t\tenum rte_thread_priority *eal_pri)\n+{\n+\tswitch (policy) {\n+\tcase SCHED_OTHER:\n+\t\tif (os_pri == (sched_get_priority_min(SCHED_OTHER) +\n+\t\t\t\tsched_get_priority_max(SCHED_OTHER))/2) {\n+\t\t\t*eal_pri = RTE_THREAD_PRIORITY_NORMAL;\n+\t\t\treturn 0;\n+\t\t}\n+\t\tbreak;\n+\tcase SCHED_RR:\n+\t\tif (os_pri == sched_get_priority_max(SCHED_RR)) {\n+\t\t\t*eal_pri = RTE_THREAD_PRIORITY_REALTIME_CRITICAL;\n+\t\t\treturn 0;\n+\t\t}\n+\t\tbreak;\n+\tdefault:\n+\t\tRTE_LOG(DEBUG, EAL, \"The OS priority value does not map to an EAL-defined priority.\\n\");\n+\t\treturn EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+int\n+rte_thread_get_priority(rte_thread_t thread_id,\n+\t\tenum rte_thread_priority *priority)\n+{\n+\tint ret;\n+\tint policy;\n+\tstruct sched_param param;\n+\n+\tret = pthread_getschedparam((pthread_t)thread_id.opaque_id, &policy,\n+\t\t\t¶m);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(DEBUG, EAL, \"pthread_getschedparam failed\\n\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\treturn thread_map_os_priority_to_eal_priority(policy,\n+\t\t\tparam.sched_priority, priority);\n+\n+cleanup:\n+\treturn ret;\n+}\n+\n+int\n+rte_thread_set_priority(rte_thread_t thread_id,\n+\t\tenum rte_thread_priority priority)\n+{\n+\tint ret;\n+\tint policy;\n+\tstruct sched_param param;\n+\n+\tret = thread_map_priority_to_os_value(priority, ¶m.sched_priority,\n+\t\t&policy);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\treturn pthread_setschedparam((pthread_t)thread_id.opaque_id,\n+\t\tpolicy, ¶m);\n+}\n+\n int\n rte_thread_attr_init(rte_thread_attr_t *attr)\n {\ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 5b100cafda..7077c9ce46 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -213,6 +213,40 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp);\n \n #endif /* RTE_HAS_CPUSET */\n \n+/**\n+ * Get the priority of a thread.\n+ *\n+ * @param thread_id\n+ * Id of the thread for which to get priority.\n+ *\n+ * @param priority\n+ * Location to store the retrieved priority.\n+ *\n+ * @return\n+ * On success, return 0.\n+ * On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_get_priority(rte_thread_t thread_id,\n+\t\tenum rte_thread_priority *priority);\n+\n+/**\n+ * Set the priority of a thread.\n+ *\n+ * @param thread_id\n+ * Id of the thread for which to set priority.\n+ *\n+ * @param priority\n+ * Priority value to be set.\n+ *\n+ * @return\n+ * On success, return 0.\n+ * On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_set_priority(rte_thread_t thread_id,\n+\t\tenum rte_thread_priority priority);\n+\n /**\n * Create a TLS data key visible to all threads in the process.\n * the created key is later used to get/set a value.\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 58b9553d59..dcc2c479e9 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -429,6 +429,8 @@ EXPERIMENTAL {\n \trte_thread_attr_set_priority;\n \trte_thread_get_affinity_by_id;\n \trte_thread_set_affinity_by_id;\n+\trte_thread_get_priority;\n+\trte_thread_set_priority;\n };\n \n INTERNAL {\ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex 0127119f49..5c02a6eaff 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -200,6 +200,133 @@ rte_thread_get_affinity_by_id(rte_thread_t thread_id,\n \treturn ret;\n }\n \n+static int\n+thread_map_priority_to_os_value(enum rte_thread_priority eal_pri,\n+\t\tint *os_pri, int *pri_class)\n+{\n+\t/* Clear the output parameters */\n+\t*os_pri = -1;\n+\t*pri_class = -1;\n+\n+\tswitch (eal_pri) {\n+\tcase RTE_THREAD_PRIORITY_NORMAL:\n+\t\t*pri_class = NORMAL_PRIORITY_CLASS;\n+\t\t*os_pri = THREAD_PRIORITY_NORMAL;\n+\t\tbreak;\n+\tcase RTE_THREAD_PRIORITY_REALTIME_CRITICAL:\n+\t\t*pri_class = REALTIME_PRIORITY_CLASS;\n+\t\t*os_pri = THREAD_PRIORITY_TIME_CRITICAL;\n+\t\tbreak;\n+\tdefault:\n+\t\tRTE_LOG(DEBUG, EAL, \"The requested priority value is invalid.\\n\");\n+\t\treturn EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+thread_map_os_priority_to_eal_value(int os_pri, int pri_class,\n+\t\tenum rte_thread_priority *eal_pri)\n+{\n+\tswitch (pri_class) {\n+\tcase NORMAL_PRIORITY_CLASS:\n+\t\tif (os_pri == THREAD_PRIORITY_NORMAL) {\n+\t\t\t*eal_pri = RTE_THREAD_PRIORITY_NORMAL;\n+\t\t\treturn 0;\n+\t\t}\n+\t\tbreak;\n+\tcase REALTIME_PRIORITY_CLASS:\n+\t\tif (os_pri == THREAD_PRIORITY_TIME_CRITICAL) {\n+\t\t\t*eal_pri = RTE_THREAD_PRIORITY_REALTIME_CRITICAL;\n+\t\t\treturn 0;\n+\t\t}\n+\t\tbreak;\n+\tdefault:\n+\t\tRTE_LOG(DEBUG, EAL, \"The OS priority value does not map to an EAL-defined priority.\\n\");\n+\t\treturn EINVAL;\n+\t}\n+\treturn 0;\n+}\n+\n+int\n+rte_thread_get_priority(rte_thread_t thread_id,\n+\t\tenum rte_thread_priority *priority)\n+{\n+\tHANDLE thread_handle = NULL;\n+\tDWORD pri_class;\n+\tint os_pri;\n+\tint ret;\n+\n+\tpri_class = GetPriorityClass(GetCurrentProcess());\n+\tif (pri_class == 0) {\n+\t\tret = thread_log_last_error(\"GetPriorityClass()\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tthread_handle = OpenThread(THREAD_SET_INFORMATION |\n+\t\t\tTHREAD_QUERY_INFORMATION, FALSE, thread_id.opaque_id);\n+\tif (thread_handle == NULL) {\n+\t\tret = thread_log_last_error(\"OpenThread()\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tos_pri = GetThreadPriority(thread_handle);\n+\tif (os_pri == THREAD_PRIORITY_ERROR_RETURN) {\n+\t\tret = thread_log_last_error(\"GetThreadPriority()\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tret = thread_map_os_priority_to_eal_value(os_pri, pri_class, priority);\n+\tif (ret != 0)\n+\t\tgoto cleanup;\n+\n+cleanup:\n+\tif (thread_handle != NULL)\n+\t\tCloseHandle(thread_handle);\n+\n+\treturn ret;\n+}\n+\n+int\n+rte_thread_set_priority(rte_thread_t thread_id,\n+\t\t\tenum rte_thread_priority priority)\n+{\n+\tHANDLE thread_handle;\n+\tint priority_class;\n+\tint os_priority;\n+\tint ret = 0;\n+\n+\tthread_handle = OpenThread(THREAD_SET_INFORMATION |\n+\t\tTHREAD_QUERY_INFORMATION, FALSE,\n+\t\tthread_id.opaque_id);\n+\tif (thread_handle == NULL) {\n+\t\tret = thread_log_last_error(\"OpenThread()\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tret = thread_map_priority_to_os_value(priority, &os_priority,\n+\t\t&priority_class);\n+\tif (ret != 0)\n+\t\tgoto cleanup;\n+\n+\tif (!SetPriorityClass(GetCurrentProcess(), priority_class)) {\n+\t\tret = thread_log_last_error(\"SetPriorityClass()\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tif (!SetThreadPriority(thread_handle, os_priority)) {\n+\t\tret = thread_log_last_error(\"SetThreadPriority()\");\n+\t\tgoto cleanup;\n+\t}\n+\n+cleanup:\n+\tif (thread_handle != NULL)\n+\t\tCloseHandle(thread_handle);\n+\n+\treturn ret;\n+}\n+\n int\n rte_thread_attr_init(rte_thread_attr_t *attr)\n {\n", "prefixes": [ "v16", "5/9" ] }{ "id": 100901, "url": "