Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100540/?format=api
{ "id": 100540, "url": "http://patches.dpdk.org/api/patches/100540/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211005171939.2989-1-xhavli56@stud.fit.vutbr.cz/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211005171939.2989-1-xhavli56@stud.fit.vutbr.cz>", "list_archive_url": "https://inbox.dpdk.org/dev/20211005171939.2989-1-xhavli56@stud.fit.vutbr.cz", "date": "2021-10-05T17:19:39", "name": "[2/2] net/bonding: ensure device is started for dedicated queues setup", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6b4f0e5db7016a8bbd03d8031aff3dab6bbd6129", "submitter": { "id": 2265, "url": "http://patches.dpdk.org/api/people/2265/?format=api", "name": "Havlík Martin", "email": "xhavli56@stud.fit.vutbr.cz" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211005171939.2989-1-xhavli56@stud.fit.vutbr.cz/mbox/", "series": [ { "id": 19398, "url": "http://patches.dpdk.org/api/series/19398/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19398", "date": "2021-10-05T17:16:11", "name": "net/bonding: fix dedicated queues flow rule issue", "version": 1, "mbox": "http://patches.dpdk.org/series/19398/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/100540/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/100540/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3FB81A0C4C;\n\tTue, 5 Oct 2021 19:20:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2E1AA41401;\n\tTue, 5 Oct 2021 19:20:02 +0200 (CEST)", "from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])\n by mails.dpdk.org (Postfix) with ESMTP id 7CA1C413FB\n for <dev@dpdk.org>; Tue, 5 Oct 2021 19:20:00 +0200 (CEST)", "from dpdk-test7.liberouter.org (rt-tmc-kou.liberouter.org\n [195.113.172.126]) (authenticated bits=0)\n by eva.fit.vutbr.cz (8.16.1/8.16.1) with ESMTPSA id 195HJiOc050691\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);\n Tue, 5 Oct 2021 19:19:48 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=stud.fit.vutbr.cz;\n s=studfit; t=1633454388;\n bh=7fwWFed/S8rQ85Ez6ZgalhP5mu+2w46NtssSg9pYo7c=;\n h=From:To:Cc:Subject:Date;\n b=HcTpS5dW0n0g9zy6feYhUFZLM8cDXvsFxT43ggQ1lnLtqxly5IiGuccjGxOrpSDp2\n fN3pT7S0sRRU6swkzIKzA5vW5wZQLqBwgTm/lXWuoN8znTo9Iue17x+jz4qIBgpA9q\n n5u7/hrYHnBUr34evse/ag2m7gHYyQaLhpZhxAOM=", "From": "Martin Havlik <xhavli56@stud.fit.vutbr.cz>", "To": "xhavli56@stud.fit.vutbr.cz, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>,\n Aman Deep Singh <aman.deep.singh@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Kiran KN <kirankn@juniper.net>, RongQing Li <lirongqing@baidu.com>", "Cc": "Jan Viktorin <viktorin@cesnet.cz>, dev@dpdk.org, haiyue.wang@intel.com", "Date": "Tue, 5 Oct 2021 19:19:39 +0200", "Message-Id": "<20211005171939.2989-1-xhavli56@stud.fit.vutbr.cz>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/bonding: ensure device is started for\n dedicated queues setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flow rule governing dedicated queues is now created\nwhen the slave allows it. That is before or after the start\nof the slave device, as the PMD is able to.\n\nSigned-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 25 +++++++++++++++++++------\n 1 file changed, 19 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 8ed9e036f4..66b38610f8 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1685,6 +1685,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \n \tint errval;\n \tuint16_t q_id;\n+\tbool device_started = false;\n \tstruct rte_flow_error flow_error;\n \n \tstruct bond_dev_private *internals = bonded_eth_dev->data->dev_private;\n@@ -1815,6 +1816,16 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \t\t\t\t\tinternals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id],\n \t\t\t\t\t&flow_error);\n \n+\t\tif (slave_eth_dev->dev_capa & RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START == 0) {\n+\t\t\terrval = rte_eth_dev_start(slave_eth_dev->data->port_id);\n+\t\t\tif (errval != 0) {\n+\t\t\t\tRTE_BOND_LOG(ERR, \"rte_eth_dev_start: port=%u, err (%d)\",\n+\t\t\t\t\t\tslave_eth_dev->data->port_id, errval);\n+\t\t\t\treturn errval;\n+\t\t\t}\n+\t\t}\n+\t\tdevice_started = true;\n+\n \t\terrval = bond_ethdev_8023ad_flow_set(bonded_eth_dev,\n \t\t\t\tslave_eth_dev->data->port_id);\n \t\tif (errval != 0) {\n@@ -1825,12 +1836,14 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \t\t}\n \t}\n \n-\t/* Start device */\n-\terrval = rte_eth_dev_start(slave_eth_dev->data->port_id);\n-\tif (errval != 0) {\n-\t\tRTE_BOND_LOG(ERR, \"rte_eth_dev_start: port=%u, err (%d)\",\n-\t\t\t\tslave_eth_dev->data->port_id, errval);\n-\t\treturn -1;\n+\tif (!device_started) {\n+\t\t/* Start device */\n+\t\terrval = rte_eth_dev_start(slave_eth_dev->data->port_id);\n+\t\tif (errval != 0) {\n+\t\t\tRTE_BOND_LOG(ERR, \"rte_eth_dev_start: port=%u, err (%d)\",\n+\t\t\t\t\tslave_eth_dev->data->port_id, errval);\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \n \t/* If RSS is enabled for bonding, synchronize RETA */\n", "prefixes": [ "2/2" ] }