Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100427/?format=api
http://patches.dpdk.org/api/patches/100427/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211004101058.2396458-6-sean.morrissey@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211004101058.2396458-6-sean.morrissey@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211004101058.2396458-6-sean.morrissey@intel.com", "date": "2021-10-04T10:10:58", "name": "[v1,5/5] lib/eal: remove unneeded header includes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ef44d281fa520c51a2230cdb6a1124a5d09a2e6f", "submitter": { "id": 1359, "url": "http://patches.dpdk.org/api/people/1359/?format=api", "name": "Sean Morrissey", "email": "sean.morrissey@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211004101058.2396458-6-sean.morrissey@intel.com/mbox/", "series": [ { "id": 19360, "url": "http://patches.dpdk.org/api/series/19360/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19360", "date": "2021-10-04T10:10:53", "name": "introduce IWYU", "version": 1, "mbox": "http://patches.dpdk.org/series/19360/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/100427/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/100427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D6F9A0C4C;\n\tMon, 4 Oct 2021 12:12:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1EF4C4132F;\n\tMon, 4 Oct 2021 12:11:46 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 102314132F\n for <dev@dpdk.org>; Mon, 4 Oct 2021 12:11:43 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Oct 2021 03:11:43 -0700", "from silpixa00401215.ir.intel.com ([10.55.128.96])\n by FMSMGA003.fm.intel.com with ESMTP; 04 Oct 2021 03:11:40 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10126\"; a=\"205501941\"", "E=Sophos;i=\"5.85,345,1624345200\"; d=\"scan'208\";a=\"205501941\"", "E=Sophos;i=\"5.85,345,1624345200\"; d=\"scan'208\";a=\"558342111\"" ], "X-ExtLoop1": "1", "From": "Sean Morrissey <sean.morrissey@intel.com>", "To": "Anatoly Burakov <anatoly.burakov@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n\t=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Harman Kalra <hkalra@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "dev@dpdk.org,\n\tSean Morrissey <sean.morrissey@intel.com>", "Date": "Mon, 4 Oct 2021 10:10:58 +0000", "Message-Id": "<20211004101058.2396458-6-sean.morrissey@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211004101058.2396458-1-sean.morrissey@intel.com>", "References": "<20211004101058.2396458-1-sean.morrissey@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 5/5] lib/eal: remove unneeded header includes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These header includes have been flagged by the iwyu_tool\nand removed.\n\nSigned-off-by: Sean Morrissey <sean.morrissey@intel.com>\n---\n lib/eal/common/eal_common_dev.c | 5 -----\n lib/eal/common/eal_common_devargs.c | 1 -\n lib/eal/common/eal_common_errno.c | 4 ----\n lib/eal/common/eal_common_fbarray.c | 3 ---\n lib/eal/common/eal_common_hexdump.c | 3 ---\n lib/eal/common/eal_common_launch.c | 6 ------\n lib/eal/common/eal_common_lcore.c | 6 ------\n lib/eal/common/eal_common_log.c | 2 --\n lib/eal/common/eal_common_memalloc.c | 3 ---\n lib/eal/common/eal_common_memory.c | 5 -----\n lib/eal/common/eal_common_memzone.c | 4 ----\n lib/eal/common/eal_common_options.c | 2 --\n lib/eal/common/eal_common_proc.c | 2 --\n lib/eal/common/eal_common_string_fns.c | 2 --\n lib/eal/common/eal_common_tailqs.c | 11 -----------\n lib/eal/common/eal_common_thread.c | 3 ---\n lib/eal/common/eal_common_timer.c | 6 ------\n lib/eal/common/eal_common_trace.c | 1 -\n lib/eal/common/hotplug_mp.h | 1 -\n lib/eal/common/malloc_elem.c | 6 ------\n lib/eal/common/malloc_heap.c | 5 -----\n lib/eal/common/malloc_mp.c | 1 -\n lib/eal/common/malloc_mp.h | 2 --\n lib/eal/common/rte_malloc.c | 6 ------\n lib/eal/common/rte_random.c | 3 ---\n lib/eal/common/rte_service.c | 6 ------\n lib/eal/include/rte_version.h | 2 --\n lib/eal/linux/eal.c | 10 ----------\n lib/eal/linux/eal_alarm.c | 7 -------\n lib/eal/linux/eal_cpuflags.c | 2 --\n lib/eal/linux/eal_debug.c | 5 -----\n lib/eal/linux/eal_dev.c | 4 ----\n lib/eal/linux/eal_hugepage_info.c | 8 --------\n lib/eal/linux/eal_interrupts.c | 8 --------\n lib/eal/linux/eal_lcore.c | 7 -------\n lib/eal/linux/eal_log.c | 11 +----------\n lib/eal/linux/eal_memalloc.c | 8 --------\n lib/eal/linux/eal_memory.c | 9 ---------\n lib/eal/linux/eal_thread.c | 5 -----\n lib/eal/linux/eal_timer.c | 15 ---------------\n lib/eal/linux/eal_vfio_mp_sync.c | 1 -\n lib/eal/unix/eal_file.c | 1 -\n lib/eal/unix/rte_thread.c | 1 -\n lib/eal/x86/rte_cycles.c | 1 -\n 44 files changed, 1 insertion(+), 203 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c\nindex 148a23830a..12bf3d3c22 100644\n--- a/lib/eal/common/eal_common_dev.c\n+++ b/lib/eal/common/eal_common_dev.c\n@@ -5,20 +5,15 @@\n \n #include <stdio.h>\n #include <string.h>\n-#include <inttypes.h>\n #include <sys/queue.h>\n \n-#include <rte_compat.h>\n #include <rte_bus.h>\n #include <rte_class.h>\n #include <rte_dev.h>\n #include <rte_devargs.h>\n-#include <rte_debug.h>\n #include <rte_errno.h>\n-#include <rte_kvargs.h>\n #include <rte_log.h>\n #include <rte_spinlock.h>\n-#include <rte_malloc.h>\n #include <rte_string_fns.h>\n \n #include \"eal_private.h\"\ndiff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c\nindex 7ab9e71b2a..f4beb35591 100644\n--- a/lib/eal/common/eal_common_devargs.c\n+++ b/lib/eal/common/eal_common_devargs.c\n@@ -12,7 +12,6 @@\n \n #include <rte_bus.h>\n #include <rte_class.h>\n-#include <rte_compat.h>\n #include <rte_dev.h>\n #include <rte_devargs.h>\n #include <rte_errno.h>\ndiff --git a/lib/eal/common/eal_common_errno.c b/lib/eal/common/eal_common_errno.c\nindex f86802705a..1091065568 100644\n--- a/lib/eal/common/eal_common_errno.c\n+++ b/lib/eal/common/eal_common_errno.c\n@@ -5,15 +5,11 @@\n /* Use XSI-compliant portable version of strerror_r() */\n #undef _GNU_SOURCE\n \n-#include <stdint.h>\n #include <stdio.h>\n #include <string.h>\n-#include <stdarg.h>\n-#include <errno.h>\n \n #include <rte_per_lcore.h>\n #include <rte_errno.h>\n-#include <rte_string_fns.h>\n \n #ifdef RTE_EXEC_ENV_WINDOWS\n #define strerror_r(errnum, buf, buflen) strerror_s(buf, buflen, errnum)\ndiff --git a/lib/eal/common/eal_common_fbarray.c b/lib/eal/common/eal_common_fbarray.c\nindex 3a28a53247..f11f87979f 100644\n--- a/lib/eal/common/eal_common_fbarray.c\n+++ b/lib/eal/common/eal_common_fbarray.c\n@@ -2,7 +2,6 @@\n * Copyright(c) 2017-2018 Intel Corporation\n */\n \n-#include <fcntl.h>\n #include <inttypes.h>\n #include <limits.h>\n #include <stdint.h>\n@@ -14,9 +13,7 @@\n #include <rte_eal_paging.h>\n #include <rte_errno.h>\n #include <rte_log.h>\n-#include <rte_memory.h>\n #include <rte_spinlock.h>\n-#include <rte_tailq.h>\n \n #include \"eal_filesystem.h\"\n #include \"eal_private.h\"\ndiff --git a/lib/eal/common/eal_common_hexdump.c b/lib/eal/common/eal_common_hexdump.c\nindex 2d2179d411..63bbbdcf0a 100644\n--- a/lib/eal/common/eal_common_hexdump.c\n+++ b/lib/eal/common/eal_common_hexdump.c\n@@ -1,10 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n * Copyright(c) 2010-2014 Intel Corporation\n */\n-#include <stdlib.h>\n #include <stdio.h>\n-#include <errno.h>\n-#include <stdint.h>\n #include <rte_hexdump.h>\n #include <rte_string_fns.h>\n \ndiff --git a/lib/eal/common/eal_common_launch.c b/lib/eal/common/eal_common_launch.c\nindex 34f854ad80..2a20b32a77 100644\n--- a/lib/eal/common/eal_common_launch.c\n+++ b/lib/eal/common/eal_common_launch.c\n@@ -3,16 +3,10 @@\n */\n \n #include <errno.h>\n-#include <stdint.h>\n-#include <stdio.h>\n-#include <sys/queue.h>\n \n #include <rte_launch.h>\n-#include <rte_memory.h>\n-#include <rte_eal.h>\n #include <rte_atomic.h>\n #include <rte_pause.h>\n-#include <rte_per_lcore.h>\n #include <rte_lcore.h>\n \n #include \"eal_private.h\"\ndiff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c\nindex 66d6bad1a7..4307a13190 100644\n--- a/lib/eal/common/eal_common_lcore.c\n+++ b/lib/eal/common/eal_common_lcore.c\n@@ -2,19 +2,13 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n-#include <unistd.h>\n-#include <limits.h>\n #include <string.h>\n \n #include <rte_common.h>\n-#include <rte_debug.h>\n-#include <rte_eal.h>\n #include <rte_errno.h>\n #include <rte_lcore.h>\n #include <rte_log.h>\n-#include <rte_rwlock.h>\n \n-#include \"eal_memcfg.h\"\n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n \ndiff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c\nindex ec8fe23a7f..24afb57c89 100644\n--- a/lib/eal/common/eal_common_log.c\n+++ b/lib/eal/common/eal_common_log.c\n@@ -11,9 +11,7 @@\n #include <regex.h>\n #include <fnmatch.h>\n \n-#include <rte_eal.h>\n #include <rte_log.h>\n-#include <rte_os_shim.h>\n #include <rte_per_lcore.h>\n \n #include \"eal_log.h\"\ndiff --git a/lib/eal/common/eal_common_memalloc.c b/lib/eal/common/eal_common_memalloc.c\nindex e872c6533b..f8770ff835 100644\n--- a/lib/eal/common/eal_common_memalloc.c\n+++ b/lib/eal/common/eal_common_memalloc.c\n@@ -5,12 +5,9 @@\n #include <string.h>\n \n #include <rte_errno.h>\n-#include <rte_lcore.h>\n #include <rte_fbarray.h>\n-#include <rte_memzone.h>\n #include <rte_memory.h>\n #include <rte_string_fns.h>\n-#include <rte_rwlock.h>\n \n #include \"eal_private.h\"\n #include \"eal_internal_cfg.h\"\ndiff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c\nindex f83b75092e..bb0da9e50a 100644\n--- a/lib/eal/common/eal_common_memory.c\n+++ b/lib/eal/common/eal_common_memory.c\n@@ -2,16 +2,11 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n-#include <fcntl.h>\n #include <errno.h>\n #include <stdio.h>\n #include <stdint.h>\n-#include <stdlib.h>\n-#include <stdarg.h>\n #include <string.h>\n-#include <unistd.h>\n #include <inttypes.h>\n-#include <sys/queue.h>\n \n #include <rte_fbarray.h>\n #include <rte_memory.h>\ndiff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c\nindex 7c21aa921e..67dcaaafbf 100644\n--- a/lib/eal/common/eal_common_memzone.c\n+++ b/lib/eal/common/eal_common_memzone.c\n@@ -2,20 +2,16 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n-#include <stdlib.h>\n #include <stdio.h>\n #include <stdint.h>\n-#include <stdarg.h>\n #include <inttypes.h>\n #include <string.h>\n #include <errno.h>\n-#include <sys/queue.h>\n \n #include <rte_log.h>\n #include <rte_memory.h>\n #include <rte_memzone.h>\n #include <rte_eal.h>\n-#include <rte_per_lcore.h>\n #include <rte_errno.h>\n #include <rte_string_fns.h>\n #include <rte_common.h>\ndiff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c\nindex eaef57312f..1eb51be09c 100644\n--- a/lib/eal/common/eal_common_options.c\n+++ b/lib/eal/common/eal_common_options.c\n@@ -4,7 +4,6 @@\n */\n \n #include <stdlib.h>\n-#include <unistd.h>\n #include <string.h>\n #ifndef RTE_EXEC_ENV_WINDOWS\n #include <syslog.h>\n@@ -17,7 +16,6 @@\n #include <dlfcn.h>\n #include <libgen.h>\n #endif\n-#include <sys/types.h>\n #include <sys/stat.h>\n #ifndef RTE_EXEC_ENV_WINDOWS\n #include <dirent.h>\ndiff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c\nindex ebd0f6673b..575b4ca24d 100644\n--- a/lib/eal/common/eal_common_proc.c\n+++ b/lib/eal/common/eal_common_proc.c\n@@ -15,7 +15,6 @@\n #include <string.h>\n #include <sys/file.h>\n #include <sys/time.h>\n-#include <sys/types.h>\n #include <sys/socket.h>\n #include <sys/un.h>\n #include <unistd.h>\n@@ -27,7 +26,6 @@\n #include <rte_errno.h>\n #include <rte_lcore.h>\n #include <rte_log.h>\n-#include <rte_tailq.h>\n \n #include \"eal_memcfg.h\"\n #include \"eal_private.h\"\ndiff --git a/lib/eal/common/eal_common_string_fns.c b/lib/eal/common/eal_common_string_fns.c\nindex ddd1891656..0236ae4023 100644\n--- a/lib/eal/common/eal_common_string_fns.c\n+++ b/lib/eal/common/eal_common_string_fns.c\n@@ -2,9 +2,7 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n-#include <string.h>\n #include <stdio.h>\n-#include <stdarg.h>\n #include <errno.h>\n \n #include <rte_string_fns.h>\ndiff --git a/lib/eal/common/eal_common_tailqs.c b/lib/eal/common/eal_common_tailqs.c\nindex ead06897b8..580fbf24bc 100644\n--- a/lib/eal/common/eal_common_tailqs.c\n+++ b/lib/eal/common/eal_common_tailqs.c\n@@ -3,24 +3,13 @@\n */\n \n #include <sys/queue.h>\n-#include <stdint.h>\n-#include <errno.h>\n #include <stdio.h>\n-#include <stdarg.h>\n #include <string.h>\n-#include <inttypes.h>\n \n-#include <rte_memory.h>\n-#include <rte_launch.h>\n #include <rte_eal.h>\n #include <rte_eal_memconfig.h>\n-#include <rte_per_lcore.h>\n-#include <rte_lcore.h>\n-#include <rte_atomic.h>\n-#include <rte_branch_prediction.h>\n #include <rte_log.h>\n #include <rte_string_fns.h>\n-#include <rte_debug.h>\n \n #include \"eal_private.h\"\n #include \"eal_memcfg.h\"\ndiff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c\nindex 1a52f42a2b..cfa6a69ad4 100644\n--- a/lib/eal/common/eal_common_thread.c\n+++ b/lib/eal/common/eal_common_thread.c\n@@ -4,10 +4,7 @@\n \n #include <stdio.h>\n #include <stdlib.h>\n-#include <stdint.h>\n-#include <unistd.h>\n #include <pthread.h>\n-#include <signal.h>\n #include <sched.h>\n #include <assert.h>\n #include <string.h>\ndiff --git a/lib/eal/common/eal_common_timer.c b/lib/eal/common/eal_common_timer.c\nindex 86f8429847..5686a5102b 100644\n--- a/lib/eal/common/eal_common_timer.c\n+++ b/lib/eal/common/eal_common_timer.c\n@@ -2,16 +2,10 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n-#include <string.h>\n #include <stdio.h>\n-#include <unistd.h>\n #include <inttypes.h>\n-#include <sys/types.h>\n-#include <time.h>\n-#include <errno.h>\n \n #include <rte_common.h>\n-#include <rte_compat.h>\n #include <rte_log.h>\n #include <rte_cycles.h>\n #include <rte_pause.h>\ndiff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c\nindex 7bff1cd2ce..036f6ac348 100644\n--- a/lib/eal/common/eal_common_trace.c\n+++ b/lib/eal/common/eal_common_trace.c\n@@ -3,7 +3,6 @@\n */\n \n #include <fnmatch.h>\n-#include <inttypes.h>\n #include <sys/queue.h>\n #include <regex.h>\n \ndiff --git a/lib/eal/common/hotplug_mp.h b/lib/eal/common/hotplug_mp.h\nindex 8fcf9b52e2..066494ff27 100644\n--- a/lib/eal/common/hotplug_mp.h\n+++ b/lib/eal/common/hotplug_mp.h\n@@ -6,7 +6,6 @@\n #define _HOTPLUG_MP_H_\n \n #include \"rte_dev.h\"\n-#include \"rte_bus.h\"\n \n #define EAL_DEV_MP_ACTION_REQUEST \"eal_dev_mp_request\"\n #define EAL_DEV_MP_ACTION_RESPONSE \"eal_dev_mp_response\"\ndiff --git a/lib/eal/common/malloc_elem.c b/lib/eal/common/malloc_elem.c\nindex c2c9461f1d..4c6e6f4910 100644\n--- a/lib/eal/common/malloc_elem.c\n+++ b/lib/eal/common/malloc_elem.c\n@@ -6,17 +6,11 @@\n #include <stddef.h>\n #include <stdio.h>\n #include <string.h>\n-#include <unistd.h>\n #include <sys/queue.h>\n \n #include <rte_memory.h>\n #include <rte_eal.h>\n-#include <rte_launch.h>\n-#include <rte_per_lcore.h>\n-#include <rte_lcore.h>\n-#include <rte_debug.h>\n #include <rte_common.h>\n-#include <rte_spinlock.h>\n \n #include \"eal_private.h\"\n #include \"eal_internal_cfg.h\"\ndiff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c\nindex ee400f38ec..61f0a5d84f 100644\n--- a/lib/eal/common/malloc_heap.c\n+++ b/lib/eal/common/malloc_heap.c\n@@ -5,7 +5,6 @@\n #include <stddef.h>\n #include <stdlib.h>\n #include <stdio.h>\n-#include <stdarg.h>\n #include <errno.h>\n #include <sys/queue.h>\n \n@@ -13,15 +12,11 @@\n #include <rte_errno.h>\n #include <rte_eal.h>\n #include <rte_eal_memconfig.h>\n-#include <rte_launch.h>\n-#include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_common.h>\n #include <rte_string_fns.h>\n #include <rte_spinlock.h>\n-#include <rte_memcpy.h>\n #include <rte_memzone.h>\n-#include <rte_atomic.h>\n #include <rte_fbarray.h>\n \n #include \"eal_internal_cfg.h\"\ndiff --git a/lib/eal/common/malloc_mp.c b/lib/eal/common/malloc_mp.c\nindex 2e597a17a2..801b2e7fbd 100644\n--- a/lib/eal/common/malloc_mp.c\n+++ b/lib/eal/common/malloc_mp.c\n@@ -5,7 +5,6 @@\n #include <string.h>\n #include <sys/time.h>\n \n-#include <rte_alarm.h>\n #include <rte_errno.h>\n #include <rte_string_fns.h>\n \ndiff --git a/lib/eal/common/malloc_mp.h b/lib/eal/common/malloc_mp.h\nindex 0095062b72..fb10817e13 100644\n--- a/lib/eal/common/malloc_mp.h\n+++ b/lib/eal/common/malloc_mp.h\n@@ -10,8 +10,6 @@\n \n #include <rte_common.h>\n #include <rte_random.h>\n-#include <rte_spinlock.h>\n-#include <rte_tailq.h>\n \n /* forward declarations */\n struct malloc_heap;\ndiff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c\nindex 9d39e58c08..6c69a2cf3b 100644\n--- a/lib/eal/common/rte_malloc.c\n+++ b/lib/eal/common/rte_malloc.c\n@@ -6,18 +6,12 @@\n #include <stddef.h>\n #include <stdio.h>\n #include <string.h>\n-#include <sys/queue.h>\n \n #include <rte_errno.h>\n #include <rte_memcpy.h>\n #include <rte_memory.h>\n #include <rte_eal.h>\n #include <rte_eal_memconfig.h>\n-#include <rte_branch_prediction.h>\n-#include <rte_debug.h>\n-#include <rte_launch.h>\n-#include <rte_per_lcore.h>\n-#include <rte_lcore.h>\n #include <rte_common.h>\n #include <rte_spinlock.h>\n \ndiff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c\nindex ce21c2242a..4535cc980c 100644\n--- a/lib/eal/common/rte_random.c\n+++ b/lib/eal/common/rte_random.c\n@@ -5,14 +5,11 @@\n #ifdef __RDSEED__\n #include <x86intrin.h>\n #endif\n-#include <stdlib.h>\n #include <unistd.h>\n \n #include <rte_branch_prediction.h>\n #include <rte_cycles.h>\n-#include <rte_eal.h>\n #include <rte_lcore.h>\n-#include <rte_memory.h>\n #include <rte_random.h>\n \n struct rte_rand_state {\ndiff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c\nindex bd8fb72e78..ef31b1f63c 100644\n--- a/lib/eal/common/rte_service.c\n+++ b/lib/eal/common/rte_service.c\n@@ -3,22 +3,16 @@\n */\n \n #include <stdio.h>\n-#include <unistd.h>\n #include <inttypes.h>\n-#include <limits.h>\n #include <string.h>\n \n-#include <rte_compat.h>\n #include <rte_service.h>\n #include <rte_service_component.h>\n \n-#include <rte_eal.h>\n #include <rte_lcore.h>\n #include <rte_common.h>\n-#include <rte_debug.h>\n #include <rte_cycles.h>\n #include <rte_atomic.h>\n-#include <rte_memory.h>\n #include <rte_malloc.h>\n #include <rte_spinlock.h>\n \ndiff --git a/lib/eal/include/rte_version.h b/lib/eal/include/rte_version.h\nindex b06a62e7a2..414b6167f2 100644\n--- a/lib/eal/include/rte_version.h\n+++ b/lib/eal/include/rte_version.h\n@@ -14,10 +14,8 @@\n extern \"C\" {\n #endif\n \n-#include <stdint.h>\n #include <string.h>\n #include <stdio.h>\n-#include <rte_common.h>\n #include <rte_compat.h>\n \n /**\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 3577eaeaa4..f55d1860d8 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -7,10 +7,8 @@\n #include <stdlib.h>\n #include <stdint.h>\n #include <string.h>\n-#include <stdarg.h>\n #include <unistd.h>\n #include <pthread.h>\n-#include <syslog.h>\n #include <getopt.h>\n #include <sys/file.h>\n #include <dirent.h>\n@@ -20,32 +18,24 @@\n #include <errno.h>\n #include <limits.h>\n #include <sys/mman.h>\n-#include <sys/queue.h>\n #include <sys/stat.h>\n #if defined(RTE_ARCH_X86)\n #include <sys/io.h>\n #endif\n #include <linux/version.h>\n \n-#include <rte_compat.h>\n #include <rte_common.h>\n #include <rte_debug.h>\n #include <rte_memory.h>\n #include <rte_launch.h>\n #include <rte_eal.h>\n #include <rte_errno.h>\n-#include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_service_component.h>\n #include <rte_log.h>\n-#include <rte_random.h>\n-#include <rte_cycles.h>\n #include <rte_string_fns.h>\n #include <rte_cpuflags.h>\n-#include <rte_interrupts.h>\n #include <rte_bus.h>\n-#include <rte_dev.h>\n-#include <rte_devargs.h>\n #include <rte_version.h>\n #include <malloc_heap.h>\n #include <rte_vfio.h>\ndiff --git a/lib/eal/linux/eal_alarm.c b/lib/eal/linux/eal_alarm.c\nindex 3252c6fa59..43f6bb14f2 100644\n--- a/lib/eal/linux/eal_alarm.c\n+++ b/lib/eal/linux/eal_alarm.c\n@@ -3,21 +3,14 @@\n */\n #include <stdio.h>\n #include <stdint.h>\n-#include <signal.h>\n #include <errno.h>\n-#include <string.h>\n #include <sys/queue.h>\n #include <sys/time.h>\n #include <sys/timerfd.h>\n \n-#include <rte_memory.h>\n #include <rte_interrupts.h>\n #include <rte_alarm.h>\n #include <rte_common.h>\n-#include <rte_per_lcore.h>\n-#include <rte_eal.h>\n-#include <rte_launch.h>\n-#include <rte_lcore.h>\n #include <rte_errno.h>\n #include <rte_spinlock.h>\n #include <rte_eal_trace.h>\ndiff --git a/lib/eal/linux/eal_cpuflags.c b/lib/eal/linux/eal_cpuflags.c\nindex d38296e1e5..c684940e1d 100644\n--- a/lib/eal/linux/eal_cpuflags.c\n+++ b/lib/eal/linux/eal_cpuflags.c\n@@ -5,8 +5,6 @@\n #include <elf.h>\n #include <fcntl.h>\n #include <string.h>\n-#include <sys/stat.h>\n-#include <sys/types.h>\n #include <unistd.h>\n \n #if defined(__GLIBC__) && defined(__GLIBC_PREREQ)\ndiff --git a/lib/eal/linux/eal_debug.c b/lib/eal/linux/eal_debug.c\nindex 64dab4e0da..b0ecf5a9dc 100644\n--- a/lib/eal/linux/eal_debug.c\n+++ b/lib/eal/linux/eal_debug.c\n@@ -5,16 +5,11 @@\n #ifdef RTE_BACKTRACE\n #include <execinfo.h>\n #endif\n-#include <stdarg.h>\n-#include <signal.h>\n #include <stdlib.h>\n #include <stdio.h>\n-#include <stdint.h>\n \n #include <rte_log.h>\n #include <rte_debug.h>\n-#include <rte_common.h>\n-#include <rte_eal.h>\n \n #define BACKTRACE_SIZE 256\n \ndiff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c\nindex 3b905e18f5..0a654e5b50 100644\n--- a/lib/eal/linux/eal_dev.c\n+++ b/lib/eal/linux/eal_dev.c\n@@ -4,20 +4,16 @@\n \n #include <string.h>\n #include <unistd.h>\n-#include <fcntl.h>\n #include <signal.h>\n #include <sys/socket.h>\n #include <linux/netlink.h>\n \n #include <rte_string_fns.h>\n #include <rte_log.h>\n-#include <rte_compat.h>\n #include <rte_dev.h>\n-#include <rte_malloc.h>\n #include <rte_interrupts.h>\n #include <rte_alarm.h>\n #include <rte_bus.h>\n-#include <rte_eal.h>\n #include <rte_spinlock.h>\n #include <rte_errno.h>\n \ndiff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c\nindex d97792cade..b3e4c40ee7 100644\n--- a/lib/eal/linux/eal_hugepage_info.c\n+++ b/lib/eal/linux/eal_hugepage_info.c\n@@ -3,7 +3,6 @@\n */\n \n #include <string.h>\n-#include <sys/types.h>\n #include <sys/file.h>\n #include <dirent.h>\n #include <fcntl.h>\n@@ -12,19 +11,12 @@\n #include <stdio.h>\n #include <fnmatch.h>\n #include <inttypes.h>\n-#include <stdarg.h>\n #include <unistd.h>\n #include <errno.h>\n #include <sys/mman.h>\n-#include <sys/queue.h>\n-#include <sys/stat.h>\n \n #include <linux/mman.h> /* for hugetlb-related flags */\n \n-#include <rte_memory.h>\n-#include <rte_eal.h>\n-#include <rte_launch.h>\n-#include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_debug.h>\n #include <rte_log.h>\ndiff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c\nindex 22b3b7bcd9..1d5c9b272c 100644\n--- a/lib/eal/linux/eal_interrupts.c\n+++ b/lib/eal/linux/eal_interrupts.c\n@@ -7,13 +7,10 @@\n #include <stdlib.h>\n #include <pthread.h>\n #include <sys/queue.h>\n-#include <stdarg.h>\n #include <unistd.h>\n #include <string.h>\n #include <errno.h>\n-#include <inttypes.h>\n #include <sys/epoll.h>\n-#include <sys/signalfd.h>\n #include <sys/ioctl.h>\n #include <sys/eventfd.h>\n #include <assert.h>\n@@ -21,9 +18,6 @@\n \n #include <rte_common.h>\n #include <rte_interrupts.h>\n-#include <rte_memory.h>\n-#include <rte_launch.h>\n-#include <rte_eal.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_branch_prediction.h>\n@@ -36,8 +30,6 @@\n #include <rte_eal_trace.h>\n \n #include \"eal_private.h\"\n-#include \"eal_vfio.h\"\n-#include \"eal_thread.h\"\n \n #define EAL_INTR_EPOLL_WAIT_FOREVER (-1)\n #define NB_OTHER_INTR 1\ndiff --git a/lib/eal/linux/eal_lcore.c b/lib/eal/linux/eal_lcore.c\nindex bc8965844c..2e6a350603 100644\n--- a/lib/eal/linux/eal_lcore.c\n+++ b/lib/eal/linux/eal_lcore.c\n@@ -4,15 +4,8 @@\n \n #include <unistd.h>\n #include <limits.h>\n-#include <string.h>\n-#include <dirent.h>\n \n #include <rte_log.h>\n-#include <rte_eal.h>\n-#include <rte_lcore.h>\n-#include <rte_common.h>\n-#include <rte_string_fns.h>\n-#include <rte_debug.h>\n \n #include \"eal_private.h\"\n #include \"eal_filesystem.h\"\ndiff --git a/lib/eal/linux/eal_log.c b/lib/eal/linux/eal_log.c\nindex c0aa1007c4..9e72412e2b 100644\n--- a/lib/eal/linux/eal_log.c\n+++ b/lib/eal/linux/eal_log.c\n@@ -2,19 +2,10 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n-#include <string.h>\n #include <stdio.h>\n-#include <stdint.h>\n #include <sys/types.h>\n #include <syslog.h>\n-#include <sys/queue.h>\n-\n-#include <rte_memory.h>\n-#include <rte_eal.h>\n-#include <rte_launch.h>\n-#include <rte_per_lcore.h>\n-#include <rte_lcore.h>\n-#include <rte_spinlock.h>\n+\n #include <rte_log.h>\n \n #include \"eal_log.h\"\ndiff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c\nindex 0ec8542283..e3aba10107 100644\n--- a/lib/eal/linux/eal_memalloc.c\n+++ b/lib/eal/linux/eal_memalloc.c\n@@ -3,23 +3,17 @@\n */\n \n #include <errno.h>\n-#include <stdarg.h>\n #include <stdbool.h>\n #include <stdlib.h>\n #include <stdio.h>\n #include <stdint.h>\n-#include <inttypes.h>\n #include <string.h>\n #include <sys/mman.h>\n-#include <sys/types.h>\n #include <sys/stat.h>\n-#include <sys/queue.h>\n #include <sys/file.h>\n #include <unistd.h>\n #include <limits.h>\n #include <fcntl.h>\n-#include <sys/ioctl.h>\n-#include <sys/time.h>\n #include <signal.h>\n #include <setjmp.h>\n #ifdef F_ADD_SEALS /* if file sealing is supported, so is memfd */\n@@ -36,9 +30,7 @@\n #include <rte_common.h>\n #include <rte_log.h>\n #include <rte_eal.h>\n-#include <rte_errno.h>\n #include <rte_memory.h>\n-#include <rte_spinlock.h>\n \n #include \"eal_filesystem.h\"\n #include \"eal_internal_cfg.h\"\ndiff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c\nindex 03a4f2dd2d..40ec9663d0 100644\n--- a/lib/eal/linux/eal_memory.c\n+++ b/lib/eal/linux/eal_memory.c\n@@ -5,7 +5,6 @@\n \n #include <errno.h>\n #include <fcntl.h>\n-#include <stdarg.h>\n #include <stdbool.h>\n #include <stdlib.h>\n #include <stdio.h>\n@@ -13,19 +12,14 @@\n #include <inttypes.h>\n #include <string.h>\n #include <sys/mman.h>\n-#include <sys/types.h>\n #include <sys/stat.h>\n-#include <sys/queue.h>\n #include <sys/file.h>\n #include <sys/resource.h>\n #include <unistd.h>\n #include <limits.h>\n-#include <sys/ioctl.h>\n-#include <sys/time.h>\n #include <signal.h>\n #include <setjmp.h>\n #ifdef F_ADD_SEALS /* if file sealing is supported, so is memfd */\n-#include <linux/memfd.h>\n #define MEMFD_SUPPORTED\n #endif\n #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES\n@@ -36,12 +30,9 @@\n #include <rte_errno.h>\n #include <rte_log.h>\n #include <rte_memory.h>\n-#include <rte_launch.h>\n #include <rte_eal.h>\n-#include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_common.h>\n-#include <rte_string_fns.h>\n \n #include \"eal_private.h\"\n #include \"eal_memalloc.h\"\ndiff --git a/lib/eal/linux/eal_thread.c b/lib/eal/linux/eal_thread.c\nindex 83c2034b93..60fa64ea55 100644\n--- a/lib/eal/linux/eal_thread.c\n+++ b/lib/eal/linux/eal_thread.c\n@@ -4,20 +4,15 @@\n \n #include <errno.h>\n #include <stdio.h>\n-#include <stdlib.h>\n #include <stdint.h>\n #include <unistd.h>\n #include <pthread.h>\n-#include <sched.h>\n-#include <sys/queue.h>\n #include <sys/syscall.h>\n \n #include <rte_debug.h>\n #include <rte_atomic.h>\n #include <rte_launch.h>\n #include <rte_log.h>\n-#include <rte_memory.h>\n-#include <rte_per_lcore.h>\n #include <rte_eal.h>\n #include <rte_lcore.h>\n #include <rte_eal_trace.h>\ndiff --git a/lib/eal/linux/eal_timer.c b/lib/eal/linux/eal_timer.c\nindex 7cf15cabac..620baf038d 100644\n--- a/lib/eal/linux/eal_timer.c\n+++ b/lib/eal/linux/eal_timer.c\n@@ -3,28 +3,13 @@\n * Copyright(c) 2012-2013 6WIND S.A.\n */\n \n-#include <string.h>\n-#include <stdlib.h>\n #include <stdio.h>\n #include <stdint.h>\n-#include <unistd.h>\n-#include <fcntl.h>\n-#include <inttypes.h>\n-#include <sys/mman.h>\n-#include <sys/queue.h>\n-#include <pthread.h>\n-#include <errno.h>\n \n #include <rte_common.h>\n-#include <rte_log.h>\n #include <rte_cycles.h>\n-#include <rte_lcore.h>\n-#include <rte_memory.h>\n-#include <rte_eal.h>\n-#include <rte_debug.h>\n \n #include \"eal_private.h\"\n-#include \"eal_internal_cfg.h\"\n \n enum timer_source eal_timer_source = EAL_TIMER_HPET;\n \ndiff --git a/lib/eal/linux/eal_vfio_mp_sync.c b/lib/eal/linux/eal_vfio_mp_sync.c\nindex a2accfab3a..e1776166af 100644\n--- a/lib/eal/linux/eal_vfio_mp_sync.c\n+++ b/lib/eal/linux/eal_vfio_mp_sync.c\n@@ -5,7 +5,6 @@\n #include <unistd.h>\n #include <string.h>\n \n-#include <rte_compat.h>\n #include <rte_errno.h>\n #include <rte_log.h>\n #include <rte_vfio.h>\ndiff --git a/lib/eal/unix/eal_file.c b/lib/eal/unix/eal_file.c\nindex ec554e0096..f04f5fbcbc 100644\n--- a/lib/eal/unix/eal_file.c\n+++ b/lib/eal/unix/eal_file.c\n@@ -3,7 +3,6 @@\n */\n \n #include <sys/file.h>\n-#include <sys/mman.h>\n #include <fcntl.h>\n #include <unistd.h>\n \ndiff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c\nindex c72d619ec1..c34ede9186 100644\n--- a/lib/eal/unix/rte_thread.c\n+++ b/lib/eal/unix/rte_thread.c\n@@ -7,7 +7,6 @@\n #include <stdlib.h>\n #include <string.h>\n \n-#include <rte_common.h>\n #include <rte_errno.h>\n #include <rte_log.h>\n #include <rte_thread.h>\ndiff --git a/lib/eal/x86/rte_cycles.c b/lib/eal/x86/rte_cycles.c\nindex edd9621abb..0e695caf28 100644\n--- a/lib/eal/x86/rte_cycles.c\n+++ b/lib/eal/x86/rte_cycles.c\n@@ -6,7 +6,6 @@\n #include <unistd.h>\n #include <cpuid.h>\n \n-#include <rte_common.h>\n \n #include \"eal_private.h\"\n \n", "prefixes": [ "v1", "5/5" ] }{ "id": 100427, "url": "