Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 100405,
    "url": "http://patches.dpdk.org/api/patches/100405/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211004054108.3890018-2-s.v.naga.harish.k@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211004054108.3890018-2-s.v.naga.harish.k@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211004054108.3890018-2-s.v.naga.harish.k@intel.com",
    "date": "2021-10-04T05:41:05",
    "name": "[v5,2/5] test/event: add unit test for Rx adapter",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "6b2efea938ab8a34275e1b9e5ff72fb14f584e05",
    "submitter": {
        "id": 2280,
        "url": "http://patches.dpdk.org/api/people/2280/?format=api",
        "name": "Naga Harish K, S V",
        "email": "s.v.naga.harish.k@intel.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211004054108.3890018-2-s.v.naga.harish.k@intel.com/mbox/",
    "series": [
        {
            "id": 19351,
            "url": "http://patches.dpdk.org/api/series/19351/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19351",
            "date": "2021-10-04T05:41:04",
            "name": "[v5,1/5] eventdev/rx_adapter: add event buffer size configurability",
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/19351/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/100405/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/100405/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D828A0C4B;\n\tMon,  4 Oct 2021 07:41:26 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 49027412AD;\n\tMon,  4 Oct 2021 07:41:23 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 22C31412B4\n for <dev@dpdk.org>; Mon,  4 Oct 2021 07:41:20 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Oct 2021 22:41:20 -0700",
            "from txandevlnx322.an.intel.com ([10.123.117.44])\n by fmsmga001.fm.intel.com with ESMTP; 03 Oct 2021 22:41:20 -0700"
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10126\"; a=\"224055612\"",
            "E=Sophos;i=\"5.85,345,1624345200\"; d=\"scan'208\";a=\"224055612\"",
            "E=Sophos;i=\"5.85,345,1624345200\"; d=\"scan'208\";a=\"621578841\""
        ],
        "X-ExtLoop1": "1",
        "From": "Naga Harish K S V <s.v.naga.harish.k@intel.com>",
        "To": "jerinj@marvell.com,\n\tjay.jayatheerthan@intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Mon,  4 Oct 2021 00:41:05 -0500",
        "Message-Id": "<20211004054108.3890018-2-s.v.naga.harish.k@intel.com>",
        "X-Mailer": "git-send-email 2.23.0",
        "In-Reply-To": "<20211004054108.3890018-1-s.v.naga.harish.k@intel.com>",
        "References": "<20210930082901.293541-1-s.v.naga.harish.k@intel.com>\n <20211004054108.3890018-1-s.v.naga.harish.k@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v5 2/5] test/event: add unit test for Rx adapter",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "this patch adds unit test for rte_event_eth_rx_adapter_create_with_params\napi and validate all possible input combinations.\n\nSigned-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>\n---\n app/test/test_event_eth_rx_adapter.c | 53 +++++++++++++++++++++++++---\n 1 file changed, 49 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c\nindex 13664a3a3b..7c2cf0dd70 100644\n--- a/app/test/test_event_eth_rx_adapter.c\n+++ b/app/test/test_event_eth_rx_adapter.c\n@@ -428,6 +428,50 @@ adapter_create_free(void)\n \treturn TEST_SUCCESS;\n }\n \n+static int\n+adapter_create_free_with_params(void)\n+{\n+\tint err;\n+\n+\tstruct rte_event_port_conf rx_p_conf = {\n+\t\t\t.dequeue_depth = 8,\n+\t\t\t.enqueue_depth = 8,\n+\t\t\t.new_event_threshold = 1200,\n+\t};\n+\n+\tstruct rte_event_eth_rx_adapter_params rxa_params = {\n+\t\t\t.event_buf_size = 1024\n+\t};\n+\n+\terr = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,\n+\t\t\t\tTEST_DEV_ID, NULL, NULL);\n+\tTEST_ASSERT(err == -EINVAL, \"Expected -EINVAL got %d\", err);\n+\n+\terr = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,\n+\t\t\t\tTEST_DEV_ID, &rx_p_conf, &rxa_params);\n+\tTEST_ASSERT(err == 0, \"Expected 0 got %d\", err);\n+\n+\terr = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,\n+\t\t\t\tTEST_DEV_ID, &rx_p_conf, &rxa_params);\n+\tTEST_ASSERT(err == -EEXIST, \"Expected -EEXIST %d got %d\", -EEXIST, err);\n+\n+\trxa_params.event_buf_size = 0;\n+\terr = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,\n+\t\t\t\tTEST_DEV_ID, &rx_p_conf, &rxa_params);\n+\tTEST_ASSERT(err == -EINVAL, \"Expected -EINVAL got %d\", err);\n+\n+\terr = rte_event_eth_rx_adapter_free(TEST_INST_ID);\n+\tTEST_ASSERT(err == 0, \"Expected 0 got %d\", err);\n+\n+\terr = rte_event_eth_rx_adapter_free(TEST_INST_ID);\n+\tTEST_ASSERT(err == -EINVAL, \"Expected -EINVAL %d got %d\", -EINVAL, err);\n+\n+\terr = rte_event_eth_rx_adapter_free(1);\n+\tTEST_ASSERT(err == -EINVAL, \"Expected -EINVAL %d got %d\", -EINVAL, err);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n static int\n adapter_queue_add_del(void)\n {\n@@ -435,7 +479,7 @@ adapter_queue_add_del(void)\n \tstruct rte_event ev;\n \tuint32_t cap;\n \n-\tstruct rte_event_eth_rx_adapter_queue_conf queue_config;\n+\tstruct rte_event_eth_rx_adapter_queue_conf queue_config = {0};\n \n \terr = rte_event_eth_rx_adapter_caps_get(TEST_DEV_ID, TEST_ETHDEV_ID,\n \t\t\t\t\t &cap);\n@@ -523,7 +567,7 @@ adapter_multi_eth_add_del(void)\n \tuint16_t port_index, port_index_base, drv_id = 0;\n \tchar driver_name[50];\n \n-\tstruct rte_event_eth_rx_adapter_queue_conf queue_config;\n+\tstruct rte_event_eth_rx_adapter_queue_conf queue_config = {0};\n \n \tev.queue_id = 0;\n \tev.sched_type = RTE_SCHED_TYPE_ATOMIC;\n@@ -594,7 +638,7 @@ adapter_intr_queue_add_del(void)\n \tstruct rte_event ev;\n \tuint32_t cap;\n \tuint16_t eth_port;\n-\tstruct rte_event_eth_rx_adapter_queue_conf queue_config;\n+\tstruct rte_event_eth_rx_adapter_queue_conf queue_config = {0};\n \n \tif (!default_params.rx_intr_port_inited)\n \t\treturn 0;\n@@ -687,7 +731,7 @@ adapter_start_stop(void)\n \tev.sched_type = RTE_SCHED_TYPE_ATOMIC;\n \tev.priority = 0;\n \n-\tstruct rte_event_eth_rx_adapter_queue_conf queue_config;\n+\tstruct rte_event_eth_rx_adapter_queue_conf queue_config = {0};\n \n \tqueue_config.rx_queue_flags = 0;\n \tif (default_params.caps &\n@@ -774,6 +818,7 @@ static struct unit_test_suite event_eth_rx_tests = {\n \t.teardown = testsuite_teardown,\n \t.unit_test_cases = {\n \t\tTEST_CASE_ST(NULL, NULL, adapter_create_free),\n+\t\tTEST_CASE_ST(NULL, NULL, adapter_create_free_with_params),\n \t\tTEST_CASE_ST(adapter_create, adapter_free,\n \t\t\t\t\tadapter_queue_add_del),\n \t\tTEST_CASE_ST(adapter_create, adapter_free,\n",
    "prefixes": [
        "v5",
        "2/5"
    ]
}