Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100124/?format=api
http://patches.dpdk.org/api/patches/100124/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210930160156.961041-5-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210930160156.961041-5-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210930160156.961041-5-andrew.rybchenko@oktetlabs.ru", "date": "2021-09-30T16:01:52", "name": "[v7,3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c709e3239525086a53a3dc72d0ea0cb1bc129a31", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210930160156.961041-5-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 19300, "url": "http://patches.dpdk.org/api/series/19300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19300", "date": "2021-09-30T16:01:48", "name": "[v7,1/4] ethdev: do not use get xstats names by IDs to obtain count", "version": 7, "mbox": "http://patches.dpdk.org/series/19300/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/100124/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/100124/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F273FA0C43;\n\tThu, 30 Sep 2021 18:02:38 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 71E2941160;\n\tThu, 30 Sep 2021 18:02:20 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 52ACA41160;\n Thu, 30 Sep 2021 18:02:19 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 25F347F6D2; Thu, 30 Sep 2021 19:02:19 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id B3E3C7F6D5;\n Thu, 30 Sep 2021 19:02:00 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B3E3C7F6D5", "Authentication-Results": "shelob.oktetlabs.ru/B3E3C7F6D5; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>, Kuba Kozak <kubax.kozak@intel.com>", "Cc": "dev@dpdk.org, Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Thu, 30 Sep 2021 19:01:52 +0300", "Message-Id": "<20210930160156.961041-5-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210930160156.961041-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>\n <20210930160156.961041-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 3/5] ethdev: fix docs of drivers callbacks\n getting xstats by IDs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nUpdate xstats by IDs callbacks documentation in accordance with\nethdev usage of these callbacks. Document valid combinations of\ninput arguments to make driver implementation simpler.\n\nFixes: 79c913a42f0 (\"ethdev: retrieve xstats by ID\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n lib/ethdev/ethdev_driver.h | 39 ++++++++++++++++++++++++++++++++++++--\n 1 file changed, 37 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h\nindex cc2c75261c..74af878bb8 100644\n--- a/lib/ethdev/ethdev_driver.h\n+++ b/lib/ethdev/ethdev_driver.h\n@@ -183,11 +183,28 @@ typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat *stats, unsigned int n);\n /**< @internal Get extended stats of an Ethernet device. */\n \n+/**\n+ * @internal\n+ * Get extended stats of an Ethernet device.\n+ *\n+ * @param dev\n+ * ethdev handle of port.\n+ * @param ids\n+ * IDs array to retrieve specific statistics. Must not be NULL.\n+ * @param values\n+ * A pointer to a table to be filled with device statistics values.\n+ * Must not be NULL.\n+ * @param n\n+ * Element count in @p ids and @p values.\n+ *\n+ * @return\n+ * - A number of filled in stats.\n+ * - A negative value on error.\n+ */\n typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev,\n \t\t\t\t const uint64_t *ids,\n \t\t\t\t uint64_t *values,\n \t\t\t\t unsigned int n);\n-/**< @internal Get extended stats of an Ethernet device. */\n \n /**\n * @internal\n@@ -214,10 +231,28 @@ typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names, unsigned int size);\n /**< @internal Get names of extended stats of an Ethernet device. */\n \n+/**\n+ * @internal\n+ * Get names of extended stats of an Ethernet device.\n+ *\n+ * @param dev\n+ * ethdev handle of port.\n+ * @param xstats_names\n+ * An rte_eth_xstat_name array of at least *size* elements to\n+ * be filled. Must not be NULL.\n+ * @param ids\n+ * IDs array to retrieve specific statistics. Must not be NULL.\n+ * @param size\n+ * Element count in @p ids and @p xstats_names.\n+ *\n+ * @return\n+ * - A number of filled in stats if both xstats_names and ids are not NULL.\n+ * - A number of available stats if both xstats_names and ids are NULL.\n+ * - A negative value on error.\n+ */\n typedef int (*eth_xstats_get_names_by_id_t)(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n \tunsigned int size);\n-/**< @internal Get names of extended stats of an Ethernet device. */\n \n typedef int (*eth_queue_stats_mapping_set_t)(struct rte_eth_dev *dev,\n \t\t\t\t\t uint16_t queue_id,\n", "prefixes": [ "v7", "3/5" ] }{ "id": 100124, "url": "