Cover Detail
Show a cover letter.
GET /api/covers/90822/?format=api
{ "id": 90822, "url": "http://patches.dpdk.org/api/covers/90822/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20210407222249.6729-1-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210407222249.6729-1-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210407222249.6729-1-dmitry.kozliuk@gmail.com", "date": "2021-04-07T22:22:45", "name": "[v8,0/4] eal/windows: do not expose POSIX symbols", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20210407222249.6729-1-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 16179, "url": "http://patches.dpdk.org/api/series/16179/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16179", "date": "2021-04-07T22:22:45", "name": "eal/windows: do not expose POSIX symbols", "version": 8, "mbox": "http://patches.dpdk.org/series/16179/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/90822/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 282A5A0A0F;\n\tThu, 8 Apr 2021 00:23:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A88FD140FB8;\n\tThu, 8 Apr 2021 00:23:00 +0200 (CEST)", "from mail-lj1-f175.google.com (mail-lj1-f175.google.com\n [209.85.208.175])\n by mails.dpdk.org (Postfix) with ESMTP id 5E7D940698\n for <dev@dpdk.org>; Thu, 8 Apr 2021 00:22:59 +0200 (CEST)", "by mail-lj1-f175.google.com with SMTP id u9so22586186ljd.11\n for <dev@dpdk.org>; Wed, 07 Apr 2021 15:22:59 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id u27sm441965lfk.254.2021.04.07.15.22.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 07 Apr 2021 15:22:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=MSbq2G9Cd0dROuYro6fyYeqE4oqMbpI/EwOKgZC94to=;\n b=pdd9nyETb4KFfYIIDNpzrHc/RYFcQsJlDJmQnt7VlsyG9WNivbXyz7qhZvPsCEte8i\n Z+wbhPW0VpCLhVQSh2N4t/LxXnH6WEnWTGl2K4gXJKpngvUjVtDM4Kxa+FqmXrmvZWSs\n px/S4fy+mVkSue9tQXfnVjML8UP8Z5IgnsFEgzBJuI0vqhlkJFRKBuCxJYqTOnsSWCd1\n GLE9XIldHJUue8n0hJGSq69TR8K3g8/P7rUzNpTY2n/bGEB1msL8v3aOpD1Mrhw8tCO2\n XQwY8Yhu7Z15+BgYYavZnKJQPKSJmhoaOqDh/lzro+zq+m3nxtzIAZOJ9dGsJS5Ip3Ve\n noJw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=MSbq2G9Cd0dROuYro6fyYeqE4oqMbpI/EwOKgZC94to=;\n b=fwvU98TlNW5lAs/QdF4jbzw74IrcTvxmqeLOVSYMA0E/SHTGOI/5AzAoM0RPaqAeWZ\n Xvh4cHveDL8h/iZlGWMvF5JXlRRkBfQYnXXLFd169NqdWwbNc9fvcRoq21f4K1yNdjHY\n UltU5YbeGSA1YsVVkoNCmf5DiNOYbvNYByFtwHCmKy9rsezszlM07mp/VEaSs45Bspaf\n HMOFYry1bkDrryMMljXqzrKUCqSvkuEWSjtuhl7jX74f0TouzZdwgcHW5eyVnB7rzqRM\n 9C8nffDMTgE6MSbMAnUEuaZPHepEBX/fyzDyP5ifh102kicbxgCFeXKq0NhFmaeP10m2\n QUVg==", "X-Gm-Message-State": "AOAM530rIE40uBr+elCERYSyJJloIStdg6GlL6+t8fZotaWO8eMe2QmM\n qFjSnEyNCYbPVPIh50OOurXwUHd6QBsleg==", "X-Google-Smtp-Source": "\n ABdhPJzhA7MtLRU+tLMMV+80lBCCnk0FnhxH9s/ZnDjgWuHHPLugwHnWkUXMzFWj3rEUpyE20QSe2g==", "X-Received": "by 2002:a2e:5c47:: with SMTP id q68mr3580336ljb.314.1617834178462;\n Wed, 07 Apr 2021 15:22:58 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Jie Zhou <jizh@linux.microsoft.com>,\n Nick Connolly <nick.connolly@mayadata.io>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Date": "Thu, 8 Apr 2021 01:22:45 +0300", "Message-Id": "<20210407222249.6729-1-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20210403234129.20296-1-dmitry.kozliuk@gmail.com>", "References": "<20210403234129.20296-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 0/4] eal/windows: do not expose POSIX symbols", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On Windows, EAL contains two sets of functions and macros for POSIX\ncompatibility: <rte_os.h> and a networking shim (socket headers).\nThe latter conflicts with system headers and should not exist.\nExposing the former from EAL can break consumer own POSIX compatibility\nlayer and is against standards in general. Hide these symbols from\nexternal consumers, while keeping them available for DPDK code.\n\nv8:\n * Drop rte_thread_sleep API, use rte_delay_us_sleep (Morten Brørup).\nv7:\n * Rearrange patches, improve wording, fix typo.\n * rte_os_internal.h -> rte_os_shim.h for possible later exposure\n * Remove unnecessary blank lines.\n\n\n*** BLURB HERE ***\n\nDmitry Kozlyuk (4):\n eal/windows: hide asprintf() shim\n eal: make OS shims internal\n net: work around s_addr macro on Windows\n net: provide IP-related API on any OS\n\n drivers/bus/pci/private.h | 4 +-\n drivers/bus/vdev/vdev_private.h | 2 +\n drivers/common/mlx5/mlx5_common.h | 1 +\n drivers/net/i40e/i40e_ethdev.c | 1 +\n drivers/net/i40e/i40e_fdir.c | 1 +\n drivers/net/mlx5/mlx5.h | 1 -\n drivers/net/mlx5/mlx5_flow.c | 4 +-\n drivers/net/mlx5/mlx5_flow.h | 3 +-\n drivers/net/mlx5/mlx5_mac.c | 1 -\n examples/cmdline/commands.c | 5 --\n examples/cmdline/parse_obj_list.c | 2 -\n lib/librte_cmdline/cmdline.c | 5 --\n lib/librte_cmdline/cmdline_os_windows.c | 2 -\n lib/librte_cmdline/cmdline_parse.c | 2 -\n lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 --\n lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 --\n lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +-\n lib/librte_cmdline/cmdline_private.h | 1 +\n lib/librte_cmdline/cmdline_socket.c | 4 -\n lib/librte_eal/common/eal_common_config.c | 1 -\n lib/librte_eal/common/eal_common_errno.c | 4 +\n lib/librte_eal/common/eal_common_options.c | 2 +-\n lib/librte_eal/common/eal_common_timer.c | 4 +-\n lib/librte_eal/common/eal_internal_cfg.h | 1 +\n lib/librte_eal/common/eal_private.h | 11 +++\n lib/librte_eal/freebsd/include/rte_os_shim.h | 14 +++\n lib/librte_eal/linux/include/rte_os_shim.h | 14 +++\n lib/librte_eal/windows/eal.c | 30 +++++++\n lib/librte_eal/windows/eal_hugepages.c | 1 -\n lib/librte_eal/windows/eal_lcore.c | 1 -\n lib/librte_eal/windows/eal_memalloc.c | 1 -\n lib/librte_eal/windows/include/arpa/inet.h | 30 -------\n lib/librte_eal/windows/include/netinet/in.h | 38 --------\n lib/librte_eal/windows/include/netinet/ip.h | 10 ---\n lib/librte_eal/windows/include/rte_os.h | 92 +-------------------\n lib/librte_eal/windows/include/rte_os_shim.h | 36 ++++++++\n lib/librte_eal/windows/include/sys/socket.h | 24 -----\n lib/librte_ethdev/ethdev_private.h | 2 +\n lib/librte_ethdev/rte_ethdev.c | 12 +--\n lib/librte_ethdev/rte_ethdev_core.h | 1 -\n lib/librte_kvargs/rte_kvargs.c | 1 +\n lib/librte_net/rte_ether.h | 26 ++++--\n lib/librte_net/rte_ip.h | 7 ++\n lib/librte_net/rte_net.c | 1 +\n 44 files changed, 164 insertions(+), 253 deletions(-)\n create mode 100644 lib/librte_eal/freebsd/include/rte_os_shim.h\n create mode 100644 lib/librte_eal/linux/include/rte_os_shim.h\n delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h\n delete mode 100644 lib/librte_eal/windows/include/netinet/in.h\n delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h\n create mode 100644 lib/librte_eal/windows/include/rte_os_shim.h\n delete mode 100644 lib/librte_eal/windows/include/sys/socket.h" }