Cover Detail
Show a cover letter.
GET /api/covers/82932/?format=api
{ "id": 82932, "url": "http://patches.dpdk.org/api/covers/82932/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1604061740-2868-1-git-send-email-timothy.mcdaniel@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1604061740-2868-1-git-send-email-timothy.mcdaniel@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1604061740-2868-1-git-send-email-timothy.mcdaniel@intel.com", "date": "2020-10-30T12:41:56", "name": "[v9,00/23] Add DLB PMD", "submitter": { "id": 826, "url": "http://patches.dpdk.org/api/people/826/?format=api", "name": "Timothy McDaniel", "email": "timothy.mcdaniel@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1604061740-2868-1-git-send-email-timothy.mcdaniel@intel.com/mbox/", "series": [ { "id": 13500, "url": "http://patches.dpdk.org/api/series/13500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13500", "date": "2020-10-30T12:41:57", "name": "Add DLB PMD", "version": 9, "mbox": "http://patches.dpdk.org/series/13500/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/82932/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E63F3A04DE;\n\tFri, 30 Oct 2020 13:40:58 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 39A33C8D6;\n\tFri, 30 Oct 2020 13:40:41 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 1B6A6C86C\n for <dev@dpdk.org>; Fri, 30 Oct 2020 13:40:34 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Oct 2020 05:40:32 -0700", "from txasoft-yocto.an.intel.com ([10.123.72.192])\n by fmsmga004.fm.intel.com with ESMTP; 30 Oct 2020 05:40:32 -0700" ], "IronPort-SDR": [ "\n FYAhL8dWwDywBToQu8d03lApOr/S0ZySg0QVaqPQCUy8HZ8xhKrcikjjgjoDHwvRI0TZKtAaZk\n uPvabWBT2HFQ==", "\n 5bvyKzMJJo2Xu3Z1kYoAO7RGVbqBv+gY0bPFkLc6XRjH8Wtc2QD/f0Y3ETsvGjYH4JFdgBP80Q\n xkhCbqEwLYWQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9789\"; a=\"156373886\"", "E=Sophos;i=\"5.77,433,1596524400\"; d=\"scan'208\";a=\"156373886\"", "E=Sophos;i=\"5.77,433,1596524400\"; d=\"scan'208\";a=\"351849527\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Timothy McDaniel <timothy.mcdaniel@intel.com>", "To": "", "Cc": "dev@dpdk.org, erik.g.carrillo@intel.com, gage.eads@intel.com,\n harry.van.haaren@intel.com, jerinj@marvell.com, thomas@monjalon.net", "Date": "Fri, 30 Oct 2020 07:41:56 -0500", "Message-Id": "<1604061740-2868-1-git-send-email-timothy.mcdaniel@intel.com>", "X-Mailer": "git-send-email 1.7.10", "In-Reply-To": "<20200612212434.6852-2-timothy.mcdaniel@intel.com>", "References": "<20200612212434.6852-2-timothy.mcdaniel@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] =?utf-8?q?=5BPATCH_v9_00/23=5D_Add_DLB_PMD?=", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The following patch series adds support for a new eventdev PMD. The DLB\nPMD adds support for the Intel Dynamic Load Balancer (DLB) hardware.\nThe DLB is a PCIe device that provides load-balanced, prioritized\nscheduling of core-to-core communication. The device consists of\nqueues and arbiters that connect producer and consumer cores, and\nimplements load-balanced queueing features including:\n- Lock-free multi-producer/multi-consumer operation.\n- Multiple priority levels for varying traffic types.\n- 'Direct' traffic (i.e. multi-producer/single-consumer)\n- Simple unordered load-balanced distribution.\n- Atomic lock-free load balancing across multiple consumers.\n- Queue element reordering feature allowing ordered load-balanced\n distribution.\n\nThe DLB hardware supports both load balanced and directed ports and\nqueues. Unlike other eventdev devices already in the repo, not all\nDLB ports and queues are equally capable. In particular, directed\nports are limited to a single link, and must be connected to a directed\nqueue.\nAdditionally, even though LDB ports may link multiple queues, the\nnumber of queues that may be linked is limited by hardware. Another\ndifference is that DLB does not have a straightforward way of carrying\nthe flow_id in the queue elements (QE) that the hardware operates on.\n\nWhile reviewing the code, please be aware that this PMD has full\ncontrol over the DLB hardware. Intel will be extending the DLB PMD\nin the future (not as part of this first series) with a mode that we\nrefer to as the bifurcated PMD. The bifurcated PMD communicates with a\nkernel driver to configure the device, ports, and queues, and memory\nmaps device MMIO so datapath operations occur purely in user-space.\n\nThe framework to support both the PF PMD and bifurcated PMD exists in\nthis patchset, and is why the iface.[ch] layer is present.\n\nMajor changes in v9 \n=====================\n- fixed a build error due to __rte_cache_aligned being placed after\n the \";\" character, instead of before it.\n\nMajor changes in v8 after dpdk reviews\n=====================\n- moved introduction of dlb in relnotes_20_11 to first patch in series\n- fixed underlines in dlb.rst that were too short\n- note that the code still uses its private byte-encoded versions of\n umonitor/umwait, rather than the new functions in the power\n patch that are built on top of those intrinsics. This is intentional.\n\nMajor changes in v7 after dpdk reviews\n=====================\n- updated MAINTAINERS file to alphabetically insert DLB\n- don't create RTE_ symbols in PMD\n- converted to use version.map scheme\n- converted to use .._master_lcore instead of .._main_lcore\n- this patch set is based on dpdk-next-eventdev\n\nMajor changes in v6 after dpdk reviews:\n=====================\n- fixed meson conditional build. Moved test into driver’s meson.build\n file instead of event/meson.build\n- documentation is populated as associated code is introduced\n- add log_register in add dynamic logging patch\n- rename RTE_xxx symbol(s) as DLB2_xxx\n- replaced function ptr enqueue_four with direct call to movdir64b\n- remove unused port_pages\n- broke up probe patch into 3 smaller patches for easier review\n- changed param order of movdir64b/movntdq to match intrinsics\n- added self to MAINTAINERS files\n- squashed announcement of availability into last patch in series\n- correct spelling errors and delete repeated words\n- DPDK_21.0 -> DPDK 21 in map file\n- add experimental banner to public structs and APIs\n- implemented other suggestions from code reviews of DLB2 PMD. The\n software is very similar in form so some DLB2 reviews comments\n were applicable to DLB as well\n\nMajor changes in v5 after dpdk reviews and additional internal reviews\nby colleagues at Intel:\n================\n- implement changes requested in code reviews by Gage Eads and Mike Chen\n- fix a memzone leak\n- convert to use eal rte-cpuflags patch from Liang Ma\n\nMajor changes in v4 after dpdk reviews and additional internal reviews\nby colleagues at Intel:\n================\n- Remove make infrastructure\n- shared code (pf/base) is now added incrementally\n- flexible interface (iface.[ch]) is now added incrementally\n- removed calls to rte_panic\n- do not call pthread_create directly\n- remove unused internal API, os_time\n- convert rte_atomic to __atomic builtins\n- broke out eventdev ABI changes, test/api changes, and new internal PCI\n named probe API\n- relocated enqueue logic to enqueue patch\n\nMajor Changes in V3:\n================\n- Fixed a memory corruption issue due to not allocating enough CQ\nmemory for depths < 8. Hardware requires minimum allocation to be\nat least 8 entries.\n- Address review comments from Gage and Mattias.\n- Remove versioning\n- minor formatting changes\n\nMajor changes in V2:\n================\n- Correct ABI break that was present in V1.\n- Address some of the review comments received from Mattias.\n I will address the remaining items identified by Mattias in the next\n patch delivery.\n- General code cleanup based on internal code reviews\n\nDepends-on: patch-82202 (\"eventdev: increase MAX QUEUES PER DEV to 255\")\nDepends-on: patch-79539 (\"eal: add new x86 cpuid support for WAITPKG\")\n\nTimothy McDaniel (23):\n event/dlb: add documentation and meson infrastructure\n event/dlb: add dynamic logging\n event/dlb: add private data structures and constants\n event/dlb: add definitions shared with LKM or shared code\n event/dlb: add inline functions\n event/dlb: add eventdev probe\n event/dlb: add flexible interface\n event/dlb: add probe-time hardware init\n event/dlb: add xstats\n event/dlb: add infos get and configure\n event/dlb: add queue and port default conf\n event/dlb: add queue setup\n event/dlb: add port setup\n event/dlb: add port link\n event/dlb: add port unlink and port unlinks in progress\n event/dlb: add eventdev start\n event/dlb: add enqueue and its burst variants\n event/dlb: add dequeue and its burst variants\n event/dlb: add eventdev stop and close\n event/dlb: add PMD's token pop public interface\n event/dlb: add PMD self-tests\n event/dlb: add queue and port release\n event/dlb: add timeout ticks entry point\n\n MAINTAINERS | 6 +-\n app/test/test_eventdev.c | 7 +\n config/rte_config.h | 6 +\n doc/api/doxy-api-index.md | 1 +\n doc/guides/eventdevs/dlb.rst | 341 ++\n doc/guides/eventdevs/index.rst | 1 +\n doc/guides/rel_notes/release_20_11.rst | 5 +\n drivers/event/dlb/dlb.c | 4129 +++++++++++++++\n drivers/event/dlb/dlb_iface.c | 79 +\n drivers/event/dlb/dlb_iface.h | 82 +\n drivers/event/dlb/dlb_inline_fns.h | 59 +\n drivers/event/dlb/dlb_log.h | 25 +\n drivers/event/dlb/dlb_priv.h | 513 ++\n drivers/event/dlb/dlb_selftest.c | 1551 ++++++\n drivers/event/dlb/dlb_user.h | 814 +++\n drivers/event/dlb/dlb_xstats.c | 1222 +++++\n drivers/event/dlb/meson.build | 21 +\n drivers/event/dlb/pf/base/dlb_hw_types.h | 334 ++\n drivers/event/dlb/pf/base/dlb_osdep.h | 310 ++\n drivers/event/dlb/pf/base/dlb_osdep_bitmap.h | 441 ++\n drivers/event/dlb/pf/base/dlb_osdep_list.h | 131 +\n drivers/event/dlb/pf/base/dlb_osdep_types.h | 31 +\n drivers/event/dlb/pf/base/dlb_regs.h | 2368 +++++++++\n drivers/event/dlb/pf/base/dlb_resource.c | 6904 ++++++++++++++++++++++++++\n drivers/event/dlb/pf/base/dlb_resource.h | 876 ++++\n drivers/event/dlb/pf/dlb_main.c | 586 +++\n drivers/event/dlb/pf/dlb_main.h | 47 +\n drivers/event/dlb/pf/dlb_pf.c | 750 +++\n drivers/event/dlb/rte_pmd_dlb.c | 38 +\n drivers/event/dlb/rte_pmd_dlb.h | 77 +\n drivers/event/dlb/version.map | 9 +\n drivers/event/meson.build | 2 +-\n 32 files changed, 21764 insertions(+), 2 deletions(-)\n create mode 100644 doc/guides/eventdevs/dlb.rst\n create mode 100644 drivers/event/dlb/dlb.c\n create mode 100644 drivers/event/dlb/dlb_iface.c\n create mode 100644 drivers/event/dlb/dlb_iface.h\n create mode 100644 drivers/event/dlb/dlb_inline_fns.h\n create mode 100644 drivers/event/dlb/dlb_log.h\n create mode 100644 drivers/event/dlb/dlb_priv.h\n create mode 100644 drivers/event/dlb/dlb_selftest.c\n create mode 100644 drivers/event/dlb/dlb_user.h\n create mode 100644 drivers/event/dlb/dlb_xstats.c\n create mode 100644 drivers/event/dlb/meson.build\n create mode 100644 drivers/event/dlb/pf/base/dlb_hw_types.h\n create mode 100644 drivers/event/dlb/pf/base/dlb_osdep.h\n create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h\n create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_list.h\n create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_types.h\n create mode 100644 drivers/event/dlb/pf/base/dlb_regs.h\n create mode 100644 drivers/event/dlb/pf/base/dlb_resource.c\n create mode 100644 drivers/event/dlb/pf/base/dlb_resource.h\n create mode 100644 drivers/event/dlb/pf/dlb_main.c\n create mode 100644 drivers/event/dlb/pf/dlb_main.h\n create mode 100644 drivers/event/dlb/pf/dlb_pf.c\n create mode 100644 drivers/event/dlb/rte_pmd_dlb.c\n create mode 100644 drivers/event/dlb/rte_pmd_dlb.h\n create mode 100644 drivers/event/dlb/version.map" }