Cover Detail
Show a cover letter.
GET /api/covers/81164/?format=api
{ "id": 81164, "url": "http://patches.dpdk.org/api/covers/81164/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20201017030701.16134-1-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201017030701.16134-1-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201017030701.16134-1-l.wojciechow@partner.samsung.com", "date": "2020-10-17T03:06:44", "name": "[v8,00/17] fix distributor synchronization issues", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20201017030701.16134-1-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 13072, "url": "http://patches.dpdk.org/api/series/13072/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13072", "date": "2020-10-17T03:06:44", "name": "fix distributor synchronization issues", "version": 8, "mbox": "http://patches.dpdk.org/series/13072/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/81164/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CDD16A04DB;\n\tSat, 17 Oct 2020 05:07:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1B24CE272;\n\tSat, 17 Oct 2020 05:07:29 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CF95DE272\n for <dev@dpdk.org>; Sat, 17 Oct 2020 05:07:27 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20201017030716euoutp012cc1905259f9e2808c3f248e6fb32a5c~_qLptjio21628816288euoutp01R\n for <dev@dpdk.org>; Sat, 17 Oct 2020 03:07:16 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20201017030710eucas1p2bdf52b58769d92324bd756c7569df0d0~_qLk1iQ3Z1097310973eucas1p22;\n Sat, 17 Oct 2020 03:07:10 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 67.E8.06456.EDF5A8F5; Sat, 17\n Oct 2020 04:07:10 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20201017030709eucas1p11285f14ee4fe2e79ad5791b0e9b9c653~_qLkCRryP0897308973eucas1p1n;\n Sat, 17 Oct 2020 03:07:09 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20201017030709eusmtrp2ba8a011c835dbc76788c3e33d73be693~_qLj8E5942572125721eusmtrp2g;\n Sat, 17 Oct 2020 03:07:09 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 1A.99.06314.DDF5A8F5; Sat, 17\n Oct 2020 04:07:09 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20201017030709eusmtip100b58c98c091647b6b57cba888cb1d4d~_qLjf1aqd0424404244eusmtip1M;\n Sat, 17 Oct 2020 03:07:09 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20201017030716euoutp012cc1905259f9e2808c3f248e6fb32a5c~_qLptjio21628816288euoutp01R", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1602904036;\n bh=y6oH84LOyQidGvtZPI5vaKTB3y7Q4/P5Rv9uclyMxdQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=uuXRTtb4GPPaXPorAwwoBYceRAU7RQZ8GYpSGOCkRz8z4neNFUL3J7QytDRJc/eFf\n IxDQYuAAkG68XUpgS4s9EqhwlwcaBBBrusCE6Wieh/99gjamO8CtHu5pJkI88vGIFu\n EK4nZWPDvEgtO5O+z1CPBrrex8NUZA7Pj6XIRLt8=", "X-AuditID": "cbfec7f2-7efff70000001938-28-5f8a5fde6886", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org, l.wojciechow@partner.samsung.com", "Date": "Sat, 17 Oct 2020 05:06:44 +0200", "Message-Id": "<20201017030701.16134-1-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201010160508.19709-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsWy7djP87r34rviDd7f0bJ492k7k8WznnWM\n DkwevxYsZfU4+G4PUwBTFJdNSmpOZllqkb5dAlfG8hW3mAtuSlZMXLaFuYHxsEgXIyeHhICJ\n xNbWr2xdjFwcQgIrGCWuv7kP5XxhlOg4cJUJpEpI4DOjxONb9l2MHGAdc6/5Q9QsZ5T43dDI\n COEA1Vzqv84C0sAmYCtxZOZXVhBbRIBFYuX372BxZgEjiZfdE5lBbGEBB4n+D2/AFrAIqEoc\n 2tfJCGLzCrhKfDu/lxniPHmJ1RsOgNmcAm4SZ7sOgl0nIbCDTeLXyTtMEEUuEp9WvmKHsIUl\n Xh3fAmXLSPzfOZ8JomEbo8TV3z8ZIZz9QI/2roCqspY4/O83G8hvzAKaEut36UOEHSVObFnO\n AvEyn8SNt4IQD/BJTNo2nRkizCvR0SYEUa0n8bRnKiPM2j9rn7BA2B4SH5oeQQNoJqNEy6R9\n zBMY5WchLFvAyLiKUTy1tDg3PbXYMC+1XK84Mbe4NC9dLzk/dxMjMK5P/zv+aQfj10tJhxgF\n OBiVeHg5lnbGC7EmlhVX5h5ilOBgVhLhdTp7Ok6INyWxsiq1KD++qDQntfgQozQHi5I4r/Gi\n l7FCAumJJanZqakFqUUwWSYOTqkGxkJT8TMWk7zOvq4tiJj6+Lv/twTmqPX1lhZixneFN/ea\n PPW5JxLSq2rl+uBy9++bLwvLvrZntRYWNfaGbi7S+ru6i+PKfz6uJUsu5GkryefvCW7x1Gyo\n f/7r79+mANXQgrCNxkUztIR3807yOHh7wwnGdUW/pouflcn13PA6WOJjHifrqc1/lFiKMxIN\n tZiLihMBIVG7q+cCAAA=", "\n H4sIAAAAAAAAA+NgFtrELMWRmVeSWpSXmKPExsVy+t/xu7p347viDc6/0LZ492k7k8WznnWM\n DkwevxYsZfU4+G4PUwBTlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1N\n SmpOZllqkb5dgl7G8hW3mAtuSlZMXLaFuYHxsEgXIweHhICJxNxr/l2MXBxCAksZJdatv8YI\n EZeR+HBJoIuRE8gUlvhzrYsNxBYS+Mgo0bWND8RmE7CVODLzKyuILSLAIrHy+3cWEJsZaOTt\n eU1g9cICDhL9H94wgdgsAqoSh/Z1MoLYvAKuEt/O72WGmC8vsXrDATCbU8BN4mzXQTaQE4SA\n an5NsJvAyLeAkWEVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYHhtO/Zz8w7GSxuDDzEKcDAq\n 8fBuWNQZL8SaWFZcmXuIUYKDWUmE1+ns6Tgh3pTEyqrUovz4otKc1OJDjKZAN01klhJNzgeG\n fl5JvKGpobmFpaG5sbmxmYWSOG+HwMEYIYH0xJLU7NTUgtQimD4mDk6pBkb3o/d/RS/o0Ji0\n xerwp6/qt2qioxUsdFpfpsw/vX+Jk4vNgjjW21yOrtfa7OQmKMnWzrH6vmD6Xg7uA7/jHZjX\n 9nMv2XPcjvezdlRAwPyLl1u3a4nYq6xlfLknUvS1k2xM9mYp0ccxP05/On7kpGgRu+LLdA+e\n 7QKLzVmc/7OdFNyn+W6SiZESS3FGoqEWc1FxIgCnG6hJRQIAAA==" ], "X-CMS-MailID": "20201017030709eucas1p11285f14ee4fe2e79ad5791b0e9b9c653", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20201017030709eucas1p11285f14ee4fe2e79ad5791b0e9b9c653", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20201017030709eucas1p11285f14ee4fe2e79ad5791b0e9b9c653", "References": "<20201010160508.19709-1-l.wojciechow@partner.samsung.com>\n <CGME20201017030709eucas1p11285f14ee4fe2e79ad5791b0e9b9c653@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v8 00/17] fix distributor synchronization issues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During review and verification of the patch created by Sarosh Arif:\n\"test_distributor: prevent memory leakages from the pool\" I found out\nthat running distributor unit tests multiple times in a row causes fails.\nSo I investigated all the issues I found.\n\nThere are few synchronization issues that might cause deadlocks\nor corrupted data. They are fixed with this set of patches for both tests\nand librte_distributor library.\n\n---\nv8:\n* simplify memory model to relaxed and remove extra variable in patch 1\n* rearrange order of patches: \"synchronize lcores statistics\"\n and \"fix freeing mbufs\" to avoid changing same code twice\n* reword \"packages\" -> \"packets\" in \"collect return mbufs\" commit message\n* add patch 17 fixing quitting of workers in distributor tests\n\nv7:\n* add patch 16 ensuring that tests will try sending packets until workers\n are started and requested for packets\n\nv6:\n* fix comments indentation\n* fix stats atomic operations memory mode from ACQUIRE/RELEASE\n to RELAXED\n\nv5:\n* implement missing functionality in burst mode - worker shutdown\n* fix shutdown test to always shutdown busy worker\n* use atomic stores instead of barrier in tests clear_packet_count()\n* reorder patches\n* new patch 7: fix call to return_pkt in single mode\n* new patch 11: replacing delays with spinlock on atomics in tests\n* new patch 12: fix scalar matching algorithm\n* new patch 13: new test with marking and checking every packet\n* new patch 14: flush also in flight packets\n* new patch 15: fix clearing returns buffer\n* minor fixes in other patches\n\nv4:\n* adjust commit name prefixes app/test -> test/distributor:\n* reorder patches\n* use NULL oldpkt in rte_distributor_get_pkt() calls in tests\n\nv3:\n* add missing acked and tested by statements from v1\n\nv2:\n* assign NULL to freed mbufs in distributor test\n* fix handshake check on legacy single distributor\n rte_distributor_return_pkt_single()\n* add patch 7 passing NULL to legacy API calls if no bufs are returned\n* add patch 8 fixing API documentation\n \n\nLukasz Wojciechowski (17):\n distributor: fix missing handshake synchronization\n distributor: fix handshake deadlock\n distributor: do not use oldpkt when not needed\n distributor: handle worker shutdown in burst mode\n test/distributor: fix shutdown of busy worker\n distributor: fix return pkt calls in single mode\n test/distributor: fix freeing mbufs\n test/distributor: synchronize lcores statistics\n test/distributor: collect return mbufs\n distributor: align API documentation with code\n test/distributor: replace delays with spin locks\n distributor: fix scalar matching\n test/distributor: add test with packets marking\n distributor: fix flushing in flight packets\n distributor: fix clearing returns buffer\n test/distributor: ensure all packets are delivered\n test/distributor: fix quitting workers\n\n app/test/test_distributor.c | 353 ++++++++++++++----\n lib/librte_distributor/distributor_private.h | 3 +\n lib/librte_distributor/rte_distributor.c | 217 ++++++++---\n lib/librte_distributor/rte_distributor.h | 23 +-\n .../rte_distributor_single.c | 4 +\n 5 files changed, 473 insertions(+), 127 deletions(-)" }