Cover Detail
Show a cover letter.
GET /api/covers/80329/?format=api
http://patches.dpdk.org/api/covers/80329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20201012080829.3446-1-conor.walsh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201012080829.3446-1-conor.walsh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201012080829.3446-1-conor.walsh@intel.com", "date": "2020-10-12T08:08:25", "name": "[v5,0/4] devtools: abi breakage checks", "submitter": { "id": 1935, "url": "http://patches.dpdk.org/api/people/1935/?format=api", "name": "Conor Walsh", "email": "conor.walsh@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20201012080829.3446-1-conor.walsh@intel.com/mbox/", "series": [ { "id": 12873, "url": "http://patches.dpdk.org/api/series/12873/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12873", "date": "2020-10-12T08:08:25", "name": "devtools: abi breakage checks", "version": 5, "mbox": "http://patches.dpdk.org/series/12873/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/80329/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B12BDA04B6;\n\tMon, 12 Oct 2020 10:08:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 92A211D620;\n\tMon, 12 Oct 2020 10:08:54 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 1A2C91D619\n for <dev@dpdk.org>; Mon, 12 Oct 2020 10:08:52 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Oct 2020 01:08:51 -0700", "from unknown (HELO silpixa00400466.ir.intel.com) ([10.237.213.195])\n by orsmga006.jf.intel.com with ESMTP; 12 Oct 2020 01:08:49 -0700" ], "IronPort-SDR": [ "\n 3wjcG3v9YnG7qkC/SVlF74ruAQpWASUXcHVBhrRp1RNjBbeJzH5ERZ49SDTGFSqN0t1QgBbZeI\n TAYdjHahDiSQ==", "\n Sb84BprYz5qCqXeKpLeUkt9smCL00u3upv+QxAzq3jYmlY38Lsb8J1i9YkbKq0opwQqoS51vOr\n l49HbwSr6aQA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9771\"; a=\"162239012\"", "E=Sophos;i=\"5.77,366,1596524400\"; d=\"scan'208\";a=\"162239012\"", "E=Sophos;i=\"5.77,366,1596524400\"; d=\"scan'208\";a=\"317841896\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Conor Walsh <conor.walsh@intel.com>", "To": "mdr@ashroe.eu, nhorman@tuxdriver.com, bruce.richardson@intel.com,\n thomas@monjalon.net, david.marchand@redhat.com", "Cc": "dev@dpdk.org,\n\tConor Walsh <conor.walsh@intel.com>", "Date": "Mon, 12 Oct 2020 08:08:25 +0000", "Message-Id": "<20201012080829.3446-1-conor.walsh@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200918121137.1370883-1-conor.walsh@intel.com>", "References": "<20200918121137.1370883-1-conor.walsh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 0/4] devtools: abi breakage checks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patchset will help developers discover abi breakages more easily\nbefore upstreaming their code. Currently checking that the DPDK ABI\nhas not changed before up-streaming code is not intuitive and the\nprocess is time consuming. Currently contributors must use the\ntest-meson-builds.sh tool, alongside some environmental variables to\ntest their changes. Contributors in many cases are either unaware or\nunable to do this themselves, leading to a potentially serious situation\nwhere they are unknowingly up-streaming code that breaks the ABI. These\nbreakages are caught by Travis, but it would be more efficient if they\nwere caught locally before up-streaming. This patchset introduces changes\nto test-meson-builds.sh, check-abi.sh and adds a new script\ngen-abi-tarballs.sh. The changes to test-meson-builds.sh include UX\nchanges such as adding command line arguments and allowing the use of\nrelative paths. Reduced the number of abi checks to just two, one for both\nx86_64 and ARM, the references for these tests can now be prebuilt and\ndownloaded by test-meson-builds.sh, these changes will allow the tests to\nrun much faster. check-abi.sh is updated to use the prebuilt references.\ngen-abi-tarballs.sh is a new script to generate the prebuilt abi\nreferences used by test-meson-builds.sh, these compressed archives can be\nretrieved from either a local directory or a remote http location.\n\n---\nv5:\n - Patchset has been completely reworked following feedback\n - Patchset is now part of test-meson-builds.sh not the meson build system\n\nv4:\n - Reworked both Python scripts to use more native Python functions\n and modules.\n - Python scripts are now in line with how other Python scripts in\n DPDK are structured.\n\nv3:\n - Fix for bug which now allows meson < 0.48.0 to be used\n - Various coding style changes throughout\n - Minor bug fixes to the various meson.build files\n\nv2: Spelling mistake, corrected spelling of environmental\n\nConor Walsh (4):\n devtools: add generation of compressed abi dump archives\n devtools: abi and UX changes for test-meson-builds.sh\n devtools: change dump file not found to warning in check-abi.sh\n doc: test-meson-builds.sh doc updates\n\n devtools/check-abi.sh | 3 +-\n devtools/gen-abi-tarballs.sh | 48 ++++++++\n devtools/test-meson-builds.sh | 170 ++++++++++++++++++++++------\n doc/guides/contributing/patches.rst | 43 +++++--\n 4 files changed, 220 insertions(+), 44 deletions(-)\n create mode 100755 devtools/gen-abi-tarballs.sh" }{ "id": 80329, "url": "