Cover Detail
Show a cover letter.
GET /api/covers/74167/?format=api
{ "id": 74167, "url": "http://patches.dpdk.org/api/covers/74167/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20200716072938.812733-1-parav@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200716072938.812733-1-parav@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200716072938.812733-1-parav@mellanox.com", "date": "2020-07-16T07:29:29", "name": "[v6,0/9] Improve mlx5 PMD driver framework for multiple classes", "submitter": { "id": 1780, "url": "http://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20200716072938.812733-1-parav@mellanox.com/mbox/", "series": [ { "id": 11075, "url": "http://patches.dpdk.org/api/series/11075/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11075", "date": "2020-07-16T07:29:29", "name": "Improve mlx5 PMD driver framework for multiple classes", "version": 6, "mbox": "http://patches.dpdk.org/series/11075/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/74167/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 42CDBA0546;\n\tThu, 16 Jul 2020 09:30:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 222C31BEA8;\n\tThu, 16 Jul 2020 09:30:00 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85])\n by dpdk.org (Postfix) with ESMTP id 6BE9B1BEA1\n for <dev@dpdk.org>; Thu, 16 Jul 2020 09:29:59 +0200 (CEST)", "from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)\n by AM0PR05MB5329.eurprd05.prod.outlook.com (2603:10a6:208:ed::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Thu, 16 Jul\n 2020 07:29:57 +0000", "from AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020\n 07:29:57 +0000", "from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by\n SN6PR16CA0057.namprd16.prod.outlook.com (2603:10b6:805:ca::34) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3195.18 via Frontend Transport; Thu, 16 Jul 2020 07:29:56 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lr2D9SoMCHrjazL9CFWQduRdd/xR+QyvX6rlloxVFVOOTzPANn2eQsMXAvyGOO9D1kwc4nQLk9lUJnWU3wAL9oc1zrKCFithHkun/40bgb8w/1snX6K3KfXNrqmfgyPN6VfG1ZN3PTjR0rRmBo++GM4yGFh9fpCsusfhKJiJq6JuQqVLdLMIR6gT0EhXvo96xVfvVgKeZ2j5HdnOy6mNXE5ixB+GM4/fsR+jkf6Le4nAJucmNeWAYlD0gQl3Pk5eTj29xCudMWXt7o3YLRYtq3+ZeUZE8G/d6j8wBctkxomC8JtFvDwtdMYImej1XCUwkUW2kJHCkis9qnnhG2YA0w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xXzlauhwuWPJposVkUOGyAqYP5IWGtL4LwhKPk/ncvE=;\n b=cC7/dX5ACKDvYUhQrx1KxgCGBAyLSgysFZP3nJgqn7Gqvvr144FBEFWJ6fOJx/VPFwfUoAUNodsjP5085BPm2Fd/zFxByYswYvtUnWdyMiCiLWDtzLADOtEUeeSGKfxOv40KoWo1sD76qo+Gl5KA+IxPE4A6OMSBZP0uzPBJtSjAuacAXUg5ZpH+Txe1cGo64FggXERgJBezp2n+/pbS8Pu/MJah7DBtyud10NEApk9BpyIR7FjZJMXrU7JWWUgwl9DkMc2PN2v4iLQueAxIM1SMzsNAYK8l8w+xWmgRNbpMhsiMz6Z23IfC3JRJYoZMLRBPZErFu4ZoyjlpWHc+4w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xXzlauhwuWPJposVkUOGyAqYP5IWGtL4LwhKPk/ncvE=;\n b=gsTK4UmYbSvpUOcrdworiGSGUeP9WNA4Chmnz8hjAuaM/gpG51vB3kkHFWuatkyMhjRfWdMZS81swnNKbxD+t+D5FuYPJrpolKvSyZmLm8XHkObVGjqJm5rHYzvCROjrxZAnFHc5W6iEfltY9DzX3T1VRAye8uojd0UvnLAzgi4=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Parav Pandit <parav@mellanox.com>", "To": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net", "Cc": "rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,\n joyce.kong@arm.com, Parav Pandit <parav@mellanox.com>", "Date": "Thu, 16 Jul 2020 10:29:29 +0300", "Message-Id": "<20200716072938.812733-1-parav@mellanox.com>", "X-Mailer": [ "git-send-email 2.26.2", "git-send-email 2.26.2" ], "In-Reply-To": "<20200610171728.89-2-parav@mellanox.com>", "References": "<20200610171728.89-2-parav@mellanox.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SN6PR16CA0057.namprd16.prod.outlook.com\n (2603:10b6:805:ca::34) To AM0PR05MB4866.eurprd05.prod.outlook.com\n (2603:10a6:208:c0::32)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[208.176.44.194]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "025a0ae7-f198-4a0a-200b-08d8295a0a9b", "X-MS-TrafficTypeDiagnostic": "AM0PR05MB5329:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB53296FCBB313FE475866F6C7D17F0@AM0PR05MB5329.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4941;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n +/XjP8Uvr/XuBSZk/dGi9Ww4UWj5O37XRCgK4FoW6lVy70N8d80m7GMABl6wBOuuDSfEwnKPs97JcpEIzIW4gNZQL0E+OvJW6Gaa0q9H1I1Wp+cyh8H6PQq2oa0Vp6yr2PpwZ1xWmWWy8nJpIRj1uq+sf+Mao/YOofpULMBFqwVuXIjJm+s+boMLOBT0GiLttEx/RQPi/suTGoYM/ggAgckKahzdYfc9zUmV67Esk+hqbUCoQ3F9SdaszObQ9q1+bFbf/UrdZmm+TRKjKtE5UTpfAaHwPmyUjKjS75lNPT2k3Z1CKbd50P0xIfNw2na/JMLMwPWeigFoKIzYmqG9Ww==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(6506007)(6666004)(16526019)(186003)(66946007)(107886003)(66556008)(26005)(8936002)(86362001)(6512007)(6486002)(52116002)(83380400001)(66476007)(5660300002)(2616005)(956004)(36756003)(8676002)(478600001)(316002)(66574015)(1076003)(2906002)(4326008);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n J/Yug1N2wtsKuY5pb245FC0OqaO6qj3FqM6IZ+NSGz76VpzFmUe7C2hTrHNi9zxbL9IbTO5kRHwMezIjDnIak6N/12lAsiAmItkGZJsozPHu/6OkxgzZynyl39t345AzmzIzhCo2hkbU75kf8VOm0xYaqyWgsqujPURG+3PUwYua5sSh2fGRidx/I3a7SZ6CVhVc0xzydzNfhDMkXxmR1ig62Zdstw6ztABx0MEUfw3dT0PpcDxl71uWaiRyOax95dhPtWCmcc7l9x/eA6Q95NebnY//TZQ3C4GVbQ+kA3UC6JhqGo1psEEBGwEZIgT6Lw07gwLYb44yC3XD7kmM6zsQ5NhliwnQc/sNvQ2ugudPfeFPIPypsZaAL1Jsojpi5ClXK1a5q+BkE4LPT+RIPmCtpr6qZgVkdxA/Ng4a6e9Rc1Vw1uoXijyBL+cGIDocNXumpyLPm5AeE4KGR7RYyj2TdVXXOHJCH44t8fcRZ7k=", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 025a0ae7-f198-4a0a-200b-08d8295a0a9b", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4866.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Jul 2020 07:29:57.6428 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n O73nkaFhhGdaAmm9X0gMTwimdf9Mv7avBwCSXmU9alXTO2kyNrQR5cI7Xtker6cvNi/fNGDtjkZf6zH0Qv37sg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB5329", "Subject": "[dpdk-dev] [PATCH v6 0/9] Improve mlx5 PMD driver framework for\n\tmultiple classes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This series introduces mlx5 bus to support multiple class of devices\nfor a single PCI device.\n\nMotivation and example\n----------------------\nmlx5 PCI device supports multiple class of devices such as net, vdpa\nand regex devices.\n\nCurrently only one pmd (either net or vdpa) can bind to this device.\nThis design limits use of PCI device only for single device class.\n\nTo support multiple classes simultaneously for a mlx5 PCI device,\na new mlx5 PCI bus is created. This bus allows binding multiple\nclass drivers (such as net, vdpa, regex(future)) to bind to the\nmlx5 PCI bus driver.\n\nChange description\n------------------\nPatch-1 Introduces RTE_BIT() macro\nPatch-2 Introduces new RTE constructor priority for common\ninitialization\nPatch-3 Fixes compilation error\nPatch-4 Define mlx5 class as bit fields\nPatch-5 Uses new RTE common priority\nPatch-6 Adds mlx5 PCI bus\nPatch-7 Implements a mlx5 PCI bus driver\nPatch-8 Migrates mlx5 net and vdpa driver to use mlx5 PCI bus\nAPI instead of rte PCI bus API\nPatch-9 Removed class check code as its already part of the bus now\nPatch-10 Add maintainers for the new bus\n\nDesign overview\n---------------\n\n ----------- ------------ -------------\n | mlx5 | | mlx5 | | mlx5 |\n | net pmd | | vdpa pmd | | regex pmd |\n ----------- ------------ -------------\n \\ | /\n \\ | /\n \\ ------------- /\n \\______| mlx5 |_____ /\n | pci bus |\n ------------- \n |\n ----------- \n | mlx5 | \n | pci dev | \n ----------- \n\n- mlx5 pci bus driver binds to mlx5 PCI devices defined by PCI\n ID table of all related mlx5 PCI devices.\n- mlx5 class driver such as net, vdpa, regex PMD defines its\n specific PCI ID table and mlx5 bus driver probes matching\n class drivers.\n- mlx5 pci bus driver is cental place that validates supported\n class combinations.\n- In future as code evolves, more device setup/cleanup and\n resource creation code moves to mlx5 PCI bus driver.\n\nAlternatives considered\n-----------------------\n1. Instead of creating mlx5 pci bus, a common driver is\nimplemented which exposes class registration API.\nHowever, bus model fits better with existing DPDK design\nsimilar to ifpga driver.\nClass registration API need to create a new callbacks\nand ID signature; instead it is better to utilize current\nwell defined methods.\n\n2. Enhance pci core to allow multiple driver binding to\nsingle rte PCI device.\nThis approach is not taken, because peer drivers using\none PCI device won't be aware of other's presence. This\nrequires cross-driver syncronization of who initializes\ncommon resources (such as irq, eq and more).\nThis also requires refcounting common objects etc among\npeer drivers.\nInstead of layered approach delivers and allows putting\ncommon resource sharing, setup code in common bus driver.\nIt also eliminates peer blind zone problem as bottom pci\nbus layer provides necessary setup without any reference\ncounting.\n\n3. In future mlx5 prefers to use RDMA MR cache of the mbuf\nused between net and regex pmd so that same mbuf use across\nmultiple device can be possible.\n\nExamples:\n--------\nA user who wish to use a specific class(es) provides list\nof classes at command line such as,\n./testpmd -w <PCI BDF>,class=net:vdpa\n./testpmd -w <PCI BDF>,class=vdpa\n\nIn future,\n./testpmd -w <PCI BDF>,class=net:regex\n\nChangelog:\nv5->v6:\n - Fixed compilation failure in parallel build for shared lib\nv4->v5:\n - Squash the maintainers update path with other patch which adds the\n bus\n - Addressed comments from Morten Brørup\n - Renamed newly added macro to RTE_BIT64\n - Added doxygen comment section for the macro\nv3->v4:\n - Fixed dma_map error unwinding flow to follow same order for unmap\nv2->v3:\n - Added RTE priority for common driver initialization\n - Addressed comments from Thomas and Asaf\n - Fixed compilation error in glue wrapper\n - Moved pci_driver structure instance as first in driver\n - Removed white spaces at the end of line in diagram\n - Address commnts from Matan\n - Removed CONFIG_RTE_LIBRTE_MLX5_PCI_BUS from config files\n - Renamed mlx5_valid_class_combo to mlx5_class_combinations\n - Added cross check for class drivers to support only 3 flags for now\n - Added full stop at the end of comment block\n - Using full names in function names\n - Added new line before function name in multiple functions\n - Added example string to parse for multiple classes\n - Dropped mlx5 prefix from static function\n - Removed empty lines\n - Fixed issue to remove multiple classes for a driver\n - Using define for drv_flags at multiple places\n - Deriving drv_flags based on the class drivers\n - Fixed alignment for id_table\n - Perform dma map on best effort basis for all supported drivers\n - Dynamically build pci id table\n - Using PCI to mlx5 device helper routines\nv1->v2:\n - Addressed most comments from Thomas and Gaetan.\n - Symbols starting with prefix rte_bus_pci_mlx5 may be\n confusing as it may appear as it belong to rte_bus_pci module.\n Hence it is kept as rte_bus_mlx5_pci which matches with other\n modules as mlx5_vdpa, mlx5_net.\n - Dropped 2nd patch and replace with new 6th patch.\n - Avoided new file, added macro to rte_bitops.h\n - Inheriting ret_pci_driver instead of rte_driver\n - Added design and description of the mlx5_pci bus\n - Enhanced driver to honor RTE_PCI_DRV_PROBE_AGAIN drv_flag\n - Use anonymous structure for class search and code changes around it\n - Define static for class comination array\n - Use RTE_DIM to find array size\n - Added OOM check for strdup()\n - Renamed copy variable to nstr_orig\n - Returning negagive error code\n - Returning directly if match entry found\n - Use compat condition check\n - Avoided cutting error message string\n - Use uint32_t datatype instead of enum mlx5_class\n - Changed logic to parse device arguments only once during probe()\n - Added check to fail driver probe if multiple classes register with\n DMA ops\n - Renamed function to parse_class_options\n - Migreate API from rte_driver to rte_pci_driver\n\nParav Pandit (9):\n eal: introduce macros for getting value for bit\n eal: introduce RTE common initialization level\n common/mlx5: fix empty input style in glue wrappers\n common/mlx5: change mlx5 class enum values as bits\n common/mlx5: use common rte priority\n bus/mlx5_pci: add mlx5 PCI bus\n bus/mlx5_pci: register a PCI driver\n bus/mlx5_pci: enable net and vDPA to use mlx5 PCI bus driver\n common/mlx5: remove class checks from individual driver\n\n MAINTAINERS | 5 +\n drivers/bus/Makefile | 4 +\n drivers/bus/meson.build | 2 +-\n drivers/bus/mlx5_pci/Makefile | 41 ++\n drivers/bus/mlx5_pci/meson.build | 19 +\n drivers/bus/mlx5_pci/mlx5_pci_bus.c | 522 ++++++++++++++++++\n drivers/bus/mlx5_pci/rte_bus_mlx5_pci.h | 84 +++\n .../bus/mlx5_pci/rte_bus_mlx5_pci_version.map | 5 +\n drivers/common/mlx5/linux/mlx5_glue.h | 4 +-\n drivers/common/mlx5/mlx5_common.c | 39 +-\n drivers/common/mlx5/mlx5_common.h | 7 +-\n .../common/mlx5/rte_common_mlx5_version.map | 2 -\n drivers/net/mlx5/Makefile | 3 +-\n drivers/net/mlx5/linux/mlx5_os.c | 6 -\n drivers/net/mlx5/meson.build | 2 +-\n drivers/net/mlx5/mlx5.c | 26 +-\n drivers/net/mlx5/mlx5.h | 1 -\n drivers/vdpa/mlx5/Makefile | 3 +-\n drivers/vdpa/mlx5/meson.build | 2 +-\n drivers/vdpa/mlx5/mlx5_vdpa.c | 30 +-\n lib/librte_eal/include/rte_bitops.h | 8 +\n lib/librte_eal/include/rte_common.h | 1 +\n mk/rte.app.mk | 1 +\n 23 files changed, 732 insertions(+), 85 deletions(-)\n create mode 100644 drivers/bus/mlx5_pci/Makefile\n create mode 100644 drivers/bus/mlx5_pci/meson.build\n create mode 100644 drivers/bus/mlx5_pci/mlx5_pci_bus.c\n create mode 100644 drivers/bus/mlx5_pci/rte_bus_mlx5_pci.h\n create mode 100644 drivers/bus/mlx5_pci/rte_bus_mlx5_pci_version.map" }