Cover Detail
Show a cover letter.
GET /api/covers/726/?format=api
{ "id": 726, "url": "http://patches.dpdk.org/api/covers/726/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-29T19:53:31", "name": "[v4,00/22] stop using variadic argument pack extension", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31311, "url": "http://patches.dpdk.org/api/series/31311/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31311", "date": "2024-02-29T19:53:33", "name": "stop using variadic argument pack extension", "version": 4, "mbox": "http://patches.dpdk.org/series/31311/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/726/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9752D43BA7;\n\tThu, 29 Feb 2024 20:54:02 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DA07142FB2;\n\tThu, 29 Feb 2024 20:53:58 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id B20CC42FAF\n for <dev@dpdk.org>; Thu, 29 Feb 2024 20:53:55 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id DEB2020B74C0; Thu, 29 Feb 2024 11:53:54 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com DEB2020B74C0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709236434;\n bh=KVQ898VNy1u+O+BaKNCTYBc4yFl+hH9OcO4/s6G+yNg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=iHG2Lsmag0BxfvDTLLedYxAbvlS03uh/BfFzwvld+q+gWKKHpEfSovsqb3+eJFYtf\n m7do+1sk/WU7UY8FkhLIgEUeNd3PkcHtjF6D2tDqJ3/7Zeszu8dujJ2xJdOAdxryhX\n Ms1wGIITEke68edgrxE0kq975FPfJCK0Wzy7n/HQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Anatoly Burakov <anatoly.burakov@intel.com>,\n Ashish Gupta <ashish.gupta@marvell.com>, Chenbo Xia <chenbox@nvidia.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Hunt <david.hunt@intel.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Sunil Kumar Kori <skori@marvell.com>, bruce.richardson@intel.com,\n mb@smartsharesystems.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 00/22] stop using variadic argument pack extension", "Date": "Thu, 29 Feb 2024 11:53:31 -0800", "Message-Id": "<1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_LOG_LINE cannot be augmented with a prefix format and arguments\nwithout the user of RTE_LOG_LINE using the args... and ## args compiler\nextension to conditionally remove trailing comma when the macro receives\nonly a single argument.\n\nProvide a new/similar macro RTE_LOG_LINE_PREFIX that accepts the prefix\nformat and arguments as separate parameters allowing them to be expanded\nat the correct locations inside of RTE_FMT() allowing the rest of the\nnon-prefix format string and arguments to be collapsed to the argument\npack which can be directly forwarded with __VA_ARGS__ avoiding the need\nfor conditional comma removal.\n\nI've done my best to manually check expansions (preprocessed) and compiled\nprintf of the logs to validate correct output.\n\nv4:\n * remove unintended addition of prefix to bpf log helper.\n * use RTE_LOG_LINE_PREFIX in other places using RTE_FMT_HEAD\n and RTE_FMT_TAIL.\n * add a checkpatch check to prevent reintroduction of ##args.\n\nv3:\n * remove leading _ from RTE_LOG_COMMA the macro is not internal\n * add doxygen comment for existing RTE_LOG{,DP}_LINE function-like\n macros, based on RTE_LOG{,DP} comments.\n * add doxygen comment for new RTE_LOG{,DP}_LINE_PREFIX function-like\n macros, based on RTE_LOG{,DP} comments.\n * merge 2 vhost patches into a single patch (mistake in previous\n submission)\n\nv2:\n * revamp entire series to be ISO C99 compliant, stop using variadic\n argument pack extension.\n\nTyler Retzlaff (22):\n log: add a per line log helper with parameterized prefix\n cfgfile: stop using variadic argument pack extension\n cmdline: stop using variadic argument pack extension\n compressdev: stop using variadic argument pack extension\n metrics: stop using variadic argument pack extension\n mldev: stop using variadic argument pack extension\n net: stop using variadic argument pack extension\n pdump: stop using variadic argument pack extension\n power: stop using variadic argument pack extension\n rawdev: stop using variadic argument pack extension\n rcu: stop using variadic argument pack extension\n stack: stop using variadic argument pack extension\n eal: stop using variadic argument pack extension\n vhost: stop using variadic argument pack extension\n ip_frag: stop using variadic argument pack extension\n bpf: stop using variadic argument pack extension\n cryptodev: stop using variadic argument pack extension\n eventdev: stop using variadic argument pack extension\n graph: stop using variadic argument pack extension\n member: stop using variadic argument pack extension\n node: stop using variadic argument pack extension\n devtools: forbid use argument variadic pack extension\n\n devtools/checkpatches.sh | 8 +++\n lib/bpf/bpf_impl.h | 4 +-\n lib/cfgfile/rte_cfgfile.c | 5 +-\n lib/cmdline/cmdline_parse.c | 2 +-\n lib/cmdline/cmdline_parse_num.c | 4 +-\n lib/compressdev/rte_compressdev_internal.h | 4 +-\n lib/cryptodev/rte_cryptodev.h | 15 ++---\n lib/eal/common/eal_trace.h | 8 +--\n lib/eal/windows/include/rte_windows.h | 5 +-\n lib/eventdev/eventdev_pmd.h | 10 ++-\n lib/eventdev/rte_event_timer_adapter.c | 5 +-\n lib/graph/graph_private.h | 5 +-\n lib/ip_frag/ip_frag_common.h | 4 +-\n lib/log/rte_log.h | 97 ++++++++++++++++++++++++++++++\n lib/member/member.h | 5 +-\n lib/metrics/rte_metrics_telemetry.c | 12 ++--\n lib/mldev/rte_mldev.h | 4 +-\n lib/net/rte_net_crc.c | 4 +-\n lib/node/node_private.h | 6 +-\n lib/pdump/rte_pdump.c | 4 +-\n lib/power/power_common.h | 6 +-\n lib/rawdev/rte_rawdev_pmd.h | 17 +++---\n lib/rcu/rte_rcu_qsbr.c | 4 +-\n lib/rcu/rte_rcu_qsbr.h | 12 ++--\n lib/stack/stack_pvt.h | 16 ++---\n lib/vhost/vhost.h | 8 +--\n lib/vhost/vhost_crypto.c | 21 ++++---\n 27 files changed, 196 insertions(+), 99 deletions(-)" }